Commit Graph

160 Commits

Author SHA1 Message Date
dwitte@stanford.edu
80d1288560 still investigating mac Tp impact. 2007-11-19 01:08:07 -08:00
dwitte@stanford.edu
1d016075a5 back out change. 2007-11-18 23:26:36 -08:00
dwitte@stanford.edu
42bc4e2e04 investigating orange. 2007-11-18 22:41:53 -08:00
dwitte@stanford.edu
43b6bbdb77 relanding modified patch for bug 403372. 2007-11-18 00:08:34 -08:00
dwitte@stanford.edu
6773c0a0f2 relanding teeny tiny part of patch to investigate Tp impact 2007-11-17 03:05:01 -08:00
reed@reedloden.com
11ea01beb7 Back out dwitte's cookie monster patch (bug 403372) due to Tp regression. 2007-11-17 01:49:18 -08:00
dwitte@stanford.edu
86d8ae1d8b relanding bug 403372. 2007-11-16 22:08:10 -08:00
dwitte@stanford.edu
d21dee9709 backing out to fix orange. 2007-11-16 19:40:34 -08:00
dwitte@stanford.edu
9fef439251 leash up the cookiemonster (cookie eviction should be in lastaccessed order, bug 403372). r=sdwilsh, sr=shaver. also includes unnecessary code removal fix by Marco Bonardo (mak77@supereva.it), bug 403767. 2007-11-16 18:54:51 -08:00
dwitte@stanford.edu
8ea12699c3 updating comment to address review comments in bug 397238. 2007-11-13 17:36:54 -08:00
neil@parkwaycc.co.uk
1482c03244 Bug 397238 Expose cookie import code so that profile migration doesn't have to duplicate it r=dwitte sr=biesi a=mtschrep 2007-11-12 01:28:22 -08:00
dwitte@stanford.edu
242cc017f4 Bug 402395 - Dangling semi-colon caused when "ac_add_options --disable-logging" throws warning in VS2005. patch by Masayuki Nakano (masayuki@d-toybox.com), r=dwitte, sr=bsmedberg, a=beltzner for M9. 2007-11-05 11:29:12 -08:00
dwitte@stanford.edu
d1c12251fb bustage fix for bug 401998. 2007-11-02 19:15:47 -07:00
dwitte@stanford.edu
f6119bec78 add logging coverage for cookie eviction and db operations. b=401998, r+sr=mconnor, a=beltzner 2007-11-01 15:34:16 -07:00
dwitte@stanford.edu
1fc7fa153e fix debug compile error in nsCookie.h. b=394243, r+sr=biesi, a=mconnor 2007-10-04 12:24:00 -07:00
dwitte@stanford.edu
740d60672b tweak documentation for countCookiesFromHost. b=394460, npob. 2007-09-03 19:07:23 -07:00
sdwilsh@shawnwilsher.com
8a369686fc Bug 389575 - Add WARNINGS_AS_ERRORS compile time flag. r=bsmedberg NPOTFB. 2007-08-28 09:02:43 -07:00
dwitte@stanford.edu
e53b738eb3 Use getters and setters for database schema version. b=386369, p=sdwilsh, r=dwitte, sr=biesi. 2007-07-16 14:05:35 -07:00
dwitte@stanford.edu
d4eda07129 web content can set httponly cookie by overwriting a non-httponly one. b=387543, p=dveditz, r=dwitte, sr=mconnor. 2007-07-10 20:21:07 -07:00
jwalden@mit.edu
6d7584839a Bug 348748 - Replace all instances of NS_STATIC_CAST and friends with C++ casts (and simultaneously bitrot nearly every patch in existence). r=bsmedberg on the script that did this. Tune in next time for Macro Wars: Episode II: Attack on the LL_* Macros. 2007-07-08 00:08:04 -07:00
dwitte@stanford.edu
bb15ff449a remove nsICookieServiceInternal. b=384990, r+sr=biesi 2007-06-26 03:41:58 -07:00
dwitte@stanford.edu
c9d4ef4c68 prevent creating, modifying, and deleting HttpOnly cookies from web content, and add unit tests to that effect. b=383181, r+sr=dveditz 2007-06-26 01:36:50 -07:00
dwitte@stanford.edu
22d4d91046 removing redeclaration, r+sr+ui-r+a=sdwilsh 2007-06-25 22:28:25 -07:00
dwitte@stanford.edu
ed30e5a43f fix typo from storage checkin. 2007-06-25 22:10:33 -07:00
dwitte@stanford.edu
b28806e2c6 remove p3p hooks from cookies. b=383994, r=timeless, sr=biesi 2007-06-20 22:17:08 -07:00
dwitte@stanford.edu
341f5cae54 rev nsICookieManager2 interface to allow adding httpOnly cookies, and update consumers to match. b=379408, r+sr=biesi. 2007-06-17 16:40:40 -07:00
dwitte@stanford.edu
5493e24575 switch cookies over to mozStorage. b=230933, r=sdwilsh, sr=mconnor.
remove nsInt64 usage from cookies, b=384225, r+sr=biesi.
2007-06-17 14:52:22 -07:00
dveditz@cruzio.com
ca4bb32d44 bug 373228 incorporate additional review comments after initial checkin, r=dwitte, a=release-drivers 2007-05-07 04:14:01 -07:00
dwitte@stanford.edu
7d5736dc1b tweak some comments to reflect the changes in bug 240963. 2007-05-05 18:29:44 -07:00
dwitte@stanford.edu
1852ac4c86 implement CountCookiesFromHost() in cookie backend for perf reasons, and update consumers to use it.bug 379239, r=mvl, sr=biesi 2007-05-05 14:09:54 -07:00
dveditz@cruzio.com
79bb329675 bug 373228 prevent cookies with long paths from taking too much space, r=dwitte, a=juanb 2007-05-01 01:14:49 -07:00
dwitte@stanford.edu
80c3bd2a8a comment sp fix. 2007-04-29 00:52:23 -07:00
benjamin@smedbergs.us
baab01ada6 Bug 376636 - Building with gcc 4.3 and -pendatic fails due to extra semicolons, patch by Art Haas <ahaas@airmail.net>, rs=me 2007-04-23 07:21:53 -07:00
gijskruitbosch@gmail.com
938a7c96af Bug 375488 - HttpOnly Cookies broken (exchanged httponly and secure arguments in function call)
p=ronny.perinke@gmx.de (Ronny Perinke)
r=mozilla@kaply.com
sr=darin.moz@gmail.com (Darin Fisher)
2007-03-27 10:34:12 -07:00
dbaron@dbaron.org
e7bb1b1c38 Remove GetKeyPointer method from nsTHashtable key types. b=374906 r=bsmedberg 2007-03-27 08:34:59 -07:00
hg@mozilla.com
05e5d33a57 Free the (distributed) Lizard! Automatic merge from CVS: Module mozilla: tag HG_REPO_INITIAL_IMPORT at 22 Mar 2007 10:30 PDT, 2007-03-22 10:30:00 -07:00
mkaply%us.ibm.com
a6d931b748 Bug 178993 -patch from robert sayre and others - r=bsmedberg, dveditz, mvl, sr=darin - add HTTPOnly support 2007-03-14 17:22:01 +00:00
sayrer%gmail.com
3d6d15d00a Backout unfinished patch for bug 178993. 2007-03-02 03:51:30 +00:00
mkaply%us.ibm.com
e82b1fc2f1 #178993
r=bsmedberg, dveditz, mvl
Add support for httpOnly cookie attribute
2007-03-01 20:09:02 +00:00
martijn.martijn%gmail.com
703aa75d3b Bug 346125 � Broken link to Netscape Cookie Specification page in cookies.txt file, patch by Robert Millan, r=bzbarsky 2007-02-08 16:46:28 +00:00
darin%meer.net
39e548c9e1 fixes bug 240201 "remove [noscript] from nsICookieManager2::add" r+sr=bzbarsky 2006-02-23 02:08:27 +00:00
mconnor%steelgryphon.com
7be090cdfd bug 306658 - disallow cookies from non-file URIs without
hostnames, r=dwitte, sr=darin
2005-10-01 05:20:21 +00:00
timeless%mozdev.org
ce896f0683 Bug 308573 use if (NS_FAILED(...)) instead of if NS_FAILED(...)
patch by joshbirnbaum-moz@yahoo.com r=darin sr=darin
2005-09-15 18:30:46 +00:00
bsmedberg%covad.net
81d0f2e5c0 Bug 295994 part 1 - add cookieservice accessors for individual cookies by name, obeying privacy preferences (second try, I reversed the string logic in nsCookieService::SetCookieInternal the first time - r=dwitte+darin 2005-09-15 11:03:09 +00:00
bsmedberg%covad.net
ba35d6749a Backout bug 295994 due to tinderbox orange. 2005-09-14 20:17:13 +00:00
bsmedberg%covad.net
237d89b23c Bug 295994 part 1 - add cookieservice accessors for individual cookies by name, obeying privacy preferences r=dwitte+darin 2005-09-14 18:27:56 +00:00
cbiesinger%web.de
44625301dd bug 283489 r=darin sr=bz
- Make the HTTP, FTP and file channels implement nsIPropertyBag2 and associated
  interfaces (by inheriting from nsHashPropertyBag)
- Use that interface to expose a "content-length" property giving the length of
  the data as a 64-bit value on the FTP and HTTP channels
- change docshell and xpinstall to use nsIPropertyBag2 instead of nsIProperties
  to read/write the referrer property
2005-04-05 17:40:32 +00:00
bsmedberg%covad.net
361daac936 Bug 281414 - global s/nsIPrefBranchInternal/nsIPrefBranch2/ rs=darin (did not change backwards-compatible code in extensions/irc extensions/venkman or extensions/inspector) 2005-02-25 20:46:35 +00:00
bryner%brianryner.com
67dba23ae4 Clean up unneeded REQUIRES (bug 73353). r+sr=dbaron. 2005-02-03 23:01:54 +00:00
dwitte%stanford.edu
1d185f2e97 make p3p cookie icon not appear for rejected cookies, only for flagged/downgraded ones; and remove some deprecated notification fu.
b=212778, r+sr=darin
2005-01-24 06:53:18 +00:00
dwitte%stanford.edu
a708472c84 fix handling of quoted token values.
b=277033, r=mvl, sr=darin
2005-01-24 06:47:44 +00:00
bsmedberg%covad.net
79241940e8 Bug 273876 - libxul step 2 (everything through widget, except spidermonkey) r=darin; again, this should not affect non-xulrunner trees. 2004-12-09 19:28:35 +00:00
cbiesinger%web.de
f31ccc73eb Bug 260659 cookies use static string objects
r=dwitte sr=darin
2004-09-21 11:58:49 +00:00
dwitte%stanford.edu
4fb8109457 fix topcrasher bug 252289, r=mvl sr=darin 2004-07-21 22:03:21 +00:00
dwitte%stanford.edu
dee773b6e5 make cookie & permission files non-world-readable.
b=59557, patch by Pavel Kankovsky (peak@argo.troja.mff.cuni.cz), r=dwitte, sr=bz.
2004-07-20 07:27:28 +00:00
dwitte%stanford.edu
bdf2a2307d sprinkle some asserts, and remove redundant #include. 2004-07-19 23:38:35 +00:00
dwitte%stanford.edu
e338583f48 rename nsISafeFileOutputStream to nsISafeOutputStream, and make nsBufferedOutputStream aware of it, to make life easier on consumers.
b=251648, r=biesi, sr=darin, with thanks to darin and bz for suggestions.
2004-07-19 22:00:03 +00:00
dwitte%stanford.edu
8ad2e8e431 add --disable-cookies build option.
b=221885, r=bsmedberg, r+sr=darin
2004-07-19 04:57:02 +00:00
dwitte%stanford.edu
bd8bee85d7 quick fix to get cookie/permission file saving working on trunk again, while we hash out a real fix.
b=251648, r+sr=darin
2004-07-16 20:08:08 +00:00
dwitte%stanford.edu
76c59a7697 add Finish() method to nsISafeFileOutputStream, and tweak things slightly.
b=251091, r=mvl, sr=darin
2004-07-15 05:52:37 +00:00
dwitte%stanford.edu
0cfd07b69e comment typo fix. 2004-07-12 09:20:55 +00:00
mvl%exedo.nl
5229c8ccbb create a non-overwriting file output stream
bug 246675, r=biesi, sr=darin
2004-07-06 20:35:40 +00:00
dwitte%stanford.edu
91efac3a92 removing unnecessary #include. 2004-06-26 20:52:14 +00:00
cbiesinger%web.de
8a5d56f052 oops. fixing bustage. 2004-06-26 18:47:01 +00:00
dwitte%stanford.edu
4b69710df2 fixing an erroneous comment. 2004-06-19 23:57:45 +00:00
roc+%cs.cmu.edu
0f4150a4e5 Bug 226439. Convert codebase to use AppendLiteral/AssignLiteral/LowerCaseEqualsLiteral. r+sr=darin 2004-06-17 00:13:25 +00:00
darin%meer.net
434cae41e9 fixes bug 236772 "Sprint Local Bill Redirection Limit Exceeded" r=dwitte sr=dveditz 2004-06-07 14:54:22 +00:00
roc+%cs.cmu.edu
0e3ff503fb Bug 226439. Convert Seamonkey to EqualsLiteral. rs=darin 2004-05-22 22:15:22 +00:00
dveditz%cruzio.com
d81a94b560 Bug 242564 revert default p3p cookie action to pre-225298 state, r=dwitte,sr=darin 2004-05-07 08:04:45 +00:00
mvl%exedo.nl
163611b57c "limit to current session" should not override a short cookie lifetime
bug 240963, r=dwitte, sr=darin
2004-04-29 16:58:09 +00:00
dwitte%stanford.edu
3d9f621775 increase the allowable number of total cookies and number of cookies per host, and add prefs so embeddors can tune these values.
b=213963, r=mconnor, sr=darin
2004-04-24 04:17:31 +00:00
bienvenu%nventure.com
4d40ab419f make nsILineInputStream take an nsACString ref, 197166, r=darin, sr=mscott, make local msg body search cache open file stream, use nsIFile instead of nsFileSpec to cut down on seeks, improve performance, sr=mscott 240538 2004-04-22 15:32:54 +00:00
gerv%gerv.net
8b8dde7d95 Bug 236613: change to MPL/LGPL/GPL tri-license. 2004-04-18 22:01:16 +00:00
mconnor%myrealbox.com
183524ff31 Bug 238931: remove the magic number 8 (kill ALLOW_SESSION_ONLY const), r=dwitte, sr=darin, a1.7=asa, fix dwitte's folly by implementing the session perm value on nsICookiePermission 2004-04-07 23:27:02 +00:00
dwitte%stanford.edu
f32b368c4f comment-only tweak. 2004-03-15 09:44:30 +00:00
darin%meer.net
8d65e087ae landing string defragmentation patch for bug 231995, r/sr=dbaron,jst,dougt 2004-02-19 02:44:03 +00:00
bsmedberg%covad.net
7d79d7ba8b Bug 232201 part 2 - update consumers to use inherited nsIPrefBranchInternal interface. This should be happy for codesize. r=alecf sr=darin 2004-01-28 23:45:17 +00:00
dwitte%stanford.edu
cd7d429814 reduce mallocs when creating a new nsCookie, by storing member strings contiguously with the cookie object.
b=223289, r=caillon, sr=darin.
2003-11-18 12:30:23 +00:00
dwitte%stanford.edu
0434ce1a39 fixing bogus comment. 2003-11-17 15:43:51 +00:00
dwitte%stanford.edu
4250def2a9 clean up p3p hooks in cookies. this shifts code out of the cookiservice into p3p, and stops the cookieservice calling into p3p if the user isn't using p3p. this will improve perf a tad.
b=225298, r=mvl, sr=darin
2003-11-14 06:43:08 +00:00
caillon%returnzero.com
500a2f874e Get rid of an addref/release pair and be explicit about deleting our nsCookie when AddCookieToList fails, rather than it just magically dissappearing via the addref/release pair in the callee.
Bug 225203
r=dwitte; sr=jst
2003-11-11 09:39:32 +00:00
dwitte%stanford.edu
e466288f41 removing evil reference to a certain OS. comment-only change. 2003-11-11 05:00:25 +00:00
dwitte%stanford.edu
b8022e8ecf staticify a couple of class methods. 2003-10-31 08:44:00 +00:00
dwitte%stanford.edu
b5e36cc833 fixing indentation. 2003-10-30 05:25:35 +00:00
dwitte%stanford.edu
88e457367f removing reference to unused file 2003-10-30 05:16:51 +00:00
dwitte%stanford.edu
a2ed6657c8 removing unused file 2003-10-30 05:11:54 +00:00
dwitte%stanford.edu
0af383bc06 remove support for network.cookies.strictDomains pref, since there's not much point in keeping it around.
b=223617, r+sr=darin, thanks to mvl for testing.
2003-10-30 03:13:54 +00:00
dwitte%stanford.edu
359f90d96a remove nsCCookieManager.h in favor of nsNetCID.h.
b=221886, r+sr=darin
2003-10-30 02:59:31 +00:00
dwitte%stanford.edu
b6f814cb06 polish the nsICookieManager2::Add interface a tad.
b=222343, r=danm, sr=darin.
2003-10-30 02:50:11 +00:00
dwitte%stanford.edu
c7754ba02e optimize nsCookie a tad by not storing an isDomain parameter.
b=223289 r+sr=darin
2003-10-30 02:43:07 +00:00
dwitte%stanford.edu
6e0efb8f0e er, for real this time... 2003-10-26 01:17:13 +00:00
dwitte%stanford.edu
5304eba08b fix the domainwalking hashtable code to do a lookup for the toplevel domain. this fixes a regression where cookies for "localhost" weren't getting sent.
b=223365, r=mvl, sr=darin, a=asa.
2003-10-26 01:13:23 +00:00
dwitte%stanford.edu
e42be4a132 move cookies to use hashtables instead of a sorted list, and implement a sane notifications
system for cookies and permissions. this will improve perf a bunch, and also sets the stage
for a more performant and flexible cookiemanager UI by providing better notifications.

bugs 143939 and 221185, with r=bsmedberg+mvl, sr=darin and r=mvl, sr=bz respectively.
2003-10-22 06:53:19 +00:00
dwitte%stanford.edu
b0c03defea unfork the core cookie backend prefs, between mozilla & firebird. this makes the cookie backend GRE-friendly. it also breaks firebird, but that's their own fault. (a firebird fix will be landing shortly).
b=221078, r=caillon, sr=darin.
2003-10-16 20:54:29 +00:00
dwitte%stanford.edu
9c84bccbd4 make the cookie whitelist override the "limit cookie lifetime to session" pref. this allows the user to whitelist certain sites for setting permanent cookies, while non-whitelisted sites are downgraded to session cookies. also adds an "downgrade cookies from this site to session" permissionlist value, so now we have a whitelist/blacklist/sessionlist. (UI for this latter feature is not yet hooked up).
this also shifts a bunch of forked pref stuff out of the cookie backend and into an app-specific place, which is good for the GRE.

b=217286, r=mvl, sr=darin.
2003-10-16 13:17:12 +00:00
dwitte%stanford.edu
728808e8d9 move along, nothing to see here...
fix a bitwise & to a logical &&. nice catch bsmedberg!
2003-10-15 14:28:07 +00:00
dwitte%stanford.edu
ded62c5db6 whoops. these weren't meant to go in. ;) 2003-10-11 00:12:33 +00:00
dwitte%stanford.edu
7d225f53dc refactor cookie prompting helper to where it belongs... this will increase perf a little, for the case where prompting is turned off.
b=220624, r=mvl, sr=darin.
2003-10-11 00:06:13 +00:00
darin%meer.net
4138767d73 moving cookies backend into necko: b=210561 r=dwitte sr=bryner
these files were moved from their old home in extensions/cookie.  the CVS
records cannot be simply moved because attic files exist in the new location,
and so i will unfortunately take cvs blame for all.  that's unfair to dwitte
who has made so many wonderful changes to the cookies backend code! ;-)

so, to find out the real cvs blame for these files, please look at the
following cvs remove'd files:

mozilla/extensions/cookie/nsCookieService.cpp
mozilla/extensions/cookie/nsCookieService.h
mozilla/extensions/cookie/nsCookie.cpp
mozilla/extensions/cookie/nsCookie.h
mozilla/extensions/cookie/nsICookie2.idl
mozilla/extensions/cookie/nsICookieConsent.idl
mozilla/extensions/cookie/nsICookie.idl
mozilla/extensions/cookie/nsICookieManager2.idl
mozilla/extensions/cookie/nsICookieManager.idl
mozilla/extensions/cookie/nsICookiePermission.idl
2003-10-10 23:09:18 +00:00
darin%meer.net
1754f96409 moving cookie service into necko: b=210561 r=dwitte sr=bryner
these files were moved from their old home in extensions/cookie.  the CVS
records cannot be simply moved because attic files exist in the new location,
and so i will unfortunately take cvs blame for all.  that's unfair to dwitte
who has made so many wonderful changes to the cookies backend code! ;-)

so, to find out the real cvs blame for these files, please look at the
following cvs remove'd files:

mozilla/extensions/cookie/nsCookieService.cpp
mozilla/extensions/cookie/nsCookieService.h
mozilla/extensions/cookie/nsCookie.cpp
mozilla/extensions/cookie/nsCookie.h
mozilla/extensions/cookie/nsICookie2.idl
mozilla/extensions/cookie/nsICookieConsent.idl
mozilla/extensions/cookie/nsICookie.idl
mozilla/extensions/cookie/nsICookieManager2.idl
mozilla/extensions/cookie/nsICookieManager.idl
mozilla/extensions/cookie/nsICookiePermission.idl
2003-10-10 23:08:01 +00:00