This is in anticipation of having a looser condition for enabling
DComp. Until that code is ready we might as well get more testing.
Differential Revision: https://phabricator.services.mozilla.com/D71060
--HG--
extra : moz-landing-system : lando
They all fail for the same reason: the sanitizer runtime in compiler-rt installs an interceptor for `getsockname` which then contains a call to the real implementation.
Differential Revision: https://phabricator.services.mozilla.com/D70889
--HG--
extra : moz-landing-system : lando
We'll want some kind of backstop no matter what optimization algorithm we use.
We don't want to go too long without running any given task so we can find
regressions quickly and have a good merge candidate.
This pulls the logic that handles this out of the SETA strategy and into its
own strategy.
This will also make the SETA shadow scheduler more representative of what the
algorithm is doing.
Note in the future we may find ways to make this backstop more efficient (i.e
only run tasks that didn't run in the last 9 pushes for example).
Depends on D68621
Differential Revision: https://phabricator.services.mozilla.com/D68622
--HG--
extra : moz-landing-system : lando
This allows to nest strategies without having to register ever intermediate
composite strategy first. For example:
All(Any("skip-unless-schedules", "seta"), "backstop")
Prior to this patch, we'd need to register that 'Any' one first and then use it
in the 'All'.
Depends on D68620
Differential Revision: https://phabricator.services.mozilla.com/D68621
--HG--
extra : moz-landing-system : lando
I'd like to implement a 'backstop' strategy, such that it will prevent all other
optimizers from removing tasks under certain conditions (e.g every 10th push).
The nicest way to implement this seems to be an 'All' composite strategy
(similar to 'Either' which this patch renames to 'Any'). This means we could
do something like:
All("seta", "backstop")
which means we would only remove tasks if *all* substrategies say to remove
tasks.
Differential Revision: https://phabricator.services.mozilla.com/D68620
--HG--
extra : moz-landing-system : lando
This fixes the user-facing issue. This skips the "open in window" and "open in
tab" tests because they're broken due to bug 1626573.
Differential Revision: https://phabricator.services.mozilla.com/D70937
--HG--
rename : browser/base/content/test/contextMenu/browser_canvas_view_image.js => browser/base/content/test/contextMenu/browser_view_image.js
extra : moz-landing-system : lando
This fixes the web-observable bits, but still not the context menu. Patch
incoming for that.
Differential Revision: https://phabricator.services.mozilla.com/D70936
--HG--
extra : moz-landing-system : lando
It's probably more helpful to have the variable documentation near the
declaration. Also amends the description to cover normal name assignments.
Depends on D70863
Differential Revision: https://phabricator.services.mozilla.com/D70864
--HG--
extra : moz-landing-system : lando
`~Maybe()` will perform the clean-up anyway, so we don't really need to call
`reset()` manually here.
Depends on D70862
Differential Revision: https://phabricator.services.mozilla.com/D70863
--HG--
extra : moz-landing-system : lando
The comment about handling name assignments separately predates `NameOpEmitter`.
Using `NameOpEmitter` we don't have to worry choosing the correct bytecode
operations and when to emit `BindName`.
Depends on D70861
Differential Revision: https://phabricator.services.mozilla.com/D70862
--HG--
extra : moz-landing-system : lando
Headers that are not present in the original request but are added by two or
more competing extensions are not merged, but only one of the changes is
applied. Since this causes issues with privacy and security enhancing
extensions trying to tighten up CSP, this introduces a special case to
explicitly always merge the CSP header.
Differential Revision: https://phabricator.services.mozilla.com/D63554
--HG--
extra : moz-landing-system : lando
When the pref is not set to true, we should not display the input,
but also the editor toolbar, the instant evaluation result and
the editor resizer.
The existing test is modified to ensure we cover all these elements.
Differential Revision: https://phabricator.services.mozilla.com/D70843
--HG--
extra : moz-landing-system : lando
Restricted to Nightly because there's still an open issue about inferred
function names and because the proposal was only recently moved to stage 3.
Depends on D70821
Differential Revision: https://phabricator.services.mozilla.com/D70823
--HG--
extra : moz-landing-system : lando
Implements the changes from: https://github.com/tc39/ecma262/pull/1408
The spec PR requires to start the non-syntactic `try` block before retrieving
the "return" property and checking whether or not the "return" property is
callable. As part of this change we can also reorder the other byte code
instructions, which enables us to make the code more similar to normal JS code.
The equivalent JS code is documented in the added comments. Furthermore these
changes allow us to remove the manual stack depth fixups.
Depends on D70819
Differential Revision: https://phabricator.services.mozilla.com/D70820
--HG--
extra : moz-landing-system : lando
Updates the two callers to `JSOp::Pick` which can be optimised to `JSOp::Swap`.
Using `JSOp::Swap` saves one byte when compared to `JSOp::Pick`.
Depends on D70817
Differential Revision: https://phabricator.services.mozilla.com/D70819
--HG--
extra : moz-landing-system : lando
Omit the ellipsis characters when the call has zero arguments. This makes the
disassembly of iterator code a bit more readable, because we're now no longer
displaying additional "..." strings when the call has no arguments.
Depends on D70816
Differential Revision: https://phabricator.services.mozilla.com/D70817
--HG--
extra : moz-landing-system : lando
