Commit Graph

8670 Commits

Author SHA1 Message Date
Bas Schouten
25a1b0f61f Bug 1669256 - Part 1: Remove AbstractEventQueue and de-templatize ThreadEventQueue. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D92709
2020-10-09 17:56:34 +00:00
Marco Zehe
0ada0a0e77 Bug 1668546 Part 2 - Remove the explicit class tag to Pivot from HyperTextAccessible and make it a normal assignment, r=eeejay
Depends on D92216

Differential Revision: https://phabricator.services.mozilla.com/D92217
2020-10-05 17:45:58 +00:00
Marco Zehe
1d00f10ad1 Bug 1668546 Part 1 - Rename the Pivot function in Android's AccessibleWrap so it doesn't collide with the name of the Pivot class, r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D92216
2020-10-05 17:45:30 +00:00
Eitan Isaacson
7a572196df Bug 1669821 - Implement search predicate API on virtual root. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D92820
2020-10-07 20:34:21 +00:00
Eitan Isaacson
f050b91638 Bug 1669599 - Support AXEditableAncestor and make it text event target. r=morgan
Depends on D92689

Differential Revision: https://phabricator.services.mozilla.com/D92690
2020-10-07 00:13:34 +00:00
Eitan Isaacson
c173a1f486 Bug 1669596 - Allow subdoc GeckoTextMarker to be demarshalled in top document. r=morgan
Depends on D92688

Differential Revision: https://phabricator.services.mozilla.com/D92689
2020-10-06 23:31:32 +00:00
Eitan Isaacson
16d2fdfadc Bug 1669595 - Use top AXWebArea as text event source. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D92688
2020-10-07 18:38:52 +00:00
Eitan Isaacson
029b948f0c Bug 1668958 - Don't wrap to first word when getting right word at end of input. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D92310
2020-10-06 22:19:13 +00:00
Eitan Isaacson
10dfa8214c Bug 1668936 - Return element when calling AXUIElementForTextMarker in entry. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D92309
2020-10-06 22:19:11 +00:00
Eitan Isaacson
7293c05ee8 Bug 1668933 - Fix get previous marker outside of entry. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D92308
2020-10-06 22:19:03 +00:00
Eitan Isaacson
bacf4042da Bug 1668961 - Avoid 2 IPC round trips in moxStringForTextMarkerRange. r=morgan
The state checking can happen in the iterator in HyperTextAccessibleWrap.

Differential Revision: https://phabricator.services.mozilla.com/D92307
2020-10-06 22:18:56 +00:00
Morgan Reschenberg
bff9a869c8 Bug 1666380: Add support for AXTextFieldSearchKey to VO rotor r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D90941
2020-10-06 18:50:31 +00:00
Eitan Isaacson
68fd6a3f35 Bug 1669359 - Fix GeckoTextMarker lesser-than operator. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D92511
2020-10-06 17:24:19 +00:00
Sylvestre Ledru
d9cd198ba1 Bug 1519636 - Reformat recent changes to the Google coding style r=andi,necko-reviewers,dragana
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D92459
2020-10-06 16:12:00 +00:00
Eitan Isaacson
7ae60f9637 Bug 1669294 - Add debug description attributes for text marker and range. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D92472
2020-10-05 21:58:57 +00:00
Narcis Beleuzu
818e3aeb0d Bug 1668653 - Fix lint failure in browser_navigate.js. a=lint-fix 2020-10-06 01:13:21 +03:00
Morgan Reschenberg
75caa1c350 Bug 1668655: Add support for AXGraphicSearchKey r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D92144
2020-10-05 19:52:15 +00:00
Morgan Reschenberg
3445c53c34 Bug 1668653: Add support for navigating by heading level with VO r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D92136
2020-10-05 19:52:15 +00:00
Morgan Reschenberg
8ea7a5cbaf Bug 1668663: Add support for navigation by blockquote r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D92145
2020-10-05 19:52:09 +00:00
Eitan Isaacson
96fe811eb7 Bug 1668142 - Support AXDirectionPrevious in rotor with no start element. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D91878
2020-10-02 16:33:42 +00:00
Eitan Isaacson
e3bbc94ed8 Bug 1668137 - Use search root for rule's aDirectDescendantsFrom argument. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D91875
2020-10-02 16:33:34 +00:00
James Teh
590d7137ee Bug 1668707: When deciding whether to create a div Accessible, skip the first/last child if it's invisible and consider inline-block, etc. r=MarcoZ
1. Text nodes can be created in the DOM just because there was white space in the source, but this isn't always visible.
    We shouldn't create an Accessible in the invisible case.
    However, there could be an inline frame after/before an invisible text node, so we still need to check for that.

2. We should create div Accessibles if there are inline-block children such as buttons.
    Previously, we weren't doing this because these aren't caught by IsInlineFrame.
    We now use IsInlineOutside, which also catches text and br.
    Aside from being a bug, this fix was needed in this patch to fix tests which previously created div Accessibles because of invisible text nodes, but lost the Accessibles once this was fixed.

3. Similarly, we should create div Accessibles if there is a previous text sibling.
    Again, IsInlineFrame wasn't catching these, but IsInlineOutside does.

4. Adjust various tests to fix assumptions based on the previous behaviour.
    Some needed role="none" to force flattening, while some needed an id to force creation.

Differential Revision: https://phabricator.services.mozilla.com/D92170
2020-10-02 07:15:15 +00:00
Butkovits Atila
6a98c9beb2 Backed out 2 changesets (bug 1668142, bug 1668137) for build bustage on MOXSearchInfo.mm. CLOSED TREE
Backed out changeset 05c9cc6dd872 (bug 1668142)
Backed out changeset 4c62dd862ae3 (bug 1668137)
2020-10-02 03:53:25 +03:00
Eitan Isaacson
34f9d53bb7 Bug 1668142 - Support AXDirectionPrevious in rotor with no start element. r=morgan
Depends on D91875

Differential Revision: https://phabricator.services.mozilla.com/D91878
2020-10-01 18:55:57 +00:00
Eitan Isaacson
f4182287b4 Bug 1668137 - Use search root for rule's aDirectDescendantsFrom argument. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D91875
2020-10-01 18:56:52 +00:00
Marco Zehe
ce4b2c115c Bug 1666998 - Implement layout-independent paragraph offset search, r=Jamie
This uses the Pivot class to search backwards and forwards from the current offsets until either end is reached, or an accessible that is either a line break or has a block frame, is found, and therefore constitutes a boundary of interest.

Differential Revision: https://phabricator.services.mozilla.com/D91407
2020-10-01 14:16:07 +00:00
Cosmin Sabou
1fa6714a17 Backed out changeset 1b8515b4548c (bug 1666998) for bustages on HyperTextAccessible.cpp. CLOSED TREE 2020-10-01 14:56:38 +03:00
Olli Pettay
8a508eaa66 Bug 1668357 - Disable tests which fail when fission and session-history-in-parent are enabled, r=peterv,marionette-reviewers,whimboo
In many cases with wpt, most of the tests in the file pass, but it is rather time consuming to annotate
.ini files case by case.

Differential Revision: https://phabricator.services.mozilla.com/D91977
2020-10-01 10:23:47 +00:00
Marco Zehe
77c3d1eac2 Bug 1666998 - Implement layout-independent paragraph offset search, r=Jamie
This uses the Pivot class to search backwards and forwards from the current offsets until either end is reached, or an accessible that is either a line break or has a block frame, is found, and therefore constitutes a boundary of interest.

Differential Revision: https://phabricator.services.mozilla.com/D91407
2020-10-01 10:41:46 +00:00
Morgan Reschenberg
671ed0bc10 Bug 1665960: Add AXStaticTextSearchKey support r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D90746
2020-09-29 23:39:49 +00:00
Morgan Reschenberg
eef7c76d3c Bug 1665962: Introduce roles::LISTITEM_MARKER to rolemap, add mac mapping to AXListMarker r=eeejay,Jamie
Differential Revision: https://phabricator.services.mozilla.com/D90745
2020-09-29 22:31:58 +00:00
Eitan Isaacson
474e7874b9 Bug 1667262 - Add AXStyleTextMarkerRangeForTextMarker. r=morgan
Depends on D91357

Differential Revision: https://phabricator.services.mozilla.com/D91850
2020-09-29 23:25:35 +00:00
Eitan Isaacson
a77a63afc1 Bug 1667218 - Introduce AXParagraphTextMarkerRangeForTextMarker. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D91357
2020-09-29 21:00:05 +00:00
Eitan Isaacson
1e470443ea Bug 1668100 - Make target root for AXUIElementsForSearchPredicate. r=morgan
Instead of having the web area be the implicit root, the search results should
exclusively be descendants of the target element that the search is called on.

Differential Revision: https://phabricator.services.mozilla.com/D91826
2020-09-29 20:49:29 +00:00
Morgan Reschenberg
1c31973d81 Bug 1666356: Add support for AXCheckboxSearchKey to VO rotor r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D91169
2020-09-29 18:48:34 +00:00
Razvan Maries
cc4aafb692 Backed out changeset e9d2bed643ab (bug 1665962) for perma failures on browser_rotor.js. CLOSED TREE 2020-09-30 00:22:30 +03:00
Morgan Reschenberg
8e5014ba1b Bug 1665962: Introduce roles::LISTITEM_MARKER to rolemap, add mac mapping to AXListMarker r=eeejay,Jamie
Differential Revision: https://phabricator.services.mozilla.com/D90745
2020-09-29 15:41:09 +00:00
Morgan Reschenberg
c1ac0d9327 Bug 1666357: Add AXRadioGroupSearchKey support to VO rotor
Differential Revision: https://phabricator.services.mozilla.com/D90922
2020-09-28 22:32:05 +00:00
Morgan Reschenberg
39d40dbb3f Bug 1667174: Create RotorRule base class to abstract checks duplicated across current rotor rules r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D91325
2020-09-28 22:32:07 +00:00
Cosmin Sabou
25fe081468 Backed out 3 changesets (bug 1665962, bug 1666357, bug 1667174) for OS X bustages on MOXSearchInfo.mm and conflicts on browser_rotor.js. CLOSED TREE
Backed out changeset 495a69dcd720 (bug 1665962)
Backed out changeset 9cdbf4e04e19 (bug 1666357)
Backed out changeset 0d9d32b08317 (bug 1667174)
2020-09-28 22:18:32 +03:00
Morgan Reschenberg
53d47afda5 Bug 1665962: Introduce roles::LISTITEM_MARKER to rolemap, add mac mapping to AXListMarker r=eeejay,Jamie
Differential Revision: https://phabricator.services.mozilla.com/D90745
2020-09-28 18:40:56 +00:00
Morgan Reschenberg
11491354e7 Bug 1666357: Add AXRadioGroupSearchKey support to VO rotor
Differential Revision: https://phabricator.services.mozilla.com/D90922
2020-09-28 18:16:10 +00:00
Morgan Reschenberg
b9b1c5400f Bug 1667174: Create RotorRule base class to abstract checks duplicated across current rotor rules r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D91325
2020-09-28 18:16:10 +00:00
Markus Stange
41c70bcd59 Bug 1666617 - Add an observer description argument to AddRefreshObserver. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D91082
2020-09-25 02:36:29 +00:00
Razvan Maries
e146bab5ce Backed out 4 changesets (bug 1665962, bug 1666356, bug 1666380, bug 1665960) for perma failure on browser_content_tree.js and browser_treeupdate_list.js. CLOSED TREE
Backed out changeset 29f8600da112 (bug 1666380)
Backed out changeset f01adb0a0e05 (bug 1666356)
Backed out changeset bed1c58441de (bug 1665960)
Backed out changeset 65d6078a5314 (bug 1665962)
2020-09-24 22:18:08 +03:00
Morgan Reschenberg
f42da71073 Bug 1666380: Add support for AXTextFieldSearchKey to VO rotor r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D90941
2020-09-23 21:19:31 +00:00
Morgan Reschenberg
1840888b31 Bug 1666356: Add support for AXCheckboxSearchKey to VO rotor r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D91169
2020-09-23 21:20:08 +00:00
Morgan Reschenberg
fd938aacbb Bug 1665960: Add AXStaticTextSearchKey support r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D90746
2020-09-22 23:31:41 +00:00
Morgan Reschenberg
bfb99727ec Bug 1665962: Introduce roles::LISTITEM_MARKER to rolemap, add mac mapping to AXListMarker r=eeejay,Jamie
Differential Revision: https://phabricator.services.mozilla.com/D90745
2020-09-23 23:33:49 +00:00
Eitan Isaacson
aadc545b2d Bug 1661760 - Followup: eslint tests. r=dluca
Differential Revision: https://phabricator.services.mozilla.com/D91302
2020-09-24 16:34:15 +00:00