Commit Graph

1362 Commits

Author SHA1 Message Date
Wes Kocher
ef0d82bb2b Merge m-c to inbound, a=merge
MozReview-Commit-ID: HSkzFTcnhOy
2017-08-11 13:25:37 -07:00
Sylvestre Ledru
3ba96071c8 Bug 1387002 - Replace .size() by .empty() when applicable in crashreporter/ r=ted
MozReview-Commit-ID: DNh3Pe3FYxG

--HG--
extra : rebase_source : e9239ccfcd470e2536b27420bc5f5b0d8c0eca5f
2017-08-03 12:07:24 +02:00
David Major
3a098c8e70 Bug 1380200 - Increase Breakpad's memory reserve size due to xul.dll inflation. r=ted 2017-07-21 09:10:00 -04:00
Sebastian Hengst
d9b72a81ca Backed out changeset c3a77d62c05d (bug 1333126) for failing own xpcshell tests test_crash_win64cfi_* on Windows 10 x64. r=backout 2017-08-07 18:06:27 +02:00
Sebastian Hengst
4a0c9a1197 Backed out changeset 64be5fefcba3 (bug 1333126) 2017-08-07 18:04:48 +02:00
Carl Corcoran
daca571abe Bug 1333126: adding tests; r=gsvelto
MozReview-Commit-ID: BNv54jtWf7k

--HG--
extra : rebase_source : b2054fd2828e6452a7cd4ced8ed8d1f64cbbc5c3
2017-08-06 08:46:50 +02:00
Carl Corcoran
1846ea009c Bug 1333126: use win64 PE unwind metadata to improve client-side stack walking; r=gsvelto
MozReview-Commit-ID: GDARnPSemyu

--HG--
extra : rebase_source : d14766715d1032db1a4dc489b3f55219e4529277
2017-08-06 08:45:58 +02:00
Sebastian Hengst
a9b93ab9cf Backed out changeset 7f10bba58580 (bug 1333126) for eslint failures in toolkit/crashreporter/test/unit/head_win64cfi.js (strings must use doublequotes). r=backout 2017-08-07 14:03:30 +02:00
Sebastian Hengst
f63869ab14 Backed out changeset 4d92e459f9ab (bug 1333126) 2017-08-07 14:02:59 +02:00
Carl Corcoran
5591814b07 Bug 1333126: adding tests; r=gsvelto
MozReview-Commit-ID: BNv54jtWf7k

--HG--
extra : rebase_source : c0b5de847560ade95776834d2ed8468a426be53d
2017-08-06 08:46:50 +02:00
Carl Corcoran
0b2ac04a9a Bug 1333126: use win64 PE unwind metadata to improve client-side stack walking; r=gsvelto
MozReview-Commit-ID: GDARnPSemyu

--HG--
extra : rebase_source : d14766715d1032db1a4dc489b3f55219e4529277
2017-08-06 08:45:58 +02:00
Masatoshi Kimura
8b713b2b0f Bug 1375125 - Stop using nsILocalFile in the tree. r=froydnj
This mechanically replaces nsILocalFile with nsIFile in
*.js, *.jsm, *.sjs, *.html, *.xul, *.xml, and *.py.

MozReview-Commit-ID: 4ecl3RZhOwC

--HG--
extra : rebase_source : 412880ea27766118c38498d021331a3df6bccc70
2017-08-04 17:49:22 +09:00
Rajesh Kathiriya
48e6bc2124 Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8
MozReview-Commit-ID: FadrI2li43G

--HG--
extra : rebase_source : b455e846ab79c8141150517e67e542e3e06d630e
2017-07-25 23:45:41 +05:30
Sebastian Hengst
804a36e668 Backed out changeset f5922a7ed25a (bug 1374620) for failing eslint at telemetry/tests/unit/test_TelemetrySend.js:358: ["os"] is better written in dot notation. r=backout 2017-07-31 14:44:34 +02:00
Rajesh Kathiriya
22dfa54ef4 Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8
MozReview-Commit-ID: FadrI2li43G

--HG--
extra : rebase_source : 5992bdde34bcc2421350433bc8c1e498a6bba848
2017-07-25 23:45:41 +05:30
Ralph Giles
8032440a7b Bug 1385503 - Correct rust srcdir url again. r=gps
The 'src' subdir needs to be part of the path *after*
the blob/commit_id section of the url, so we need to
no strip it from the prefix when we match.

MozReview-Commit-ID: 9HA3a7d8kh4

--HG--
extra : rebase_source : 6a558c06085844cd7b664c1c65a6e5023ecbb423
2017-07-28 17:04:39 -07:00
Nathan Froyd
320fa56056 Bug 1384220 - remove --with-crashreporter-enable-percent configure option; r=ted.mielczarek
This option was added ~decade ago; AFAICT from bug archaeology, the
option was added to prevent our servers from being overwhelmed.
Somewhere over the years, however, we obtained more capable servers and
the option disappeared from mozconfigs.  It seems moderately unlikely
that we'll have a need for this option again, and we could reintroduce
this patch very easily in any event.  Let's go ahead and remove it.
2017-07-26 11:16:43 -04:00
Nicholas Nethercote
2a4f265a62 Bug 1381727 (part 2) - Remove SmprintfFree(). r=glandium.
It's just a complex wrapper for free(), or equivalent function. (In practice,
all the uses end up in free().)

--HG--
extra : rebase_source : 247ea8458aa57319bd1c8366115a9b4f39ed5a33
2017-07-25 09:09:25 +10:00
Nicholas Nethercote
20df43a549 Bug 1382099 - Remove MOZ_WIDGET_GONK from toolkit/. r=glandium.
--HG--
extra : rebase_source : 709744b24104b463c8dc4cbe215d2250e7c1a9f5
2017-07-19 18:38:48 +10:00
J. Ryan Stinnett
50ecb4bb87 Bug 1379857 - Record Rust panics for child process crashes. r=dmajor
Install crash reporter's panic hook in child processes (and also delay the main
process installation until we know crash reporter is enabled).

When collecting child crash annotations, read the Rust panic message if it
exists.

MozReview-Commit-ID: Gfp2E8IHjw8

--HG--
extra : rebase_source : 9e261f399e7c54fc262a1500cf2514ddd1012406
2017-07-12 14:41:19 -05:00
Chris Manchester
5cb678d0e7 Bug 1304042 - Fail the build if running dsymutil fails. r=mshal
MozReview-Commit-ID: 9ROIRpuoVGR

--HG--
extra : rebase_source : 4fc696f8b658a0a494d4ae9690e8a7cd5b6e3554
2017-07-13 11:57:50 -07:00
Brad Werth
47c4736962 Bug 1059424 Part 3: Simplify DynamicImages::GetDyldAllImageInfosPointer now that we are minimum macOS 10.9. r=mstange
MozReview-Commit-ID: EMJwpU7LetP

--HG--
extra : rebase_source : 80d00d5165aa9c70ce71db7cb88d53c4ff06870d
2017-07-10 15:44:37 -07:00
Ralph Giles
50b5412f42 Bug 1379382 - Correct rust srcdir url. r=gps
We were prefix-matching the rust srcdir when hyperlinking
symbols, but then appending the relative source path to
the top level repo url, resulting in broken links.

Instead, link to the srcdir url at github.

MozReview-Commit-ID: 33tSMM96Vie

--HG--
extra : rebase_source : 13d5638d4029e40077c0ba8de34a64d3ff9e92be
2017-07-08 08:00:27 -07:00
Sylvestre Ledru
4e9cf83ee8 Bug 1378712 - Remove all trailing whitespaces r=Ehsan
MozReview-Commit-ID: Kdz2xtTF9EG

--HG--
extra : rebase_source : 7235b3802f25bab29a8c6ba40a181a722f3df0ce
2017-07-06 14:00:35 +02:00
Perry Jiang
3f8ea432d9 Bug 1377868 - .dmp.ignore files should not cause other crash reports to be ignored. r=felipe
MozReview-Commit-ID: Lvebn8uLoYd
2017-07-03 14:48:40 -07:00
Nicholas Nethercote
3e439bb4f8 Bug 1376638 - Minimize uses of prmem.h. r=glandium.
It's silly to use prmem.h within Firefox code given that in our configuration
its functions are just wrappers for malloc() et al. (Indeed, in some places we
mix PR_Malloc() with free(), or malloc() with PR_Free().)

This patch removes all uses, except for the places where we need to use
PR_Free() to free something allocated by another NSPR function; in those cases
I've added a comment explaining which function did the allocation.

--HG--
extra : rebase_source : 0f781bca68b5bf3c4c191e09e277dfc8becffa09
2017-06-30 19:05:41 -07:00
Ted Mielczarek
e9db7838e4 bug 1275424 - hardcode Rust source paths in symbolstore.py. r=gps
This gives us source file names with repository info in our generated
symbol files, so that crash reports on crash-stats can link to the
correct source files for files from the Rust standard library.

I've hardcoded the source paths that the Rust project uses, which is
not my favorite thing, but there's no simple way to get this information
otherwise.

MozReview-Commit-ID: 6SeaMqH8xfc

--HG--
extra : rebase_source : 227a52db42b3f86378d744e68b4d88d2d8ba9757
2017-06-23 16:19:49 -04:00
Bill McCloskey
f115503a0b Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-26 14:19:58 -07:00
Carsten "Tomcat" Book
259377b6ab merge mozilla-inbound to mozilla-central a=merge 2017-06-26 13:25:51 +02:00
Perry Jiang
80ef003d65 Bug 862178 - Remove main thread I/O from CrashSubmit.jsm and KeyValuParser.jsm, replacing with OS.File. r=gsvelto
MozReview-Commit-ID: 6WIvz15Xtp3

--HG--
extra : rebase_source : 274136cf40459f012776213b18e51f9062d68eb5
2017-06-19 17:04:03 -07:00
Florian Quèze
2924991bf6 Bug 1368456 - remove Promise.jsm imports in tests, r=mconley. 2017-06-23 11:25:52 +02:00
Cervantes Yu
7ef2a81770 Bug 1360308 - Part 3: Support off-main-thread I/O in CrashReporter::CreateMinidumpsAndPair(). r=gsvelto
This moves the I/O operations of writing minidumps in CrashReporter::CreateMinidumpsAndPair()
off the main thread and use callbacks to notify the completion of the operations.

MozReview-Commit-ID: 9wpTDDUp9GN
2017-06-22 18:53:10 +08:00
Nathan Froyd
452dc60022 Bug 1372670 - part 4 - use nsIThreadManager::dispatchToMainThread more from JS; r=florian
We did an automated conversion for many of these in another bug, but
these instances were either missed or have been added since then.
2017-06-21 12:59:28 -04:00
Nathan Froyd
27c58cf89f Bug 1372670 - part 3 - add spinEventLoopUntil to nsIThreadManager; r=erahm,florian 2017-06-21 12:59:28 -04:00
Carsten "Tomcat" Book
8a1350b5a6 Backed out changeset 4f6302a98ae4 (bug 1372405)
--HG--
extra : rebase_source : 41632f3158e88e692809731394a683d065a73dfb
2017-06-21 13:59:26 +02:00
Bill McCloskey
6b3e84ed5f Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-20 21:44:11 -07:00
Cervantes Yu
2719860fe4 Bug 1286802 - Part 7: Don't generate overlapping app memory regions in the crash dump. r=ted
This deduplicates/merges app memory regions so that we don't generate overlapping
memory regions in the minidump. We need to do this because older version of
dbghelp.dll (e.g. that on Windows 7) doesn't handle overlaps in its memory list,
which causes xpcshell bustages.

The test bustages are fixed by sorting and merging app memory regions before
adding to the input to the MinidumpWriteDump callback. Memory regions on the thread
stack is also excluded because thread stack memory is included in the minidump
by default.

MozReview-Commit-ID: 541vzG0b0kC
2017-06-20 15:01:37 +08:00
Cervantes Yu
c5cd0f339c Bug 1286802 - Part 6: Implement CrashGenerationServer::set_include_context_heap() for OOP crash generation. r=ted
MozReview-Commit-ID: 2W0VATExXmE
2017-06-20 15:01:18 +08:00
Cervantes Yu
28be2f1f7d Bug 1286802 - Part 5: Implement ExceptionHandler::set_include_context_heap() for inprocess crash generation. r=ted
MozReview-Commit-ID: AOrGlMjnNjE
2017-06-20 15:01:05 +08:00
Cervantes Yu
18ccb25d49 Bug 1286802 - Part 4: Implemention of including heap regions from the crashing context. r=ted
This patch is the core part of including heap regions using the registers of
the crashing context to be used by in-process and out-of-process crash
generations. It works as follows:

When a crash happens, the ExceptionHandler or CrashGenerationServer uses the register
values in the crash contex as candidates for heap regions. If a value "looks like"
a pointer to some data on the heap, we register a region around the value using a
preallocated AppMemory instance. Then in the "MemoryCallback" type of MinidumpCallback,
we register the memory regions for inclusion in the minidump.

MozReview-Commit-ID: BEik3lRJJkj
2017-06-20 15:00:47 +08:00
Cervantes Yu
d52aeedecb Bug 1286802 - Part 3: Add empty set_include_context_heap() implementation to ExceptionHandler and CrashGenerationServer. r=ted
MozReview-Commit-ID: 5GBzvyvNPDa
2017-06-20 15:00:32 +08:00
Cervantes Yu
8b323a48e2 Bug 1286802 - Part 2: Refactor google_breakpad::ExceptionHandler for including heap regions. r=ted
This moves type definitions and minidump callback to minidump_callback.{h|cpp},
which will be used by google_breakpad::ExceptionHandler for in-process crash
generation, and by googld_breakpad::CrashGenerationServer for out-of-process
crash generation.

MozReview-Commit-ID: AMsQHSUTYNx
2017-06-20 15:00:16 +08:00
Cervantes Yu
b65e8a1203 Bug 1286802 - Part 1: Add minidump_callback.{h|cpp} to Windows breakpad client. r=ted
MozReview-Commit-ID: 5Vpk4jWC63v
2017-06-20 14:59:48 +08:00
Carsten "Tomcat" Book
ea1b86680c Backed out changeset 9846de3bd954 (bug 1372405)
--HG--
extra : rebase_source : 5d4a48e8ec394c329994689d938d2a6e9b2752b0
2017-06-20 08:27:02 +02:00
Bill McCloskey
4592152411 Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-19 22:25:47 -07:00
Masatoshi Kimura
3231cb3535 Bug 1372886 - Remove dead parameters from nsIConverterInputStream.init(). r=hsivonen
MozReview-Commit-ID: GliLHLsUWjt

--HG--
extra : rebase_source : 50d3f4680a498125ddf600b0d64f6740b0229f80
2017-06-17 19:30:09 +09:00
Ted Mielczarek
1e95e2ff3b bug 1302078 - re-enable test_crash_rust_panic.js on win64. r=dmajor
MozReview-Commit-ID: CgbWgxjcoJh

--HG--
extra : rebase_source : d6e87698602a9d53ae8dabdadf00fa39a9271e86
2017-06-14 11:54:59 -04:00
Gabriele Svelto
049e3bf229 Bug 1294025 - Fix the broken promise chain when recording a crash submission attempt; r=bsmedberg
MozReview-Commit-ID: IkXh14Tta7z

--HG--
extra : rebase_source : d71b66ff59590dd08d25320a732c820135cf07ee
2017-06-12 12:00:56 +02:00
Ehsan Akhgari
7fa4662253 Bug 1370609 - Avoid reading the version of dbghelp.dll on startup; r=ted
We will do the same thing for all versions of this DLL that ship
on the versions of Windows that we support, so this currently
only serves as a way to slow down startup.
2017-06-08 12:38:05 -04:00
Sylvestre Ledru
bc5b6f4ff4 Bug 1366882 - Fix a resource leak - CID 221217 - r=ted
MozReview-Commit-ID: G3THkXZN9GA

--HG--
extra : rebase_source : 1a55c4fd3a6b57af4ba1743c755865d7a5d03d69
2017-05-22 23:23:08 +02:00