Commit Graph

716 Commits

Author SHA1 Message Date
Henrik Skupin
d20778cacd Bug 1710000 - [remote] Allow the "remote-listening" observer to also print other messages to stderr. r=remote-protocol-reviewers,jgraham,jdescottes
It's needed to independently print messages for CDP and/or
WebDriver BiDi depending on which protocol is actually active.

Differential Revision: https://phabricator.services.mozilla.com/D114572
2021-05-10 08:55:31 +00:00
Iulian Moraru
8c46a6b4ca Backed out changeset 8307b8b0bc7c (bug 1710000) for causing mochitests failures on browser_agent.js. CLOSED TREE 2021-05-07 20:27:37 +03:00
Henrik Skupin
884ece1b7f Bug 1710000 - [remote] Allow the "remote-listening" observer to also print other messages to stderr. r=remote-protocol-reviewers,jgraham
It's needed to independently print messages for CDP and/or
WebDriver BiDi depending on which protocol is actually active.

Differential Revision: https://phabricator.services.mozilla.com/D114572
2021-05-07 14:26:59 +00:00
Henrik Skupin
955d7a045e Bug 1693296 - [remote] Hardening Browser.close() for a clean shutdown. r=remote-protocol-reviewers,jdescottes
For a shutdown attempt all windows should be informed first so
that various components can safely do clean-up work.

If something prevents the shutdown the Remote Agent should force it.
This will make sure that no application process remains,
or would have to be force killed externally via its PID.

Differential Revision: https://phabricator.services.mozilla.com/D105490
2021-05-04 06:34:37 +00:00
Henrik Skupin
3504533e98 Bug 1701674 - [remote] Add handling of expectation data to readme. r=remote-protocol-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D113499
2021-04-27 12:43:31 +00:00
Henrik Skupin
460f0ed59f Bug 1676803 - [remote] Hardening discards of registered FileIO streams. r=remote-protocol-reviewers,jdescottes
In some situations the FileIO stream's underlying file might not
exist anymore. Discarding the stream should not fail.

Depends on D112004

Differential Revision: https://phabricator.services.mozilla.com/D113379
2021-04-26 19:46:09 +00:00
Butkovits Atila
2e34e363b9 Backed out 2 changesets (bug 1696251) for causing js-bench-sm failures. CLOSED TREE
Backed out changeset 1c84c9a34575 (bug 1696251)
Backed out changeset e169193b7423 (bug 1696251)
2021-04-23 02:53:36 +03:00
Alex Lopez
d1a82b8092 Bug 1696251 - Pass MachCommandBase object as first argument for Mach Commands. r=mhentges,remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers
As an intermediate step to allow mach commands as standalone functions, the MachCommandBase
subclass instance that currently corresponds to self has to be made available as a separate
argument (named command_context).

Differential Revision: https://phabricator.services.mozilla.com/D109650
2021-04-22 18:56:15 +00:00
Henrik Skupin
e5512a23ac Bug 1701168 - [remote] Properly wait for resize events on browser dimension changes. r=remote-protocol-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D112738
2021-04-20 18:15:45 +00:00
Henrik Skupin
4d050d2ebf Bug 1693763 - [remote] Downstream sync graceful browser shutdown. r=remote-protocol-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D110061
2021-04-20 04:46:00 +00:00
Henrik Skupin
a7c720d7c9 Bug 1704998 - [remote] Don't use hidden window for WebSocket creation. r=remote-protocol-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D112082
2021-04-19 17:16:14 +00:00
Cosmin Sabou
785f9b8a87 Backed out changeset d4a5d8567977 (bug 1696251) for non-unified build bustages. CLOSED TREE 2021-04-19 19:43:31 +03:00
Alex Lopez
75dfe35468 Bug 1696251 - Pass MachCommandBase object as first argument for Mach Commands. r=mhentges,remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers
As an intermediate step to allow mach commands as standalone functions, the MachCommandBase
subclass instance that currently corresponds to self has to be made available as a separate
argument (named command_context).

Differential Revision: https://phabricator.services.mozilla.com/D109650
2021-04-19 16:15:11 +00:00
Emilio Cobos Álvarez
9afefdd884 Bug 1705757 - Move FrameLoader.print to BrowsingContext.print. r=nika,remote-protocol-reviewers,marionette-reviewers,extension-reviewers,zombie
This makes it trivial to choose the right BrowserParent to print a
browsing context, by removing the OuterWindowID / FrameLoader
indirections.

Differential Revision: https://phabricator.services.mozilla.com/D112412
2021-04-17 18:41:11 +00:00
Henrik Skupin
ff3dfaa3ad Bug 1704548 - [remote] Re-enable Target.receivedMessageFromTarget events. r=remote-protocol-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D111702
2021-04-13 04:18:51 +00:00
Henrik Skupin
6303ba95ce Bug 1704542 - [remote] Remove "CDP: *" Bugzilla component suggestions from moz.build. r=remote-protocol-reviewers,jdescottes
DONTBUILD

Differential Revision: https://phabricator.services.mozilla.com/D111643
2021-04-12 18:11:55 +00:00
tildaudufo
bfa02a1052 Bug 1631570 - [remote] Use optional options arguments for all public CDP commands r=whimboo,remote-protocol-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D105046
2021-04-10 10:36:53 +00:00
Mike Conley
3234dacb1a Bug 1686743 - Fix up CDP tests for when prompts.contentPromptSubDialog is enabled. r=remote-protocol-reviewers,mtigley,jdescottes,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D110270
2021-04-08 16:50:01 +00:00
Henrik Skupin
10ed8516d0 Bug 1702142 - [remote] Unify logging between Marionette and Remote Agent. r=remote-protocol-reviewers,jgraham
Differential Revision: https://phabricator.services.mozilla.com/D110936
2021-04-06 15:08:50 +00:00
Bogdan Tara
c4608fba0e Backed out changeset 0fccc6a4922d (bug 1686743) for remote failures on browser_javascriptDialog_* CLOSED TREE 2021-04-01 20:40:33 +03:00
Mike Conley
e5940abe8b Bug 1686743 - Fix up CDP tests for when prompts.contentPromptSubDialog is enabled. r=remote-protocol-reviewers,mtigley,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D110270
2021-04-01 16:43:14 +00:00
Julian Descottes
3382fe303e Bug 1702406 - [remote] Rename targets to targetList in remote codebase r=remote-protocol-reviewers,jgraham
Differential Revision: https://phabricator.services.mozilla.com/D110514
2021-04-01 12:27:25 +00:00
Dorel Luca
60a72134cc Backed out changeset 4d29ba47da66 (bug 1693763) for causing Bug 1701960. CLOSED TREE 2021-03-30 21:35:47 +03:00
Julian Descottes
43975df10a Bug 1609162 - [remote] Start remote agent only once in remote mochitests r=remote-protocol-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D110214
2021-03-30 12:25:32 +00:00
Henrik Skupin
9f673fb7ee Bug 1693763 - [remote] Downstream sync graceful browser shutdown. r=remote-protocol-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D110061
2021-03-29 12:30:02 +00:00
Julian Descottes
7f55e6839f Bug 1694506 - [puppeteer] Update puppeteer-expected.json for v8.0.0 r=remote-protocol-reviewers,whimboo
Depends on D108859

Summary of changes.
New tests:
- PASS: Page Page.waitForRequest should work with async predicate (page.spec.ts)
- PASS: JSHandle JSHandle.jsonValue works with jsonValues that are not objects (jshandle.spec.ts)
- PASS: JSHandle JSHandle.jsonValue works with jsonValues that are primitives (jshandle.spec.ts)
- FAIL: Page Page.emulateNetworkConditions should change navigator.connection.effectiveType (page.spec.ts)
- FAIL: Launcher specs Puppeteer Puppeteer.connect should be able to reconnect (launcher.spec.ts)

The existing TIMEOUT test "Page Page.Events.Popup should work with clicking target=_blank (page.spec.ts)" was split in 2:
- TIMEOUT: Page Page.Events.Popup should work with clicking target=_blank and without rel=opener (page.spec.ts)
- TIMEOUT: Page Page.Events.Popup should work with clicking target=_blank and with rel=opener (page.spec.ts)

The existing FAIL test "Screenshots Page.screenshot should clip elements to the viewport (screenshot.spec.ts)" was changed and is now passing (we didn't clip to the viewport, and puppeteer doesn't expect that anymore):
- PASS: Screenshots Page.screenshot should get screenshot bigger than the viewport (screenshot.spec.ts)

The existing SKIP test "Launcher specs Puppeteer Puppeteer.launch should be able to launch Firefox (launcher.spec.ts)" is now running with itFailsWindows instead of itOnlyRegularInstall. It used to be flagged as SKIP, but it is now failing because we attempt to run it.
- FAIL: Launcher specs Puppeteer Puppeteer.launch should be able to launch Firefox (launcher.spec.ts)

Differential Revision: https://phabricator.services.mozilla.com/D108100
2021-03-18 15:02:13 +00:00
Julian Descottes
408f997797 Bug 1694506 - [puppeteer] chore: skip non-standard cookie asserts on Firefox (sync #6994) r=remote-protocol-reviewers,whimboo
Depends on D108099

Synchronize the upstream change merged at https://github.com/puppeteer/puppeteer/pull/6994

Differential Revision: https://phabricator.services.mozilla.com/D108859
2021-03-18 15:02:13 +00:00
Julian Descottes
3eac4f3ce3 Bug 1694506 - [puppeteer] Sync vendored puppeteer to v8.0.0 r=remote-protocol-reviewers,whimboo
Generated by running ./mach remote vendor-puppeteer and replacing itFailsFirefox to it etc...

Differential Revision: https://phabricator.services.mozilla.com/D108099
2021-03-18 15:02:12 +00:00
Henrik Skupin
43261f7648 Bug 1698152 - [puppeteer] Improve "Page.close should run beforeunload if asked for" unittest for Firefox. r=remote-protocol-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D108636
2021-03-16 15:38:39 +00:00
Ted Campbell
0004fb8b5c Bug 1697954 - Remove unused javascript.options.showInConsole prefs r=marionette-reviewers,webdriver-reviewers,mossop,remote-protocol-reviewers,whimboo
This dates back to a time before the browser console where the normal content
console could optionally show chrome code messages. Today it serves no use.

Differential Revision: https://phabricator.services.mozilla.com/D108130
2021-03-15 19:50:41 +00:00
Henrik Skupin
306b013345 Bug 1695243 - [remote] Remove 3rd argument when importing "addDebuggerToGlobal". r=remote-protocol-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D107649
2021-03-09 15:15:40 +00:00
Henrik Skupin
85f09833cd Bug 1695639 - [remote] Enforce disabling of update checks. r=remote-protocol-reviewers,jdescottes
Use the preference "app.update.disabledForTesting" to enforce
that no update checks are performed when the Remote Agent is
active.

Differential Revision: https://phabricator.services.mozilla.com/D106909
2021-03-08 13:44:55 +00:00
Henrik Skupin
983c92b44e Bug 1696160 - [remote] Only reset those recommended preferences that were previously set. r=remote-protocol-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D107054
2021-03-08 13:44:55 +00:00
Bogdan Tara
9d696ebe03 Backed out 2 changesets (bug 1695639) for remote crashes CLOSED TREE
Backed out changeset a54388a30704 (bug 1695639)
Backed out changeset d345b8a1d9ec (bug 1695639)
2021-03-03 00:22:18 +02:00
Henrik Skupin
f46a866ba6 Bug 1695639 - [remote] Enforce disabling of update checks. r=remote-protocol-reviewers,jdescottes
Use the preference "app.update.disabledForTesting" to enforce
that no update checks are performed when the Remote Agent is
active.

Differential Revision: https://phabricator.services.mozilla.com/D106909
2021-03-02 17:35:15 +00:00
Henrik Skupin
b7893c030d Bug 1601618 - [remote] Use lazy loading of modules and delayed setting of global properties. r=remote-protocol-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D106602
2021-02-26 15:37:41 +00:00
Henrik Skupin
889c0aae00 Bug 1694322 - [remote] Fix "mach file-info bugzilla-component" for /remote/cdp. r=remote-protocol-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D106614
2021-02-26 15:22:58 +00:00
Cosmin Sabou
960ace0eea Bug 1690475 - Fix lint error on mach_commands.py. a=lint-fix 2021-02-23 19:55:30 +02:00
Henrik Skupin
3b79ee16fe Bug 1690475 - [remote] Move puppeteer-expected.json into test folder. r=remote-protocol-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D106063
2021-02-23 17:37:03 +00:00
Henrik Skupin
563458af7d Bug 1690475 - [remote] Reorganize xpcshell and browser chrome tests. r=remote-protocol-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D106062
2021-02-23 17:37:03 +00:00
Henrik Skupin
c1aa949ca0 Bug 1693021 - [puppeteer] Add --enable-webrender argument to mach command. r=remote-protocol-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D105361
2021-02-17 08:48:57 +00:00
Henrik Skupin
8cb90829cc Bug 1690474 - [remote] Move CDP specific code to cdp/. r=remote-protocol-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D104574
2021-02-14 14:24:27 +00:00
Henrik Skupin
a8048b6222 Bug 1691814 - [remote] Improve failure message for timestamp assertions. r=remote-protocol-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D104578
2021-02-13 11:04:09 +00:00
Henrik Skupin
198eb87df5 Bug 1682076 - [remote] Add favicon.ico for Puppeteer unit tests. r=remote-protocol-reviewers,jdescottes
Temporarily add a favicon to fix Puppeteer tests relying on a proper set of console log messages. It's the same favicon as used in https://github.com/puppeteer/puppeteer/pull/6868 which will land post Puppeteer 7.0.4.

Differential Revision: https://phabricator.services.mozilla.com/D104809
2021-02-13 11:03:29 +00:00
Kris Maglione
0ec4615244 Bug 1662840: Move overrideDPPX from nsIContentViewer to BrowsingContext. r=whimboo,remote-protocol-reviewers,mtigley,emilio
Differential Revision: https://phabricator.services.mozilla.com/D104001
2021-02-10 01:30:35 +00:00
Henrik Skupin
dec36ad2f5 Bug 1690469 - [remote] Reorganize Remote Agent Rust module. r=remote-protocol-reviewers,jgraham
Differential Revision: https://phabricator.services.mozilla.com/D104209
2021-02-06 16:27:22 +00:00
Henrik Skupin
d461492d57 Bug 1690468 - [remote] Move Remote Agent component related files to components/. r=remote-protocol-reviewers,jgraham,mak
Differential Revision: https://phabricator.services.mozilla.com/D104159
2021-02-08 12:34:37 +00:00
Henrik Skupin
a82f8b1b2d Bug 1690472 - [remote] Move sharable top-level JS modules to shared/ subfolder. r=remote-protocol-reviewers,jgraham
Differential Revision: https://phabricator.services.mozilla.com/D103944
2021-02-06 16:27:01 +00:00
Paul Zuehlcke
cbda00d7e1 Bug 1596897 - Updated tests for decoupled permissions panel. r=johannh,remote-protocol-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D99893
2021-02-05 13:40:42 +00:00
Bogdan Tara
bbc8af695c Backed out 3 changesets (bug 1690472, bug 1690469, bug 1690468) for browser_Troubleshoot.js failures CLOSED TREE
Backed out changeset a8552dfa3009 (bug 1690469)
Backed out changeset dccc9af2fd2d (bug 1690468)
Backed out changeset 3f2817c73dff (bug 1690472)
2021-02-05 18:15:26 +02:00