Commit Graph

18366 Commits

Author SHA1 Message Date
hb
f05c8469c7 Bug 1575217, r=michal,dragana
Differential Revision: https://phabricator.services.mozilla.com/D43761

--HG--
extra : moz-landing-system : lando
2019-09-02 18:06:09 +00:00
Tom Schuster
68ebc30ae5 Bug 1405971 - Strip existing disallowed schemes in Origin header. r=JuniorHsu,ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D39781

--HG--
extra : moz-landing-system : lando
2019-09-03 18:58:18 +00:00
arthur.iakab
4ea120b5cb Backed out changeset e3f06f11de62 (bug 1237782) for causing browser-chrome failure on automation.py CLOSED TREE 2019-09-03 21:04:49 +03:00
Jonathan Kingston
dbfd29b586 Bug 1237782 - Remove http override and add appcache pref r=baku
Differential Revision: https://phabricator.services.mozilla.com/D44472

--HG--
extra : moz-landing-system : lando
2019-09-03 16:44:13 +00:00
Honza Bambas
482bfa7a25 Bug 1559088 - Fix test_redirect-caching_failure.js to again do what it has to, r=kershaw
Differential Revision: https://phabricator.services.mozilla.com/D43796

--HG--
extra : moz-landing-system : lando
2019-09-03 12:24:11 +00:00
Andrea Marchesini
d5803b5f62 Bug 1563313 - URL-Classifier should process nsIChannel before the proxy, r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D36872

--HG--
extra : moz-landing-system : lando
2019-09-03 10:50:40 +00:00
Dorel Luca
15fefbe415 Merge mozilla-inbound to mozilla-central. a=merge 2019-09-03 07:03:04 +03:00
Jean-Yves Avenard
1c657f7d19 Bug 1556489 - P25. Make nsIIdentChannel support conditional for nsBaseChannel. r=mayhemer
So that we can restrict QI(nsIIdentChannel) to nsIHttpChannel and DocumentChannelChild objects only.

Differential Revision: https://phabricator.services.mozilla.com/D44111

MANUAL PUSH: multiple authors stack
2019-09-03 10:20:16 +10:00
Jean-Yves Avenard
5749840f21 Bug 1556489 - P23 - Only create new ClientSource objects in the content, but use the recreated info from redirects in the parent. r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D42260
2019-09-03 10:19:53 +10:00
Jean-Yves Avenard
ff8e5e92fd Bug 1556489 - P22 - Manually add history entries for all DocumentChannel redirects, since these aren't exposed to the content process as channel redirects. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D42259
2019-09-03 10:19:53 +10:00
Matt Woodrow
4151ea2a94 Bug 1556489 - P21 - Cache the original referrer before url classification has been applied to send back to the content process, since the docshell expects to find the original. r=mayhemer,tnguyen
Differential Revision: https://phabricator.services.mozilla.com/D42258
2019-09-03 10:19:52 +10:00
Jean-Yves Avenard
9cdcb33634 Bug 1556489 - P20 - Remove unused method. r=mayhemer 2019-09-03 10:19:52 +10:00
Jean-Yves Avenard
d65c5e0309 Bug 1556489 - P19. Fix devtools stack traces. r=honza,ochameau
DevTools rely on events when a new HttpChannel is opened, it needs to know when a DocumentChannel is.

Differential Revision: https://phabricator.services.mozilla.com/D40975
2019-09-03 10:19:46 +10:00
Matt Woodrow
1b5f7c772a Bug 1556489 - P18. Add DocumentChannel and hook it up. r=nika,mayhemer
DocumentChannel acts as a replacement for HttpChannel where redirects are now entirely handled in the DocumentChannelParent. The ContentChild will receive the final nsIChannel once all redirects have been handled.

Differential Revision: https://phabricator.services.mozilla.com/D37490
2019-09-03 10:19:38 +10:00
Jean-Yves Avenard
f0b40a38d7 Bug 1556489 - P15. Move methods into dedicated nsI* interface. r=mayhemer
This allows in the future for the nsHttpChannel to deal with things others than the HttpChannelParent.

Differential Revision: https://phabricator.services.mozilla.com/D40972
2019-09-03 10:19:37 +10:00
Matt Woodrow
8a54afbb4c Bug 1556489 - P14. No longer pass nsILoadInfo to TriggerCrossProcessRedirect. r=mayhemer
We can deduct it from the nsIChannel argument already. In the future, the httpParent may be either HttpChannelParent or DocumentChannelParent.

Differential Revision: https://phabricator.services.mozilla.com/D40971
2019-09-03 10:19:36 +10:00
Jean-Yves Avenard
b43fd91ea2 Bug 1556489 - P11. Add nIIdentChannel interface. r=mayhemer
The devtools listens to http-on-opening-request event which is expected to receive a nsIHttpChannel. However future changes will make it that it's not always a nsIHttpChannel that can fire such event.

As such we create an intermediary interface nsIIdentChannel and move the subset generating such event in nsIHttpChannel there.

Differential Revision: https://phabricator.services.mozilla.com/D40968
2019-09-03 10:19:34 +10:00
Matt Woodrow
a209298de2 Bug 1556489 - P7. Make LoadInfoArgsToLoadInfo works with LoadInfo class. r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D40964
2019-09-03 10:19:11 +10:00
Jean-Yves Avenard
0c52caf2b2 Bug 1556489 - P6. Simplify use of namespace. r=mayhemer
This is a cosmetic only change.

Differential Revision: https://phabricator.services.mozilla.com/D40963
2019-09-03 10:19:10 +10:00
Jean-Yves Avenard
e76aa88e15 Bug 1556489 - P4. Add ability to set Document object on LoadInfo. r=mayhemer,ckerschb
This will be required to access the Performance object from future DocumentChannel.

Differential Revision: https://phabricator.services.mozilla.com/D41133
2019-09-03 10:18:58 +10:00
Jean-Yves Avenard
a23b70b74e Bug 1556489 - P3. Move logic on when to return the PerformanceStorage into nsILoadInfo. r=mayhemer
This more closely follow the code as earlier documented. To remove all ambiguities, the idl documentation was amended.

Differential Revision: https://phabricator.services.mozilla.com/D40961
2019-09-03 09:50:05 +10:00
Jean-Yves Avenard
de650bb217 Bug 1556489 - P2. Use ReplacementChannelConfig across HttpChannelParent and ContentChild. r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D40960
2019-09-03 09:49:46 +10:00
Jean-Yves Avenard
cc07990908 Bug 1556489 - P1. Introduce ReplacementChannelConfig. r=mayhemer
This class allows to encapsulate all the information required in order to create a new HttpChannel object following a redirect.

Differential Revision: https://phabricator.services.mozilla.com/D40959
2019-09-03 09:47:17 +10:00
Michal Novotny
85857b979d Bug 1577354 - Assertion failure: decoded.CountChar('\t') == 2, at /netwerk/cache2/CacheFileContextEvictor.cpp:409, r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D43902

--HG--
extra : moz-landing-system : lando
2019-09-02 17:26:08 +00:00
Honza Bambas
26889bce93 Bug 1578136 - Add a non-null check before dereferencing TLSFilterTransaction::Connection(), r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D44391

--HG--
extra : moz-landing-system : lando
2019-09-02 17:22:23 +00:00
Michal Novotny
a9aa8451c2 Bug 1570932 - Add telemetry about how often we observe network change events, r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D44215

--HG--
extra : moz-landing-system : lando
2019-08-30 18:18:19 +00:00
arthur.iakab
fd7aae5565 Backed out changeset 9057d052acee (bug 1559088) for causing xpcshell failures on test_redirect-caching_failure.js CLOSED TREE 2019-08-30 21:37:15 +03:00
Honza Bambas
1b5f4ca60b Bug 1559088 - Fix test_redirect-caching_failure.js to again do what it has to, r=kershaw
Differential Revision: https://phabricator.services.mozilla.com/D43796

--HG--
extra : moz-landing-system : lando
2019-08-30 16:44:11 +00:00
Ehsan Akhgari
625509f19c Bug 1399803 - Consider all IPv4 loopback addresses as secure context; r=bzbarsky,dragana
Differential Revision: https://phabricator.services.mozilla.com/D43633

--HG--
extra : moz-landing-system : lando
2019-08-30 07:57:34 +00:00
Eric Rahm
e678238a60 Bug 1569323 - Remove verbose warning in SetUserPass. r=mayhemer
This removes a rather verbose warning during URI mutation. This often
happens for use cases such as attempting to clear the field. Since `Finalize`
is marked as `MOZ_MUST_USE` we can be confident that any failures that used
to be warned about are properly handled.

Differential Revision: https://phabricator.services.mozilla.com/D42384

--HG--
extra : moz-landing-system : lando
2019-08-22 14:49:28 +00:00
Ehsan Akhgari
d5e2f368cc Bug 1529396 - Fix another test CLOSED TREE
Bug #: 1529396

Differential Revision: https://phabricator.services.mozilla.com/D44071

--HG--
extra : amend_source : 7445e9c7c4168365e363731dcc69b76a8bea3c20
2019-08-30 01:50:41 +03:00
Ehsan Akhgari
52b58160a7 Bug 1576109 - Ensure that the content blocking allow list principal is set correctly during HTTP redirects; r=baku,dragana
Differential Revision: https://phabricator.services.mozilla.com/D43541

--HG--
extra : moz-landing-system : lando
2019-08-29 18:48:43 +00:00
Bogdan Tara
3310211997 Backed out changeset a4768bd82d57 (bug 1559088) for test_redirect-caching_failure_wrap.js failures CLOSED TREE 2019-08-29 21:01:38 +03:00
Honza Bambas
bcbbd6b737 Bug 1559088 - Fix test_redirect-caching_failure.js to again do what it has to, r=kershaw
Differential Revision: https://phabricator.services.mozilla.com/D43796

--HG--
extra : moz-landing-system : lando
2019-08-29 12:07:54 +00:00
Michal Novotny
19c05de902 Bug 1576826 - Intermittent Assertion failure: isResponse, at NetlinkService.cpp:613, r=kershaw
Obviously broadcasted messages can be multipart too.

Differential Revision: https://phabricator.services.mozilla.com/D43849

--HG--
extra : moz-landing-system : lando
2019-08-29 12:08:53 +00:00
Barret Rennie
b0cbc31990 Bug 1510569 - Implement serializers for nsITransportSecurityInfo, nsIX509Cert, and nsIX509CertList r=froydnj,keeler,mayhemer
As part of the ongoing effort to port the nsIWebProgress events from
RemoteWebProgress / WebProgressChild to BrowserParent / BrowserChild, we need
to (de)serialize the nsITransportSecurityInfo instance across the IPC layer.
The existing code was calling `NS_SerializeToString` which has the overhead of
(a) allocating a buffer and also performing base64 encoding/decoding. This
patch adds `IPC::ParamTraits` implementations for `nsITransportSecurityInfo`,
`nsIX509Certificate`, and `nsIX509CertList` that (de)serializes the params
directly onto and off of the IPC message so that we don't go through the
overhead of allocating and encoding/decoding an additional buffer.

This (de)serialization will address the performance issues present in the
current implementation.

As a side effect, I also make nsITransportSecurityInfo a builtinclass XPCOM
interface, since the existing serialization code was assuming it was, there is
only one implementation, and it is in C++.

Differential Revision: https://phabricator.services.mozilla.com/D35090

--HG--
extra : moz-landing-system : lando
2019-08-28 18:55:31 +00:00
Dorel Luca
b09fe526aa Backed out 4 changesets (bug 1510569) for build bustage. CLOSED TREE
Backed out changeset d7db6a1935ce (bug 1510569)
Backed out changeset 03b7cf756a7f (bug 1510569)
Backed out changeset fa318eec0e76 (bug 1510569)
Backed out changeset cecb17bd8c03 (bug 1510569)
2019-08-28 21:46:40 +03:00
Barret Rennie
4ab0fd7d38 Bug 1510569 - Implement serializers for nsITransportSecurityInfo, nsIX509Cert, and nsIX509CertList r=froydnj,keeler,mayhemer
As part of the ongoing effort to port the nsIWebProgress events from
RemoteWebProgress / WebProgressChild to BrowserParent / BrowserChild, we need
to (de)serialize the nsITransportSecurityInfo instance across the IPC layer.
The existing code was calling `NS_SerializeToString` which has the overhead of
(a) allocating a buffer and also performing base64 encoding/decoding. This
patch adds `IPC::ParamTraits` implementations for `nsITransportSecurityInfo`,
`nsIX509Certificate`, and `nsIX509CertList` that (de)serializes the params
directly onto and off of the IPC message so that we don't go through the
overhead of allocating and encoding/decoding an additional buffer.

This (de)serialization will address the performance issues present in the
current implementation.

As a side effect, I also make nsITransportSecurityInfo a builtinclass XPCOM
interface, since the existing serialization code was assuming it was, there is
only one implementation, and it is in C++.

Differential Revision: https://phabricator.services.mozilla.com/D35090

--HG--
extra : moz-landing-system : lando
2019-08-28 18:00:16 +00:00
dlee
f981c3905f Bug 1575811 - Remove |IsAllowListed| check in UrlClassifierCommon::AnnotateChannel. r=Ehsan
When URL Classifier reports a channel is a tracker, we should only notify the classification
result when it is a third-party channel.
That means, |IsAllowListed| should not take into consideation here.

Differential Revision: https://phabricator.services.mozilla.com/D43735

--HG--
extra : moz-landing-system : lando
2019-08-28 13:40:33 +00:00
Henrik Skupin
1803585259 Bug 1570104 - Add shared IPv4 range from RFC 6598 (100.64/10) to allowed list of IP addresses for testing. r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D40167

--HG--
extra : moz-landing-system : lando
2019-08-28 10:58:48 +00:00
Kershaw Chang
5018d39958 Bug 1571987 - Forward proxy check request to parent process r=dragana,bwc
Differential Revision: https://phabricator.services.mozilla.com/D41004

--HG--
extra : moz-landing-system : lando
2019-08-24 05:37:00 +00:00
Paul Bone
08bc01ab37 Bug 1576814 - Skip tests that timeout r=kmag
Depends on D43572

Differential Revision: https://phabricator.services.mozilla.com/D43573

--HG--
extra : moz-landing-system : lando
2019-08-27 19:07:43 +00:00
Ehsan Akhgari
6ed82c152f Bug 1540117 - Part 1: Do not generate a console warning when we reject an attempt to retrieve a cookie for a host that has none stored; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D43270

--HG--
extra : moz-landing-system : lando
2019-08-27 15:10:45 +00:00
Noemi Erli
d6af4c1426 Backed out 3 changesets (bug 1540117) for failures in browser_storageAccessPrivateWindow.js
Backed out changeset 1dcf5956a3f1 (bug 1540117)
Backed out changeset 1dc867e1d4b2 (bug 1540117)
Backed out changeset c93e83feda5e (bug 1540117)
2019-08-27 18:06:58 +03:00
Ehsan Akhgari
184c0ca703 Bug 1540117 - Part 1: Do not generate a console warning when we reject an attempt to retrieve a cookie for a host that has none stored; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D43270

--HG--
extra : moz-landing-system : lando
2019-08-27 10:36:39 +00:00
Michal Novotny
390918caab Bug 1567616 - network id based on default gateway is wrong when VPN overrides default gateway by more specific routes r=dragana
This patch implements NetlinkService which communicates with kernel via netlink socket. It keeps track of addresses, default routes, interfaces and neighbors and uses it to calculate network ID.

Differential Revision: https://phabricator.services.mozilla.com/D43175

--HG--
rename : netwerk/system/linux/nsNotifyAddrListener_Linux.cpp => netwerk/system/linux/nsNetworkLinkService.cpp
rename : netwerk/system/linux/nsNotifyAddrListener_Linux.h => netwerk/system/linux/nsNetworkLinkService.h
extra : moz-landing-system : lando
2019-08-26 21:46:32 +00:00
Andreea Pavel
f042d32425 Backed out changeset 22469090e93e (bug 1567616) for build bustages on a CLOSED TREE
--HG--
rename : netwerk/system/linux/nsNetworkLinkService.cpp => netwerk/system/linux/nsNotifyAddrListener_Linux.cpp
rename : netwerk/system/linux/nsNetworkLinkService.h => netwerk/system/linux/nsNotifyAddrListener_Linux.h
2019-08-27 00:30:40 +03:00
Michal Novotny
128254f45e Bug 1567616 - network id based on default gateway is wrong when VPN overrides default gateway by more specific routes r=dragana
This patch implements NetlinkService which communicates with kernel via netlink socket. It keeps track of addresses, default routes, interfaces and neighbors and uses it to calculate network ID.

Differential Revision: https://phabricator.services.mozilla.com/D43175

--HG--
rename : netwerk/system/linux/nsNotifyAddrListener_Linux.cpp => netwerk/system/linux/nsNetworkLinkService.cpp
rename : netwerk/system/linux/nsNotifyAddrListener_Linux.h => netwerk/system/linux/nsNetworkLinkService.h
extra : moz-landing-system : lando
2019-08-26 20:03:33 +00:00
Dragana Damjanovic
2826398670 Bug 1575780 - We need a long request's timeout for trronly mode. r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D43410

--HG--
extra : moz-landing-system : lando
2019-08-26 19:52:20 +00:00
Honza Bambas
e09f9634c2 Bug 1451714 - Fix comment over LOAD_NO_NETWORK_IO flag, r=michal
Simply removing the confusing and not much info providing sentence.

Differential Revision: https://phabricator.services.mozilla.com/D43451

--HG--
extra : moz-landing-system : lando
2019-08-26 13:58:47 +00:00