Commit Graph

1546 Commits

Author SHA1 Message Date
Milan Sreckovic
3db2b5ee67 Bug 1423551: Use BaseRect access methods instead of member variables in view/. r=jet
MozReview-Commit-ID: 1VlWJWAqRB3

--HG--
extra : rebase_source : 4c713d43fda024ac4f2c590b77c84ad3cfbd9ff5
2018-01-10 11:16:22 -05:00
Sylvestre Ledru
eabcdd21b2 Bug 1278282 - Replace #if (MOZ_WIDGET_GTK == 3) by #ifdef MOZ_WIDGET_GTK r=lsalzman
MozReview-Commit-ID: Bo0m7n078oh

--HG--
extra : rebase_source : 1874ac3e0abca65b821b5d04a6610a5cbb63fe24
2018-01-09 11:51:07 +01:00
Mats Palmgren
1c2b8c222e Bug 1414666 part 1 - Add nsIFrame::PresShell() for convenient access to the shell. r=emilio
MozReview-Commit-ID: 8FPTPKWyVtY
2017-11-09 03:00:48 +01:00
Xidorn Quan
712cec8d27 Bug 1397644 part 2 - Remove test annotations for this bug. r=emilio
MozReview-Commit-ID: 3JbqY0UMTuh

--HG--
extra : source : c7eff47660a88d702a3c8daea692faadac95e024
2017-10-20 21:31:13 +11:00
Xidorn Quan
fd467033f9 Bug 1407847 - Enable stylo for XUL document without system principal and annotate failures accordingly. r=heycam
MozReview-Commit-ID: KcJxloT2rR8

--HG--
extra : rebase_source : 8943efaa7afbf1bc74ac85ca103a52e2f4d1b1a4
2017-10-12 10:43:38 +11:00
Matt Woodrow
fdf09b88f2 Bug 1261175. r=tnikkel, a=abillings 2017-10-12 13:10:27 +13:00
Olli Pettay
7c1513048a Bug 1398196, flush layout before hittesting when handling mousedown/up, r=ehsan
--HG--
extra : rebase_source : 2850005ddbf1f68141bf309249c57925ba68e6ef
2017-09-14 23:26:24 +03:00
Kirk Steuber
6e217001f8 Bug 1362382 - Move RegisterDragDrop to be called during idle time, if possible r=jimm
Additionally, do not call RegisterDragDrop for hidden windows.

MozReview-Commit-ID: Fv8j9FntGGT

--HG--
extra : rebase_source : fccbc576887d000805da8ac915d16fc4fddfeceb
2017-08-30 11:18:25 -07:00
Timothy Nikkel
8dddd316bb Backed out changeset 497dbf087ad5 (add diagnostic asserts) (bug 1354933) 2017-07-07 14:54:55 -05:00
Timothy Nikkel
417163a1db Back out changeset 43af422173e3 (add diagnostic asserts) (bug 1354933) 2017-06-22 15:40:40 -05:00
Sylvestre Ledru
4e9cf83ee8 Bug 1378712 - Remove all trailing whitespaces r=Ehsan
MozReview-Commit-ID: Kdz2xtTF9EG

--HG--
extra : rebase_source : 7235b3802f25bab29a8c6ba40a181a722f3df0ce
2017-07-06 14:00:35 +02:00
Bill McCloskey
f115503a0b Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-26 14:19:58 -07:00
Nicholas Nethercote
58786e1ea7 Bug 1375392 - Tweak the PROFILER_LABEL* macros. r=mstange.
This patch makes the following changes to the macros.

- Removes PROFILER_LABEL_FUNC. It's only suitable for use in functions outside
  classes, due to PROFILER_FUNCTION_NAME not getting class names, and it was
  mostly misused.

- Removes PROFILER_FUNCTION_NAME. It's no longer used, and __func__ is
  universally available now anyway.

- Combines the first two string literal arguments of PROFILER_LABEL and
  PROFILER_LABEL_DYNAMIC into a single argument. There was no good reason for
  them to be separate, and it forced a '::' in the label, which isn't always
  appropriate. Also, the meaning of the "name_space" argument was interpreted
  in an interesting variety of ways.

- Adds an "AUTO_" prefix to PROFILER_LABEL and PROFILER_LABEL_DYNAMIC, to make
  it clearer they construct RAII objects rather than just being function calls.
  (I myself have screwed up the scoping because of this in the past.)

- Fills in the 'js::ProfileEntry::Category::' qualifier within the macro, so
  the caller doesn't need to. This makes a *lot* more of the uses fit onto a
  single line.

The patch also makes the following changes to the macro uses (beyond those
required by the changes described above).

- Fixes a bunch of labels that had gotten out of sync with the name of the
  class and/or function that encloses them.

- Removes a useless PROFILER_LABEL use within a trivial scope in
  EventStateManager::DispatchMouseOrPointerEvent(). It clearly wasn't serving
  any useful purpose. It also serves as extra evidence that the AUTO_ prefix is
  a good idea.

- Tweaks DecodePool::SyncRunIf{Preferred,Possible} so that the labelling is
  done within them, instead of at their callsites, because that's a more
  standard way of doing things.

--HG--
extra : rebase_source : 318d1bc6fc1425a94aacbf489dd46e4f83211de4
2017-06-22 17:08:53 +10:00
Carsten "Tomcat" Book
8a1350b5a6 Backed out changeset 4f6302a98ae4 (bug 1372405)
--HG--
extra : rebase_source : 41632f3158e88e692809731394a683d065a73dfb
2017-06-21 13:59:26 +02:00
Bill McCloskey
6b3e84ed5f Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-20 21:44:11 -07:00
Carsten "Tomcat" Book
ea1b86680c Backed out changeset 9846de3bd954 (bug 1372405)
--HG--
extra : rebase_source : 5d4a48e8ec394c329994689d938d2a6e9b2752b0
2017-06-20 08:27:02 +02:00
Bill McCloskey
4592152411 Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-19 22:25:47 -07:00
Timothy Nikkel
6c8d12a5d2 Bug 1354933. Add some asserts for document viewer teardown. r=mats 2017-06-03 01:31:12 -05:00
Mats Palmgren
297b9d70e1 Bug 1365614 part 3 - Backout bug 1333482 part 1-9. Removes support for [-webkit-]appearance for now b/c web compat issues. r=bz
MozReview-Commit-ID: IbwWM0FL6HF

--HG--
extra : source : bbb688fe1ba3f5201a190c6e25b693ef7272ea2d
2017-05-21 17:15:00 +08:00
Carsten "Tomcat" Book
00d4ea331d Backed out changeset bbb688fe1ba3 (bug 1365614) 2017-05-22 15:45:31 +02:00
Mats Palmgren
e706869580 Bug 1365614 part 3 - Backout bug 1333482 part 1-9. Removes support for [-webkit-]appearance for now b/c web compat issues. r=bz 2017-05-21 17:15:00 +08:00
Jeremy Chen
920934c51e Bug 1363000 - re-enable <select> related SVG crashtests. r=heycam
MozReview-Commit-ID: CXoNYeiwJpL

--HG--
extra : rebase_source : d6c3a58bf07cb557f2be0d8311a6be11f1cee35f
2017-05-12 10:52:16 +08:00
Cameron McCormack
203bdaed3b Bug 1361235 - Part 2: Re-enable some tests. r=emilio
MozReview-Commit-ID: 76FaOwHjIMB

--HG--
extra : rebase_source : e2e36bd8a6b86761fe616d7c30d8df7b661a4e09
2017-05-11 19:19:52 +08:00
Jeremy Chen
e265ee592d Bug 1359343 - annotate svg related crashtests to enable stylo for SVG documents. r=heycam
The two skipped tests (1 in layout/base/ and 1 in view/) both cause leaks while
running crashtests, so annotate them with a tracking bug (bug 1363000) filed.

MozReview-Commit-ID: GhSRt4wqu44

--HG--
extra : rebase_source : ed81c75251b35cee7f940b38e3998a6df3c1fcc6
2017-05-05 09:58:56 +00:00
Ting-Yu Lin
918033ba12 Bug 1321754 Part 2 - Update reftest and crashtest expectations for stylo. r=heycam
MozReview-Commit-ID: AunZ2DE209M

--HG--
extra : rebase_source : 4a091cd55581039c8d81f4db9bfbe2af8c0d0863
2017-04-28 14:53:16 +08:00
Emilio Cobos Álvarez
e44543aad4 Bug 1360241: Devirtualize nsIFrame::GetType. r=heycam
MozReview-Commit-ID: 5Nzhyta5Hle

--HG--
extra : rebase_source : c2e9d4bfb9239f5e851d110cd7dff98c1e1a8d8b
2017-04-30 17:30:08 +02:00
Timothy Nikkel
0b57ca9241 Bug 1354933. Add annotation if the view is for a printing document if the view has a frame in its destructor. r=mats 2017-04-27 17:50:00 -05:00
Nicholas Nethercote
625d4520a7 Bug 1357298 - Remove the 'layers.frame-counter' option. r=mstange,mattwoodrow.
This option turns on a frame counter that is shown in the top left corner via a
QR code. It was designed to be used in video recordings of B2G phones.

It no longer seems useful, so this patch removes it.
* * *
Bug 1357298 - Remove all traces of frame numbers and power from the profiler output. r=mstange.

--HG--
extra : rebase_source : 0ce87963ce375df64bb8d80ef2b5d40ea507bc7c
2017-04-18 15:40:24 +10:00
Timothy Nikkel
858e066891 Backed out changeset 2c6ecadd506b (bug 1354933). 2017-04-20 16:39:38 -05:00
Timothy Nikkel
89a24f54e4 Bug 1354933. Assert that the frame pointer is null in the nsView destructor. r=mats 2017-04-18 18:17:35 -05:00
Eric Rahm
861a58d5a4 Bug 1351904 - Switch layout over to ArenaAllocator. r=xidorn
This switches over layout's usage of PLArena to ArenaAllocator. This allows
us to build more files in unified sources and gets rid of various CONST masks.

MozReview-Commit-ID: Aaf3Dl2kaoz
2017-03-31 14:06:33 -07:00
Kartikaya Gupta
3956a6bca3 Merge m-c to graphics
MozReview-Commit-ID: FT418lFT961
2017-03-24 10:10:11 -04:00
Kartikaya Gupta
9a05efe637 Bug 1335745 - Guard against a null rootPresContext. r=tnikkel
With WebRender enabled, the DidComposite notification message can be delayed
because of the extra indirection of the WR Render thread. This can result
in the DidComposite notification arriving for a popup window after it has already
been put into the bfcache and no longer has a root prescontext. This results in
an intermittent crash or assertion failure during crashtests. A null guard here
should avoid the problem.

MozReview-Commit-ID: A1U82tStFsQ
2017-03-23 17:22:26 -04:00
Mats Palmgren
2feec4025d Bug 1333482 part 5 - [css-ui] Enable '-moz-appearance' support for some tests. r=dholbert
* * *
[mq]: sssssssss

MozReview-Commit-ID: 4wgnjld1rDt
2017-03-23 22:11:23 -07:00
Joel Maher
c71ad06da1 Bug 1345514 - add BUG_COMPONENT to view/* files. r=jet
MozReview-Commit-ID: JC3bsH1Ok0D
2017-03-17 16:39:18 -04:00
Matt Woodrow
4be7d40139 Bug 1302071 - Part 5: Bucket PresContext invalidations by transaction ID, and only deliver them when the associated composite has completed. r=tnikkel
This patch does a few things:
* Buckets invalidations by transaction ID, and sends MozAfterPaints events for them when the associated composite completes.
* Creates a separate EventualDidPaint timer for each transaction ID we have invalidations for rather than just using one.
* Removes NotifyDidPaintForSubtree(PAINT_LAYERS), as it was only necessary for the existing bucketing mechanism.

MozReview-Commit-ID: JERMsgxhPQd

--HG--
extra : rebase_source : aad23cb4e77afe12ddf4ebf21db36ae6edec9692
2017-02-17 15:16:15 +13:00
Markus Stange
413dfd064d Bug 1275347 - Move the display list profiler marker to the right place. r=mattwoodrow
MozReview-Commit-ID: JcSmqlXlr4A

--HG--
extra : rebase_source : f3f5982a0c9e8b63310c0134617cf6edf11893fe
2017-02-16 19:18:37 -05:00
Sylvestre Ledru
f30b04c987 Bug 1338086 - Remove useless else blocks in order to reduce complexity in view/ r=tnikkel
MozReview-Commit-ID: 6H794QjWZ1t

--HG--
extra : rebase_source : 613b83061028ad2d3f18f3441c12aa0855327466
2017-02-09 10:42:41 +01:00
Olli Pettay
35e2f8c417 Bug 1338901 - nsViewManager::ProcessPendingUpdatesForView should use AutoTArray to avoid alloc/free, r=tn 2017-02-14 03:44:23 +02:00
Cameron McCormack
b2ee81223c Bug 1334735 - Part 1: Move need style/flush flags from document to pres shell. r=bz
MozReview-Commit-ID: 2Amf9yGRiJA
2017-02-10 10:42:27 +08:00
Julian Seward
cf549b474e Bug 1232696 - Remove NS_DECL_AND_IMPL_ZEROING_OPERATOR_NEW as it causes segfaulting for GCC 6 builds (1 of 5, fixes for view/). r=tnikkel. 2017-01-24 17:10:01 +01:00
Timothy Nikkel
1b21b07765 Bug 1330225. Remove unused function nsViewManager::InsertChild. r=mats 2017-01-12 00:59:11 -06:00
Cameron McCormack
9560e97767 Bug 1323665 - Part 2: Allow StyleSheet.disabled CSSOM access to disable/enable a ServoStyleSheet. r=xidorn
Now that bug 1290209 has landed, we can make StyleSheet.disabled work in Servo
styled documents.  This fixes a bunch of test crashes due to the assertion no
longer firing.

MozReview-Commit-ID: 6sLrdrxWlvK

--HG--
extra : rebase_source : cf8ab29f98fbba6be837a38ffe2a03ed9b33b701
2017-01-09 17:44:30 +08:00
Nathan Froyd
a747eb3f2c Bug 1322553 - part 2 - use the new constructor of GeckoProfilerTracingRAII; r=mstange
This patch is not strictly relevant to the current bug, but doing the
work here nicely illustrates how the constructor we added in part 1 can
be used in existing parts of the codebase.
2017-01-07 15:56:49 -05:00
Timothy Nikkel
f98faf04e3 Bug 1323606. Implement the pref layout.show_previous_page for e10s. r=gw280 r=mats
The existing implementation only works for non-remote subdocuments.

This essentially makes the changes from bug 1157941 conditional on this pref.
2016-12-19 17:34:00 -06:00
Nicholas Nethercote
1dab0c3072 Bug 1299335 (part 3) - Streamline nsIWidget::SetParent. r=mstange.
This patch removes its return value, because none of the call sites check it
except for one non-vital assertion.

--HG--
extra : rebase_source : 3471c4e22394b8a05c6708d0f8469686ffad9814
2016-12-16 10:54:11 +11:00
Cameron McCormack
366f6eb24d Bug 1323892 - Disable currently crashing stylo crashtests. r=xidorn
MozReview-Commit-ID: 2BNjdBWdT5V
2016-12-16 18:54:41 +08:00
Andi-Bogdan Postelnicu
1e0c740db2 Bug 1320874 - Use auto type specifier where aplicable for variable declarations to improve code readability and maintainability in view/. r=mstange
MozReview-Commit-ID: G5BkqvHRhW7

--HG--
extra : rebase_source : 1a73b0b93fc995236faa3c1fcd5c1209ecbf0bcc
2016-11-29 10:36:29 +02:00
Sylvestre Ledru
3b74864611 Bug 1317430 - Avoid a unnecessary copy by passing a const & in view/ r=njn
MozReview-Commit-ID: BAZITOmUMVg

--HG--
extra : rebase_source : cddf1f80e6a646384f82cf9d70f96eacd09d8efd
2016-11-14 23:16:52 +01:00
Nicholas Nethercote
67af4817e9 Bug 1293596 (part 2) - Rework nsIWidget bounds getters. r=mstange.
This patch makes GetBounds(), GetScreenBounds() and GetClientBounds() more
obviously infallible, like existing functions such as GetNaturalBounds() and
GetClientSize(). This results in clearer behaviour in nsCocoaWindow.mm if
Objective C exceptions occur. Along the way, the patch removes some useless
failure checks for these functions.

The patch also removes the NS_IMETHOD from GetRestoredBounds and makes that
function MOZ_MUST_USE.
2016-08-19 09:03:04 +10:00