Commit Graph

73 Commits

Author SHA1 Message Date
Andrew Halberstadt
89cabb3dc5 Bug 1700774 - [taskgraph] Move test transforms to a 'transforms/test' directory, r=gbrown
This includes:

    transforms/tests.py -> transforms/test/__init__.py
    transforms/raptor.py -> transforms/test/raptor.py

This is a pre-cursor to splitting the file up into multiple smaller files under
the new 'test' transform directory.

Differential Revision: https://phabricator.services.mozilla.com/D132068
2021-11-29 15:52:19 +00:00
Nika Layzell
26555d958a Bug 1734739 - Part 1: Stop requiring otherpid for ShareTo, r=handyman
Differential Revision: https://phabricator.services.mozilla.com/D128218
2021-11-24 17:56:00 +00:00
Nika Layzell
d73755617d Bug 1732343 - Part 2: Migrate all uses of base::FileDescriptor to UniqueFileHandle, r=handyman
This is useful for the following parts, as UniqueFileHandle is a cross-platform
type which can also be used to support transferring HANDLEs between processes.

This change requires fairly sweeping changes to existing callsites, which
previously did not require owning access to the handle types when transferring.
For the most part these changes were straightforward, but manual.

Differential Revision: https://phabricator.services.mozilla.com/D126564
2021-11-09 14:17:32 +00:00
Andrew Halberstadt
95449daa6d Bug 1732723 - Rename "taskgraph" Python module to "gecko_taskgraph". r=jmaher
For a long time two copies of the 'taskgraph' module have existed in parallel.
We've attempted to keep them in sync, but over time they have diverged and the
maintenance burden has increased.

In order to reduce this burden, we'd like to re-join the two code bases. The
canonical repo will be the one that lives outside of mozilla-central, and this
module will depend on it. Since they both have the same module name (taskgraph)
we need to rename the version in mozilla-central to avoid collisions.

Other consumers of 'taskgraph' (like mobile repos) have standardized on
'<project>_taskgraph' as their module names. So replicating that here as well.

Differential Revision: https://phabricator.services.mozilla.com/D127118
2021-09-30 09:50:08 -04:00
Andrew Halberstadt
ce075afd70 No Bug - Update documentation for generating ccov reports locally, r=marco
Differential Revision: https://phabricator.services.mozilla.com/D124954
2021-09-09 14:49:27 +00:00
Calixte Denizet
11d5119f80 Bug 1541224 - Avoid to use uninitialized handle when flushing ccov counters r=marco
Counters can be flushed before init has been called so this patch add a condition in FlushCounters to be sure that everything has been initialized.

Differential Revision: https://phabricator.services.mozilla.com/D110575
2021-05-04 16:02:49 +00:00
Jens Stutte
05581ddca4 Bug 1678330: Ensure nested SpinEventLoopUntil(OrShutdown) calls are traceable to the originating source in case of crash. r=nika,extension-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D106839
2021-03-02 22:11:58 +00:00
Cosmin Sabou
b2eb620ed0 Backed out changeset 03cae7800b41 (bug 1678330) for mochitest plain failures on test_window_open_discarded_bc.html. CLOSED TREE 2021-03-02 20:18:21 +02:00
Jens Stutte
a0af9ea0a4 Bug 1678330: Ensure nested SpinEventLoopUntil(OrShutdown) calls are traceable to the originating source in case of crash. r=nika,extension-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D106839
2021-03-02 15:15:20 +00:00
Calixte Denizet
a0b66fc1c7 Bug 1602482 - Remove use of ___custom_llvm_gcov_flush r=marco,dmajor
Because of conflicts between gcov_flush from gcc and the one from llvm, we renamed llvm one into ___custom_llvm_gcov_flush.
Since we switched to clang for linux ccov builds, this workaround is now useless.

Differential Revision: https://phabricator.services.mozilla.com/D104990
2021-02-12 20:37:25 +00:00
Csoregi Natalia
63a9b1da37 Backed out changeset 333391f911e5 (bug 1602482) for toolchains bustage. CLOSED TREE 2021-02-12 18:14:44 +02:00
Calixte Denizet
169e0b5a38 Bug 1602482 - Remove use of ___custom_llvm_gcov_flush r=marco,dmajor
Because of conflicts between gcov_flush from gcc and the one from llvm, we renamed llvm one into ___custom_llvm_gcov_flush.
Since we switched to clang for linux ccov builds, this workaround is now useless.

Differential Revision: https://phabricator.services.mozilla.com/D104990
2021-02-12 14:45:24 +00:00
Simon Giesecke
971b645fe3 Bug 1660470 - Add missing include directives/forward declarations. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D87865
2020-11-23 16:21:38 +00:00
Ricky Stewart
02a7b4ebdf Bug 1654103: Standardize on Black for Python code in mozilla-central.
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-26 18:34:53 +00:00
Bogdan Tara
da1098d4aa Backed out 10 changesets (bug 1654103, bug 1672023, bug 1518999) for PanZoomControllerTest.touchEventForResult gv-junit failures CLOSED TREE
Backed out changeset ff3fb0b4a512 (bug 1672023)
Backed out changeset e7834b600201 (bug 1654103)
Backed out changeset 807893ca8069 (bug 1518999)
Backed out changeset 13e6b92440e9 (bug 1518999)
Backed out changeset 8b2ac5a6c98a (bug 1518999)
Backed out changeset 575748295752 (bug 1518999)
Backed out changeset 65f07ce7b39b (bug 1518999)
Backed out changeset 4bb80556158d (bug 1518999)
Backed out changeset 8ac8461d7bd7 (bug 1518999)
Backed out changeset e8ba13ee17f5 (bug 1518999)
2020-10-24 03:36:18 +03:00
Ricky Stewart
c0cea3b0fa Bug 1654103: Standardize on Black for Python code in mozilla-central. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-23 20:40:42 +00:00
Dorel Luca
1ff59cb7a3 Backed out changeset 7558c8821a07 (bug 1654103) for multiple failures. CLOSED TREE 2020-10-22 03:51:06 +03:00
Ricky Stewart
50762dacab Bug 1654103: Standardize on Black for Python code in mozilla-central. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-21 21:27:27 +00:00
Sylvestre Ledru
9bce072e44 Bug 1588458 - Replace dxr by searchfox in the rst doc r=ahal DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D49140
2020-10-08 08:13:15 +00:00
Sylvestre Ledru
6be67c14c4 Bug 1667831 - doc: refresh links as many pages moved in-tree r=firefox-source-docs-reviewers,ahal DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D91619
2020-09-29 17:53:54 +00:00
Evan Welsh
2e8ba0e06f Bug 1654696 - Implement code coverage JSAPI. r=nbp,jwalden
Differential Revision: https://phabricator.services.mozilla.com/D85808
2020-08-08 03:23:31 +00:00
David Major
4950130b02 Bug 1657391 - Update CodeCoverageHandler.cpp for clang-12 r=marco
In clang-12, 5809a32e7c split `__gcov_flush` into `__gcov_dump` and `__gcov_reset`. We have to make a corresponding update in CodeCoverageHandler.cpp to avoid build errors.

Differential Revision: https://phabricator.services.mozilla.com/D86026
2020-08-05 22:00:39 +00:00
Sylvestre Ledru
260f01d445 no bug - mozlint/codespell - Add two docs directories in the list + fix typos r=marco DONTBUILD
Depends on D65911

Differential Revision: https://phabricator.services.mozilla.com/D65912

--HG--
extra : moz-landing-system : lando
2020-03-09 10:43:14 +00:00
Sylvestre Ledru
5c0647fe0a Bug 1619159 - Refresh the code coverage doc r=marco
Depends on D64902

Differential Revision: https://phabricator.services.mozilla.com/D64903

--HG--
extra : moz-landing-system : lando
2020-03-02 15:43:20 +00:00
Sylvestre Ledru
30bee79d50 Bug 1619159 - Import the code coverage doc from mdn to in-tree r=marco
No change:
$ pandoc -trst https://wiki.developer.mozilla.org/en-US/docs/Mozilla/Testing/Measuring_Code_Coverage_on_Firefox\?raw\=1 > index.rst

Differential Revision: https://phabricator.services.mozilla.com/D64902

--HG--
extra : moz-landing-system : lando
2020-03-02 15:42:14 +00:00
Perry Jiang
dfe4262aaf Bug 1611046 - avoid using namespace declaration r=dom-workers-and-storage-reviewers,sg
In particular this avoids unqualified name lookup ambiguity between
::Request and mozilla::dom::Request (imported into the global namespace by
using namespace mozilla::dom).

Differential Revision: https://phabricator.services.mozilla.com/D61212

--HG--
extra : moz-landing-system : lando
2020-01-29 12:05:47 +00:00
Dorel Luca
e070fba60f Backed out changeset 870b38a3dc28 (bug 1602482) for as per dev's request. a=backout 2019-12-10 13:47:12 +02:00
Calixte Denizet
0232caa2b6 Bug 1602482 - Remove use of ___custom_llvm_gcov_flush r=marco
Because of conflicts between gcov_flush from gcc and the one from llvm, we renamed llvm one into ___custom_llvm_gcov_flush.
Since we switched to clang for ccov builds, this workaround is now useless.

Differential Revision: https://phabricator.services.mozilla.com/D56394

--HG--
extra : moz-landing-system : lando
2019-12-09 17:07:00 +00:00
Ted Campbell
62565b25fc Bug 1578730 - Add js::GetCodeCovergeSummaryAll API. r=nbp,marco
Split the GetCodeCoverageSummary API into a variant for a specific realm
vs checking all realms. This restores the original behaviour of the
getLcovInfo testing function to only return info on current realm. This
makes testing OOM behaviour much more predictable.

Differential Revision: https://phabricator.services.mozilla.com/D46167

--HG--
extra : moz-landing-system : lando
2019-09-19 00:08:39 +00:00
Victor Porof
5c7cdbd4ba Bug 1561435 - Format tools/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35940

--HG--
extra : source : d214f0c82813e5a8d3987debc490a2c11f1308ff
2019-07-05 11:18:19 +02:00
Brian Grinstead
ede8c44ef2 Bug 1544322 - Part 2.1 - Remove the [type] attribute for one-liner <script> tags loading files in /tests/SimpleTest/ in everything except for dom/ r=bzbarsky
This excludes dom/, otherwise the file size is too large for phabricator to handle.

This is an autogenerated commit to handle scripts loading mochitest harness files, in
the simple case where the script src is on the same line as the tag.

This was generated with https://bug1544322.bmoattachments.org/attachment.cgi?id=9058170
using the `--part 2` argument.

Differential Revision: https://phabricator.services.mozilla.com/D27456

--HG--
extra : moz-landing-system : lando
2019-04-16 03:50:44 +00:00
Mike Hommey
d89350611b Bug 1543009 - Move code coverage xpcom component to static registration. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D26893
2019-04-11 16:23:52 +09:00
Mike Hommey
071a2fe984 Bug 1541792 - Replace linker magic with manual component registration. r=froydnj
Before bug 938437, we had a rather large and error-prone
nsStaticXULComponents.cpp used to register all modules. That was
replaced with clever use of the linker, which allowed to avoid the mess
that maintaining that file was.

Fast forward to now, where after bug 1524687 and other work that
preceded it, we have a much smaller number of remaining static xpcom
components, registered via this linker hack, and don't expect to add
any new ones. The list should eventually go down to zero.

Within that context, it seems to be the right time to get rid of the
magic, and with it the problems it causes on its own.

Some of those components could probably be trivially be converted to
static registration via .conf files, but I didn't want to deal with the
possible need to increase the number of dummy modules in XPCOMInit.cpp.
They can still be converted as a followup.

Differential Revision: https://phabricator.services.mozilla.com/D26076

--HG--
extra : moz-landing-system : lando
2019-04-05 02:30:56 +00:00
Mike Hommey
fc4f272cd4 Followup for bug 1538060 again. More bustage fix. r=me,a=CristianB 2019-04-02 23:48:01 +09:00
Mark Banner
dba6983e75 Bug 1415265 - Remove now unnecessary .eslintrc.js files or entries. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D23850

--HG--
extra : moz-landing-system : lando
2019-03-28 09:38:14 +00:00
Kris Maglione
e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
Ehsan Akhgari
e5e885ae31 Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre
# ignore-this-changeset

--HG--
extra : amend_source : 7221c8d15a765df71171099468e7c7faa648f37c
extra : histedit_source : a0cce6015636202bff09e35a13f72e03257a7695
2019-01-18 10:16:18 +01:00
Jean-Yves Avenard
48517afae6 Bug 1512298 - Make IPDL MozPromise exclusive. r=gerald,froydnj
MozPromise most common use is to have an single or exclusive listener. By making the MozPromise generated by IPDL exclusive we can also use move semantics.

While at it, we also use move semantics for the ResponseRejectReason and via the callback's reject method so that the lambda used with the MozPromise::Then can be identical to the one used by the IPDL callback.
As it currently is, it provides no advantage over a copy as it's just an enum; however, this will facilitate future changes where it may not be.

Differential Revision: https://phabricator.services.mozilla.com/D13906

--HG--
extra : moz-landing-system : lando
2018-12-11 19:22:26 +00:00
Tooru Fujisawa
7983faeb5d Bug 1511393 - Use c-basic-offset: 2 in Emacs mode line for C/C++ code. r=nbp 2018-12-01 04:52:05 +09:00
Sylvestre Ledru
265e672179 Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
# ignore-this-changeset

--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
Marco Castelluccio
3a820232fa Bug 1502021 - Keep renaming __gcov_flush in LLVM to avoid naming clashes with builds mixing GCC and LLVM coverage instrumentation. r=decoder
--HG--
rename : build/build-clang/rename_gcov_flush.patch => build/build-clang/rename_gcov_flush_.patch
extra : rebase_source : 68be58d4fa714c79a6a384fd2b1660e5eb8e7f4a
2018-11-14 01:41:22 +01:00
Marco Castelluccio
b70c36e059 Bug 1504073 - Close output stream for flushing JS coverage data after we're done writing. r=froydnj
--HG--
extra : rebase_source : b7dfc0c21419a8fa24831d2d5346cccc8de176b9
extra : source : a85127941344e9a18610eabd3c0bc10a0a8efd93
2018-11-02 01:03:11 +01:00
Cosmin Sabou
6933921ac8 Backed out 2 changesets (bug 1504073) for spidermonkey build bustages on functionnames.js
Backed out changeset 8d667ad8e5aa (bug 1504073)
Backed out changeset 3d14a1201277 (bug 1504073)
2018-11-05 15:47:07 +02:00
Marco Castelluccio
58cff813e0 Bug 1504073 - Close output stream for flushing JS coverage data after we're done writing. r=froydnj
--HG--
extra : rebase_source : a85127941344e9a18610eabd3c0bc10a0a8efd93
2018-11-02 01:03:11 +01:00
Marco Castelluccio
a1f8d401aa Bug 1380661 - Make use of JS engine coverage flushing functionality to reset/dump counters in per-test mode. r=jmaher
--HG--
extra : rebase_source : 689c756696fde514859fe8f249d0e36c81f4ba49
2018-10-24 21:33:01 +02:00
Marco Castelluccio
46eea092e8 Bug 1380661 - Test JS counters are being flushed. r=nbp
--HG--
extra : rebase_source : 6717a51b9b4821ba50c336ecb3f6e170d335a6de
2018-10-24 21:33:14 +02:00
Marco Castelluccio
9d11e91a0b Bug 1380661 - Flush JS counters too when flushing GCOV counters. r=froydnj
--HG--
extra : rebase_source : 5f29d856b3eb3f246c9bf62e6095c0294a281f3c
2018-10-24 21:32:41 +02:00
Marco Castelluccio
2c9d05cea0 Bug 1498637 - Use __gcov_flush to implement dumping and resetting instead of __gcov_dump and __gcov_reset. r=froydnj
--HG--
extra : rebase_source : 7c23ca15e09d367458b2f78d9b9b2c0674bd9d0d
2018-10-15 10:36:45 +02:00
Jan de Mooij
84036b8de4 Bug 1474272 part 4 - Stop using js::GetGlobalForObjectCrossCompartment in xpc::NativeGlobal. r=bholley 2018-08-01 11:25:50 +02:00
Marco Castelluccio
3603b9498e Bug 1476213 - Include process.h on Windows and define getpid as _getpid. r=me
--HG--
extra : rebase_source : 6d9d998248243be8b9f7dda9230450017117d2a6
2018-07-17 12:09:16 +02:00