Commit Graph

70 Commits

Author SHA1 Message Date
Brindusan Cristian
e2348a18ee Backed out 2 changesets (bug 1573211) as requested by dmajor on irc. CLOSED TREE
Backed out changeset 587463567434 (bug 1573211)
Backed out changeset de0fe40466cb (bug 1573211)

--HG--
rename : build/build-clang/clang-android.json => build/build-clang/clang-8-android.json
rename : build/build-clang/clang-linux64-aarch64-cross.json => build/build-clang/clang-8-linux64-aarch64-cross.json
rename : build/build-clang/clang-linux64.json => build/build-clang/clang-8-linux64.json
rename : build/build-clang/clang-macosx64.json => build/build-clang/clang-8-macosx64.json
rename : taskcluster/scripts/misc/build-clang-linux-macosx-cross.sh => taskcluster/scripts/misc/build-clang-8-linux-macosx-cross.sh
extra : histedit_source : 3f9570ab67fd42186265b1dbb6e93c8342bc60e2
2019-09-26 20:12:51 +03:00
Andi-Bogdan Postelnicu
5f02cc9b02 MANUAL PUSH: Fix for Bug 1573211 - Re-generate the autotest results for clang-tidy analysis. r=myself.
--HG--
extra : rebase_source : d360e92b0da5701e1cfd4e1f49032283bd288ed5
extra : amend_source : edf7899f8bce61f4a5120713bd04cedc83085ea7
2019-09-25 17:30:19 +03:00
David Major
9d69f6a5ba Bug 1573211 - Update to clang 9.0.0 r=glandium
Updates all clang 8.0.1 to version 9.0.0, except for the mingw builds
which suffer from bug 1548624 and will be handled separately later.

Differential Revision: https://phabricator.services.mozilla.com/D44160

MANUAL PUSH: Rebuild clang toolchains without stalling autoland

--HG--
rename : build/build-clang/clang-8-android.json => build/build-clang/clang-android.json
rename : build/build-clang/clang-8-linux64-aarch64-cross.json => build/build-clang/clang-linux64-aarch64-cross.json
rename : build/build-clang/clang-8-linux64.json => build/build-clang/clang-linux64.json
rename : build/build-clang/clang-8-macosx64.json => build/build-clang/clang-macosx64.json
rename : taskcluster/scripts/misc/build-clang-8-linux-macosx-cross.sh => taskcluster/scripts/misc/build-clang-linux-macosx-cross.sh
extra : amend_source : 2dc7e91897e869ead501f19fbd7960d59c4b79bd
2019-09-21 16:26:53 +02:00
Sylvestre Ledru
fa8b298b59 Bug 1577726 - Ride along: Remove third_party from the clang tidy configuration as it isn't used r=andi
Differential Revision: https://phabricator.services.mozilla.com/D44163

--HG--
extra : moz-landing-system : lando
2019-09-05 13:52:22 +00:00
Sylvestre Ledru
65d8b0025e Bug 1564252 - Move to clang 8.0.1 r=glandium
Differential Revision: https://phabricator.services.mozilla.com//D42325

--HG--
extra : amend_source : 129ff97f6edc41ad7a2f54520141158416e75b8d
2019-08-20 21:06:24 +02:00
Andi-Bogdan Postelnicu
4b22abe3d1 Bug 1558987 - For clang based static-analysis, disable readability-isolate-declaration. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D34818

--HG--
extra : moz-landing-system : lando
2019-06-13 12:32:57 +00:00
Andi-Bogdan Postelnicu
ca4a195007 Bug 1551842 - Add new clang-tidy checkers from clang 8.0.0. r=sylvestre,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D31229

--HG--
extra : moz-landing-system : lando
2019-05-22 14:55:45 +00:00
Andi-Bogdan Postelnicu
7be18f3d26 Bug 1503453 - re-enable static-analysis autotest on win64 platform after migrating to clang-tidy 8. r=sylvestre
Also for checker `modernize-avoid-bind` export the respective reliability index from config.yaml

Differential Revision: https://phabricator.services.mozilla.com/D30904

--HG--
extra : moz-landing-system : lando
2019-05-14 13:00:13 +00:00
Sylvestre Ledru
88e7b97c2a Bug 1551083 - Enable bugprone-move-forwarding-reference r=andi
Differential Revision: https://phabricator.services.mozilla.com/D30816

--HG--
extra : moz-landing-system : lando
2019-05-14 07:12:37 +00:00
Andi-Bogdan Postelnicu
32fe00ed34 Bug 1544764 - Add description at review phase about defects found - clang-tidy. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D27669

--HG--
extra : moz-landing-system : lando
2019-04-18 08:49:52 +00:00
Csoregi Natalia
feb0789249 Backed out changeset 7cefdbb63711 (bug 1544764) for static-analysis bustage on clang-analyzer-deadcode.DeadStores.cpp. CLOSED TREE 2019-04-18 00:33:29 +03:00
Andi-Bogdan Postelnicu
bbedccc1b9 Bug 1544764 - Add description at review phase about defects found - clang-tidy. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D27669

--HG--
extra : moz-landing-system : lando
2019-04-17 16:16:42 +00:00
Andi-Bogdan Postelnicu
c9b234eafc Bug 1543492 - for clang based static-analysis and formating add a package version that represents a baseline if we continue the analysis or prompt for an update. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D27042

--HG--
extra : moz-landing-system : lando
2019-04-11 09:58:59 +00:00
Andi-Bogdan Postelnicu
fb86931b20 Bug 1503453 - Fix Perma 'mach static-analysis autotest; caused by Bug 1540769. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D26095

--HG--
extra : moz-landing-system : lando
2019-04-04 11:34:47 +00:00
Sylvestre Ledru
c52ebc3ea9 Bug 1540769 - Enable readability-redundant-preprocessor r=andi
Differential Revision: https://phabricator.services.mozilla.com/D25630

--HG--
extra : moz-landing-system : lando
2019-04-02 06:07:39 +00:00
Sylvestre Ledru
bf99cf9d2e Bug 1536790 - Upgrade to clang-{tidy,format} 8.0.0 (from 7.0.1) r=andi
Differential Revision: https://phabricator.services.mozilla.com/D24175

--HG--
extra : moz-landing-system : lando
2019-04-01 12:24:35 +00:00
Ciure Andrei
8a67ec169a Backed out 3 changesets (bug 1538060, bug 1539779, bug 1536790) for causing clang-tidy bustages CLOSED TREE
Backed out changeset 7d058f3174e5 (bug 1538060)
Backed out changeset 8839622122ed (bug 1539779)
Backed out changeset 9eb7867c1dd4 (bug 1536790)

--HG--
rename : build/build-clang/clang-8-android.json => build/build-clang/clang-7-android.json
rename : build/build-clang/clang-8-linux64.json => build/build-clang/clang-7-linux64.json
rename : build/build-clang/clang-8-macosx64.json => build/build-clang/clang-7-macosx64.json
rename : build/build-clang/clang-8-mingw.json => build/build-clang/clang-trunk-mingw.json
rename : taskcluster/scripts/misc/build-clang-8-android.sh => taskcluster/scripts/misc/build-clang-7-android.sh
rename : taskcluster/scripts/misc/build-clang-8-linux-macosx-cross.sh => taskcluster/scripts/misc/build-clang-7-linux-macosx-cross.sh
rename : taskcluster/scripts/misc/build-clang-8-linux.sh => taskcluster/scripts/misc/build-clang-7-linux.sh
rename : taskcluster/scripts/misc/build-clang-8-mingw.sh => taskcluster/scripts/misc/build-clang-trunk-mingw.sh
2019-03-30 01:52:37 +02:00
Sylvestre Ledru
878a6926e9 Bug 1536790 - Upgrade to clang-{tidy,format} 8.0.0 (from 7.0.1) r=andi
Reviewers: andi

Reviewed By: andi

Bug #: 1536790

Differential Revision: https://phabricator.services.mozilla.com/D24175

--HG--
extra : rebase_source : 4916f93d375ba7415a000fd1a4c48f214b300f47
extra : histedit_source : d21ca90bd40c0fe2db99ea69b7d3c98eaf872f49
2019-03-30 01:23:21 +02:00
Daniel Varga
0bc3e10232 Backed out 2 changesets (bug 1539779, bug 1536790) for toolchain failure. On a CLOSED TREE
Backed out changeset 5ecdbfab88b4 (bug 1539779)
Backed out changeset 20d5cdaa08e3 (bug 1536790)
2019-03-29 10:34:45 +02:00
Andi-Bogdan Postelnicu
437397c847 Bug 1536790 - Upgrade to clang-{tidy,format} 8.0.0 (from 7.0.1) r=andi
Patch wrote by Sylvestre Ledru (sylvestre@mozilla.com)

Differential Revision: https://phabricator.services.mozilla.com/D24175

--HG--
extra : moz-landing-system : lando
2019-03-28 17:49:41 +00:00
Andi-Bogdan Postelnicu
ff772f8795 Bug 1480480 - Explain why some clang-tidy checkers are not published. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D7170

--HG--
extra : moz-landing-system : lando
2019-03-26 10:04:58 +00:00
Andi-Bogdan Postelnicu
ff9e9c5e7a Bug 1500241 - [Clang-Tidy] Disable 'readability-implicit-bool-conversion' check. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D10264

--HG--
extra : moz-landing-system : lando
2018-10-30 17:11:55 +00:00
Andi-Bogdan Postelnicu
2139aad55e Bug 1479298 - [Static-Analysis][Clang-Based] Implement the passing of configuration flags to checkers in the configuration file. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D7997

--HG--
extra : moz-landing-system : lando
2018-10-10 08:01:24 +00:00
Andi-Bogdan Postelnicu
aced38a8a9 Bug 1496379 - [Static-Analysis][Clang-Tidy] Don't publish bugprone-multiple-statement-macro. r=janx
Differential Revision: https://phabricator.services.mozilla.com/D7706

--HG--
extra : moz-landing-system : lando
2018-10-04 12:14:11 +00:00
Sylvestre Ledru
fb80392dd8 Bug 1253844 - Enable the readability-implicit-bool-conversion checker r=andi
Differential Revision: https://phabricator.services.mozilla.com/D7606

--HG--
extra : moz-landing-system : lando
2018-10-03 16:30:29 +00:00
Andi-Bogdan Postelnicu
b22a8a3837 Bug 1494951 - [Static-Analysis][Clang-Tidy] Publish checker 'readability-redundant-smartptr-get'. r=janx
Differential Revision: https://phabricator.services.mozilla.com/D7169

--HG--
extra : moz-landing-system : lando
2018-10-01 12:52:39 +00:00
Sylvestre Ledru
7e45fa9101 Bug 1496084 - Document in config.yaml how to add a new checker r=andi
Differential Revision: https://phabricator.services.mozilla.com/D7607

--HG--
extra : moz-landing-system : lando
2018-10-03 15:53:31 +00:00
Andi-Bogdan Postelnicu
bc36108b34 Bug 1487321 - [Static-Analysis][Clang-Tidy] Add new checkers present in 7.0. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D7045

--HG--
extra : moz-landing-system : lando
2018-10-02 14:10:32 +00:00
Andi-Bogdan Postelnicu
4d4386fe8f Bug 1493672 - Configuration file should also contain a minimum clang-tidy version. r=janx
Differential Revision: https://phabricator.services.mozilla.com/D6665

--HG--
extra : moz-landing-system : lando
2018-09-25 07:51:39 +00:00
Andi-Bogdan Postelnicu
8218d8a740 Bug 1492770 - Activate google-* checkers that make sense to our code. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D6391

--HG--
extra : moz-landing-system : lando
2018-09-20 15:29:32 +00:00
Andi-Bogdan Postelnicu
fb4dc15757 Bug 1480089 - pass all of the test files to to our static-analysis pipeline. r=janx
Differential Revision: https://phabricator.services.mozilla.com/D4659

--HG--
extra : moz-landing-system : lando
2018-09-20 07:38:27 +00:00
Sylvestre Ledru
e148db5ea3 Bug 1488687 - Enable braces around statements clang-tidy checker r=Ehsan
This will be enabled only at review phase.
If the warning is ignored in phabricator, nothing will happen.

This should be enforced as it is part of the Mozilla coding style:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Control_Structures

Differential Revision: https://phabricator.services.mozilla.com/D5014

--HG--
extra : moz-landing-system : lando
2018-09-05 14:07:58 +00:00
Jan Keromnes
11dd9afb58 Bug 1486410 - Bug 1466427 - Enable new clang-tidy 7.0 checks. r=andi
Differential Revision: https://phabricator.services.mozilla.com/D4210

--HG--
extra : moz-landing-system : lando
2018-09-04 11:55:19 +00:00
Andi-Bogdan Postelnicu
64682f8e84 Bug 1486729 - [Static-Analysis][Clang-Tidy] As default, a checker should be publish by default. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D4436

--HG--
extra : moz-landing-system : lando
2018-08-29 10:10:54 +00:00
Margareta Eliza Balazs
294c48bb26 Backed out changeset f9d93a20e6d6 (bug 1486410) for Sa failures error: clang-tidy auto-test failed for checker performance-inefficient-algorithm CLOSED TREE
--HG--
extra : rebase_source : b7234db6fde4e4ec59933e20f10820f5a8fc82ec
2018-08-28 18:28:41 +03:00
Jan Keromnes
595e7789c3 Bug 1486410 - Bug 1466427 - Enable new clang-tidy 7.0 checks. r=andi
Differential Revision: https://phabricator.services.mozilla.com/D4210

--HG--
extra : moz-landing-system : lando
2018-08-27 17:56:03 +00:00
Andi-Bogdan Postelnicu
34a6c4ff8f Bug 1466427 - Migrate clang-tidy package from 5.0.1 to 7.0.0-rc2. r=glandium,janx
Differential Revision: https://phabricator.services.mozilla.com/D3980

--HG--
rename : tools/clang-tidy/test/misc-bool-pointer-implicit-conversion.cpp => tools/clang-tidy/test/bugprone-bool-pointer-implicit-conversion.cpp
rename : tools/clang-tidy/test/misc-forward-declaration-namespace.cpp => tools/clang-tidy/test/bugprone-forward-declaration-namespace.cpp
rename : tools/clang-tidy/test/misc-macro-repeated-side-effects.cpp => tools/clang-tidy/test/bugprone-macro-repeated-side-effects.cpp
rename : tools/clang-tidy/test/misc-string-constructor.cpp => tools/clang-tidy/test/bugprone-string-constructor.cpp
rename : tools/clang-tidy/test/misc-string-integer-assignment.cpp => tools/clang-tidy/test/bugprone-string-integer-assignment.cpp
rename : tools/clang-tidy/test/misc-suspicious-missing-comma.cpp => tools/clang-tidy/test/bugprone-suspicious-missing-comma.cpp
rename : tools/clang-tidy/test/misc-swapped-arguments.cpp => tools/clang-tidy/test/bugprone-swapped-arguments.cpp
rename : tools/clang-tidy/test/misc-unused-raii.cpp => tools/clang-tidy/test/bugprone-unused-raii.cpp
extra : moz-landing-system : lando
2018-08-24 12:39:58 +00:00
Sylvestre Ledru
d8cf7f225f Bug 1477979 - Add the name of the clang-tidy 6.0 as a comment r=janx
Differential Revision: https://phabricator.services.mozilla.com/D2291

--HG--
extra : moz-landing-system : lando
2018-07-24 12:15:04 +00:00
Andi-Bogdan Postelnicu
2132bcd260 Bug 1476762 - Declare strcat, strlen and size_t to use appropriate types in declaration, definition. r=janx
MozReview-Commit-ID: 7JuATmROVVr

--HG--
extra : rebase_source : f798a188a521b76a5ed15913d24733324602820e
2018-07-18 22:59:10 +03:00
Chris Peterson
05d177e56a Bug 1475882 - clang-tidy: Enable misc-string-integer-assignment check. r=andi
The check finds assignments of an integer to std::string:

https://clang.llvm.org/extra/clang-tidy/checks/bugprone-string-integer-assignment.html

There are currently ten misc-string-integer-assignment warnings in mozilla-central, but they are all in third-party Breakpad code:

toolkit/crashreporter/google-breakpad/src/processor/minidump.cc:306:17: warning: an integer is interpreted as a character code when assigning it to a string; if this is intended, cast the integer to the appropriate character type; if you want a string representation, use the appropriate conversion facility
toolkit/crashreporter/google-breakpad/src/processor/minidump.cc:307:17: warning: an integer is interpreted as a character code when assigning it to a string; if this is intended, cast the integer to the appropriate character type; if you want a string representation, use the appropriate conversion facility
toolkit/crashreporter/google-breakpad/src/processor/minidump.cc:309:17: warning: an integer is interpreted as a character code when assigning it to a string; if this is intended, cast the integer to the appropriate character type; if you want a string representation, use the appropriate conversion facility
toolkit/crashreporter/google-breakpad/src/processor/minidump.cc:310:17: warning: an integer is interpreted as a character code when assigning it to a string; if this is intended, cast the integer to the appropriate character type; if you want a string representation, use the appropriate conversion facility
toolkit/crashreporter/google-breakpad/src/processor/minidump.cc:311:17: warning: an integer is interpreted as a character code when assigning it to a string; if this is intended, cast the integer to the appropriate character type; if you want a string representation, use the appropriate conversion facility
toolkit/crashreporter/google-breakpad/src/processor/minidump.cc:313:17: warning: an integer is interpreted as a character code when assigning it to a string; if this is intended, cast the integer to the appropriate character type; if you want a string representation, use the appropriate conversion facility
toolkit/crashreporter/google-breakpad/src/processor/minidump.cc:314:17: warning: an integer is interpreted as a character code when assigning it to a string; if this is intended, cast the integer to the appropriate character type; if you want a string representation, use the appropriate conversion facility
toolkit/crashreporter/google-breakpad/src/processor/minidump.cc:315:17: warning: an integer is interpreted as a character code when assigning it to a string; if this is intended, cast the integer to the appropriate character type; if you want a string representation, use the appropriate conversion facility
toolkit/crashreporter/google-breakpad/src/processor/minidump.cc:316:17: warning: an integer is interpreted as a character code when assigning it to a string; if this is intended, cast the integer to the appropriate character type; if you want a string representation, use the appropriate conversion facility

MozReview-Commit-ID: AUOyOuCzy1R

--HG--
extra : source : 93356b5c58539d19c27dade7b1514bae709bc149
extra : histedit_source : 4bc38ab5a7a50869aaf4fce87aa2f75ce9dd301a
2018-07-14 23:48:40 -07:00
Chris Peterson
126761ba3c Bug 1475882 - clang-tidy: Enable misc-string-constructor check. r=andi
Finds string constructors that are suspicious and probably errors. There are currently no misc-string-constructor warnings in mozilla-central!

https://clang.llvm.org/extra/clang-tidy/checks/bugprone-string-constructor.html

MozReview-Commit-ID: LyJt6wqOhg9

--HG--
extra : source : 0b36b6b1b7931adec5846086a52080edb3ec5e7d
extra : histedit_source : 30249980b219d4813fc5503c87e84265ad354e2f
2018-07-14 23:41:55 -07:00
Chris Peterson
59cd83d07a Bug 1475882 - clang-tidy: Enable bugprone-suspicious-memset-usage check. r=andi
This check finds memset() calls with potential mistakes in their arguments. There are currently no bugprone-suspicious-memset-usage warnings in mozilla-central!

https://clang.llvm.org/extra/clang-tidy/checks/bugprone-suspicious-memset-usage.html

MozReview-Commit-ID: 9gmtidgMPwW

--HG--
extra : source : 9c6f6e1553c45751f476c2d8418b9d4735e27e50
extra : histedit_source : 721536e24babf3734e116bd6beaf8d43722cca96
2018-07-08 23:54:13 -07:00
Chris Peterson
9574957168 Bug 1475882 - clang-analyzer: Enable clang-analyzer-unix.Malloc check. r=andi
Check for memory leaks, double free, and use-after-free and offset problems involving malloc. There are currently no clang-analyzer-unix.Malloc warnings in mozilla-central!

https://clang-analyzer.llvm.org/available_checks.html

MozReview-Commit-ID: G32SlokD64O

--HG--
extra : source : a2c8ccd2da1968b64510569f12f4631c54fea2d8
extra : histedit_source : b42c3ce2c3f8132fc0b301e6309b5ad25192167c
2018-07-14 23:28:26 -07:00
Chris Peterson
a1aecf2da2 Bug 1475882 - clang-analyzer: Enable clang-analyzer-unix.cstring.NullArg check. r=andi
Check for null pointers being passed as arguments to C string functions. There are no clang-analyzer-unix.cstring.NullArg warnings in mozilla-central!

strlen
strnlen
strcpy
strncpy
strcat
strncat
strcmp
strncmp
strcasecmp
strncasecmp

https://clang-analyzer.llvm.org/available_checks.html

MozReview-Commit-ID: EkfaItfo5cu

--HG--
extra : source : e05c6cfa3b8ae6b3234ebf5e4895475bc623edcd
extra : histedit_source : 6aa97bb8d82884fb2ac92793df9defd7a7985e89
2018-07-14 22:07:12 -07:00
Chris Peterson
ced65109b9 Bug 1475882 - clang-analyzer: Enable clang-analyzer-unix.cstring.BadSizeArg check. r=andi
Check the size argument passed to strncat for common erroneous patterns. There are currently no clang-analyzer-unix.cstring.BadSizeArg warnings in mozilla-central!

https://clang-analyzer.llvm.org/available_checks.html

MozReview-Commit-ID: DUI3ZNIBoLQ

--HG--
extra : source : 8dafc73215cddd2737b4d8dbcb926521736d98c2
extra : histedit_source : ed27a98e47c01c9951c03eb2129ed4997f3cf624
2018-07-14 23:15:37 -07:00
Chris Peterson
6f691d73b1 Bug 1475882 - clang-tidy: Enable misc-unused-alias-decls check. r=andi
This check finds unused namespace alias declarations. There are currently no misc-unused-alias-decls warnings in mozilla-central!

https://clang.llvm.org/extra/clang-tidy/checks/misc-unused-alias-decls.html

MozReview-Commit-ID: LHziGESvaM5

--HG--
extra : rebase_source : f10fbb6364bc947b5fa2ca8c0b47494519856940
extra : source : 987ca732290093c4bd36690c6ebd3ed2ac0b5444
2018-07-09 11:04:31 -07:00
Chris Peterson
6d8a23d9c8 Bug 1475882 - clang-tidy: Enable misc-swapped-arguments check. r=andi
This check finds potentially swapped function arguments by looking at implicit conversions. There are currently no misc-swapped-arguments warnings in mozilla-central!

https://clang.llvm.org/extra/clang-tidy/checks/bugprone-swapped-arguments.html

MozReview-Commit-ID: 6SETUcQhQP

--HG--
extra : rebase_source : d364fc90e776807ab2540d714594d07a5a83b054
extra : source : 689980bf12e98780d0d60c851549d16a4cc8efb0
2018-07-09 00:26:58 -07:00
Chris Peterson
d9fe858d74 Bug 1475882 - clang-tidy: Enable misc-macro-repeated-side-effects check. r=andi
This check finds side effects from repeated macro arguments:

https://clang.llvm.org/extra/clang-tidy/checks/bugprone-macro-repeated-side-effects.html

There are currently 16 misc-macro-repeated-side-effects warnings in mozilla-central, but they are all in third-party gfx/cairo code:

gfx/cairo/cairo/src/cairo-tor-scan-converter.c:1432:10: warning: side effects in the 1st macro argument 'x' are repeated in macro expansion
gfx/cairo/libpixman/src/pixman-access.c:1011:16: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion
gfx/cairo/libpixman/src/pixman-access.c:1037:16: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion
gfx/cairo/libpixman/src/pixman-access.c:1062:16: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion
gfx/cairo/libpixman/src/pixman-access.c:1088:16: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion
gfx/cairo/libpixman/src/pixman-access.c:1107:16: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion
gfx/cairo/libpixman/src/pixman-access.c:1126:27: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion
gfx/cairo/libpixman/src/pixman-access.c:1194:21: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion
gfx/cairo/libpixman/src/pixman-access.c:1258:16: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion
gfx/cairo/libpixman/src/pixman-access.c:600:28: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion
gfx/cairo/libpixman/src/pixman-access.c:629:28: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion
gfx/cairo/libpixman/src/pixman-access.c:660:28: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion
gfx/cairo/libpixman/src/pixman-access.c:690:28: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion
gfx/cairo/libpixman/src/pixman-access.c:721:28: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion
gfx/cairo/libpixman/src/pixman-access.c:986:16: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion
gfx/cairo/libpixman/src/pixman-edge-imp.h:126:20: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion

MozReview-Commit-ID: CQ6iO9JO773

--HG--
extra : rebase_source : 0e7dc6fa3990ab187c597d8042a403c554152b02
extra : source : 5f47d400d53107df0e0478b369745bfd3f055702
2018-07-09 10:14:40 -07:00
Chris Peterson
557f9a3436 Bug 1475882 - clang-analyzer: Enable clang-analyzer-cplusplus.NewDeleteLeaks check. r=andi
Check for memory leaks. Traces memory managed by new/ delete. There are currently no clang-analyzer-cplusplus.NewDeleteLeaks warnings in mozilla-central!

https://clang-analyzer.llvm.org/available_checks.html

MozReview-Commit-ID: 3tmwR26UB8K

--HG--
extra : rebase_source : 3796cc6b61c03e83ce8b390e3342b870085b2ed2
extra : source : 3389fb54d2e3daee38db38503b37e9d994878bcd
2018-07-14 23:10:39 -07:00
Chris Peterson
11ee6d0d0c Bug 1475882 - clang-analyzer: Enable clang-analyzer-cplusplus.NewDelete check. r=andi
Check for double-free, use-after-free and offset problems involving C++ delete. There are currently no clang-analyzer-cplusplus.NewDelete warnings in mozilla-central!

https://clang-analyzer.llvm.org/available_checks.html

MozReview-Commit-ID: 9sVp4fc4JTj

--HG--
extra : rebase_source : 733974ff07b873f6e5cd1e83104f82eafbf7f3c7
extra : source : 778684b276e6658fb9f3fa125aaec984cca8760a
2018-07-14 23:07:40 -07:00