Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-13 23:17:57 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
248,501 Commits 615 Branches 98 Tags 5.9 GiB
f1cc736bc2
Commit Graph

2495 Commits

Author SHA1 Message Date
David Anderson
dd9c55abdd [JAEGER] Merge from tracemonkey. 2010-07-19 20:49:26 -07:00
Clint Talbert
a24e132c4c Bug 584218 Fix sutagent bustage - checked in incorrect files a=bustage,NPOTB 2010-08-26 14:47:29 -07:00
Bob Moss
7f9ecb440c Bug 584218 Android SUT agent needs ability to update itself r=ctalbert a=NPOTB 2010-08-25 11:47:39 -07:00
David Anderson
f9c1b5f068 [JAEGER] Merge from fatval & TM. 2010-07-05 18:07:39 -07:00
Vladimir Vukicevic
4cd467403f b=?; fix make-makefile and cairo-features.h.in hack; r=ted 2010-07-02 11:20:29 -07:00
David Mandelin
e42840d083 Browser prefs for enabling methodjit 2010-06-29 16:46:10 -07:00
Kyle Huey
c0d56af5ca Bug 585774: Revert pymake to an earlier version to fix a massive build perf loss. 2010-08-09 17:56:49 -07:00
Kyle Huey
44101484a3 Backed out changeset f2c04d62dc9c 2010-08-09 17:55:33 -07:00
Benjamin Smedberg
7c3e8bf65e Merge bug 579178 to mozilla-central. reviews by Mossop/khuey/jwalden/ted 2010-08-09 10:04:10 -04:00
Mitchell Field
40272e4dd0 Bug 581938 - Update pymake snapshot. rs=ted 2010-08-06 01:08:40 +10:00
Benjamin Smedberg
b3e54c80b8 Bug 579178 part D - When unifying as sorted-matching, keep version A as the unified version, not the sorted version, r=ted 2010-08-05 10:11:39 -04:00
Kyle Huey
16199bde74 Backing out Bug 489813 due to test failures 2010-08-04 17:38:20 -07:00
Kyle Huey
6f2ed7d68e Backed out changeset 1d8d2deb3644 2010-08-04 17:36:54 -07:00
Kyle Huey
b33484f540 Bug 518136: Use -showIncludes to generate dependencies for MSVC for a substantial build performance win. r=ted 2010-08-04 16:59:23 -07:00
Doug Turner
3123a8d709 Bug 489813 - Fire timeout error if provider fails to response after initial response. Also cleans up test. r=olli 
--HG--
extra : rebase_source : 00aa6024b9e3e998801cf548b8ade5c532a6965d
 2010-08-04 13:58:15 -07:00
Clint Talbert
65a508d873 Bug 580418 Fix remote reftests to start their own httpd.js webserver r=jmaher 2010-07-26 18:43:34 -07:00
Jonathan Griffin
df583f3699 Bug 572570 - backed out changeset 90ade0c197ed due to linux m0 oranges 2010-07-26 16:01:06 -07:00
Jonathan Griffin
e8663cf449 Bug 572570 - make ssltunnel recognize WebSocket traffic via header inspection. r=ted 2010-07-26 14:40:08 -07:00
Bob Moss
110f1da2cf Bug 579578 Update SUTAgent code for android r=ctalbert 2010-07-19 08:55:42 -07:00
Clint Talbert
3da0ed5194 Bug 573281 Update Devicemanager.py for android r=jmaher 2010-07-19 08:55:42 -07:00
Eli Friedman
406336b84f Bug 579689 - Fix cases of return without expression in a function returning "int". r=khuey 2010-07-18 11:19:48 +02:00
Jonathan Griffin
49f25de186 Bug 572570 - allow ssltunnel to detect WebSocket traffic via header inspection. r=ted 2010-07-28 10:55:36 -07:00
Jacek Caban
21b911d85f Bug 559854 - Compile target xpidl only if libIDL is configured when cross compiling. [r=ted] 
(transplanted from 0388c837c9867762bcc10a1fb88428050d158479)

--HG--
extra : transplant_source : %03%88%C87%C9%86wb%BC%C1%0A%1F%B8%84%28%05%0D%15%84y
 2010-06-02 10:08:00 -04:00
Benjamin Smedberg
e17740e1ab Merge mozilla-central to the bug 568691 branch. 
--HG--
rename : gfx/public/nsITheme.h => gfx/src/nsITheme.h
 2010-06-30 14:23:23 -04:00
Benjamin Smedberg
ae3fe7f334 Unify should ensure that when a .manifest file is being compared, if the last line doesn't end with a newline, it should add one so that lines don't get munged together incorrectly. rs=ted 2010-06-29 19:19:23 -04:00
Benjamin Smedberg
29e089defb Merge mozilla-central into the branch for bug 568691, including fixup of the new jetpack binary module. 2010-06-25 19:41:09 -04:00
Benjamin Smedberg
822ccb0789 Merge mozilla-central into the static-xpcom-registration branch. 2010-06-23 17:26:25 -04:00
Clint Talbert
683f0ec90b Bug 567945 - Re-enable sutagent build now that we have proper tool chain on android builds r=ted 2010-06-23 09:57:17 -07:00
Benjamin Smedberg
3f7e71abfb Rename NSGetModule to NSModule in various build scripts for bug 568691. 2010-06-22 20:21:34 -04:00
Clint Talbert
d9bc873b09 Bug 567945 - Fix burning on Android - *bustage fix* - see https://bugzilla.mozilla.org/show_bug.cgi?id=567945#c11 2010-06-21 17:27:14 -07:00
Clint Talbert
a81d410131 Bug 567945 Import of sutagent code for Android 2010-06-21 14:26:56 -07:00
Clint Talbert
6ebe6803b1 Bug 567945 Android agent needs to build in mozilla-central r=ted 2010-06-21 14:26:55 -07:00
Jacek Caban
24a16fd076 Bug 508905 - /Zc:wchar_t- is no longer required (wince part) r=doug.turner 
--HG--
extra : rebase_source : 13d6dadb676ca5e29b7e7bcfff5bbb1c964f78e4
 2010-06-27 01:30:05 +02:00
Jesse Ruderman
05038c032d Fix bug 574912 - leftover self.ctypes after fix for bug 543825 2010-06-25 22:40:13 -07:00
Jesse Ruderman
cc75858eb7 Bug 570287 - New stack fixer that uses breakpad symbol files. r=ted 2010-06-25 14:47:19 -07:00
Robert Strong
dce736a623 Bug 562795: Fix update tests to ignore application extensions. r=dtownsend 2010-06-18 08:54:22 -07:00
Dave Townsend
69eb9199ca Potential bustage fix for update tests, reverting the change to automation.py.in from bug 562795. 2010-06-17 17:26:55 -07:00
Dave Townsend
b121d79b3c Bug 562795: Sorting by name in the digest view is case-sensitive for all types of add-ons. r=Unfocused 2010-06-16 20:13:54 -07:00
Jonathan Griffin
d7a8b09690 Bug 570789. Change default websocket server port to 9988, as 9999 is used by something by default on fedora 
--HG--
extra : rebase_source : d4e0d05f58ff82ec6d6300d9c3c9e943c07d77ef
 2010-06-17 12:00:58 -07:00
Jonathan Griffin
e6fdd7ae87 Bug 570789. Add WebSocket support to mochitest. r=ted 
--HG--
extra : rebase_source : 2e33d054a13824d1a7e527777383820946684c3f
 2010-06-16 22:38:55 -07:00
Josh Aas
c59bf4347e Make flight.mk for universal binaries not specific to PPC/i386. b=411588 r=ted 2010-06-15 12:31:38 -04:00
Jonas Sicking
a66617aa2d Bug 546857 Part 5: Add a default permissions.sqlite to unit test profiles. r=ted a=blocker 2010-08-19 16:12:46 -07:00
Ted Mielczarek
8ebae2dc0a bug 569965 - automationutils.processLeakLog() should learn not to TEST-UNEXPECTED-FAIL every single object line when there are lots. r=philor 
--HG--
extra : rebase_source : 4ce122222020d522f742b7e77bfacafe8f7f90bc
 2010-06-10 08:27:47 -04:00
Jesse Ruderman
c54b9bd259 Bug 570730 - followup fix to reset test name if runApp is called twice 2010-06-10 21:28:36 -07:00
Jesse Ruderman
3f11bd09e1 Bug 570730 - automation.py should indicate which test crashed (or timed out) for reftests and mochitests. r=ctalbert 2010-06-10 18:46:18 -07:00
Jesse Ruderman
db961dd470 Turn off mac stack fixer because it's causing random orange (bug 569981) and soon to be replaced 
--HG--
extra : rebase_source : 4f731795bdff2ac10034163baba0d5a2ec735b45
 2010-06-08 20:55:44 -07:00
Dave Townsend
be149ce189 Bug 573079: Package Beta Feedback extension in beta release builds. r=ted, r=beltzner 2010-06-24 16:36:31 -07:00
Clint Talbert
ce2826b7ed Bug 573263 - Refactor remote reftest to work on android, create shared remoteautomation class r=jmaher 2010-06-24 02:32:01 -07:00
Benjamin Smedberg
d4b8d1bcc8 Import a new rev of pymake which fixes, among other things, bug 576914 2010-07-10 20:56:38 -07:00
L. David Baron
65c3d85b93 Fix indentation in configure --help. (Bug 569261) r=ted 2010-06-02 14:04:21 -07:00
Clint Talbert
bf76d918e5 Bug 563860 - update runtestsremote.py to start webserver automatically and to work on android better r=jmaher 2010-05-27 13:02:15 -07:00
Makoto Kato
c3bdf61d95 Bug 561740 - disable vmwarerecordinghelper on x64 build. r=ted 2010-05-17 11:29:35 +09:00
Michael Kohler
9d899e6494 Bug 506041 Part 2: Correct misspellings in source code 
r=timeless
 2010-05-13 14:19:51 +02:00
Michael Kohler
6c0f59f4a6 Bug 506041 Part 2: Correct misspellings in source code 
r=timeless
 2010-05-13 14:19:50 +02:00
Oleg Romashin
9cbb1c5d7b Bug 558825 - run-mozilla.sh does not work with -d native-gdb. r=ted.mielczarek 
--HG--
extra : rebase_source : 764ca82339869411c4a3fa402f3060de17d7f768
 2010-05-11 13:23:59 -04:00
Dave Townsend
00d2e0f967 Bug 555486: Add a scope property to add-ons and allow disabling loading add-ons from certain scopes. r=robstrong 2010-04-07 11:08:32 -07:00
Ted Mielczarek
bda71eee8a bug 563745 - Make automationutils.py's minidump processing able to send minidumps to minidump-stackwalk-cgi. r=catlee 
--HG--
extra : rebase_source : ebbf745e5e77c55437cb05071f49d421d08956c6
 2010-05-06 08:06:09 -04:00
Chris AtLee
a001bfb0c2 Bug 563008 - fix upload.py on python2.4. r=ted 2010-04-30 14:54:51 -04:00
Dave Townsend
bfd56a86b8 Backout new add-ons manager due to Ts regression on OSX 10.5 
--HG--
rename : toolkit/mozapps/extensions/test/xpcshell/data/test_bug404024.xml => toolkit/mozapps/extensions/test/unit/data/test_bug404024.xml
rename : toolkit/mozapps/extensions/test/xpcshell/data/test_bug417606.xml => toolkit/mozapps/extensions/test/unit/data/test_bug417606.xml
rename : toolkit/mozapps/extensions/test/xpcshell/data/test_bug424262.xml => toolkit/mozapps/extensions/test/unit/data/test_bug424262.xml
rename : toolkit/mozapps/extensions/test/xpcshell/test_bug404024.js => toolkit/mozapps/extensions/test/unit/test_bug404024.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_bug417606.js => toolkit/mozapps/extensions/test/unit/test_bug417606.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_bug424262.js => toolkit/mozapps/extensions/test/unit/test_bug424262.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_bug449027.js => toolkit/mozapps/extensions/test/unit/test_bug449027.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_bug455906.js => toolkit/mozapps/extensions/test/unit/test_bug455906.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_bug514327_3.js => toolkit/mozapps/extensions/test/unit/test_bug514327_3.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_bug541420.js => toolkit/mozapps/extensions/test/unit/test_bug541420.js
 2010-05-01 11:04:44 -07:00
Dave Townsend
09099ef21b Bug 555486: Add a scope property to add-ons and allow disabling loading add-ons from certain scopes. r=robstrong 2010-04-07 11:08:32 -07:00
Mike Hommey
2112074658 Bug 543469 - Remove compiled python objects from automation during 'make clean' [r=ted.mielczarek] 
--HG--
extra : rebase_source : 9a0445c40fe27ec9fced679cc601ce55598d6fb8
 2010-04-19 10:17:51 +02:00
Mike Hommey
acc556837f Bug 557750: Remove vestigial code from the old safebrowsing protocol. r=vlad 2010-04-10 15:59:33 -04:00
Jacek Caban
ad4c1c7990 Bug 551256 - Disable vmwarerecordinghelper on mingw. 
r=ted.mielczarek.
 2010-03-24 00:24:38 +01:00
Jesse Ruderman
3988aabe8b Fix bug 539691: disable timeouts when using an interactive debugger, and use a saner timeout-kill method when using a non-interactive debugger. r=ted 2010-03-20 23:08:49 -07:00
Joel Maher
8991adb7bc Bug 540617 Process.kill instantiates another Automation() which adds another log handler r=ted 2010-03-18 13:13:33 -07:00
Joel Maher
d2705546fc Bug 543825 use of __import__ needs to be removed from automation.py r=ted 2010-03-18 11:14:14 -07:00
Ted Mielczarek
107bc1933c bug 411588 - support 64-bit universal binaries on OSX. add a build/macosx/universal/mozconfig-64. r=josh 
--HG--
rename : build/macosx/universal/mozconfig => build/macosx/universal/mozconfig.common
 2010-03-18 10:22:54 -04:00
Smokey Ardisson
3cc4e3b597 Bug 552028 - Teach flight.mk about Camino-with-toolkit.jar. r=ted. Camino-only, NPOTDB 2010-03-17 20:37:50 -04:00
Ted Mielczarek
182beccf00 bustage fix from bug 551941 - remove old binaries before running test 2010-03-17 14:14:08 -04:00
Ted Mielczarek
2e00065470 bug 551941 - fix 'unify' to recognize 64-bit Mach-O files. r=bsmedberg 
--HG--
extra : rebase_source : 5b9ae5f47929f69d8c0627ed694b6c4354ca995e
 2010-03-17 11:55:56 -04:00
Joel Maher
fe92dacd05 Bug 552441 Update devicemanager to have better error reporting for failed file transactions r=ctalbert a=dholbert for CLOSED TREE landing, NPOTB 2010-03-15 15:45:00 -07:00
Ben Turner
b333ee7b0f Bug 551256 - 'Automate VMWare recording over mochitests'. r=ted, a=dholbert for CLOSED TREE 2010-03-15 14:44:29 -07:00
Clint Talbert
c764b6beb3 Backed out changeset 31b7d1785eb2 due to automation.py bustage 2010-03-13 11:57:16 -08:00
Joel Maher
5157e45805 Bug 543825 remove __import__ from automation.py r=ted 2010-03-13 11:20:27 -08:00
Joel Maher
b6fdcf4a52 Bug 512319 Add options for mochitest to use an external server r=ted 2010-03-13 09:56:24 -08:00
Joel Maher
2425aebee7 Bug 493748 Refactor xpcshell test harness to enable it to work for remote devices r=ted (comment 14) p=jmaher Landing on a CLOSED TREE 2010-03-12 14:57:29 -08:00
Joel Maher
06ea20abd9 Bug 544097 Fixing up leaktest and profileserver tests to run with these changes r=ctalbert p=jmaher. Landed on CLOSED TREE 2010-03-12 13:53:37 -08:00
Joel Maher
6b6e9978a3 Bug 544097 Chaning mochitests to run against mochi.test instead of localhost r=ted, waldo, dwitte p=jmaher. Landed on CLOSED TREE 2010-03-12 13:53:36 -08:00
Brad Lassey
9e91dd4f04 bug 550138 - default thread size is too big r=dougt 2010-03-11 12:28:48 -05:00
Brad Lassey
4257e0473f bug 548207 - allow make check to run over remote connection from devicemanager.py r=ted,ctalbert,jmaher 
--HG--
rename : build/devicemanager.py => build/mobile/devicemanager.py
 2010-03-10 13:36:45 -05:00
Brad Lassey
369622eebe follow up to bug winmo_xmalloc, removing circular dependency r=dougt 2010-03-10 00:43:26 -05:00
Brad Lassey
96319c4535 backing out changesets e939397fc6a5, 88529662c474 and 3d7c54b194bb due to random hangs in pgo tests 2010-03-09 22:33:11 -05:00
Joel Maher
b52e3c4dfb Bug 512319 Add options for mochitest to use an external server p=jmaher r=ted 2010-03-09 11:54:39 -08:00
Joel Maher
e8cd5c9ea7 Bug 544097 changing mochitests to use mochi.test instead of localhost for windows mobile refactoring p=jmaher, r=ted,dwitte, sayrer, waldo, ctalbert 2010-03-09 08:55:39 -08:00
Joel Maher
1c8d232df2 Bug 544097 changing mochitests to use mochi.test instead of localhost for windows mobile refactoring p=jmaher, r=ted,dwitte, sayrer, waldo, ctalbert 2010-03-09 08:55:39 -08:00
Kyle Huey
ef9946d39a Backing out Bug 544097 due to test failures. 2010-03-09 01:16:43 -05:00
Kyle Huey
a7c3948d0a Backed out changeset 8ce70abd7777 2010-03-09 01:14:21 -05:00
Brad Lassey
daab44389b bug 551098 - windows mobile crashes on start up since xmalloc landing r=cjones 2010-03-08 22:45:51 -05:00
Joel Maher
694ec71da0 Bug 544097 Change mochitests to use mochi.test instead of localhost for mobile refactoring p=jmaher r=ted,dwitte,sayrer 2010-03-08 19:21:33 -08:00
Ginn Chen
7bf40bb9eb Bug 538723: run_for_effect is not portable for Bourne shell r=ted.mielczarek 2010-03-08 17:30:40 +08:00
Clint Talbert
5b4513c7e9 Backed out changeset b4372055f473 -- due to unexplained orange on OS X Leak test (Bd) box 2010-03-07 17:34:23 -08:00
Joel Maher
3cd691129e Bug 544097 - Change mochitests to use mochi.test instead of localhost for mobile test refactoring p=jmaher, r=sayrer,dwitte 2010-03-07 16:08:05 -08:00
Mike Hommey
77a49033d9 Bug 541768 - automation.py is not cleaned up. r=ted 2010-03-05 14:41:53 +01:00
Mike Hommey
17fda5950e Bug 541769 - leaktest files are not cleaned up by make clean. r=ted 2010-03-05 13:36:11 +01:00
Robert O'Callahan
66d7a231ec Bug 536524. Normalize paths when possible/necessary to keep them under MAX_PATH limits. r=bsmedberg 2010-03-05 11:52:59 +13:00
Chris Jones
f181d3cf73 Bug 441324, part 4: Enable infallible operator new (leaving malloc fallible) in Gecko, and play well with the wince shunt. r=bsmedberg r=blassey r=vlad 2010-03-03 23:02:58 -06:00
Chris Jones
90e5b2265a Bug 441324, part 3: Configure and build changes for libmozalloc. r=bsmedberg 2010-03-03 23:02:57 -06:00
Serge Gautherie
1a6115bba2 Bug 501436 - move Gecko 1.9.3 tinderboxes and production builds to Mac OS X 10.5, 10.5 SDK, gcc-4.2; (Bv1) Fix comment too. 
r=ted.mielczarek.
 2010-03-03 11:12:28 +01:00
Karl Tomlinson
5e290dd3be Use SIGABRT to trigger breakpad in hangs on UNIX to make these easier to distinguish from SIGSEGV crashes rs=ted no bug 
--HG--
extra : rebase_source : 6fad8dba8c062f3f0bf54fb29e0f1ae64d0bec0b
 2010-02-25 15:05:48 -08:00
Brad Lassey
e24c2cce8e bug 547627 - formattm test fails on windows mobile r=dougt 2010-02-25 13:12:33 -05:00
Doug Turner
328a598fc9 Backed out Bug 489813 / changeset 0542680c6f74 2010-02-23 23:11:18 -08:00
Doug Turner
d2afc943c8 Bug 489813 - fire geolocation timeout error if the provider fails to response after initial response. r=olli 
--HG--
extra : rebase_source : 03c08ca4f017302e8ae2e63cdb844c62f01c234e
 2010-02-23 20:27:27 -08:00
Joel Maher
98f2550953 bug 541410 - add devicemanager.py to mozilla-central r=ctalbert 2010-02-23 11:48:16 -05:00
Brad Lassey
316ce75429 bug 547864 - default entry point from winmo tool wrappers is invalid r=dougt 2010-02-22 20:28:38 -05:00
Jesse Ruderman
96ef373380 Bug 539516 - Switch automation.py to use the new python stack fixer. r=ted 
--HG--
rename : tools/rb/fix-macosx-stack.py => tools/rb/fix_macosx_stack.py
 2010-02-21 13:03:20 -08:00
Alex Pakhotin
6e99d103a7 bug 536972 - Cannot uninstall Fennec from Settings -> Memory Settings/Remove Programs r=blassey a=NPOTB 2010-02-04 23:44:24 -08:00
Ted Mielczarek
1451ee2e6c bug 540627 - provide an environment variable to save minidumps from test runs. r=bsmedberg 
--HG--
extra : rebase_source : d53ac17a06eb938e1fcd9a59e409b3467c04fed9
 2010-02-03 14:15:17 -05:00
Daniel Holbert
ab2d529d51 Backed out changeset 8006ad2d0c06 (tests for bug 542263), since its test 'test_GCrace.html' failed on OSX in its first cycle. 2010-02-02 18:57:15 -08:00
Benjamin Smedberg
deba97ab72 Testcase for bug 542263 - crash at NPObjWrapper_NewResolve or various other places 2010-02-02 17:18:41 -08:00
Benjamin Smedberg
f29d5d96f1 Fix typo in error-handling case that we rarely hit, r=trivial 
--HG--
extra : rebase_source : a6172b6b004f71fd14f818eb5da56dc04f98b46a
 2010-01-26 17:46:47 -05:00
Ted Mielczarek
8551798f2a punt on bug 540369, set timeout=None for leaktest 
--HG--
extra : rebase_source : 76440f6d2d263f951bf18e53336d51a779c8a838
 2010-01-26 08:14:01 -05:00
Phil Ringnalda
17f98e1b77 Try again to fix the Windows debug bloatcycle bustage from bug 540369, by cranking the timeout up to 3540 seconds 2010-01-25 21:22:45 -08:00
Jonathan Griffin
7e0b15b6d9 Provide a higher timeout for leaktest.py, since it began timing out at 60s after fixing bug 540369. 2010-01-25 17:45:39 -08:00
Jonathan Griffin
e845a6725c Bug 540369. Fix unit test hang detection on Windows. r=ted 
--HG--
extra : rebase_source : 9e9c8f45f61585ac0bb3f08d873289003d95c14d
 2010-01-25 12:37:58 -08:00
Jesse Ruderman
389531178d Bug 540518 - when searching for debugger, ignore directory names. r=jgriffin 2010-01-21 12:02:51 -08:00
Jesse Ruderman
36ed6473eb Fix bustage from rev 0aeedccc0125 (bug 530475) when running tests with maxTime. 2010-01-19 15:47:57 -08:00
Joel Maher
2f4abc99e3 Bug 530475 - convert test harness python code to classes additional refactoring for automation.py and runtests.py p=jmaher r=ted 2010-01-19 11:45:04 -08:00
Joel Maher
9cbb17cab6 Bug 530475 - Convert testharness python code to classes for future integration with mobile framework p=jmaher r=ted 2010-01-15 09:22:54 -08:00
Benjamin Smedberg
56fe91e3d0 Bug 539290 - Test harness should look for minidumps from child (plugin) processes but not turn the tree orange automatically, r=ted 
--HG--
extra : rebase_source : abc65388958859668b63342c046985e1e4083012
 2010-01-12 16:53:10 -05:00
Clint Talbert
97380eb3ce Orange on Bd builds: Backed out changeset 745af1f3dbf5 2010-01-13 14:44:49 -08:00
Joel Maher
d3cc2ac124 Bug 530475, convert test harness python code to classes for future integration with mobile framework. r=ted patch=jmaher 2010-01-13 13:53:26 -08:00
Benjamin Smedberg
5d57e270ca Import ctypes.wintypes explicitly to avoid a python exception when child processes get hung. 2010-01-08 15:52:37 -05:00
Neil Rashbrook
f26aad7e85 Bug 525057 'make clean' deletes automationutils.py r=ted 2010-01-11 23:55:51 +00:00
Clint Talbert
a961a03110 Backed out changeset e67e79969232 due to orange on debug mochitests 2010-01-07 19:57:02 -06:00
Joel Maher
ab0d8f0041 Bug 530475 - Refactoring test harnesses to classes for easier reuse for mobile testing p=jmaher r=ted 2010-01-07 12:47:19 -06:00
Jesse Ruderman
d4106cb768 Bug 532184: add optional maxTime argument to runApp. r=ted 2010-01-06 16:45:46 -08:00
Clint Talbert
4fc756af56 Merging backout to tip - backout of 85cd0f297421 2010-01-06 16:08:37 -06:00
Clint Talbert
d938e08992 Backed out changeset 85cd0f297421 - causing orange on leak bloat and linux mochitests 2010-01-06 16:03:29 -06:00
Clint Talbert
b9266a5d55 Backed out changeset aa6337822028 2010-01-06 16:01:43 -06:00
Mark Banner
806e1586f4 Follow-ups to fix bloat bustage and make xpcshell-test result reporting work with buildbot after the landing of bug 530475. r=ted over irc. 2010-01-06 19:59:12 +00:00
Dave Townsend
d90169e548 Bug 435743: Add expire ssl certificate to the mochitest certdb. r=ted 2010-01-06 10:25:44 -08:00
Joel Maher
3d0c15f608 Bug 530475 - convert all python test harnesses to classes for easier reuse, patch=jmaher, r=ted 2010-01-06 12:01:18 -06:00
Benjamin Smedberg
235c04a443 Bug 535802 - disable the Windows JIT crash dialog when running mochitests, r=ted 2009-12-18 16:16:38 -05:00
Jonathan Griffin
eee412ce5e But 535564. Remove log file after all processes are closed. r=bsmedberg 2009-12-22 15:13:59 -08:00
Neil Rashbrook
df2df0f429 Bug 525047 'make clean' deletes automationutils.py (backout) 2009-12-18 00:19:53 +00:00
Neil Rashbrook
6e655e8633 Bug 525057 'make clean' deletes automationutils.py r=ted 2009-12-17 20:59:10 +00:00
Benjamin Smedberg
b51dfb8d55 Merge mozilla-central into electrolysis 2009-12-16 08:38:42 -05:00
Gavin Sharp
c1a2f3dfa9 Back out revision dbdbe3ad0234 from bug 525047 - every leak test box that's clobbered since it landed has failed, not finding the first thing it tries to import from automationutils 
--HG--
extra : rebase_source : 6c8b3ef583b3ad06de1b395db13bedee735f125e
 2009-12-15 23:35:30 -05:00
Benjamin Smedberg
83b97480d2 Merge mozilla-central into electrolysis. 2009-12-15 20:31:04 -05:00
Jonathan Griffin
2fe20f5e48 Bug 534934 - mochitest-ipcplugins: OSError: [Errno 10] No child process, r=bsmedberg 2009-12-15 20:21:51 -05:00
Neil Rashbrook
7ce78cf1ff Bug 525057 \'make clean\' deletes automationutils.py r=ted 2009-12-15 21:39:51 +00:00
Benjamin Smedberg
a54e6acfd8 Merge mozilla-central into electrolysis. 2009-12-14 08:01:18 -05:00
Benjamin Smedberg
636d74b114 Merge mozilla-central into electrolysis. One code change was required: in nsDocShell::CreateStaticClone I replaced EnsureDocShell with MaybeCreateDocShell. 2009-12-12 13:38:25 -05:00
Jonathan Griffin
569ac26eaa Bug 533482. Let plugin crashtest notify testrunner that no leak log is expected when the plugin process is deliberately crashed. r=bsmedberg 2009-12-09 10:51:38 -08:00
Chris Jones
d082c2f770 bug 532962: allow run-mozilla.sh to accept debugger arguments. r=luser 2009-12-07 01:10:46 -06:00
Benjamin Smedberg
e98d1daf07 Merge mozilla-central into Electrolysis 2009-11-30 12:59:43 -05:00
Jesse Ruderman
8bbd3e6ae5 Bug 531479 - Always return exit status of the app, not the stack fixer process. r=dbaron 2009-11-29 13:29:03 -08:00
L. David Baron
d26b02876a Rerun 'make genservercert' in build/pgo and commit the resulting certs to fix expired test server certs and make the tree green. 
--HG--
extra : transplant_source : L%D1V%EAX%C1%C1%E2%8A%DF%F5%AC%AA%B4%DB%D2%D1L%2AS
 2009-11-28 21:30:27 -08:00
Clint Talbert
522c53eb83 Causing oranges -- Backed out changeset b3c18f150531 2009-11-25 18:00:31 -08:00
Joel Maher
3dcbe17432 Bug 512319 Add option to allow mochitest to use external web server patch=jmaher r=ted 2009-11-25 17:04:02 -08:00
Ted Mielczarek
2dae1cece4 bug 530093 - allow building with VC10. configure+build system changes. r=bsmedberg 2009-11-23 10:20:21 -05:00
Benjamin Smedberg
4ee635dc19 Bug 523208 - ensure mochitest expects multiple processes, original patch by jgriffin, reworked for ted's review comments by bsmedberg, r=ted 2009-11-20 14:48:56 -05:00
Benjamin Smedberg
d74c6776f3 Merge mozilla-central into electrolysis. 2009-11-19 12:41:46 -05:00
Jacek Caban
dec48e47be Fixed includes on case sensitive systems. (actually, this time) 
Bug 501034 - (Packaged) Unit tests boxes should be able to get a stack trace from browser hangs/timeouts.
r=ted.mielczarek.
 2009-11-19 14:04:44 +01:00
Serge Gautherie
ce1d1e473e s/CrLf/Lf/g, EOL whitespace removals. 
Bug 501034 - (Packaged) Unit tests boxes should be able to get a stack trace from browser hangs/timeouts; (Dv1).
r=ted.mielczarek.
 2009-11-19 14:01:01 +01:00
Jonathan Griffin
e57f832609 Bug 519570. Log leaks for child processes in separate files, and handle them in automation.py. r=bsmedberg 2009-11-10 11:16:12 -08:00
Brad Lassey
7316a1c605 bug 515748 - differentiate between wince and winmo (change windows mobile ABI to arm-wince-winmo) r=ted 2009-12-04 14:14:18 -05:00
Ted Mielczarek
34015a77aa bug 525370 - figure out windows bustage with hang detection and re-enable it. r=jwalden 
--HG--
extra : rebase_source : 24ea6c09d89f20c21dc7f0b49b6dc62e32cd5934
 2009-10-30 13:00:19 -04:00
Benjamin Smedberg
1ead4f5856 Bug 519357 - Only load known binary components from the app directory by reading a components.list file, r=vlad 2009-11-05 09:08:49 -05:00
Ted Mielczarek
cca6da95a5 bug 526668 - add option to 'unify' to allow files to match if their sorted contents match. r=bsmedberg 2009-11-05 09:04:49 -05:00
Jesse Ruderman
059c6b337f automation.py no longer needs to set this SMIL pref, since it is now the default. Bug 532997, r=dholbert 2009-12-04 14:25:31 -08:00
Blake Kaplan
525da59c55 Bug 524690 - Explicitly disable the crashreporter if we have a debugger. r=ted 2009-11-17 03:11:33 -08:00
Jonathan Griffin
9c01be79f0 Bug 524489. Add the --setpref option to runreftest.py. r=ted 2009-11-11 14:50:35 -08:00
Ted Mielczarek
a6c23d0999 back out accidental changes (on a CLOSED TREE, no less) 2009-11-11 13:27:09 -05:00
Ted Mielczarek
be7ae61cc0 add some debug output to investigate bug 522729 (on a CLOSED TREE) 2009-11-11 12:32:07 -05:00
David Mandelin
370a86b518 Bug 515211: remove memory reserve feature from jemalloc, r=jasone 2009-11-02 13:02:37 -08:00
David Mandelin
b8fb573849 Backed out changeset 109b74e8e902 due to tinderbox bustage (was bug 515211) 2009-10-30 11:15:03 -07:00
David Mandelin
e82d146136 Bug 515211: remove memory reserve feature from jemalloc, r=jasone 2009-10-30 11:02:38 -07:00
Ted Mielczarek
d69d1afc18 disable windows hang checking for now, bug 525370 filed to sort it out 2009-10-29 20:25:58 -04:00
Ted Mielczarek
7745adcd88 bustage fix for bug 501034 2009-10-29 19:20:42 -04:00
Ted Mielczarek
9c12663894 bug 501034 - add a Win32 helper app to crash a process, and make automation.py use it when the app hangs. r=Waldo 
--HG--
extra : rebase_source : 845326f8cfcd3dfe7ca5b0a98bd0810966cf2809
 2009-10-16 13:34:27 -04:00
Ted Mielczarek
76b0e0bd6a bug 501034 - add hang detection + breakpad triggering to automation.py. r=Waldo 
--HG--
extra : rebase_source : 088eeeb0c3135d1048dca08f3639642a90b2eab2
 2009-10-13 16:56:24 -04:00
Benjamin Smedberg
1b015e4cd1 Bug 524139 - Eval .all.pp instead of including it. This means that in the normal case we avoid any make restarts and the associated I/O that goes with them, which could possibly be slowing Windows builds down considerably r=ted 
--HG--
extra : rebase_source : 9671d212954595ef76b1870957e09ec6bc018e83
 2009-10-23 13:00:19 -04:00
Benjamin Smedberg
fd29090054 Update pymake for additional fixes, including making it work in MozillaBuild 1.4 without manually exporting SHELL, not printing warnings for -include files which don't exist, and parsing errors in browser/locales/Makefile. 2009-10-26 14:08:20 -04:00
Jonathan Griffin
6bc3380759 Bug 523208. Fix string to refer to --setpref instead of --extra-pref. 2009-10-26 09:57:33 -07:00
Phil Ringnalda
d5b8092f6f Bug 523054 - Sweep out some more viewer orts, r=dbaron 2009-10-25 10:03:17 -07:00
Benjamin Smedberg
1dcf48cce4 Update pymake to pick up the fix for bug 523691 and some other stuff, NPODB. 2009-10-23 11:16:27 -04:00
Ted Mielczarek
77db50f3f3 bug 523330 - default symbols path busted for mochitest/reftest. r=bsmedberg 2009-10-21 14:19:51 -04:00
L. David Baron
996fc6836b Set dom.popup_maximum to -1 to work around weirdness with the offline tests and get the tree green again, and because we probably want to do it anyway. CLOSED TREE 2009-10-22 13:49:21 -04:00
Ted Mielczarek
13ceba6a75 bug 522829 - add an extra print statement to checkForCrashes to try to figure out what's going wrong 2009-10-20 13:27:02 -04:00
Jonathan Griffin
89b487b6ff Bug 521457. Add debugger options to runreftest.py and runxpcshelltests.py. r=ted 
--HG--
extra : rebase_source : 420b33b1d44aae7361c25d8bcc15032c303aa80d
 2009-10-19 16:12:09 -07:00
Jonathan Griffin
997ce091cb Bug 519574. Add --setpref to runtests.py, to add custom prefs to mochitest runs. r=mielczarek 
--HG--
extra : rebase_source : db4f83d61b30b70fe5e3f49b25367f223a1ea5e3
 2009-10-14 10:55:25 -07:00
Ted Mielczarek
8c1c721b01 bug 515436 - Electrolysis test runs need a special LD_LIBRARY_PATH. fix automation.py and various consumers to not overwrite LD_LIBRARY_PATH. r=bsmedberg 
--HG--
extra : rebase_source : 414a8059faaf7888b53f98712d0b0f6b4863d2ad
 2009-10-08 14:10:47 -04:00
Chris Jones
2151b59798 Merge backout 2009-10-02 18:09:39 -05:00
Chris Jones
708e2e04ae Backed out changeset 8cbc47eee659 2009-10-02 18:09:08 -05:00
Ted Mielczarek
11b5eeca6c bug 519194 - No symbols in stack trace on tests of optimized builds (landing without review, consider it a bustage fix) 2009-10-02 14:46:49 -04:00
Chris Jones
f2df9d3504 bug 441324: implement infallible ::operator new(), malloc() and friends. make |new Foo()| infallible, but leave |malloc()| fallible for the time being. r=blassey sr=bsmedberg,vlad 2009-10-01 21:50:09 -05:00
Ted Mielczarek
d73c55c6ca bug 518641 followup, don't try to copy files around if the test-package directories don't exist. 
--HG--
extra : rebase_source : baa18363c47218f4020b19c9782155c9aae27992
 2009-10-01 18:07:52 -04:00
Nick Thomas
fbbae053a0 Bug 518641 followup, delete unified test-package directory (resolves bustage the 2nd time a build slave packages tests) 2009-10-01 17:21:51 +13:00
Ted Mielczarek
735e15be83 bug 518641 - "make package-tests" doesn't work right on OS X universal builds. r=bsmedberg 
This patch causes us to build archictecture-specific test packages in the
OS X universal build postflight makefile, and unifies them into a universal
test-package (containing the same test files, but universal binaries), and
then special-cases the "package-tests" target to use that pre-generated
test package in the universal build case.

--HG--
extra : rebase_source : 41d1f3fe887a2dbdee3ad560ab46bcb261883690
 2009-09-29 08:31:50 -04:00
Ted Mielczarek
555cf95f52 bug 518641 - fix the "unify" script to properly handle Java .class files. r=bsmedberg 
Java .class files and Mach-O fat binaries use the same 4-byte magic
number at the start of the file. 'unify' uses the magic number to detect
Mach-O binaries, so it chokes on Java .class files. This change makes us
use the same heuristic as file(1), which is to check the second 4 bytes
in the file. Java class files put a version number there, and Mach-O
fat binaries put the number of contained architectures there. Conveniently,
Mach defines only 18 architectures, and Java's lowest shipping version
number is 43, so there's no overlap in valid values.

--HG--
extra : rebase_source : 84f5382bca6fa4bde721686f029514a41dfaf6b4
 2009-09-29 08:31:50 -04:00
Brad Lassey
e2d6474902 bug 503710 - PR_FormatTime / strftime() doesn't work on Windows CE shunt r=dougt 2009-09-25 12:52:09 -04:00
Boris Zbarsky
b0c5eda9d5 Another fix for bug 485531, working around the bustage from bug 504480. r=ted 2009-09-25 12:47:51 -04:00
Mitchell Field
41c8798093 Bug 514665 - fix stupid module name differences on windows. r=ted 2009-09-25 18:41:16 +02:00
Benjamin Smedberg
bc9329c8b8 Build bustage from bug 485409: extra quoting required for PERL now. 2009-09-22 10:13:27 -04:00
Benjamin Smedberg
2ddee4d280 Bug 485409 - Handle a Windows-style path as $srcdir in configure, by modifying the default autoconf M4 macros so that they recognize Z:/ as an absolute path. r=ted 2009-09-22 09:05:48 -04:00
Phil Ringnalda
8490d39416 Bug 514211 - Sweep some mouse turds out of build/unix/, r=ted 2009-09-18 19:59:52 -07:00
Serge Gautherie
bd635f12a4 Bug 469523 - xpcshell-tests: enable leak log in tinderbox (log); (Hv1) Use automationutils.dumpLeakLog(), fix/update automationutils.processLeakLog() log messages 
r=ted.mielczarek
 2009-09-16 17:50:03 +02:00
Josh Aas
8ebbb5dc03 Use gcc-4.2 and the 10.5 SDK by default in Gecko 1.9.3. Gecko 1.9.3 builds will no longer run on Mac OS X 10.4. b=501436 r=ted 2009-09-15 13:11:24 -04:00
Alex Pakhotin
d493348d47 Bug 508721 - fixing a bug in argument passing in WinCE build tools, r=blassey 2009-09-10 14:32:32 -07:00
Josh Aas
4d74048d88 Remove build/package/debian. See bug 233323. r=ted 2009-09-10 16:05:41 -04:00
Brad Lassey
41f9430c6d bug 515415 - [WinCE] Software Update not being applied, path from wgetcwd doesn't always end with a slash r=dougt 2009-09-10 14:45:08 -04:00
Josh Aas
c015876638 Add executable bits back to config.guess files. b=515002 2009-09-09 08:20:25 -04:00
Josh Aas
5d3659c9b7 Sync config.guess to latest version from gnu, include fix for GNU Savannah bug 6827. b=515002 r=ted 2009-09-08 14:55:19 -04:00
Serge Gautherie
530cee485c Bug 469523 - xpcshell-tests: enable leak log in tinderbox (log); (Fv1) Move code to automationutils.py from automation.py.in 
r=ted.mielczarek
 2009-09-06 03:08:49 +02:00
Ted Mielczarek
c65ac173f4 Bug 469523 - xpcshell-tests: enable leak log in tinderbox (log); (Gv1a) fix build dependencies of automationutils.py 
r=benjamin
 2009-09-06 03:08:46 +02:00
Benjamin Smedberg
667f63d102 Bug 513032 - remove empty conditionals in our makefiles, r=ted 2009-08-27 10:48:18 -07:00
Brad Lassey
7943b46da5 bug 506763 - wgetcwd implementation in the WinCE shunt is broken in some circumstances r=dougt 2009-08-28 10:15:24 -04:00
Benjamin Smedberg
9319c2f3df Additional followup #3 to bug 398573 - remove more REQUIRES by fixing another bug in the script 2009-08-27 09:09:31 -07:00
Benjamin Smedberg
36bc86429d Additional followup to bug 398573 - remove REQUIRES from the tree even when they are in makefile conditional blocks 
--HG--
extra : rebase_source : cc65c34a414e6c67a5651fc9cf0b6bd709ebcdbd
 2009-08-27 08:53:13 -07:00
Serge Gautherie
e2676420d0 Backed out changeset: f6bf83b50648 2009-08-26 22:36:55 +02:00
Serge Gautherie
0d86432574 Bug 469523 - xpcshell-tests: enable leak log in tinderbox (log); (Fv1) Move code to automationutils.py from automation.py.in 
r=ted.mielczarek
 2009-08-26 18:36:40 +02:00
Benjamin Smedberg
ba372f3a4c Followup to bug 398573 - remove REQUIRES from the tree since it is no longer used... automatically generated patch, rs=ted 2009-08-25 08:59:31 -07:00
Brian Crowder
1defac4647 fixing an issue w/ global variable in cab builder python script, r=me 2009-08-22 01:02:21 -07:00
Brian Crowder
c2d66429fa Bug 511936: cab-file building python script should respect MOZ_FASTSTART and add a faststart link to cab installer, r=blassey 2009-08-22 00:13:49 -07:00
Robert Strong
d17b9ee601 Bug 510836 - mozce_shunt.dll loaded with updater.exe. r=blassey, r=vlad 2009-08-20 19:58:47 -07:00
Vladimir Vukicevic
8430c62d48 b=511568; WinCE shunt not overriding std::nothrow operator new; r=blassey 2009-08-20 18:46:34 -07:00
Karl Tomlinson
b0934c0c94 Bug 477724 avoid pointless shell interpreter hanging around r=bsmedberg 2009-08-21 10:09:54 +12:00
Nick Thomas
2c70708eb9 Bug 530469, disable parallel make in build/wince/tools, r=ted.mielczarek 2009-08-18 17:23:38 +12:00
Justin Dolske
975583b96f Bug 509138 - errors reported when building WinCE tools. r=benjamin 2009-08-14 16:22:43 -07:00
Clint Talbert
c030f1404e Bug 482260, Add more comprehensive tests, patch=dougt, r=mfinkle,jmaher,ctalbert 2009-08-14 16:12:09 -07:00
Brad Lassey
e480b0ea50 Backed out changeset 08f71a710ae3 due to orange unit tests r=dougt 2009-08-12 19:26:03 -07:00
Doug Turner
4f5320f9e8 Bug 482260. Add more tests cases for geolocation. Also fixes max age not being able to be set to zero. r=mfinkle,jmaher. 2009-08-12 12:17:33 -07:00
Nick Thomas
80a345edce Bug 503469, Support packaging WinCE Firefox builds as zip, complete.mar, r=ted.mielczarek 2009-08-11 15:50:32 +12:00
L. David Baron
863d371153 Run output of debug builds through fix-linux-stack/fix-macosx-stack. (Bug 385248) r=ted 2009-08-10 15:52:29 -07:00
Boris Zbarsky
035e5c7461 Bug 485531. Make --debugger-gdb work reliably on mac. r=ted 2009-08-06 13:34:49 -04:00
Phil Ringnalda
f2aeeb5dd4 Bug 504239. Remove useless chunk of barely-used script. r=ted 2009-08-04 09:50:18 +12:00
Paul O’Shannessy
0baea5a5b1 Bug 506394 - ExpandEnvironmentStringsW in CE shunt isn't quite right, r=vlad 2009-08-01 16:21:58 -07:00
Honza Bambas
9a7c591b1f Bug 483440 - PSM doesn't detect invalid OID encodings in Cert Viewer Details tab, r=nelson+johnath 2009-07-29 22:23:27 +02:00
Honza Bambas
487118f352 Bug 483437 - PSM doesn't properly escape AVA Values in Cert Viewer Details tab, r=nelson+benjamin 2009-07-29 22:23:27 +02:00
Jim Blandy
5f5d38207c Bug 475654: Allow workaround for NSPR installations with no nspr-config script. a=wes, r=jimb 2009-07-28 13:18:50 -07:00
Ginn Chen
e1b3b43cd4 Bug 456719 run-mozilla.sh doesn't work well with ksh93 r=benjamin 2009-07-23 18:09:10 +08:00
Mark Banner
3f98fff29e Bug 503886 Allow non-mozilla central applications to use automation-build.mk. r=bsmedberg 2009-07-17 09:25:41 +01:00
Doug Turner
05b95d88e2 [Bug 504181 
1] WinCE build tools - optionally force text and rdata to be locked. r=vlad
 2009-07-16 11:32:03 -07:00
Vladimir Vukicevic
344e4eadd9 b=503123; add some additional defines/include paths to WinCE tools; r=dougt 2009-07-08 16:34:01 -07:00
Brad Lassey
e3456fed1e bug 498844 - need _wchdir for updater (in shunt) r=dougt 2009-07-08 11:46:36 -04:00
Robert Kaiser
47ec939c62 bug 498500 - Mac DMG unpackaging is unreliable, r=ted 2009-07-06 18:13:57 +02:00
Vladimir Vukicevic
f08671291f b=501180; add flag to disable compress for cabwiz to make_wince_cab; r=blassey 2009-07-01 11:38:00 -07:00
Brad Lassey
a6223e7bd0 bug 50070 - mozconfig2configure can't handle paths with parenthesis r=ted 2009-06-24 16:21:14 -04:00
Chris AtLee
a841e58701 Bug 499161 - Set xrePath when creating the environment for the main process. r=ted 2009-06-18 15:13:20 -04:00
Brad Lassey
8609331e56 bug 498394 - wince shunt's unlink has wrong return value r=dougt 2009-06-18 07:34:12 -04:00
Hiroyuki Ikezoe
65d54cc638 bug 491795 - argpath_conv in toolspath should support Fe option r=blassey 2009-06-18 07:33:01 -04:00
Brad Lassey
96329b9967 bug 491796 - arm-wince-gcc should support link and entry options r=dougt 2009-06-18 07:28:57 -04:00
Dave Townsend
30cbd05ee8 Bug 497884: Intermittent failure in test_classifier.html and test_classifier_worker.html. r=sdwilsh 2009-06-17 11:47:08 +01:00
Joel Maher
75b52fe065 Bug 489817 - migrate existing geolocation tests from mochitest to browser-chrome; r=(ctalbert + doug.turner) 2009-06-08 21:50:04 +02:00
Hiroyuki Ikezoe
bb7a53e73f bug 493648 - build errors due to mozce_shunt.h is in dist/include (caused by bug 488175) r=bsmedberg, blassey 2009-05-19 14:15:51 -04:00
Asaf Romano
3f7058f3aa backing out bogus checkin again 2009-05-18 04:18:37 +03:00
Asaf Romano
592042f9c0 bug 490068 - leak window after showing bookmarks panel. r=dietrich. 2009-05-17 23:14:27 +03:00
Josh Aas
355a68db3b Remove a perl module used to build on classic Mac OS (MacCVS). rs=bsmedberg 2009-05-14 16:41:55 -04:00
Josh Aas
f1fcda13ba Sync config.guess with latest from gnu "config" package. See bug for changelog. b=492623 r=ted 2009-05-12 23:47:03 -04:00