Commit Graph

206 Commits

Author SHA1 Message Date
roc+%cs.cmu.edu
4667a9b409 Bug 330305. Rename nsSelection to nsFrameSelection, and deCOMtaminate it, removing nsIFrameSelection. patch by Marc Liddell, r+sr=roc 2006-04-26 01:57:22 +00:00
mrbkap%gmail.com
8cde2f4313 Make the caret paint in the same color as the foreground so it's not always painted black. bug 334635, r+sr=roc 2006-04-21 19:13:58 +00:00
mrbkap%gmail.com
e27b36efcc Draw the caret in the normal path of frame painting instead of doing it directly to the current view. bug 287813, r+sr=roc 2006-04-17 23:16:46 +00:00
dbaron%dbaron.org
5dcd0b1309 One-line descriptions of files, partly because they show up in LXR. 2006-03-30 05:56:38 +00:00
uriber%gmail.com
ba0d30b880 In nsTextEditRules::CheckBidiLevelForDeletion(), use nsSelection::GetPrevNextBidiLevels to determine bidi levels. bug=330460 r=smontagu sr=roc 2006-03-23 08:20:29 +00:00
smontagu%smontagu.org
d999b33cff Bug 305798: Bidi: After deleting last character of reverse-direction text, arrow keys move caret incorrectly. Patch by Uri Bernstein <uriber@gmail.com, r=smontagu, sr=roc 2005-11-16 09:37:01 +00:00
mark%moxienet.com
045ce7774f Bug 311399, Crash [@ SetOrigin] during rendering context destruction. Remove QD save/restore from rendering context, it was placed there as a workaround for scrollbar functional and aesthetic bugs. Add OS event handler to fix aesthetic problems, and check for bad states to work around functional problems. r=josh sr=smfr 2005-11-10 03:46:52 +00:00
masayuki%d-toybox.com
e7ed3d82a7 Bug 313918 IME candidate list is positioned to wrong position if the caret is positioned non-root view r+sr=roc 2005-10-29 12:43:51 +00:00
roc+%cs.cmu.edu
344b4be95e Bug 311152. Make DOM selection changes repaint the caret in the new position. r=mrbkap,sr=dbaron 2005-10-12 18:40:38 +00:00
aaronleventhal%moonset.net
fd97041e21 Bug 193316. Caret not visible in readonly fields (HTML or XUL). r=mrbkap, sr=smfr 2005-10-04 03:14:03 +00:00
mats.palmgren%bredband.net
f048b80534 Caret drawn at incorrect position after typing a single LTR character in a blank RTL input field (or vice versa) while caret is visible. b=307533 r=uriber sr=bzbarsky 2005-09-10 11:14:48 +00:00
mrbkap%gmail.com
5187e69f5f bug 303399: Bidi: Problems with caret positioning on blank lines. Patch by Uri Bernstein <uriber@gmail.com>. r=mrbkap sr=roc 2005-08-24 17:44:28 +00:00
mats.palmgren%bredband.net
decb76621e Erase caret if needed when content is removed. b=304383 r=mrbkap sr=bzbarsky 2005-08-22 00:25:20 +00:00
mats.palmgren%bredband.net
b3f31d48d4 Don't use a Frame pointer to remember where we last painted the caret, instead use Content+offset+hint. b=296464 r=mrbkap sr=roc a=cbeard 2005-08-11 03:44:16 +00:00
dougt%meer.net
be6760da53 Windows CE build changes. This addresses most of the outstanding Windows
CE compilation issues.

This patch also fixes/removes CheckStackGrowthDirection assertions in
Javscript.  This change is based on bug 242518.  See comment 36.

This patch also removes the unused enum in transformiix .  See bug
292118.

r/sr = dveditz/shaver
b    = 291229
a    = asa
2005-04-29 13:33:49 +00:00
mats.palmgren%bredband.net
a3c9fa1b01 Account for the view's origin not lining up with the widget's. b=190290 r=bzbarsky sr=roc 2005-03-26 14:50:09 +00:00
bzbarsky%mit.edu
f01adb747a Fix crashes in GTK1 builds due to reuse of rendering contexts for the caret.
Bug 254049, patch by Mark Banner <mark@standard8.demon.co.uk>, r=jst, sr=roc
2005-02-01 21:19:05 +00:00
bryner%brianryner.com
f575a675b2 Remove nsIAutoCopy and fold the functionality into nsSelection.cpp (bug 231343). r+sr=roc. 2005-01-31 23:47:26 +00:00
bmlk%gmx.de
d3197a9276 remove unused prescontext argument from GetOffsetFromView bug 276015 r/sr=dbaron 2004-12-26 19:48:54 +00:00
smontagu%smontagu.org
52ff1c323f Prevent the right-to-left directional hook from overlapping the caret and make both directions thinner. Bug 264903, r=mkaply, aaronleventhal, sr=rbs. 2004-11-30 19:28:00 +00:00
neil%parkwaycc.co.uk
a45fb5a046 Don't use QueryInterface to get a scrollable view from a view b=258521 r+sr=roc 2004-11-24 00:19:21 +00:00
scott%scott-macgregor.org
903bd845ea Try landing the fix for infamous Bug #98564 again -->
caret overlaps the last character in textfield (if positioned after the last char)

r=smontagu
sr=sfraser

We think this patch can land again because the regression it introduced was fixed by
Bug #216101 which does a better job of clearing out caret fragments.
2004-11-10 07:14:08 +00:00
aaronleventhal%moonset.net
cd89107e7e Fixing bustage 2004-10-13 02:24:38 +00:00
aaronleventhal%moonset.net
ca0cd1c767 Bug 261054. Make caret consistently the same width throughout Gecko/Mozilla. Configurable through ui.caretWidth. r=glazou, sr=rbs 2004-10-13 01:12:14 +00:00
neil%parkwaycc.co.uk
6a4f37de6b Don't use QueryInterface to get a view from a scrollable view b=258521 r+sr=roc 2004-09-20 22:25:07 +00:00
bryner%brianryner.com
d082d2bf5e More nsIPresShell deCOMtamination:
- Made Get/SetAuthorStyleDisabled and ReconstructStyleData non-virtual when called internally.
- Inlined GetFrameSelection and renamed it to FrameSelection.
- Removed non-inline version of GetViewManager.
- Removed unused EnablePrefStyleRules and ArePrefStyleRulesEnabled.

Bug 253889, r+sr=roc.
2004-08-29 03:08:44 +00:00
bryner%brianryner.com
180b0b7373 Remove refcounting version of nsIPresShell::GetPresContext. Bug 253889, r+sr=roc. 2004-08-20 20:34:37 +00:00
bryner%brianryner.com
5c02a6978c Change nsIPresContext to nsPresContext globally, follow-up to bug 253470. rs=roc 2004-07-31 23:15:21 +00:00
caillon%redhat.com
8f71882950 Bug 241507
Don't create new rendering contexts for each caret drawn on *nix platforms since there are no known issues with doing so.  If issues crop up, I will undo this change.
r/sr=jst/bryner
2004-06-29 19:12:19 +00:00
neil%parkwaycc.co.uk
ed766b9ccb Bug 216101 Cleaing frame refs can leave caret fragments p=mnyromyr@tprac.de r/sr=roc 2004-06-25 09:57:35 +00:00
bryner%brianryner.com
97a65f9548 Get rid of nsILanguageAtom and deCOMtaminate nsILanguageAtomService (bug 230603). Also, fix a bunch of atom double-addref leaks in nsFontMetricsXlib. r+sr=dbaron. 2004-06-08 23:53:59 +00:00
smontagu%smontagu.org
82d48e1672 DeCOMtaminate nsIFrame Set/GetProperty and merge Set/GetBidiProperty with it. Bug 117751, r+sr=roc 2004-06-01 06:20:16 +00:00
sspitzer%mozilla.org
3862b3557b bullet proofing (wall paper) fix for top crasher bug #243294
now we just assert, instead of crash. see bug #245055 about the real problem.

Crash [@ nsCaret::GetViewForRendering] when printing a schedule from www.matkahuolto.info

r/sr=roc
2004-05-29 19:57:00 +00:00
gerv%gerv.net
708b56cff4 Bug 236613: change to MPL/LGPL/GPL tri-license. 2004-04-18 14:30:37 +00:00
tor%cs.brown.edu
83eb215db9 Bug 240274 - remove PopState() argument. r=blizzard, sr=bryner 2004-04-18 13:13:35 +00:00
bryner%brianryner.com
0af1a79c51 More nsIPresContext deCOMtamination (bug 229371). r+sr=roc. 2004-04-13 00:28:44 +00:00
bryner%brianryner.com
433c389ddf Inline getters and setters for scaling factors on nsIDeviceContext. Bug 233103, r+sr=dbaron. 2004-02-05 01:57:10 +00:00
bryner%brianryner.com
4f69ec2c2e Guarantee that the pres context's device context will be non-null by returning failure from Init() if it's null. Rename inline getter GetDeviceContext() to DeviceContext(), convert all callers to use the inline getter, and remove the virtual/refcounting getter. Bug 229371, r+sr=dbaron. 2004-02-02 22:17:21 +00:00
bryner%brianryner.com
ef5c330583 Continuing nsIPresContext deCOMtamination (bug 229371). Remove GetImageLoadFlags (unused). Make failure to fetch the LookAndFeel service cause Init() to fail, don't null check it after that, and inlined the getter. Move IOService caching to nsImageFrame, the only user of it. r+sr=bzbarsky. 2004-01-21 09:35:59 +00:00
scott%scott-macgregor.org
c2df672e12 Bug #226325 --> Back out the fix for Bug #98564 as this opened us up to a regression where trailing stationary caret remnant left after backspace.
a=asa for 1.6b
2003-12-03 20:32:47 +00:00
scott%scott-macgregor.org
54777f2e4f Bug #98564 --> caret overlaps the last character in textfield (if positioned after the last char).
Patch written by kin.


r=smontagu
sr=sfraser
2003-11-16 07:08:55 +00:00
bryner%brianryner.com
9d11b3c424 Fix build on gcc 3.4 by removing extra semicolons (bug 218551). r/sr=dbaron, a=brendan. 2003-09-07 22:37:27 +00:00
jaggernaut%netscape.com
95899387f6 Bug 213602: Switch some users of NS_GetWeakReference over to do_GetWeakReference. r=bzbarsky, sr=dbaron 2003-07-25 19:06:59 +00:00
jaggernaut%netscape.com
83c571e877 Bug 25886: Get rid of a bunch of unused NS_DEFINE_IID, NS_DEFINE_CID. r=caillon, sr=dbaron 2003-07-20 07:47:59 +00:00
roc+%cs.cmu.edu
e324543a75 Ongoing deCOMtamination. r+sr=dbaron 2003-07-02 10:30:00 +00:00
leon.zhang%sun.com
b1b7ead95d Bug 204005: optimize caret timer usage
r=sfraser sr=brendan
2003-05-26 07:03:29 +00:00
timeless%mozdev.org
22604cfbf6 Bug 206165 Unused variable `PRBool aCanCacheFrameOffset' in nsCaret::GetCaretRectAndInvert
r=sfraser sr=sfraser
2003-05-23 22:24:37 +00:00
dbaron%dbaron.org
75ff60c62f Clean up API (and its callers) for getting style data: remove unneeded null checks and switch to new inline member functions (one for each struct) that return values. b=197205 r+sr=roc a=brendan 2003-05-15 03:42:21 +00:00
leon.zhang%sun.com
526c0515e9 Bug 199412: optimize nsTypedSelection::ScrollIntoView r/sr=sfraser 2003-04-20 01:03:40 +00:00
leon.zhang%sun.com
c5e44e7d6e Patch for bug 35296:SetCaretEnabled() takes too long
r/sr=sfraser
2003-04-13 08:38:57 +00:00
henry.jia%sun.com
a873e7e743 Patch for bug 35296: SetCaretEnabled() takes too long
Patch by Leon.Zhang@sun.com
r=sfraser, sr=kin
2003-04-02 05:48:09 +00:00
sfraser%netscape.com
511b311820 Fix bug 74404: show caret drag feedback. r=brade, sr=kin 2003-02-27 23:09:51 +00:00
kin%netscape.com
86eabf3281 Fix for regression bug 194774 (cursor appears to "jump" to beginning of line after hitting backspace)
Checking in this work around for leon.zhang@sun.com. Comment out the code that sets mCachedOffsetValid to PR_TRUE. This effectively disables the fix for bug 35296.

r=brade@netscape.com  sr=sfraser@netscape.com  a=leaf@mozilla.org
2003-02-25 18:10:35 +00:00
henry.jia%sun.com
1dd5b9dab2 Bug 35296: SetCaretEnabled() takes too long
Patch by Leon.Zhang@sun.com, r/sr=sfraser
2003-02-24 10:26:20 +00:00
jrgm%netscape.com
9f319a79e1 remove '#ifndef REPEATING_TIMERS' code. This was accidentally turned back on in 9/02 after being dead from 12/01, and will now revert to using repeating timers. Affect caret, <blink>, bookmarks & search 'ping'. bug 182141, r+sr=smfr 2003-01-20 04:26:17 +00:00
smontagu%netscape.com
50972ff560 Caret not displayed in empty right-aligned text input fields. Bug 105397, r=kin, sr=sfraser. 2003-01-09 01:01:38 +00:00
dbaron%dbaron.org
3ea0dc57d4 Bug 178643: Remove uses of NS_INIT_ISUPPORTS, since it is no longer needed. r=timeless sr=jag 2003-01-08 21:07:51 +00:00
caillon%returnzero.com
0dffa137af Re-landing these because I don't believe this are responsible for the Txul spike.
Bug 181975 - Convert layout to use nsIPrefService, nsIPrefBranch, and friends.
r/sr=roc+moz
2002-12-11 14:05:41 +00:00
caillon%returnzero.com
22b558c150 Backing out these changes since they appear to have caused a Txul regression on some tinderboxes (not all... weird...) 2002-12-11 05:11:02 +00:00
caillon%returnzero.com
71f8783cae Bug 181975 - Convert layout to use nsIPrefService, nsIPrefBranch, and friends.
r/sr=roc+moz
2002-12-10 23:41:12 +00:00
aaronl%netscape.com
076b6d3c59 Bug 166791. Invisible insertion point after tabbing to text field when typeaheadfind is active. r=mjudge, sr=alecf 2002-09-26 00:07:53 +00:00
dougt%netscape.com
68faeb5241 166917. Clean up xpcom SDK includes. r=rpotts@netscape.com, sr=alecf@netscape.com, a=rjesup@wgate.com 2002-09-07 17:13:19 +00:00
dougt%netscape.com
fae89c4077 Fixes up the timer interface. b157136, r=rpotts@netscape.com, sr=alecf@netscape.com, a=rjesup@wgate.com 2002-09-07 05:38:16 +00:00
mjudge%netscape.com
a07cba5734 4302 r=jfrancis sr=kin. pageup/down bug with navigation. 2002-08-26 20:55:30 +00:00
aaronl%netscape.com
fac59ec279 Bug 158754. Allow type ahead find to change selection color, and show caret with selection. r=akkana, sr=jst 2002-08-10 08:15:30 +00:00
aaronl%netscape.com
2d5ce67f73 Bug 153196. Active Accessibility: support MSAA caret object and events. r=kyle, sr=kin 2002-06-25 22:54:23 +00:00
cbiesinger%web.de
15a321ca78 bug 115473 r=pavlov sr=brendan
Remove timer priorities
2002-06-11 20:47:04 +00:00
shanjian%netscape.com
7f5900aa67 #142562 problem with <td align=right or align=center
We are observing langGroup in some place while ignor it in others. This patch
make all font metrics call consistent. nsIRenderingContext API is change to
make things neat.
r=rbs, sr=waterson
2002-05-24 20:11:14 +00:00
kin%netscape.com
6b835d7397 Fix for bug 135154 (Cursor not appearing in textarea after tabbing into it)
Don't call StopBlinking() if the selection changed notification is
for a selection that is different from the one in mDomSelectionWeak.

r=akkana@netscape.com  sr=attinasi@netscape.com
2002-04-26 13:11:47 +00:00
mjudge%netscape.com
cbca07291c 82151 r=jfrancis sr = kin 2002-04-16 02:42:09 +00:00
hyatt%netscape.com
e0734fa45e Fix for 129893, cocoa changes to gfx/layout/view, r=pink, sr=ben 2002-04-12 02:05:12 +00:00
dbaron%fas.harvard.edu
0c93d110f3 Tweak XP_MACOSX ifdefs to fix keyboard shortcuts (partly), context menus, and hidden window behavior and build the mac classic skin in the Mach-O build. b=109165 r=pinkerton sr=beard 2001-11-10 23:30:13 +00:00
dbaron%fas.harvard.edu
157c017816 Bug 86947:
Make the line list doubly linked and access it through a list class and iterators.
Stop recomputing margins on all of the children of each block in the reflow chain (which causes O(N^2) state recovery during incremental reflow).  Instead, add a second dirty bit to the lines and walk backwards through the line list to recompute vertical margins only when either dirty bit is set and the previous line was not reflowed.  Add nsIFrame::IsEmpty to identify frames through which margins collapse.
Fix O(N^2) propagation of float damage by maintaining a set of intervals damaged by floats (bug 61962) and be sure to damage the correct areas (bug 48138).
Introduce nsCollapsingMargin to do correct collapsing of combinations of positive and negative margins (bug 50142).
Clean up some odds and ends and fix another smaller O(N^2) problem in nsBlockFrame::AddFrames.
r=attinasi, rbs  sr=waterson
2001-10-25 01:08:40 +00:00
mkaply%us.ibm.com
72816bd6d4 #79798
r=ftang, sr=kin@netscape.com
Cursor is an ambigous term - use caret to refer to the text caret in Bidi functions
2001-09-30 20:35:55 +00:00
gerv%gerv.net
4e12e44b2f Relicensing Round 1, Take 2. Most C-like NPL files -> NPL/GPL/LGPL. Bug 98089. 2001-09-28 20:14:13 +00:00
simon%softel.co.il
4a71690e4f Move the IBMBIDI code in nsCaret.cpp to fix a crash when backspacing in a form with dir=rtl. Bug 89964, r=ftang, sr=kin. 2001-07-19 06:56:46 +00:00
dbaron%fas.harvard.edu
aa4fec2b67 Header include dependency cleanup. b=64023 r=jag rs=brendan 2001-07-16 02:40:48 +00:00
ftang%netscape.com
434d9c464f fix 84031. replace sizeof(datatype) to sizeof(variable)
r=nhotta sr=kin a=blizzard
2001-06-21 12:23:56 +00:00
hyatt%netscape.com
b135c5b55a Fix for 78695 (rule matching improvements). r/sr=attinasi, jst, waterson 2001-05-31 22:19:43 +00:00
ftang%netscape.com
5938ccae19 fix bug 80552 r=ftang r/sr=jst
check in for simon@softel.co.il
change BidiEnable to GetBidiEnable
2001-05-16 13:40:08 +00:00
ftang%netscape.com
6ffc96481f fix 76003. fix bidi rendering context state corrupting
check in for simon@softel.co.il
r=dbaron@fas.harvard.edu
sr=kin@netscape.com
2001-05-16 12:18:19 +00:00
hyatt%netscape.com
8130400b54 Fix for 77002. reviewers=jst,waterson,hixie,shaver,brendan,pavlov 2001-04-25 19:52:49 +00:00
shanjian%netscape.com
819a855d2b #59405 IME candidate window position is not correct in text field on New card and To field
r = sfraser sr=kin a=blizzard
Handle the difference of cursor coordinate required by different platform.
nsICaret.h
nsCaret.cpp
nsEditor.cpp
nsPlaintextEditor.cpp
nsHTMLEditor.cpp
2001-04-19 22:46:29 +00:00
sfraser%netscape.com
fa5c968dc3 Fix the build by doing the correct style struct casting foo. 2001-04-13 01:09:06 +00:00
sfraser%netscape.com
37c42b5e7c Fix for bug 53610. When the caret is in a <br> frame at the end of a line, use font metrics to get the height, rather than faking it. r=dbaron, sr=kin 2001-04-13 00:17:21 +00:00
blakeross%telocity.com
c9b9689e26 Use more efficient command structure, refactor commands, broadcasters and keys, remove unused attributes, do some other optimization (72923). Landing navigator part only; this should help new window opening and some other areas. r=ben sr=hyatt 2001-04-05 19:53:13 +00:00
timeless%mac.com
e76ccfd647 fix Bug 70989 Clean up lots of "shadows" and other common warnings
r=peterv, jst, ducarroz, edburns. sr=jst, shaver
2001-03-21 05:32:22 +00:00
erik%netscape.com
c5bd1e8ade bug 71314; author=simon@softel.co.il; r=mjudge,anthonyd; sr=erik; changes
from IBM bidi project (Arabic, Hebrew, etc); some in ifdef for now
2001-03-21 01:16:22 +00:00
aaronl%chorus.net
ab4d0dcaee Pref accessibility.browsewithcaret implemented, bug=49508, r=sfraser, sr=waterson 2001-02-15 05:07:46 +00:00
brade%netscape.com
eeddb3fa5d rename to GetCaretCoordinates, parameter/code cleanup; r=kin; sr=sfraser 2001-02-05 15:43:24 +00:00
blakeross%telocity.com
7f14eed94b Fix 41077: show caret during selection on Windows. r=rcassin@supernova.org sr=sfraser 2000-12-28 03:27:23 +00:00
mkaply%us.ibm.com
2f0725f023 #57006
r=mjduge, sr/a=sfraser
Change hardcoded 15 to a call to the devicecontext to get conversion value
2000-11-01 18:54:16 +00:00
warren%netscape.com
cd56c0575b Bug 47207. Backing out logging/PRINTF changes until we can fix stopwatch.h, introduce double parens, etc. 2000-10-28 22:17:53 +00:00
warren%netscape.com
9a6d92a433 Bug 47207. Changing printf to PRINTF to use new logging facility. r=valeski,sr=waterson 2000-10-27 22:43:51 +00:00
shanjian%netscape.com
44861a402c #53072 IME candidate window position problem
r=sfraser a=ftang
Offset within view is missing in one of the code path. Add it there.
2000-09-19 21:55:59 +00:00
mjudge%netscape.com
e2be918716 small but pervasive change to make nsIDOMSelection an xpidl interface. also broke it into 2 interfaces, nsISelection and nsISelectionPrivate. moved nsIDOMSelectionListener also to xpidl. these new idl files live in layout/base/public. r=sfraser, r=anthonyd bug 48575 2000-09-14 11:45:01 +00:00
rayw%netscape.com
0257791053 Bug 37275, Changing value of all progids, and changing everywhere a progid
is mentioned to mention a contractid, including in identifiers.

r=warren
2000-09-13 23:57:52 +00:00
sfraser%netscape.com
323042d90a Fix 51747 -- caret not drawing at the end of a line. Fix offset of clip. r=kin 2000-09-07 20:21:22 +00:00
sfraser%netscape.com
5543105886 Fix bugs 45881 and 46850 -- general caret cruft. Ensure that caret is clipped to the scrolling view, and fix things so that the caret is properly hidden on scrolling. r=beard 2000-09-07 05:26:25 +00:00
anthonyd%netscape.com
940be572c5 bug fixes:
39529 - caret width not correct for single/muti line textfields, which relied on:
46445 -  nsLookAndFeel needs to be a service.
r: mjudge@netscape.com, kin@netscape.com
a:beppe
2000-07-28 22:12:45 +00:00