Commit Graph

197 Commits

Author SHA1 Message Date
Simon Giesecke
a892bc01f6 Bug 1633719 - Use *InitializedOnce* with NotNull instead of *InitializedOnce*NotNull for pointers. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D73025
2020-05-14 09:14:04 +00:00
Bogdan Tara
078debe589 Backed out 2 changesets (bug 1623278, bug 1633719) for assertion failure on NotNull.h CLOSED TREE
Backed out changeset 8a21ea441fc7 (bug 1623278)
Backed out changeset ab6a041c0d57 (bug 1633719)
2020-05-14 11:34:50 +03:00
Simon Giesecke
98b9d42815 Bug 1633719 - Use *InitializedOnce* with NotNull instead of *InitializedOnce*NotNull for pointers. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D73025
2020-05-14 07:47:46 +00:00
Simon Giesecke
86ba544cc6 Bug 1536540 - Implement IDBCursor.request attribute. r=dom-workers-and-storage-reviewers,janv,webidl,baku
Differential Revision: https://phabricator.services.mozilla.com/D71786
2020-04-23 08:38:57 +00:00
Andreea Pavel
80afdc5ddc Backed out changeset 7dccafbf3437 (bug 1536540) for failing wpt at idlharness.any.worker.html on a CLOSED TREE 2020-04-22 21:54:11 +03:00
Simon Giesecke
bcf94e6de5 Bug 1536540 - Implement IDBCursor.request attribute. r=dom-workers-and-storage-reviewers,janv,webidl,baku
Differential Revision: https://phabricator.services.mozilla.com/D71786
2020-04-22 14:53:17 +00:00
Simon Giesecke
18c7f261c4 Bug 1623278 - Use SafeRefPtr for IDBTransaction. r=dom-workers-and-storage-reviewers,ttung,janv
Differential Revision: https://phabricator.services.mozilla.com/D67287
2020-04-21 14:32:51 +00:00
Jon Coppeard
299455107e Bug 1627282 - Mark all IndexDB cursor subclasses as potentially containing pointers into more than one JS zone r=sg
At this point it's probably worth marking all these subclasses in the same way as I expect they can all contain pointers into multiple zones.

Differential Revision: https://phabricator.services.mozilla.com/D69809

--HG--
extra : moz-landing-system : lando
2020-04-06 13:02:52 +00:00
Simon Giesecke
b62d30f4db Bug 1625444 - Make IDBObjectStoreCursor a multi-zone JSHolder class. r=jonco,dom-workers-and-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D68766

--HG--
extra : moz-landing-system : lando
2020-03-30 18:31:04 +00:00
Jon Coppeard
c1e3671c97 Bug 1624810 - Set the multi-zone JS holder flag on appropriate cycle collected classes r=mccr8
Set the flag on the affected classes, which are:
 - CallbackTimeoutHandler
 - nsJSArgArray
 - CallbackObject
 - Console
 - MessageEvent
 - IDBIndexCursor
 - ExtendableMessageEvent
 - JSPurpleBuffer

Differential Revision: https://phabricator.services.mozilla.com/D68196

--HG--
extra : moz-landing-system : lando
2020-03-26 10:49:06 +00:00
Simon Giesecke
ad3730c81e Bug 1617170 - Fix non-unified build. r=janv,dom-workers-and-storage-reviewers
Based on a patch supplied by janv@mozilla.com

Differential Revision: https://phabricator.services.mozilla.com/D67129

--HG--
extra : moz-landing-system : lando
2020-03-17 11:28:49 +00:00
Simon Giesecke
f28bafa279 Bug 1617170 - Split StructuredCloneReadInfo into parent- and child-specific classes. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D64131

--HG--
extra : moz-landing-system : lando
2020-03-11 17:30:33 +00:00
Boris Zbarsky
c878a8bb26 Bug 1619112 part 2. Pass char literals instead of char16_t literals into ErrorResult throwing methods. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D65538

--HG--
extra : moz-landing-system : lando
2020-03-06 21:04:58 +00:00
Simon Giesecke
a27fa59c89 Bug 1613340 - Remove const_cast relating to StructuredCloneReadInfo. r=dom-workers-and-storage-reviewers,edenchuang
Differential Revision: https://phabricator.services.mozilla.com/D61670

--HG--
extra : moz-landing-system : lando
2020-03-03 13:45:26 +00:00
Simon Giesecke
37b6637a59 Bug 1497007 - Replace CanAcceptRequests by the now equivalent IsActive. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D59834

--HG--
extra : moz-landing-system : lando
2020-01-17 12:47:09 +00:00
Simon Giesecke
a5e45033f2 Bug 1600906 - Convert IDBCursor and BackgroundCursorChild to templates to increase type safety and reduce state. r=dom-workers-and-storage-reviewers,ytausky
This also simplifies delegating calls that are dependent on the cursor type.

Also reduce dependency on IDBCursor.h by moving enums and type traits to IDBCursorType.h

Differential Revision: https://phabricator.services.mozilla.com/D57993

--HG--
extra : moz-landing-system : lando
2020-01-10 15:23:52 +00:00
Csoregi Natalia
8c7b4f143a Backed out 3 changesets (bug 1600906) for bustage on StaticAnalysisFunctions.h. CLOSED TREE
Backed out changeset aae2faf1907c (bug 1600906)
Backed out changeset d61a65e2e4ac (bug 1600906)
Backed out changeset a114b9b8e6ea (bug 1600906)
2020-01-10 17:19:22 +02:00
Simon Giesecke
a48be584a9 Bug 1600906 - Convert IDBCursor and BackgroundCursorChild to templates to increase type safety and reduce state. r=dom-workers-and-storage-reviewers,ytausky
This also simplifies delegating calls that are dependent on the cursor type.

Also reduce dependency on IDBCursor.h by moving enums and type traits to IDBCursorType.h

Differential Revision: https://phabricator.services.mozilla.com/D57993

--HG--
extra : moz-landing-system : lando
2020-01-10 14:21:18 +00:00
Simon Giesecke
0d5b4fd7af Bug 1600906 - Use scoped enums in IDBCursor. r=dom-workers-and-storage-reviewers,ytausky
Depends on D57990

Differential Revision: https://phabricator.services.mozilla.com/D57991

--HG--
extra : moz-landing-system : lando
2020-01-06 14:19:39 +00:00
Simon Giesecke
477b7e637e Bug 1600283 - Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D55492

--HG--
extra : moz-landing-system : lando
2019-12-16 14:42:54 +00:00
Simon Giesecke
90427d7da3 Bug 1598164 - Align ReadyState with states defined in the spec. r=dom-workers-and-storage-reviewers,edenchuang
Differential Revision: https://phabricator.services.mozilla.com/D54322

--HG--
extra : moz-landing-system : lando
2019-11-28 16:00:29 +00:00
Simon Giesecke
652ecd936e Bug 1598164 - Fixed log message printf string. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D55076

--HG--
extra : moz-landing-system : lando
2019-11-28 10:19:45 +00:00
Simon Giesecke
55a2f652bc Bug 1598164 - Use scoped enums in IDBTransaction. r=dom-workers-and-storage-reviewers,edenchuang
Differential Revision: https://phabricator.services.mozilla.com/D54321

--HG--
extra : moz-landing-system : lando
2019-11-27 10:54:57 +00:00
Simon Giesecke
59cd698867 Bug 1168606 - Support preloading also for index cursors. r=ttung,asuth
Depends on D43252

Differential Revision: https://phabricator.services.mozilla.com/D43461

--HG--
extra : moz-landing-system : lando
2019-11-05 14:40:35 +00:00
Simon Giesecke
9804c8f159 Bug 1168606 - Send extra records with every ObjectStoreCursorResponse if enabled by pref. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D43252

--HG--
extra : moz-landing-system : lando
2019-11-05 14:40:37 +00:00
Cosmin Sabou
1211bbc800 Backed out 12 changesets (bug 1168606) for causing build bustages on ActorsParent.cpp and Assertions.h. CLOSED TREE
Backed out changeset 307bd8d24407 (bug 1168606)
Backed out changeset a2ae085f929f (bug 1168606)
Backed out changeset 8fdc4a3d3ecb (bug 1168606)
Backed out changeset 918dc7cce5e9 (bug 1168606)
Backed out changeset 8c776a5cb5db (bug 1168606)
Backed out changeset dffe1e6c58bd (bug 1168606)
Backed out changeset 41f1bef0f019 (bug 1168606)
Backed out changeset 96cb7140a4f6 (bug 1168606)
Backed out changeset 6818224b9b11 (bug 1168606)
Backed out changeset f1be81af7d6b (bug 1168606)
Backed out changeset 8dc185488801 (bug 1168606)
Backed out changeset 9d8b02674d45 (bug 1168606)
2019-11-05 16:34:22 +02:00
Simon Giesecke
69cd8f61cb Bug 1168606 - Support preloading also for index cursors. r=ttung,asuth
Depends on D43252

Differential Revision: https://phabricator.services.mozilla.com/D43461

--HG--
extra : moz-landing-system : lando
2019-11-05 12:45:48 +00:00
Simon Giesecke
1db45a09bf Bug 1168606 - Send extra records with every ObjectStoreCursorResponse if enabled by pref. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D43252

--HG--
extra : moz-landing-system : lando
2019-11-05 12:48:36 +00:00
Simon Giesecke
cd0b6f05a1 Bug 1168606 - Use const where easily possible. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D43631

--HG--
extra : moz-landing-system : lando
2019-10-03 07:56:45 +00:00
Simon Giesecke
16d87d7487 Bug 1168606 - Avoid copying keys on cursor creation. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D43470

--HG--
extra : moz-landing-system : lando
2019-10-03 07:56:32 +00:00
Oana Pop Rus
cb31d323be Backed out 5 changesets (bug 1168606) for xpcshell failures in dom/indexedDB/test/unit/test_temporary_storage.js on a CLOSED TREE
Backed out changeset fc5e1bee1332 (bug 1168606)
Backed out changeset 63cf0966cb41 (bug 1168606)
Backed out changeset f844afbebc6a (bug 1168606)
Backed out changeset 9e7a90dcc429 (bug 1168606)
Backed out changeset e493a6b5f125 (bug 1168606)
2019-10-02 02:28:15 +03:00
Simon Giesecke
3feb8e1ebe Bug 1168606 - Send two records with every ObjectStoreCursorResponse. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D43252

--HG--
extra : moz-landing-system : lando
2019-10-01 09:15:49 +00:00
Simon Giesecke
a9cf10ae19 Bug 1168606 - Use const where easily possible. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D43631

--HG--
extra : moz-landing-system : lando
2019-10-01 09:14:04 +00:00
Simon Giesecke
0438fc4336 Bug 1168606 - Avoid copying keys on cursor creation. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D43470

--HG--
extra : moz-landing-system : lando
2019-10-01 08:56:37 +00:00
Simon Giesecke
470b2174a1 Bug 1168606 - Allow current key to be provided with PBackgroundIDBCursor::Continue. r=ttung,asuth
The key is assumed to be unset for now.

Differential Revision: https://phabricator.services.mozilla.com/D43251

--HG--
extra : moz-landing-system : lando
2019-09-27 10:11:41 +00:00
Simon Giesecke
bd2e4939bc Bug 1168606 - Remove duplication in uses of IDB_LOG_MARK. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D46576

--HG--
extra : moz-landing-system : lando
2019-09-27 10:11:45 +00:00
Boris Zbarsky
e26682d684 Bug 1581173 part 1. Add a way to more easily throw TypeErrors and RangeErrors with custom message strings via ErrorResult. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D45932

--HG--
extra : moz-landing-system : lando
2019-09-20 02:19:18 +00:00
Simon Giesecke
e6e5f01c36 Bug 1168606 - Apply renamings suggested for Cursor::*Key members and related identifiers. r=ytausky,asuth
Differential Revision: https://phabricator.services.mozilla.com/D43249

--HG--
extra : moz-landing-system : lando
2019-09-18 06:41:35 +00:00
Simon Giesecke
73777f4f14 Bug 1565515 - Move sortKey variable declaration close to usage r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D38075

--HG--
extra : moz-landing-system : lando
2019-07-30 14:51:21 +00:00
Andreea Pavel
3f0fb9fec4 Backed out 12 changesets (bug 1565515) hazard failures on a CLOSED TREE
Backed out changeset 4d8c2c1bce2d (bug 1565515)
Backed out changeset 8619e09b03bb (bug 1565515)
Backed out changeset d70293010941 (bug 1565515)
Backed out changeset 90fb12799ecd (bug 1565515)
Backed out changeset 93be9fcab443 (bug 1565515)
Backed out changeset 91f546c40f98 (bug 1565515)
Backed out changeset 2c0fb0c0e228 (bug 1565515)
Backed out changeset 57ed49a17c9d (bug 1565515)
Backed out changeset 75cb7938f704 (bug 1565515)
Backed out changeset 2359da4989a7 (bug 1565515)
Backed out changeset 8f3493b2cae1 (bug 1565515)
Backed out changeset e0aa82bed5fa (bug 1565515)
2019-07-30 17:16:15 +03:00
Simon Giesecke
fd2c92c543 Bug 1565515 - Move sortKey variable declaration close to usage r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D38075

--HG--
extra : moz-landing-system : lando
2019-07-29 09:26:27 +00:00
Yaron Tausky
f33a502eb3 Bug 1544750 - Part 2: Refactor Key::EncodeJSValInternal to show direct correspondence to spec r=asuth,tcampbell
This commit adds the text of the spec as inline comments and refactors
the code such that it directly corresponds to the spec's steps. This
makes it easier to understand how the spec's algorithm is implemented.

Differential Revision: https://phabricator.services.mozilla.com/D28976

--HG--
extra : moz-landing-system : lando
2019-07-29 09:05:44 +00:00
Gurzau Raul
e9b0044a0a Backed out 13 changesets (bug 1544750, bug 1565515) for bustages at /indexedDB/Key.cpp on a CLOSED TREE.
Backed out changeset 8bdfc4852ae5 (bug 1565515)
Backed out changeset 6afea4389eb2 (bug 1565515)
Backed out changeset 4f4f25ecac5c (bug 1565515)
Backed out changeset 052b34ddf704 (bug 1565515)
Backed out changeset 6d8e8f078383 (bug 1565515)
Backed out changeset 4815a910245c (bug 1565515)
Backed out changeset 5e2dcfefb4f5 (bug 1565515)
Backed out changeset aac0a4a4fc67 (bug 1565515)
Backed out changeset ba109131fcad (bug 1565515)
Backed out changeset 594f76e67769 (bug 1565515)
Backed out changeset 800e7de53622 (bug 1565515)
Backed out changeset bd2e92310857 (bug 1565515)
Backed out changeset 076029811ae9 (bug 1544750)
2019-07-26 23:00:03 +03:00
Simon Giesecke
1c214ce205 Bug 1565515 - Move sortKey variable declaration close to usage r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D38075

--HG--
extra : moz-landing-system : lando
2019-07-26 15:54:31 +00:00
Yaron Tausky
94fda141b7 Bug 1544750 - Part 2: Refactor Key::EncodeJSValInternal to show direct correspondence to spec r=asuth,tcampbell
This commit adds the text of the spec as inline comments and refactors
the code such that it directly corresponds to the spec's steps. This
makes it easier to understand how the spec's algorithm is implemented.

Differential Revision: https://phabricator.services.mozilla.com/D28976

--HG--
extra : moz-landing-system : lando
2019-07-26 14:14:22 +00:00
Yaron Tausky
6e39f30075 Bug 1544750 - Part 1: Refactor some IndexedDB code to use ErrorResult r=asuth
This is mostly laying the groundwork for further refactoring.

Differential Revision: https://phabricator.services.mozilla.com/D27666

--HG--
extra : moz-landing-system : lando
2019-04-26 16:53:59 +00:00
Andrea Marchesini
da174a4757 Bug 1539407 - Use the correct global for DOMEventTargetHelper in IndexedDB, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D25041

--HG--
extra : moz-landing-system : lando
2019-03-29 18:05:11 +00:00
Daniel Varga
7af208ab28 Backed out changeset 98452610cfcc (bug 1539407) for browser-chrome failure at /builds/worker/workspace/build/src/dom/indexedDB/IDBRequest.cpp:284. On a CLOSED TREE
--HG--
extra : histedit_source : 236c5d6a7a4440a7b545c1ec5a0a72a8c5777b6b
2019-03-29 18:01:58 +02:00
Andrea Marchesini
788d12712b Bug 1539407 - Use the correct global for DOMEventTargetHelper in IndexedDB, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D25041

--HG--
extra : moz-landing-system : lando
2019-03-29 14:12:04 +00:00
Sylvestre Ledru
265e672179 Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
# ignore-this-changeset

--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00