The comment was added in bug 407459, but the code it was relevant to was
moved without the comment in bug 1257448. At the same time, while the
code that came with the comment was moved and is still relevant, the
comment itself refers to code that was removed in bug 1364358.
Differential Revision: https://phabricator.services.mozilla.com/D202189
Bug 1524461 introduced a typo, using __VA_ARGS instead of __VA_ARGS__. A
previous attempt to fix that led to bug 1684265 and the fix has been in
limbo since then. Bug 1876415 however recently changed things so that
mac builds may not use CLOCK_MONOTONIC for TimeStamp, which would avoid
bug 1684265 after fixing the configure test.
Since the first attempt, though, the availability() hack ceased to work.
At the same time, macOS < 10.12 is not supported anymore, so all
supported versions of macOS do have CLOCK_MONOTONIC, so we just remove
the availability() hack altogether.
Differential Revision: https://phabricator.services.mozilla.com/D202187
This should help connect preferences to server's target configurations.
Once we get rid of thread's actor attach sequence, we may be able to also fold the getThreadOptions's preferences into this new system.
Differential Revision: https://phabricator.services.mozilla.com/D202277
`devtools.debugger.features.overlay` boolean preference will control this paused overlay.
(same name as an old preference which used to do that)
Differential Revision: https://phabricator.services.mozilla.com/D201697
By protocol.js conventions, most target scopes actors have a `targetActor` attribute set to their parent,
i.e. the related target actor. Thread Actor was old enough to not follow this pattern.
Also remove the second constructor argument and `global` attribute as it was unused.
Differential Revision: https://phabricator.services.mozilla.com/D201696
When setting the position state for a media session, it might not be the
active. When activating a session it should be sent.
Differential Revision: https://phabricator.services.mozilla.com/D198848
The PositionState is already saved as an optional value inside the MediaSession.
This makes the PositionState optional in all events emitted as it can be
explicitly reset by passing an empty object.
Differential Revision: https://phabricator.services.mozilla.com/D198847
We were using process script and process message managers to interact with content processes.
This patch migrates the whole logic to JS Process Actor.
Note that we may still use old API in process descriptor, but that's a different story.
This helps align frame, process and worker targets all around JS Actors,
making it easier to align all three target types to the same logic.
Also fix passing `isModeSwitching` for content process targets
so that console is correctly cleared when switching between modes.
With this and the ongoing Service Worker equivalent work, we should be able to factorize some code.
Differential Revision: https://phabricator.services.mozilla.com/D167965
In the Browser Console/Toolbox setup, we spawn both Content Process Targets
and WindowGlobal Targets for document running in the same process as the target.
While the debugger will only use the Content process targets and ignore the WindowGlobal ones,
the inspector will only consider the WindowGlobal ones.
Because of this mixed up setup, we have to ensure disabling (avoid attaching)
the thread actor of the WindowGlobal target in the context of the browser toolbox.
Differential Revision: https://phabricator.services.mozilla.com/D167964
Some text nodes can be selected whatever their ancestors bounding box are
so they must be taken into account when calling Range.getClientRects.
Differential Revision: https://phabricator.services.mozilla.com/D195484
Those files are now in a different location and one of them (UpdateSettings) will already exist rather than needing to be created.
A few other changes are also made here:
- Currently, when we need to make changes to a gTestFiles entry, we access it by index, which is both unreadable (how is anyone supposed to know what gTestFiles[13] refers to?) and a maintenance nightmare (adding an item to the list in the wrong position potentially screws up all the indicies and now a bunch of the tests are making changes to the wrong gTestFiles entry). To improve this, I added `getTestFileByName` so that, for example, `gTestFiles[gTestFiles.length - 1]` can be replaced with `getTestFileByName(FILE_CHANNEL_PREFS)`.
- Two extra (optional) properties added to gTestFiles entries: `existingFile` and `removeOriginalFile`. `existingFile == true` indicates that the file exists already and doesn't need to be created. `removeOriginalFile` is only relevant if `existingFile == true`, and it causes the file to be removed rather than retained. If `existingFile && !removeOriginalFile`, `compareContents` will be automatically set to the current file contents if it (and `compareFile`) is unset, as will `comparePerms` to ensure that the update process doesn't change the file.
- `setUpdateSettingsUseWrongChannel` was added to make it easier to set the wrong update channel either via the INI file (on non-Mac) or via the Framework (on Mac).
Differential Revision: https://phabricator.services.mozilla.com/D198899
Given that (a) it is no longer possible to easily inspect the Update Settings file and (b) it is intentionally possible to swap out Update Settings frameworks, I anticipate that in the future we may want a way to determine what channels the updater will accept. Thus, I think it is a good idea to add an easy way to make the updater output this information.
Differential Revision: https://phabricator.services.mozilla.com/D198897
This test is no longer necessary. It was needed to avoid breaking the signature on macOS apps, but now we are solving that problem another way (See Bugs 1799332 and 1854868).
Differential Revision: https://phabricator.services.mozilla.com/D196626
