Commit Graph

113 Commits

Author SHA1 Message Date
cku
14c2482fbe Bug 1301245 - Part 3. Resolve a style image if nsSVGPaintingProperty can not handle it. r=heycam
MozReview-Commit-ID: 9m7yJ4CgCvr

--HG--
extra : rebase_source : 3f0fa1a7ead8ca5ac595e1a5d3cf15bf555291e7
2017-07-26 12:02:44 +08:00
cku
5acc1499f0 Bug 1383791 - Download an SVG resource only if the mask URL consists of a fragment. r=heycam
MozReview-Commit-ID: OT6ipv3qSj

--HG--
extra : rebase_source : 295f3de7ece6aaa2473d7efc376de078419f3e10
extra : source : cb4b39a80923ff50dc6b4c3dc0b9ff9c508e5b48
2017-07-19 19:45:34 +08:00
L. David Baron
53383e2d5c Bug 1369260 - Remove use of MOZ_ASSERT_IF in layout. r=heycam
As I've said before, as module owner I prefer that MOZ_ASSERT_IF not be
used in the module because I consider it to be unreadable.  However, a
few uses have crept in, and this patch removes them.

I consider it to be unreadable because the name looks like a name that
uses smalltalk-ish naming conventions, i.e., with a part of the name
corresponding to each parameter, in order.  However, the parameters are
in the order opposite the name.

This was written primarily with the vim commands:
:%s/MOZ_ASSERT_IF(\([^,]*\),/MOZ_ASSERT(!\1 ||/
:wn
followed by manual cleanup for indentation and removal of !!.

MozReview-Commit-ID: G6rLbOn7k8d
2017-06-06 22:27:17 -07:00
Jonathan Kew
a8f81efd8e Bug 1365982 - Attach frame properties to each frame instead of looking them up in a hashtable on the prescontext. r=mats
--HG--
rename : layout/base/FramePropertyTable.cpp => layout/base/FrameProperties.cpp
rename : layout/base/FramePropertyTable.h => layout/base/FrameProperties.h
2017-05-27 12:36:00 +01:00
cku
b533c4c2ae Bug 1362000 - (followup) remove unused headers. r=me
MozReview-Commit-ID: 4SO8tdhbIHt

--HG--
extra : rebase_source : 7abc0bddf356bc705b130ea15294f8c5036f6ccf
2017-05-27 16:57:44 +08:00
cku
0fa11bffa0 Bug 1362000 - (follow-up) Simplify match logic in CSSMaskLayerUserData::operator==. r=mstange
Remove HasUserSpaceOnUseUnitsMaskOrClipPath since it's not necessary.
MozReview-Commit-ID: 2sen23m5GjE

--HG--
extra : rebase_source : fe15fc807daf79f6f2175224928a1d83736cf85b
2017-05-27 01:38:54 +08:00
cku
082f6c2f30 Bug 1362000 - When the position of masked frame changed, always regenerate mask layer if any of maskUnits/maskContentUnits/clipPathUnits is userSpaceOnUse. r=cjku
For SVG mask/clipPath, comparison at [1] is not enough to detect whether cached
mask layer is reusable duriang animation. Since aMaskItem->IsInvalid() may keep
return fasle during OMTA. Bring in new condition check in
CSSMaskLayerUserData::IsMaskReusable..

I do not create a reftest for this bug, the reason is almost the same with bug
1350663.

So I manually verified paiting result by visit this three pages:
 https://codepen.io/tadeuszwojcik/pen/ZKJwRE
 https://codepen.io/tadeuszwojcik/pen/oWexWW
 http://codepen.io/iiroullin/pen/oWEOOM

[1] https://hg.mozilla.org/mozilla-central/file/2bc714f86791/layout/painting/FrameLayerBuilder.cpp#l3887

MozReview-Commit-ID: 7lUKTMYPFXo

--HG--
extra : rebase_source : c3e4d7b9df0c335222f09d7ce7d6918c7dbad00e
extra : source : 4717af028474a700a2b7e81eecae142f2ab82ff1
2017-05-12 20:17:14 +08:00
Emilio Cobos Álvarez
23bce99ae1 Bug 1361051: rename mozilla::FrameType to mozilla::LayoutFrameType. r=xidorn
This avoids conflicts with mozilla::dom::FrameType.

MozReview-Commit-ID: 7aEMbHRaTFk

--HG--
extra : rebase_source : 2d01321f5ce0ec8c0e3f70984674f82678034b3c
2017-05-01 19:32:52 +02:00
Emilio Cobos Álvarez
e44543aad4 Bug 1360241: Devirtualize nsIFrame::GetType. r=heycam
MozReview-Commit-ID: 5Nzhyta5Hle

--HG--
extra : rebase_source : c2e9d4bfb9239f5e851d110cd7dff98c1e1a8d8b
2017-04-30 17:30:08 +02:00
cku
71f1a61edb Bug 1357432 - Part 2. Implement nsSVGEffects::GetBaseURLForLocalRef to export local-ref-url-resolving logic. r=heycam
ResolveURLUsingLocalRef is designed to be internally used by
nsSVGEffects::Get-{SVGEffect}-URI functions. Since we also need it in
SVGUseElement::LookupHref, make it public in nsSVGEffects.

MozReview-Commit-ID: Hsvs8Uzahrz

--HG--
extra : rebase_source : 54698a477a2ebb3f635fb3a77f6bc39b1741b05b
2017-04-20 15:58:19 +08:00
cku
21a1b43445 Bug 1352096 - Part 2. Remove Layer::mSourceURI. r=heycam
Now, remove Layer::mSourceURI, there are several benefit of doing this:
1. Reduce the size of nsStyleImage::Layer.
2. By storing style image and url information in nsStyleImage, we can remove
many verbose comments. That is becasue there is no need to explain why we use
mSourceURI here, or why we use nsStyleImage there anymore.
3. Since all inforamtion is stored in on place, nsStyleImage, we can setup image
request or URLs by one single Gecko_SetUrlImageValue call.

MozReview-Commit-ID: 7aTQobddTB1

--HG--
extra : rebase_source : 247e3b66c727a9116c58d3d6ff3ae0f7a58f2338
2017-03-31 01:50:21 +08:00
cku
a9228a48bc Bug 1343139 - Part 1. Implement nsStyleSVGReset::HasMask. r=heycam
Implement this unil function to improve readability
MozReview-Commit-ID: FLKOGyq180W

--HG--
extra : rebase_source : db8dbc67dbc63c19df806e79ea36016d3d5fc8b6
extra : source : 47fa0a1f03acd6007e2d40e4ec5bc0ddba221361
2017-03-07 13:43:21 +08:00
cku
a52259bf72 Bug 1349462 - Part 1. Rename IsSVGText as IsInSVGTextSubtree. r=heycam
MozReview-Commit-ID: LTo6c8tTtaf

--HG--
extra : rebase_source : bc6913c42cca141d7a3098fdd4dcc72fbf146b5a
2017-03-23 15:29:11 +08:00
cku
6a92a74443 Bug 1345052 - Remove EffectProperties::MightHaveNoneSVGMask. r=heycam
MozReview-Commit-ID: 3WFAjwhBkDp

--HG--
extra : rebase_source : 1840ab0b7d156e4ff6e65ebe1f6127e5975ac6ac
2017-03-07 17:01:31 +08:00
Cameron McCormack
f63cdecde2 Bug 1297899 - Part 6: Move RestyleManagerHandle functionality into RestyleManager. r=bholley
MozReview-Commit-ID: 7lsti0bGzNr

--HG--
extra : rebase_source : 13c64026190afe5de25f540adb6deea9f518149f
2017-02-13 11:21:33 +08:00
Robert Longson
1bae76206e Bug 1239100 - Implement SVGGeometryElement interface. r=cam r=peterv
--HG--
rename : dom/svg/nsSVGPathGeometryElement.cpp => dom/svg/SVGGeometryElement.cpp
rename : dom/svg/nsSVGPathGeometryElement.h => dom/svg/SVGGeometryElement.h
rename : dom/svg/nsSVGPolyElement.cpp => dom/svg/SVGPolyElement.cpp
rename : dom/svg/nsSVGPolyElement.h => dom/svg/SVGPolyElement.h
rename : layout/svg/nsSVGPathGeometryFrame.cpp => layout/svg/SVGGeometryFrame.cpp
rename : layout/svg/nsSVGPathGeometryFrame.h => layout/svg/SVGGeometryFrame.h
2016-12-18 11:11:47 +00:00
Sebastian Hengst
cdeb642a1b Backed out changeset 0b44e8715bf5 (bug 1239100) for build bustage (SVGGeometryElement.webidl missing). r=backout
--HG--
rename : dom/svg/SVGGeometryElement.cpp => dom/svg/nsSVGPathGeometryElement.cpp
rename : dom/svg/SVGGeometryElement.h => dom/svg/nsSVGPathGeometryElement.h
rename : dom/svg/SVGPolyElement.cpp => dom/svg/nsSVGPolyElement.cpp
rename : dom/svg/SVGPolyElement.h => dom/svg/nsSVGPolyElement.h
rename : layout/svg/SVGGeometryFrame.cpp => layout/svg/nsSVGPathGeometryFrame.cpp
rename : layout/svg/SVGGeometryFrame.h => layout/svg/nsSVGPathGeometryFrame.h
2016-12-18 11:42:51 +01:00
Robert Longson
783bfbb1e4 Bug 1239100 - Implement SVGGeometryElement interface. r=cam r=peterv
--HG--
rename : dom/svg/nsSVGPathGeometryElement.cpp => dom/svg/SVGGeometryElement.cpp
rename : dom/svg/nsSVGPathGeometryElement.h => dom/svg/SVGGeometryElement.h
rename : dom/svg/nsSVGPolyElement.cpp => dom/svg/SVGPolyElement.cpp
rename : dom/svg/nsSVGPolyElement.h => dom/svg/SVGPolyElement.h
rename : layout/svg/nsSVGPathGeometryFrame.cpp => layout/svg/SVGGeometryFrame.cpp
rename : layout/svg/nsSVGPathGeometryFrame.h => layout/svg/SVGGeometryFrame.h
2016-12-18 09:54:02 +00:00
cku
e50551a66d Bug 1323157 - Rename HasNoFilterOrHasValidFilter as HasNoOrValidFilter. r=longsonr+218550
MozReview-Commit-ID: GQzPf9Qy8LJ

--HG--
extra : rebase_source : d03d5609a8ed2eddaf596a019775a35bfd7d2f24
2016-12-13 19:40:27 +08:00
cku
65237b3417 Bug 1322330 - Part 3. Implement EffectProperties::HasInvalidMask. r=longsonr+218550
MozReview-Commit-ID: 7bEheewinTl

--HG--
extra : rebase_source : e695fae9a595c65a28b45e7e0f66690b9afb750c
2016-12-07 00:11:06 -10:00
cku
fb19c45aa9 Bug 1322330 - Part 2. Implement EffectProperties::HasInvalidClipPath. r=longsonr+218550
MozReview-Commit-ID: F3m4UZ0ET9x

--HG--
extra : rebase_source : aa11ea80bc566f287095ad91f721a2f70870c13c
2016-12-06 21:28:47 -10:00
cku
932164f048 Bug 1322330 - Part 1. Remove EffectProperties::GetFirstMaskFrame and implement EffectProperties::HasInvalidMaskOrClipPathResource. r=longsonr+218550
MozReview-Commit-ID: 4nfhL7btNFT

--HG--
extra : rebase_source : 37748f1858f9ea42e849cb02ef086183b8a52458
2016-12-06 16:12:36 -10:00
cku
a46dd4f00e Bug 1320364 - Correct NS_ASSERTION failure condition in GetPreEffectsVisualOverflowRect. r=heycam
MozReview-Commit-ID: 4675cFLehK4

--HG--
extra : rebase_source : 5ff6778a558e2773b926d9317fef34cdd79e94e6
2016-11-28 16:26:34 +08:00
Cameron McCormack
b93ab3109e Bug 1298774 - Part 9: Remove FragmentOrURL. r=cjku
MozReview-Commit-ID: Du10tRgKtQ4

--HG--
extra : rebase_source : 8092f86207b1fd91ba00beb088c894afd374bd56
2016-10-11 14:56:12 +08:00
Cameron McCormack
ccba4f429e Bug 1298774 - Part 8: Make mask-image use css::URLValueData for url() storage instead of FragmentOrURL. r=cjku
MozReview-Commit-ID: 2Xm3IP3SXK0

--HG--
extra : rebase_source : e524bf9a7641a80ef591dc380f4832cbcb5944ba
2016-10-11 14:56:12 +08:00
Cameron McCormack
840196223a Bug 1298774 - Part 7: Make nsStyleFilter use css::URLValue for url() storage instead of FragmentOrURL. r=cjku
MozReview-Commit-ID: FyhH9QG9vYq

--HG--
extra : rebase_source : 300a97e42ae9b27d83e7316e502295c597fad7cd
2016-10-11 14:56:12 +08:00
Cameron McCormack
e07dbc8da6 Bug 1298774 - Part 6: Make SVG marker properties use css::URLValue for storage instead of FragmentOrURL. r=cjku
MozReview-Commit-ID: 8OQWmDpP7Ax

--HG--
extra : rebase_source : f372d5d77481bc71d49d0f7446244f6e9162d0ac
2016-10-11 14:56:11 +08:00
Cameron McCormack
a9271aac63 Bug 1298774 - Part 5: Make nsStyleSVGPaint use css::URLValue for url() storage instead of FragmentOrURL. r=cjku
MozReview-Commit-ID: CkNcSxVToTL

--HG--
extra : rebase_source : 956149a0d12e7633aca15eb460704926a7db7371
2016-10-11 14:56:11 +08:00
Cameron McCormack
f1dcd6fc45 Bug 1298774 - Part 4: Make ShapeStyleSource use css::URLValue for url() storage instead of FragmentOrURL. r=cjku
MozReview-Commit-ID: CQy6ArR48Sp

--HG--
extra : rebase_source : 71203745bca616395daeffe5b47b288b0ce67b0b
2016-10-11 14:56:11 +08:00
cku
818c1c0974 Bug 1302779 - Part 1. Resolve a local fragment against the current document that relative URLs are resolved against. r=heycam
MozReview-Commit-ID: 2vJDnfzoPiC

--HG--
extra : rebase_source : 3c43bd335caa918ac32f3ba1979f822db5319b11
2016-09-20 14:13:13 +08:00
Ting-Yu Lin
4ad0c1bbe3 Bug 1288626 Part 5 - Rename StyleClipPathType to StyleShapeSourceType. r=heycam
StyleClipPathType will be generalized to StyleShapeSourceType to match this
change.

MozReview-Commit-ID: Igaad2EoSSt

--HG--
extra : rebase_source : 517d7b968e90f8f83e1223d33bd9d59000e034fd
2016-08-04 11:51:20 +08:00
cku
e39570c057 Bug 1291280 - Part 2. Declare nsStyleImageLayers::Layer::mSourceURI as FragmentOrURI r=heycam
MozReview-Commit-ID: 6KFb7MjlLqj

--HG--
extra : rebase_source : 24ac046807f12e3bea6717baab962de94d8fafc5
2016-08-06 06:38:44 +08:00
cku
e5a7157308 Bug 652991 - Part 12. Correct pointer/refernce parameter convention. r=me
MozReview-Commit-ID: 2QTCJxnaAi2

--HG--
extra : rebase_source : e83d8d5afd9ecfbc5a685a3e5b7d4324f0333dce
extra : amend_source : c61aa20f453bdc9e76112d50beb7e07224709059
2016-08-02 19:06:14 +08:00
cku
9e967a4f21 Bug 652991 - Part 9. Using FragmentOrURL to represent PanitServer url. r=heycam
MozReview-Commit-ID: IZf0fGantoB

--HG--
extra : rebase_source : 201786ad6a890bb96f5f4384b1420802c926373f
extra : source : 1a80ce736d77b1dba6d9cf53c8a20b5a6078ac6d
2016-07-05 01:00:15 +08:00
cku
856763a293 Bug 652991 - Part 7. Using FragmentOrURL to represent SVG filter url. r=heycam
MozReview-Commit-ID: F6BpTQfC82i

--HG--
extra : rebase_source : 07c2e6fb662b00c453a5d491722267f810ef3fa7
extra : source : 3e53712a3b48bb771a2faeafc1603eb10fbb851f
2016-07-23 16:16:59 +08:00
cku
185dbee93b Bug 652991 - Part 6. Reftest for clip-path. r=heycam
MozReview-Commit-ID: 9ozNCH7nOsY

--HG--
extra : rebase_source : 4aae2a80018fcb6243cfa5050acb38d82321b830
extra : source : c791ea11591fd7a4a6a34ee8811c3fbde9132c4a
2016-07-24 03:45:38 +08:00
cku
25577ba9c8 Bug 652991 - Part 5. Using FragmentOrURL to represent SVG clippath. r=heycam
MozReview-Commit-ID: BErpWUQ5iQ1

--HG--
extra : rebase_source : 16ed0cd6bb1fd3bc7ac91b33078c9938306a69b6
extra : source : fd15e7962cffec5b2c1f101a36e32dcdce17146c
2016-07-05 00:59:57 +08:00
cku
385c8ddfb0 Bug 652991 - Part 3. Using FragmentOrURL to represent SVG maker url. r=heycam
MozReview-Commit-ID: IQDGL7j5p1q

--HG--
extra : rebase_source : 3dcfca05e5dd9056c6a332da1e4caa2e7aeaa4b3
2016-06-24 02:11:51 +08:00
Manish Goregaokar
f4dffe63a1 Bug 1288383 - Replace NS_STYLE_CLIP_PATH_* with an enum class; r=heycam
MozReview-Commit-ID: H6nwOybonF3

--HG--
extra : rebase_source : db3ab986f7708540219cefa18a21b4624a2dc27a
2016-07-25 11:52:34 +05:30
Olli Pettay
ef55583835 Bug 1286183 - Improve SVGEffects' unlinking. r=mstange 2016-07-15 02:40:30 +03:00
Brad Werth
bb6b3396a0 Bug 1243559 - Removes static casts from calls to FrameProperties::Get, ::Set, and ::Remove, and forces callers to use the type associated with the property. r=dbaron 2016-06-21 13:17:11 -07:00
Phil Ringnalda
28ae5ce216 Back out changeset 0bb00282a4c2 (bug 1243559) for widespread SVG assertion failures
CLOSED TREE
2016-06-22 18:45:08 -07:00
Brad Werth
179aa18d0d Bug 1243559 - Removes static casts from calls to FrameProperties::Get, ::Set, and ::Remove, and forces callers to use the type associated with the property. r=dbaron
--HG--
extra : rebase_source : fd19554f1611f8028a364ce93e833d8939688bfb
2016-06-21 13:17:11 -07:00
Jeremy Chen
685cf4c3d8 Bug 1273766 - part3: purge NS_UpdateHint inline. r=heycam
MozReview-Commit-ID: IIOT9jq8hOl

--HG--
extra : rebase_source : dfb3d874ce4419f32f13e662bd495e97ac9cac10
2016-05-23 11:26:03 +08:00
CJKu
fb8594dce2 Bug 1228280 - Part 8. Keep style consistent and stop doing null check for return value of operator new
MozReview-Commit-ID: GoK0xuCWTP
2016-05-19 15:44:42 +08:00
CJKu
936ab8c243 Bug 1228280 - Part 4. Create nsSVGMaskProperty to carry multiple mask info;
MozReview-Commit-ID: LPTqls7wvqJ
2016-05-19 15:43:55 +08:00
Cameron McCormack
6b84ca3abb Bug 1261754 - Part 12: Move filter from nsStyleSVGReset to nsStyleEffects. r=dholbert 2016-04-12 15:52:43 +10:00
Cameron McCormack
89cac5abd1 Bug 1248864 - Part 3: Use RestyleManagerHandle instead of concrete restyle manager class. r=dholbert 2016-02-24 18:01:12 +11:00
Cameron McCormack
736a5f47e7 Bug 1248864 - Part 1: Move RestyleManager.h to EXPORTS.mozilla. r=dholbert 2016-02-24 18:01:12 +11:00
Birunthan Mohanathas
d7371d07d0 Bug 1235261 - Part 1: Rename nsAutoTArray to AutoTArray. r=froydnj 2016-02-02 17:36:30 +02:00