Commit Graph

158 Commits

Author SHA1 Message Date
Sylvestre Ledru
734f79b541 Bug 1624237 - Run misc-unused-using-decls - Remove useless declarations r=andi
$ ./mach static-analysis check --checks="-*, misc-unused-using-decls" --fix <path>

Differential Revision: https://phabricator.services.mozilla.com/D67811

--HG--
extra : moz-landing-system : lando
2020-03-23 13:15:33 +00:00
Geoff Brown
abf6e0fdc4 Bug 1612345 - Add custom retrigger support for gtest; r=bc
Add test package mach support for gtest and hook into the custom retrigger
action. Some existing custom retrigger features, like setting gecko prefs,
are not (easily) applicable to gtest, which doesn't use mozprofile; for
this reason, use a separate action context with items suitable for gtest.

Differential Revision: https://phabricator.services.mozilla.com/D67384

--HG--
extra : moz-landing-system : lando
2020-03-19 16:12:51 +00:00
Geoff Brown
f9b51b3540 Bug 1612345 - Convert gtest argument parser to argparse; r=bc
Convert the gtest option parser from optparse to argparse. mochitest, reftest,
and other suites use argparse. Using argparse will simplify the integration
of gtest with the custom retrigger action.

Differential Revision: https://phabricator.services.mozilla.com/D66429

--HG--
extra : moz-landing-system : lando
2020-03-11 23:46:08 +00:00
Geoff Brown
4286faeb7b Bug 1590354 - Remove checks for remote minidumps directory; r=jmaher
Whereas:
 - desktop tests don't make this check;
 - the check for directory existence has been troublesome and almost never useful;
 - bug classification of this condition has been troublesome;
 - if a startup crash actually did occur before crashreporter init, there would still be an indication in logcat and possibly a tombstone, and the "No test summary found" check would definitely be triggered;
Let's stop checking for minidumps directory creation.

Differential Revision: https://phabricator.services.mozilla.com/D54755

--HG--
extra : moz-landing-system : lando
2019-11-26 16:38:44 +00:00
Geoff Brown
14153653a8 Bug 1581157 - Improve gtest completion logging; r=bc
Improve gtest diagnostics in an effort to improve our understanding
of this intermittent failure.

Differential Revision: https://phabricator.services.mozilla.com/D50654

--HG--
extra : moz-landing-system : lando
2019-10-25 21:18:50 +00:00
Geoff Brown
3dbb203a84 Bug 1558885 - Use separate directory for android gtest libxul; r=bc,nalexander
In Android gtest, instead of pushing the gtest libxul.so to the
(assumed and potentially incorrect) location of the test application's
libraries, push libxul.so to /data/local/gtest, and direct the linker
to use that instead.

Differential Revision: https://phabricator.services.mozilla.com/D34942

--HG--
extra : moz-landing-system : lando
2019-10-10 21:38:01 +00:00
Geoff Brown
971d9e3214 Bug 1565497 - Improve android gtest's wait for final output; r=jmaher
A possible explanation for the infrequent observation of an incomplete log is that
the log is still being written when the harness detects that the process has completed.
Waiting for one extra polling interval may avoid this.

Differential Revision: https://phabricator.services.mozilla.com/D38577

--HG--
extra : moz-landing-system : lando
2019-07-19 07:56:39 +00:00
Kartikaya Gupta
711c133f6d Bug 1558598 - Force WebRender on or off in the gtest harness. r=ahal
This covers the local and remote gtests, as well as the mach command.

Differential Revision: https://phabricator.services.mozilla.com/D35852

--HG--
extra : moz-landing-system : lando
2019-06-29 09:48:16 +00:00
Chris Manchester
4158f69bc1 Bug 1559982 - Make testing/gtest importable with python 3. r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D35245

--HG--
extra : moz-landing-system : lando
2019-06-26 23:06:51 +00:00
Geoff Brown
ad79adad7c Bug 1561737 - Log full exception traceback from android gtest; r=bc
Including the traceback info will include the exception name, like "ADBError" which
should trigger the android-em task retry; it also provides more debugging info.

Differential Revision: https://phabricator.services.mozilla.com/D36116

--HG--
extra : moz-landing-system : lando
2019-06-27 09:26:35 +00:00
Mihai Alexandru Michis
9852c55d11 Backed out 5 changesets (bug 1559982, bug 1559975) for cpp unit test failures due to unsupported operand type. CLOSED TREE
Backed out changeset 2309aac6cea3 (bug 1559975)
Backed out changeset bf5a6d853abd (bug 1559975)
Backed out changeset 0c36f78c971a (bug 1559975)
Backed out changeset 0560cf7df7dc (bug 1559975)
Backed out changeset 4cb64ca524e7 (bug 1559982)
2019-06-27 02:03:31 +03:00
Chris Manchester
89a6a2647d Bug 1559982 - Make testing/gtest importable with python 3. r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D35245

--HG--
extra : moz-landing-system : lando
2019-06-24 21:20:43 +00:00
Geoff Brown
710630afc9 Bug 1558867 - Report log for short runs of 'mach gtest'; r=bc
This allows me to run 'mach gtest "APZ*"' and other short runs of gtest
that were previously failing.

Differential Revision: https://phabricator.services.mozilla.com/D34764

--HG--
extra : moz-landing-system : lando
2019-06-12 20:38:37 +00:00
Geoff Brown
110084336b Bug 1550161 - Avoid attribute error in android gtest; r=bc
Differential Revision: https://phabricator.services.mozilla.com/D30593

--HG--
extra : moz-landing-system : lando
2019-05-10 01:19:43 +00:00
Gijs Kruitbosch
c14acdeadd Bug 1548941 - remove e10s force-enable and force-disable prefs, and on desktop restrict 'normal' e10s pref to automation and unofficial builds, r=bholley,ahal
Differential Revision: https://phabricator.services.mozilla.com/D29892

--HG--
extra : moz-landing-system : lando
2019-05-09 21:55:46 +00:00
Geoff Brown
230da20010 Bug 1549380 - Increase gtest process timeout from 20 minutes to 40 minutes; r=jmaher
Increasing the timeout avoids a perma-fail on linux64/ccov and leaves room for the
test suite to grow on all platforms.

Differential Revision: https://phabricator.services.mozilla.com/D30083

--HG--
extra : moz-landing-system : lando
2019-05-06 18:53:54 +00:00
Geoff Brown
51f5d3a884 Bug 1548555 - For android gtest, push support files to device; r=bc
Differential Revision: https://phabricator.services.mozilla.com/D29837

--HG--
extra : moz-landing-system : lando
2019-05-03 17:45:21 +00:00
Geoff Brown
069f6587db Bug 1318091 - Support |mach gtest| for android; r=bc
Add basic support for 'mach gtest' on Android.
Handling of Android-only and desktop-only options is awkward; I hope to
re-visit this after bug 1519369.

Differential Revision: https://phabricator.services.mozilla.com/D28129

--HG--
extra : moz-landing-system : lando
2019-04-22 15:55:23 +00:00
Geoff Brown
f1e06657d2 Bug 1318091 - Add more options to remotegtests.py; r=bc
Support --shuffle and <gtest_filter> for android gtest.

Differential Revision: https://phabricator.services.mozilla.com/D27731

--HG--
extra : moz-landing-system : lando
2019-04-16 17:47:58 +00:00
Geoff Brown
c83acb1180 Bug 1318091 - Add remotegtests.py, supporting android gtests; r=bc
Adds remotegtests.py, like rungtests.py, but for Android. Unlike some other test harnesses, remotegtests is not a sub-class of rungtests: There wasn't much code that could be re-used.

The code to wait for the test app and collect and display the log is derived from and similar to existing code in remoteautomation.py: I didn't want to increase reliance on remoteautomation; I don't mind a bit of code duplication.

There is a TODO item related to libxul.so. gtest runs in the browser, but with tests compiled into a gtest-specific version of libxul.so. remotegtests.py patches the installed app by pushing the libxul.so to the installation directory of the app -- root required and fragile, but works fine on the emulator. I think the "right" way to do this is to create a gtest-specific apk; I plan to file a follow-up bug and petition build folks to help sort that out.

I have been running this locally with:
  mach gtest (builds gtests, then errors out)
  mach python testing/gtest/remotegtests.py --libxul=/home/gbrown/objdirs/x86_64/dist/bin/gtest/libxul.so
Work-in-progress on 'mach gtest' will make this much simpler.

Differential Revision: https://phabricator.services.mozilla.com/D26835

--HG--
extra : moz-landing-system : lando
2019-04-12 15:04:39 +00:00
Sylvestre Ledru
7f60810d86 Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D27245

--HG--
extra : moz-landing-system : lando
2019-04-12 13:14:25 +00:00
Geoff Brown
a6180a6479 Bug 1318091 - Support env override of gtest minidump location; r=Ehsan
Desktop gtest creates minidumps in the current working directory. That is
problematic on Android, since the test app's cwd may not be writable, or
may not be readable by the test harness. This patch allows the test harness
to specify an alternate minidump path with environment variable
MOZ_GTEST_MINIDUMPS_PATH.

Differential Revision: https://phabricator.services.mozilla.com/D26833

--HG--
extra : moz-landing-system : lando
2019-04-11 01:25:02 +00:00
Geoff Brown
33aac3ce8e Bug 1318091 - Support logging to file in mozilla gtest; r=bc,Ehsan
On Android, update mozilla gtest logging so that logging appears in the Android logcat.
Also, when MOZ_GTEST_LOG_PATH is defined in the environment, create the named file
and direct logging to that file. Android gtest will use this to collect gtest logging from
the device and copy it to the test log.

Differential Revision: https://phabricator.services.mozilla.com/D26610

--HG--
extra : moz-landing-system : lando
2019-04-10 22:11:48 +00:00
Sylvestre Ledru
03fc65347c Bug 1542146 - Apply the change with the option StatementMacros from clang-format-8 r=andi
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D26280

--HG--
extra : moz-landing-system : lando
2019-04-05 21:42:17 +00:00
Csoregi Natalia
ba58e936bd Backed out changeset 4ad80127f89f (bug 1519636) for bustage on MarkupMap.h and nsAccessibilityService.cpp. CLOSED TREE 2019-04-05 09:48:19 +03:00
Sylvestre Ledru
d1c1878603 Bug 1519636 - clang-format-8: Reformat recent changes to the Google coding style r=Ehsan
clang-format-8 upstream had some improvements wrt macros
See: https://reviews.llvm.org/D33440
This is why the diff is bigger than usual

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D26098

--HG--
extra : moz-landing-system : lando
2019-04-04 21:36:16 +00:00
Narcis Beleuzu
24dbe577a5 Backed out changeset 389b6bbd76db (bug 1519636) for bustages on MarkupMap.h . CLOSED TREE 2019-04-05 00:27:56 +03:00
Sylvestre Ledru
399dbd28fe Bug 1519636 - clang-format-8: Reformat recent changes to the Google coding style r=Ehsan
clang-format-8 upstream had some improvements wrt macros
See: https://reviews.llvm.org/D33440
This is why the diff is bigger than usual

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D26098

--HG--
extra : moz-landing-system : lando
2019-04-04 20:12:23 +00:00
Ryan VanderMeulen
8c673bb9c6 Bug 1534605 - Update gtest and gmock to version 1.8.1. r=gbrown
Differential Revision: https://phabricator.services.mozilla.com/D23118

--HG--
extra : moz-landing-system : lando
2019-03-12 16:34:09 +00:00
Boris Zbarsky
68863e1004 Bug 1533617 part 4. Mark virtual methods with CAN_RUN_SCRIPT overrides as CAN_RUN_SCRIPT. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D22838

--HG--
extra : moz-landing-system : lando
2019-03-11 14:20:29 +00:00
Ehsan Akhgari
e5e885ae31 Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre
# ignore-this-changeset

--HG--
extra : amend_source : 7221c8d15a765df71171099468e7c7faa648f37c
extra : histedit_source : a0cce6015636202bff09e35a13f72e03257a7695
2019-01-18 10:16:18 +01:00
terrameijar
3a49f2d315 Bug 1506611 - Fixed linter errors in testing/gtest r=ahal
Before this change, testing/gtest had 19 errors. These errors have been resolved.

Bug 1506611 - Fixed flake8 errors in testing/gtest

Differential Revision: https://phabricator.services.mozilla.com/D15074

--HG--
extra : moz-landing-system : lando
2018-12-31 16:51:03 +00:00
Sylvestre Ledru
6f45c666bc Bug 1513205 - Also update the tests to match the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D14595

--HG--
extra : moz-landing-system : lando
2018-12-14 18:10:35 +00:00
Chris Manchester
dc4c4637b0 Bug 1468547 - Re-factor gtest mach command to not invoke make when not necessary. r=mshal
MozReview-Commit-ID: 6j7t0YIZc8n

--HG--
extra : rebase_source : e4478904d4f4e54ead473435df2c9e9a47a9294c
2018-07-09 14:28:59 -07:00
Henrik Skupin
894f69b8b2 Bug 1470414 - Clean-up moz.build files for BUG_COMPONENT in testing/. r=ahal
MozReview-Commit-ID: F5vHc4G13v6

--HG--
extra : rebase_source : 1c6c8de55def6026da467d589ec3a8b511986125
2018-06-22 13:32:05 +02:00
Margareta Eliza Balazs
38873b16e7 Backed out changeset 52e86ed85e54 (bug 1470414) for bustage in ./config/tests/test_mozbuild_reading.py::TestMozbuildReading on a CLOSED TREE 2018-06-25 17:29:18 +03:00
Henrik Skupin
df65676052 Bug 1470414 - Clean-up moz.build files for BUG_COMPONENT in testing/. r=ahal
MozReview-Commit-ID: F5vHc4G13v6

--HG--
extra : rebase_source : c39293be7a60ecc22be2f385671769f371dca06b
2018-06-22 13:32:05 +02:00
Sebastian Hengst
0819f35e51 Backed out 4 changesets (bug 525063) on request from Andi. a=backout
Backed out changeset 516c4fb1e4b8 (bug 525063)
Backed out changeset 6ff8aaef2866 (bug 525063)
Backed out changeset bf13e4103150 (bug 525063)
Backed out changeset d7d2f08e051c (bug 525063)
2018-04-13 16:01:28 +03:00
Tristan Bourvon
a3a77c0312 Bug 525063 - Initialize uninitialized class attributes in m-c. r=ehsan 2018-04-10 21:11:02 +02:00
William Lachance
be63617e6b Bug 1451008 - Disable perfherder reporting for microbenchmarks on asan builds r=froydnj
MozReview-Commit-ID: HZLU6gsx7Sq

--HG--
extra : rebase_source : b02b507173dd0a36af8fddbae20827be648c7ae2
2018-04-03 11:31:36 -04:00
Nathan Froyd
0544a4cf70 Bug 1434671 - add a benchmarking macro permitting custom test fixtures; r=ted.mielczarek
GTest supports the TEST macro, which just runs a bunch of tests, and the
TEST_F macro, which enables writing custom test fixtures to perform
per-test setup and teardown.  The benchmarking framework we have has a
corresponding macro for the former, but no corresponding macro for the
latter.  If there's significant work to be done during setup and
teardown, we certainly don't want to be doing that work during the
actual benchmarking!  So let's introduce a MOZ_GTEST_BENCH_F macro that
works similarly to the TEST_F macro.
2018-02-26 17:31:58 -04:00
Geoff Brown
1b0e1177cb Bug 1322616 - Report unique message for gtest output timeout; r=jmaher 2017-12-05 15:43:03 -07:00
Mike Hommey
f238dce0bd Bug 1419196 - Use the "threadsafe" variant of gtest death tests. r=ted
Because the default "fast" variant uses fork() on !windows, death tests
are dangerous, as they themselves say. There are race conditions
involving locks that lead to dead locks in the death test process while
disabling the crash reporter (currently, but this could happen for
different code, even the tested code itself).

See https://bugzilla.mozilla.org/show_bug.cgi?id=1419196#c7 for details.

Using the "threadsafe" variant creates new processes for each death
test. This is notably slower, but can't dead-lock because of some random
lock being held by some random other thread at the moment fork occurred.

--HG--
extra : rebase_source : 56bf678bc9a6588751520549d57db7293134e1f8
2017-11-24 14:22:20 +09:00
Gabriele Svelto
ade65e26df Bug 1402519 - Remove MOZ_CRASHREPORTER directives from testing; r=ted.mielczarek
MozReview-Commit-ID: 3QJI8o9f9UW

--HG--
extra : rebase_source : fe23e92fa060e4ca58158eb4e8d82dcf9da2d2fe
2017-10-10 15:22:56 +02:00
shindli
fb855aa7ba Backed out 16 changesets (bug 1402519) for conflicts during merge r=backout on a CLOSED TREE
Backed out changeset 07fcf163241a (bug 1402519)
Backed out changeset c6d2ad45d8e2 (bug 1402519)
Backed out changeset 8a3caca61294 (bug 1402519)
Backed out changeset 01425eae2c48 (bug 1402519)
Backed out changeset cf298d3815de (bug 1402519)
Backed out changeset e1964f4389cd (bug 1402519)
Backed out changeset f405337f3569 (bug 1402519)
Backed out changeset a76356fd3359 (bug 1402519)
Backed out changeset d3bb350d1c34 (bug 1402519)
Backed out changeset 9d3bfd9f932c (bug 1402519)
Backed out changeset e3dd6e5b073f (bug 1402519)
Backed out changeset e801b0c00134 (bug 1402519)
Backed out changeset 8a4139fa5dca (bug 1402519)
Backed out changeset 8d01c14ac1ca (bug 1402519)
Backed out changeset 24e0dcd01898 (bug 1402519)
Backed out changeset f8fdf450613f (bug 1402519)
2017-11-23 00:11:44 +02:00
Gabriele Svelto
c0bde0772e Bug 1402519 - Remove MOZ_CRASHREPORTER directives from testing; r=ted.mielczarek
MozReview-Commit-ID: 3QJI8o9f9UW

--HG--
extra : rebase_source : 986fb3758f18c852abd0bc35005251c7ab9b8261
2017-10-10 15:22:56 +02:00
Henri Sivonen
9a34044063 Bug 1396208 - For benchmarking, add a black box function that is opaque to the optimizer. r=froydnj
MozReview-Commit-ID: 82jn6u6WRf0

--HG--
extra : rebase_source : 76e173841ed555b7e3741bf3d004de5aa071f3b0
2017-10-10 09:48:26 +03:00
Tom Ritter
701ee70a22 Bug 1406687 Pass return values from fwrite to Unused to silence the warn-unused-result warning r=njn
MozReview-Commit-ID: 4v6tPF5aMz7

--HG--
extra : rebase_source : fe434db73a8da686391462c12b91648348abcdc9
2017-10-09 15:01:48 -05:00
Sebastian Hengst
ee63f2e30a Backed out changeset 0317bcff40bc (bug 1406687) for build bustage at testing/gtest/gtest/src/gtest.cc:3871: 'Unused' was not declared in this scope. r=backout 2017-10-09 18:52:39 +02:00
Tom Ritter
22d2cdf063 Bug 1406687 Pass return values from fwrite to Unused to silence the warn-unused-result warning r=njn
MozReview-Commit-ID: 4v6tPF5aMz7

--HG--
extra : rebase_source : c54b129c6815096035e262322f40aa0884b1ae56
2017-10-09 00:26:16 -05:00