Commit Graph

879 Commits

Author SHA1 Message Date
Sonia Singla
7e4a582215 Bug 1528649 - Remove the context parameter from nsInputStreamPump::AsyncRead. r=valentin,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D85154
2020-08-05 11:21:51 +00:00
Simon Giesecke
96f3e7e019 Bug 1654992 - Use std::move instead of SwapElements where possible. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D84807
2020-08-04 11:27:07 +00:00
Noemi Erli
381fca9783 Backed out 4 changesets (bug 1654992, bug 1654991) for causing timeous in mask-opacity-1e.html
Backed out changeset 11f0f54c6e0a (bug 1654992)
Backed out changeset a353dd5b3f08 (bug 1654991)
Backed out changeset 6a7964ba549f (bug 1654991)
Backed out changeset cf3bfb91d98c (bug 1654991)
2020-08-03 22:09:36 +03:00
Simon Giesecke
032d2ac9d3 Bug 1654992 - Use std::move instead of SwapElements where possible. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D84807
2020-08-03 14:54:18 +00:00
Simon Giesecke
cd8b8939b9 Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D80860
2020-07-01 08:29:29 +00:00
Jean-Yves Avenard
87438519f0 Bug 1637500 - P2. Rename methods as they are not always dealing with "threads". r=froydnj
Before P1, GetCurrentThreadSerialEventTarget would have always returned the same data as NS_GetCurrentThread, making the comment incorrect Now it will properly return the running TaskQueue if any.

This change of name more clearly exposes what they are doing, as we aren't always dealing with threads directly; but a nsISerialEventTarget

Differential Revision: https://phabricator.services.mozilla.com/D80354
2020-06-23 05:05:36 +00:00
Jean-Yves Avenard
d7b9a044db Bug 1647133 - P1. Use nsISerialEventTarget where it's actually that. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D80419
2020-06-23 03:21:14 +00:00
Peter Van der Beken
af82496fc7 Bug 1639310 - Remove unnecessary implicitJSContext annotations. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D76020
2020-05-19 20:48:21 +00:00
Simon Giesecke
5455d8494b Bug 1626570 - Improve handling of copying arrays in dom/network/. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D73670
2020-05-06 11:46:42 +00:00
sagudev
94a5c2f430 Bug 1319881 - Remove UsingNeckoIPCSecurity r=valentin,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D72534
2020-04-29 12:00:01 +00:00
Kris Maglione
4c89b71494 Bug 1614462: Part 2d - Fix tests that don't need to use mozbrowser. r=mccr8
These tests used <iframe mozbrowser> for convenience, mostly forcing
themselves to only run in non-e10s mode in the process, but none of them
really have any need to.

Differential Revision: https://phabricator.services.mozilla.com/D70745
2020-04-20 22:31:29 +00:00
Ciure Andrei
a5ac2a8bbc Backed out 10 changesets (bug 1614462) for causing test_ipc_messagemanager_blob.js failures CLOSED TREE
Backed out changeset bf4f8253c708 (bug 1614462)
Backed out changeset c61b797d63e9 (bug 1614462)
Backed out changeset 284002de7137 (bug 1614462)
Backed out changeset 7f604ee5731c (bug 1614462)
Backed out changeset a73ef8167cd4 (bug 1614462)
Backed out changeset ecc3477ed34e (bug 1614462)
Backed out changeset 2106f3ccc4b5 (bug 1614462)
Backed out changeset e68c38a7741d (bug 1614462)
Backed out changeset 93b3bacdbb34 (bug 1614462)
Backed out changeset 0cf4898ae08d (bug 1614462)
2020-04-21 01:11:37 +03:00
Kris Maglione
d1639bbfcd Bug 1614462: Part 2d - Fix tests that don't need to use mozbrowser. r=mccr8
These tests used <iframe mozbrowser> for convenience, mostly forcing
themselves to only run in non-e10s mode in the process, but none of them
really have any need to.

Differential Revision: https://phabricator.services.mozilla.com/D70745
2020-04-20 20:11:43 +00:00
Ciure Andrei
c15dcac93b Backed out 10 changesets (bug 1614462) for causing xpcshell failures CLOSED TREE
Backed out changeset 34d4a86530b4 (bug 1614462)
Backed out changeset dbc2e2556d08 (bug 1614462)
Backed out changeset 512bbab4730c (bug 1614462)
Backed out changeset cd6b8d630f4c (bug 1614462)
Backed out changeset e4ad5037658f (bug 1614462)
Backed out changeset 0ffed1dc4296 (bug 1614462)
Backed out changeset 90ed81cbfe34 (bug 1614462)
Backed out changeset 6d2137eb1d52 (bug 1614462)
Backed out changeset b4819c99e16e (bug 1614462)
Backed out changeset b7deaed376ed (bug 1614462)
2020-04-17 02:26:14 +03:00
Kris Maglione
c45d02801c Bug 1614462: Part 2d - Fix tests that don't need to use mozbrowser. r=mccr8
These tests used <iframe mozbrowser> for convenience, mostly forcing
themselves to only run in non-e10s mode in the process, but none of them
really have any need to.

Differential Revision: https://phabricator.services.mozilla.com/D70745
2020-04-16 16:57:14 +00:00
Simon Giesecke
06dddea97a Bug 1613985 - Use default for equivalent-to-default constructors/destructors in dom/network. r=smaug
Depends on D66020

Differential Revision: https://phabricator.services.mozilla.com/D66021

--HG--
extra : moz-landing-system : lando
2020-03-09 15:18:20 +00:00
Mark Banner
15cfe23b88 Bug 1620542 - Automatically fix ESLint errors in .eslintrc.js files. r=mossop
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D65703

--HG--
extra : moz-landing-system : lando
2020-03-07 10:09:44 +00:00
Boris Zbarsky
c878a8bb26 Bug 1619112 part 2. Pass char literals instead of char16_t literals into ErrorResult throwing methods. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D65538

--HG--
extra : moz-landing-system : lando
2020-03-06 21:04:58 +00:00
Kris Maglione
c31aa68fb4 Bug 1535617: Part 2 - Clear weak references for most cycle collected objects on unlink. r=mccr8
This covers most cycle collected objects which support weak references, but
not the ones which inherit from a cycle collected class and don't do any cycle
collection on their own.

Differential Revision: https://phabricator.services.mozilla.com/D63962

--HG--
extra : moz-landing-system : lando
2020-02-25 19:44:39 +00:00
Eric Rahm
b9ba9be64d Bug 1322095 - Part 1b: Update callbacks to support moved args and convert nsAutoPtr usage. r=jya
In order to support the update to move args when invoking callbacks we:
 - Convert anything that was using WrapRunnable with `nsAutoPtr` to `UniquePtr`
 - Convert anything that was using a non-const ref as a param to either a
   const ref or a by-val copy

Addtionally we convert the remaining `nsAutoPtr` usage to `UniquePtr`.

Differential Revision: https://phabricator.services.mozilla.com/D59961

--HG--
extra : moz-landing-system : lando
2020-02-21 22:43:53 +00:00
David Major
c4e3b2d209 Bug 1613606 - Bonus cleanup of IPC::Principals r=nika
All of these call sites were unnecessarily converting nsIPrincipal* => IPC::Principal => nsIPrincipal*.

Differential Revision: https://phabricator.services.mozilla.com/D62327

--HG--
extra : moz-landing-system : lando
2020-02-10 20:52:56 +00:00
Edgar Chen
9e846bd48a bug 1610296 - Rename TypedArray_base::ComputeLengthAndData to TypedArray_base::ComputeState; r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D60514

--HG--
extra : moz-landing-system : lando
2020-01-23 03:22:06 +00:00
Coroiu Cristina
73c0827187 Backed out 2 changesets (bug 1322095) for build bustage at dist/include/mtransport/runnable_utils.h on a CLOSED TREE
Backed out changeset 14e115ba7f12 (bug 1322095)
Backed out changeset 078c0fe497b7 (bug 1322095)
2020-01-23 19:50:51 +02:00
Eric Rahm
e120eee6b8 Bug 1322095 - Part 1b: Update callbacks to support moved args and convert nsAutoPtr usage. r=jya
In order to support the update to move args when invoking callbacks we:
 - Convert anything that was using WrapRunnable with `nsAutoPtr` to `UniquePtr`
 - Convert anything that was using a non-const ref as a param to either a
   const ref or a by-val copy

Addtionally we convert the remaining `nsAutoPtr` usage to `UniquePtr`.

Differential Revision: https://phabricator.services.mozilla.com/D59961

--HG--
extra : moz-landing-system : lando
2020-01-23 17:38:18 +00:00
Gabriele Svelto
ace6d1063f Bug 1600545 - Remove useless inclusions of header files generated from IDL files in dom/ r=Ehsan
The inclusions were removed with the following very crude script and the
resulting breakage was fixed up by hand. The manual fixups did either
revert the changes done by the script, replace a generic header with a more
specific one or replace a header with a forward declaration.

find . -name "*.idl" | grep -v web-platform | grep -v third_party | while read path; do
    interfaces=$(grep "^\(class\|interface\).*:.*" "$path" | cut -d' ' -f2)
    if [ -n "$interfaces" ]; then
        if [[ "$interfaces" == *$'\n'* ]]; then
          regexp="\("
          for i in $interfaces; do regexp="$regexp$i\|"; done
          regexp="${regexp%%\\\|}\)"
        else
          regexp="$interfaces"
        fi
        interface=$(basename "$path")
        rg -l "#include.*${interface%%.idl}.h" . | while read path2; do
            hits=$(grep -v "#include.*${interface%%.idl}.h" "$path2" | grep -c "$regexp" )
            if [ $hits -eq 0 ]; then
                echo "Removing ${interface} from ${path2}"
                grep -v "#include.*${interface%%.idl}.h" "$path2" > "$path2".tmp
                mv -f "$path2".tmp "$path2"
            fi
        done
    fi
done

Differential Revision: https://phabricator.services.mozilla.com/D55442

--HG--
extra : moz-landing-system : lando
2019-12-06 09:24:56 +00:00
Boris Zbarsky
75124bdd98 Bug 1517588. Use nsIPrincipal::IsSystemPrincipal instead of nsContentUtils::IsSystemPrincipal r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D53067

--HG--
extra : moz-landing-system : lando
2019-12-05 04:44:32 +00:00
Dorel Luca
a381d5c96d Backed out changeset f6e53d1c6518 (bug 1600545) for Android build bustage. CLOSED TREE 2019-12-04 17:32:27 +02:00
Gabriele Svelto
bc9290f767 Bug 1600545 - Remove useless inclusions of header files generated from IDL files in dom/ r=Ehsan
The inclusions were removed with the following very crude script and the
resulting breakage was fixed up by hand. The manual fixups did either
revert the changes done by the script, replace a generic header with a more
specific one or replace a header with a forward declaration.

find . -name "*.idl" | grep -v web-platform | grep -v third_party | while read path; do
    interfaces=$(grep "^\(class\|interface\).*:.*" "$path" | cut -d' ' -f2)
    if [ -n "$interfaces" ]; then
        if [[ "$interfaces" == *$'\n'* ]]; then
          regexp="\("
          for i in $interfaces; do regexp="$regexp$i\|"; done
          regexp="${regexp%%\\\|}\)"
        else
          regexp="$interfaces"
        fi
        interface=$(basename "$path")
        rg -l "#include.*${interface%%.idl}.h" . | while read path2; do
            hits=$(grep -v "#include.*${interface%%.idl}.h" "$path2" | grep -c "$regexp" )
            if [ $hits -eq 0 ]; then
                echo "Removing ${interface} from ${path2}"
                grep -v "#include.*${interface%%.idl}.h" "$path2" > "$path2".tmp
                mv -f "$path2".tmp "$path2"
            fi
        done
    fi
done

Differential Revision: https://phabricator.services.mozilla.com/D55442

--HG--
extra : moz-landing-system : lando
2019-12-04 15:01:19 +00:00
Boris Zbarsky
6b410b5b48 Bug 927610 part 1. Stop using NS_ERROR_TYPE_ERR in UDPSocket. r=smaug
The only ways DispatchReceivedData can fail are if our scope is torn down, we
OOM when creating a typed array, or we fail to queue a runnable.  These all
seem like pretty unexpected situations, so NS_ERROR_UNEXPECTED seems
appropriate if we don't want to just propagate through the error from
DispatchReceivedData.

Differential Revision: https://phabricator.services.mozilla.com/D46483

--HG--
extra : moz-landing-system : lando
2019-09-24 16:53:44 +00:00
Boris Zbarsky
e26682d684 Bug 1581173 part 1. Add a way to more easily throw TypeErrors and RangeErrors with custom message strings via ErrorResult. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D45932

--HG--
extra : moz-landing-system : lando
2019-09-20 02:19:18 +00:00
Byron Campen [:bwc]
fec8b0d807 Bug 1569183: Stop doing a proxy lookup to determine whether we're configured to use a proxy (for the proxy_only_if_behind_proxy pref), and instead look at whether we loaded the doc using a proxy. r=mjf,mayhemer,jld
Differential Revision: https://phabricator.services.mozilla.com/D45289

--HG--
extra : moz-landing-system : lando
2019-09-18 14:27:42 +00:00
Byron Campen [:bwc]
57de6c6130 Bug 1569183: Remove some stuff from TCPSocket that NrTcpSocketIpc was the only user of. r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D45112

--HG--
extra : moz-landing-system : lando
2019-09-17 18:18:15 +00:00
Mark Banner
351d147e2f Bug 1577746 - Enable ESLint rule object-shorthand for dom/. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D44149

--HG--
extra : moz-landing-system : lando
2019-09-02 11:22:27 +00:00
Barret Rennie
c5fb688d6a Bug 1289211 - Rename InfallibleTArray to nsTArray in dom/network/ r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D36947

--HG--
extra : moz-landing-system : lando
2019-07-10 03:27:30 +00:00
Victor Porof
0a8ff0ad85 Bug 1561435 - Format dom/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35951

--HG--
extra : source : 62f3501af4bc1c0bd1ee1977a28aee04706a6663
2019-07-05 10:44:55 +02:00
Mark Banner
c51c2a8807 Bug 1558822 - Fix more issues related to shadowing of variables in dom/ code. r=perry
Differential Revision: https://phabricator.services.mozilla.com/D34760

--HG--
extra : moz-landing-system : lando
2019-06-14 18:04:01 +00:00
Boris Zbarsky
a4410ccb51 Bug 1558726. Stop using [array] in nsISocketTransportService. r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D34668

--HG--
extra : moz-landing-system : lando
2019-06-13 04:21:32 +00:00
Boris Zbarsky
8e413da004 Bug 1558738. Stop using [array] in nsIUDPSocket. r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D34672

--HG--
extra : moz-landing-system : lando
2019-06-12 07:00:01 +00:00
Sylvestre Ledru
d57d4905f1 Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D30883

--HG--
extra : moz-landing-system : lando
2019-05-25 17:46:15 +00:00
arthur.iakab
af8e458c5f Backed out changeset a296439a25ff (bug 1519636) for frequent Windows cppunit failures CLOSED TREE 2019-05-24 14:26:01 +03:00
Sylvestre Ledru
c82ea97226 Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D30883

--HG--
extra : moz-landing-system : lando
2019-05-24 09:59:17 +00:00
Boris Zbarsky
e26cc00e3e Bug 1550364 part 6. Stop using [array] in nsIUDPSocketInternal. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D30449

--HG--
extra : moz-landing-system : lando
2019-05-09 06:55:07 +00:00
Boris Zbarsky
5ae4d7046a Bug 1550364 part 5. Get rid of nsIUDPSocketChild. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D30448

--HG--
extra : moz-landing-system : lando
2019-05-09 06:55:06 +00:00
Boris Zbarsky
941d39f649 Bug 1550364 part 4. Move various methods from nsIUDPSocketChild to dom::UDPSocketChild, and simplify their signatures where possible. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D30447

--HG--
extra : moz-landing-system : lando
2019-05-09 06:55:06 +00:00
Boris Zbarsky
7299b02992 Bug 1550364 part 3. Remove unused nsIUDPSocketChild methods. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D30446

--HG--
extra : moz-landing-system : lando
2019-05-09 06:55:06 +00:00
Boris Zbarsky
86aa098b68 Bug 1550364 part 2. Use dom::UDPSocketChild, not nsIUDPSocketChild, in C++ code. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D30445

--HG--
extra : moz-landing-system : lando
2019-05-09 06:55:05 +00:00
Boris Zbarsky
70b91760d9 Bug 1550364 part 1. Stop claiming nsIUDPSocketChild is scriptable, since we never use it from script. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D30444

--HG--
extra : moz-landing-system : lando
2019-05-09 06:55:05 +00:00
Kershaw Chang
6bd2b36d88 Bug 1542593 - Don't access gNeckoChild if not on main thread r=jdm
gNeckoChild is only accessed on main thread, so we should use NS_IsMainThread to see whether we should access gNeckoChild or not.
This patch also makes UDPSocketChild::Bind return NS_ERROR_NOT_AVAILABLE when mBackgroundManager is null.

Differential Revision: https://phabricator.services.mozilla.com/D29658

--HG--
extra : moz-landing-system : lando
2019-05-02 17:29:46 +00:00
Kershaw Chang
3aad5c69c2 Bug 1541114 - Check mIPCOpen before sending messages r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D27869

--HG--
extra : moz-landing-system : lando
2019-05-02 12:00:57 +00:00
Sebastian Streich
8ac88db494 Bug 1444503 - Remove the IPC::Principal r=ckerschb,nika
***
Removed IPC References in PCContent
***
Removed IPC References on nsContentPermissionHelper
***
 Remove IPC Principal from PBrowser
***
Remove IPCPrincipal from the PaymentRequest
***
Remove IPCPrincipal from the PPresentation
***
Remove IPC Principal from PNecko

Differential Revision: https://phabricator.services.mozilla.com/D28650

--HG--
extra : moz-landing-system : lando
2019-04-25 14:18:11 +00:00