Commit Graph

638411 Commits

Author SHA1 Message Date
Samuel Thibault
3ec9cb5130 Bug 919508 - nsTextFrame::GetTrimmedOffsets: Rework flag parameters r=jfkthame
--HG--
extra : histedit_source : 5c59e716d7a94030b6146bc471bc8dbbd92c7122
2019-02-22 22:12:27 +01:00
Kartikaya Gupta
122b09781a Bug 1526468 - Disable intermittently-failing newly added test on Linux-qr. r=me 2019-02-22 12:14:08 -05:00
Coroiu Cristina
6a915c899d Merge mozilla-central to inbound a=merge 2019-02-22 18:41:16 +02:00
Coroiu Cristina
0f56da86e3 Backed out changeset a465a9a1a913 (bug 1526752) for mochitest failures with ValueError: need more than 1 value to unpack 2019-02-22 15:32:03 +02:00
Mats Palmgren
f92f45d7b6 Bug 1526567 - Fix devtools dependence on this bug. r=dholbert 2019-02-22 13:58:24 +01:00
Mats Palmgren
0f4868138a Bug 1526567 - [css-grid] Make the block-axis percentage basis be indefinite for measuring reflows. r=dholbert 2019-02-22 13:58:24 +01:00
Michael Ratcliffe
11f246e18a Bug 1042082 - Chrome event bubbles are displayed when they shouldn't be r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D18358

--HG--
extra : moz-landing-system : lando
2019-02-22 11:17:02 +00:00
Dave Hunt
bf8987e947 Bug 1526752 - [mozdevice] Run modernize over adb.py; r=ahal
Improve support for Python 3 by running modernize over adb.py and a few other related changes.

Differential Revision: https://phabricator.services.mozilla.com/D19306

--HG--
extra : moz-landing-system : lando
2019-02-22 12:33:14 +00:00
Dorel Luca
e2b65baabd Backed out changeset cd5dbeee8c5d (bug 1502917) for build bustage. CLOSED TREE 2019-02-22 14:32:42 +02:00
Lawrence
0161f9d961 Bug 1515009 Deduplicate code for displaying multi-store data in about:telemetry r=janerik
Differential Revision: https://phabricator.services.mozilla.com/D20083

--HG--
extra : moz-landing-system : lando
2019-02-22 12:30:31 +00:00
Jean-Yves Avenard
916342f7c5 Bug 1222851 - Keep the one dropped frame prior the first one to prime the decoder. r=bryce
Some audio decoders, such as AAC and Opus have a need for a pre-roll content. As such, in order to be able to fully get the content of the first frame we keep the frame just prior that would have normally been dropped.

We set this frame to have a duration of 1us so that it will be dropped later by the decoding pipeline. The starting time of the first frame is adjusted so that we have continuous data, without gap in the buffered range.

Differential Revision: https://phabricator.services.mozilla.com/D20322

--HG--
extra : moz-landing-system : lando
2019-02-22 09:58:18 +00:00
Jean-Yves Avenard
850a9d6aa7 Bug 1524890 - P17. Set duration on IMF sample. r=bryce
We didn't set the duration on the created IMF sample before sending it to the decoder.
For audio this isn't a problem as the duration is calculated from the number of frames returned.
For video however, the duration appears to have been calculated by WMF as the delta of pts. However, for the last frame, the value returned was set to a value not matching our input.

So we set the duration on the IMFSample so it doesn't have to make it up.

Setting the duration on the IMFSample isn't sufficient with Windows 7, which still continues to calculate it based on previous samples durations.
So we store the last sample duration and set it when draining.

Differential Revision: https://phabricator.services.mozilla.com/D20653

--HG--
extra : moz-landing-system : lando
2019-02-23 09:28:14 +00:00
Jean-Yves Avenard
ffc1352b1f Bug 1524890 - P16. Fix mochitests. r=bryce
Differential Revision: https://phabricator.services.mozilla.com/D20330

--HG--
extra : moz-landing-system : lando
2019-02-22 09:21:13 +00:00
Jean-Yves Avenard
5569ae1a9c Bug 1524890 - P15. [MSE] Add extra logging. r=bryce
Differential Revision: https://phabricator.services.mozilla.com/D20321

--HG--
extra : moz-landing-system : lando
2019-02-22 09:21:11 +00:00
Jean-Yves Avenard
4a6552a7d5 Bug 1524890 - P14. Add AudioTrimmer wrapper. r=bryce
A simplistic decoder wrapper that will take decoded frames and truncate them should the originally compressed frame contained trimming information.

Differential Revision: https://phabricator.services.mozilla.com/D20173

--HG--
extra : moz-landing-system : lando
2019-02-24 10:29:52 +00:00
Jean-Yves Avenard
68176b56c7 Bug 1524890 - P13. [MSE] Mark frames as truncated when needed. r=bryce
There's two cases to handle.
1- A Frame isn't entirely contained between appendWindowStart and appendWindowEnd
2- A new frame is appended which overlaps partially an existing frame.

To achieve this we tweak the start time and duration of the sample added (case 1), or the frame about to be partially covered (case 2). We then set a flag that will indicate to the decoder that the decompressed frame will have to be truncated.

Differential Revision: https://phabricator.services.mozilla.com/D20172

--HG--
extra : moz-landing-system : lando
2019-02-22 09:21:05 +00:00
Jean-Yves Avenard
a61c2a98fe Bug 1524890 - P12. Serialise TimeUnit over ipdl. r=mjf
Nicer than passing int64_t directly.

Differential Revision: https://phabricator.services.mozilla.com/D20171

--HG--
extra : moz-landing-system : lando
2019-02-23 09:21:41 +00:00
Jean-Yves Avenard
4377bd3b8b Bug 1524890 - P11. Remove duration from AudioData construction parameter. r=bryce
It can be determined from the size of the buffer and the number of audio frames. Additionally, it ensures that the duration of the frame is always exactly what the AudioData contains.

Differential Revision: https://phabricator.services.mozilla.com/D20170

--HG--
extra : moz-landing-system : lando
2019-02-22 09:19:47 +00:00
Jean-Yves Avenard
ca21a59533 Bug 1524890 - P10. Add AudioData::SetTrimWindow. r=bryce
Don't re-create a new trimmed AudioData when we want to remove some content. This remove the need for some copies.

Differential Revision: https://phabricator.services.mozilla.com/D20168

--HG--
extra : moz-landing-system : lando
2019-02-22 09:19:32 +00:00
Jean-Yves Avenard
ed02a5879c Bug 1524890 - P9. Add += and -= operator. r=gerald
Differential Revision: https://phabricator.services.mozilla.com/D20167

--HG--
extra : moz-landing-system : lando
2019-02-22 09:19:18 +00:00
Jean-Yves Avenard
7f3801ebd7 Bug 1524890 - P8. Rely on buffer length to calculate the number of frames. r=bryce
Differential Revision: https://phabricator.services.mozilla.com/D20166

--HG--
extra : moz-landing-system : lando
2019-02-22 09:19:00 +00:00
Jean-Yves Avenard
3cf8c6d0df Bug 1524890 - P7. No longer access AudioData::mFrames directly. r=bryce
This will allow to remove mFrames member and calculate from the size of the content, which will dynamically change depending on a cropping filter.

Differential Revision: https://phabricator.services.mozilla.com/D20165

--HG--
extra : moz-landing-system : lando
2019-02-22 09:18:47 +00:00
Jean-Yves Avenard
dd3c534de5 Bug 1524890 - P6. Remove mFrames member from MediaData. r=bryce
The number of frames is only meaningful with audio as a VideoData always contain a single frame.
So we only have this member in AudioData, which will simplify the logic in a future commit where the number of frames present depends on the trimming filter applied.

Differential Revision: https://phabricator.services.mozilla.com/D20164

--HG--
extra : moz-landing-system : lando
2019-02-22 09:18:33 +00:00
Jean-Yves Avenard
964cc95e13 Bug 1524890 - P5. Make MediaData::Type an enum class. r=bryce
Make its use more explicit and less likely to be incorrect.

Differential Revision: https://phabricator.services.mozilla.com/D20163

--HG--
extra : moz-landing-system : lando
2019-02-22 09:18:18 +00:00
Jean-Yves Avenard
1f5dfb6d37 Bug 1524890 - P4. Use Span<> with AudioBufferCursor. r=bryce
And we add some strong assertions that we never read passed the end of the buffer.

Differential Revision: https://phabricator.services.mozilla.com/D20162

--HG--
extra : moz-landing-system : lando
2019-02-22 09:18:05 +00:00
Jean-Yves Avenard
afe04d2952 Bug 1524890 - P3. Add AudioData::Data method that returns a Span. r=bryce
So that we never access the underlying buffer directly.

Differential Revision: https://phabricator.services.mozilla.com/D20161

--HG--
extra : moz-landing-system : lando
2019-02-22 09:18:04 +00:00
Jean-Yves Avenard
b67dc45537 Bug 1524890 - P2. Add Intersects methods. r=gerald
Differential Revision: https://phabricator.services.mozilla.com/D20160

--HG--
extra : moz-landing-system : lando
2019-02-22 09:18:04 +00:00
Jean-Yves Avenard
d41a4fc09b Bug 1524890 - P1. Remove unused method. r=bryce
Differential Revision: https://phabricator.services.mozilla.com/D20159

--HG--
extra : moz-landing-system : lando
2019-02-22 09:18:03 +00:00
Razvan Maries
5b3e1e60d4 Backed out changeset 070cb0982606 (bug 1512956) for xpcshell fails on test_parseDeclarations.js. CLOSED TREE 2019-02-24 15:06:59 +02:00
Razvan Caliman
535771205c Bug 1512956 - Ensure empty string is considered valid CSS authoredText; r=pbro
When removing all declarations from a rule via the Rule view, the authoredText value ends up as an empty string.
This patch ensures that the fallback cssText is not used in that case because that accidentally restores the whole declaration block when re-parsing the text of the rule.

Differential Revision: https://phabricator.services.mozilla.com/D14753

--HG--
extra : moz-landing-system : lando
2019-02-24 10:28:14 +00:00
Razvan Maries
7a5c7bab52 Backed out changeset 8c7ac177290e (bug 1479335) for ES Lint fialure. CLOSED TREE 2019-02-24 12:17:38 +02:00
ui.manish
4d1af398d9 Bug 1479335 - Remove permissions close button r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D16264

--HG--
extra : moz-landing-system : lando
2019-02-24 09:58:15 +00:00
Tooru Fujisawa
ab3eee7b52 Bug 1529448 - Move {hasUsedName,hasUsedNamedeclareFunctionThis,declareFunctionThis,declareFunctionArgumentsObject,declareDotGeneratorName} to ParseContext. r=jorendorff
Differential Revision: https://phabricator.services.mozilla.com/D20779

--HG--
extra : moz-landing-system : lando
2019-02-24 03:35:44 +00:00
Tooru Fujisawa
54d153b42a Bug 1529439 - Share variable redeclaration code between regular parser and BinAST parser. r=Yoric
Shared the part to redeclare vars as body-level functions.

Differential Revision: https://phabricator.services.mozilla.com/D20778

--HG--
extra : moz-landing-system : lando
2019-02-24 03:35:19 +00:00
Tooru Fujisawa
7f54ff4d1d Bug 1529823 - Remove untagged tuple. r=Yoric
Untagged tuple is not used in multipart format and entropy format.

Differential Revision: https://phabricator.services.mozilla.com/D20776

--HG--
extra : moz-landing-system : lando
2019-02-24 03:34:46 +00:00
Tooru Fujisawa
765b149359 Bug 1529442 - Move BinASTParserBase fields to BinASTParserPerTokenizer. r=Yoric
Both BinASTParserBase.{lazyScript_,handler_} are not used in BinASTParserBase,
but in BinASTParserPerTokenizer.
Moved them to BinASTParserPerTokenizer.

Differential Revision: https://phabricator.services.mozilla.com/D20775

--HG--
extra : moz-landing-system : lando
2019-02-24 03:34:03 +00:00
Tooru Fujisawa
de2a04e277 Bug 1528844 - Move ParseNode allocation from BinASTParserBase to FullParseHandler. r=Yoric
BinASTParserBase::allocParseNode was used only for creating
ParseNodeKind::ParamsBody node, and other nodes are created by FullParseHandler.
Added FullParseHandler::newParamsBody and removed ParseNode allocation
methods from BinASTParserBase.

Differential Revision: https://phabricator.services.mozilla.com/D20774

--HG--
extra : moz-landing-system : lando
2019-02-24 09:42:53 +00:00
Tooru Fujisawa
5fc0c2d2a4 Bug 1528837 - Part 14: Add ParserSharedBase class. r=Yoric
Differential Revision: https://phabricator.services.mozilla.com/D20226

--HG--
extra : moz-landing-system : lando
2019-02-24 09:42:51 +00:00
Tooru Fujisawa
e520c68042 Bug 1528837 - Part 13: Rename PerHandlerParser::handler field to handler_. r=Yoric
Differential Revision: https://phabricator.services.mozilla.com/D20225

--HG--
extra : moz-landing-system : lando
2019-02-24 03:32:09 +00:00
Tooru Fujisawa
a2a3955524 Bug 1528837 - Part 12: Rename BinASTParserBase::factory_ field to handler_. r=Yoric
Differential Revision: https://phabricator.services.mozilla.com/D20224

--HG--
extra : moz-landing-system : lando
2019-02-24 03:31:45 +00:00
Tooru Fujisawa
2c43d5027c Bug 1528837 - Part 11: Rename BinASTParserBase::parseContext_ field to pc_. r=Yoric
Differential Revision: https://phabricator.services.mozilla.com/D20223

--HG--
extra : moz-landing-system : lando
2019-02-24 03:31:04 +00:00
Tooru Fujisawa
1c79a6e610 Bug 1528837 - Part 10: Rename ParserBase::checkOptionsCalled field to checkOptionsCalled_. r=Yoric
Differential Revision: https://phabricator.services.mozilla.com/D20222

--HG--
extra : moz-landing-system : lando
2019-02-24 03:30:36 +00:00
Tooru Fujisawa
01ccdbbf13 Bug 1528837 - Part 9: Rename ParserBase::foldConstants field to foldConstants_. r=Yoric
Differential Revision: https://phabricator.services.mozilla.com/D20221

--HG--
extra : moz-landing-system : lando
2019-02-24 03:29:55 +00:00
Tooru Fujisawa
74d86a94c6 Bug 1528837 - Part 8: Rename ParserBase::keepAtoms field to keepAtoms_. r=Yoric
Differential Revision: https://phabricator.services.mozilla.com/D20220

--HG--
extra : moz-landing-system : lando
2019-02-24 03:29:05 +00:00
Tooru Fujisawa
81fa03ab0a Bug 1528837 - Part 7: Rename ParserBase::sourceObject field to sourceObject_. r=Yoric
Differential Revision: https://phabricator.services.mozilla.com/D20219

--HG--
extra : moz-landing-system : lando
2019-02-24 03:28:30 +00:00
Tooru Fujisawa
ba499c1e3c Bug 1528837 - Part 6: Rename ParserBase::usedNames field to usedNames_. r=Yoric
Differential Revision: https://phabricator.services.mozilla.com/D20218

--HG--
extra : moz-landing-system : lando
2019-02-24 03:27:59 +00:00
Tooru Fujisawa
cdf4ccd07a Bug 1528837 - Part 5: Rename ParserBase::pc field to pc_. r=Yoric
Differential Revision: https://phabricator.services.mozilla.com/D20217

--HG--
extra : moz-landing-system : lando
2019-02-24 03:27:55 +00:00
Tooru Fujisawa
1c9a1e2216 Bug 1528837 - Part 4: Rename ParserBase::traceListHead field to traceListHead_. r=Yoric
Differential Revision: https://phabricator.services.mozilla.com/D20215

--HG--
extra : moz-landing-system : lando
2019-02-24 03:26:35 +00:00
Tooru Fujisawa
ae21598c38 Bug 1528837 - Part 3: Rename ParserBase::tempPoolMark field to tempPoolMark_. r=Yoric
Differential Revision: https://phabricator.services.mozilla.com/D20214

--HG--
extra : moz-landing-system : lando
2019-02-24 03:26:08 +00:00
Tooru Fujisawa
d041c9aac7 Bug 1528837 - Part 2: Rename ParserBase::alloc field to alloc_. r=Yoric
Differential Revision: https://phabricator.services.mozilla.com/D20213

--HG--
extra : moz-landing-system : lando
2019-02-24 03:25:38 +00:00