Commit Graph

2230 Commits

Author SHA1 Message Date
ian%hixie.ch
86e3bcd2ae * Improved the helpfulness of the extremely verbose debugging information of PLIF.pm by quoting embedded variables
* Implemented MagicCollectingArray, which acts like MagicPipingArray except that the result is collected into one big array instead of multiple arrayrefs
* Added the relevant getCollecting*List methods to the Controller class
* Added DESTROY methods to the magic array to prevent DESTROY method calls from being propagated
* Made the debug.dumpVars string more robust when the data hash includes one of the three magic characters '(', '.' or ')'
* Implemented sanitation in COSES so that any keys in the data hash containing one of the three magic characters '(', '.' or ')' will have them transliterated to '[', ':' and ']' respectively (sanitation is optional and can be bypassed)
* Changed the API of the generic output module's 'output' method to take the optional $session argument last, thus simplifying the call sites a lot
* Implemented the 'dispatcher.output' service in several classes to return strings that must be support in variants (required for a good UI in the COSES editor)
* Renamed the Login module's strings so that they use the dot-notation separating significant parts
2001-06-04 06:13:22 +00:00
ian%hixie.ch
a6faa21a5f Stub implementation of a COSES editor component, plus added 'component.nameOfComponent' to the list of services provided by the other two components 2001-06-03 23:06:09 +00:00
ian%hixie.ch
15b9f89cde Moved AdminCommands.pm and Login.pm to a Component directory 2001-06-03 22:45:37 +00:00
ian%hixie.ch
407f43e493 Minor bug fixes required to make the code run without crashing... 2001-06-03 16:14:41 +00:00
ian%hixie.ch
02d609eb82 Some more minor corrections to get it to run as well as compile... (removes some XXX comments and adds some error checking) 2001-06-03 15:27:16 +00:00
ian%hixie.ch
5dd8af9c83 Fixing a gazillion syntax, logic and XML errors and adding some debug code. It compiles! 2001-06-03 14:49:41 +00:00
ian%hixie.ch
7daa595cd4 * Added some comments (including some XXX comments where I realised we had missing code)
* Added implicit data to the hash passed to the string expander from the generic output service
* To support the implicit data, added a |hash| stub method to the Session.pm module (and changed the already implemented version in the descendant user service to take this into account)
* To support the implicit data, added |hash| and |getArguments| methods to the Input.pm module (and implemented |getArguments| in the Arguments.pm module)
* To support the implicit data, made the Program.pm module keep track of the executing command
* To support the implicit data, added |hash| and |name| methods to the Program.pm module (actually, |name| was already assumed to exist in other parts of the codebase)
* Corrected trivial semantic mistake in Program.pm's |verifyInput| method
* Added a way to get a user not by username but by a specific address (modifies the user service and the user data source and it's MySQL implementation)
* Implemented GenericOutputs.pm, an implementation of 'dispatcher.output.generic' and 'dataSource.strings.default' for some strings used by other parts of PLIF (currently only supports 'stdout' and 'http' protocols, and minimally at that)
* Implemented Login.pm, a helper module that implements user authentication, user creation and the sending of a new password if it is forgotten, a utility method |hasRight| to ensure that the authenticated user has a particular right (resulting in a message if not), and various routines to support all this.
2001-06-03 10:11:58 +00:00
tara%tequilarista.org
eda44f5b9f Landing Myk's patch for bug #71767 2001-06-02 22:02:02 +00:00
jake%acutex.net
dd724b762d sanitycheck.cgi was able to be run by anybody - even people without Bugzilla accounts. It is now restricted to only people with the editbugs permission (bug 54556).
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net
2001-06-02 14:24:45 +00:00
justdave%syndicomm.com
770e473d23 Fix for bug 65190: add comparison type "all words as substrings" and "any words as substrings" to the text fields in query.cgi
Patch by Andreas Franke <afranke@ags.uni-sb.de>
r= justdave@syndicomm.com
2001-06-02 04:02:13 +00:00
justdave%syndicomm.com
46f339c5a5 Fix for bug 78407: extra safeguard against overpopping the email list when pruning people who aren't supposed to get mail.
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-06-02 03:19:26 +00:00
justdave%syndicomm.com
6e09c91524 Fix for bug 83596: optional dependency on XML::Parser now checked in checksetup.pl
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-06-02 01:57:22 +00:00
justdave%syndicomm.com
988054fcd5 Fix for bug 83618: checksetup.pl crashes if DBI module isn't already installed.
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-06-02 01:53:01 +00:00
jake%acutex.net
d92f61970d More leak pluggin. This one fixes bug 39526.
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net
2001-06-01 13:38:01 +00:00
justdave%syndicomm.com
a490c6a17a Fix for bug 83633: perl warnings in 5.6
r= Hixie
2001-06-01 10:03:52 +00:00
justdave%syndicomm.com
b2c86ed7e1 Fix for bug 73249: perl warnings under 5.6.0.
Patch by Chris Yeh <Chris.Yeh@nokia.com>
r= justdave@syndicomm.com
2001-06-01 08:34:45 +00:00
justdave%syndicomm.com
d3e70e89ba Fix for bug 79317: dependency on CGI::Carp not caught by checksetup.pl
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-06-01 03:13:28 +00:00
justdave%syndicomm.com
8ab8f92481 backing out previous fix to importxml.pl. It fixed it on Perl 5.6 and broke it on Perl 5.005. Will need to investigate. 2001-06-01 02:27:52 +00:00
justdave%syndicomm.com
bb1c25a4d0 Fix for bug 72862: fixes more Perl warnings in RelationSet.pm and globals.pl 2001-06-01 02:14:23 +00:00
justdave%syndicomm.com
ed939131dc Fix for bug 57848, perl warnings in several files.
Patch by Nick Hibma <n_hibma@qubesoft.com>
r= justdave@syndicomm.com
2001-06-01 02:07:28 +00:00
ian%hixie.ch
07b4d3d583 * fixing some syntactic errors
* added addUserGroup and removeUserGroup to the data source interface for users
* added some comments
* changed many double quotes |"| to single quotes |'| where double quotes were not needed
* implemented the remaining methods for the MySQL implementation of the user data source
* added a mode flag to user fields (idea from MattyT) so that fields can be disabled, hidden, etc
2001-06-01 00:32:35 +00:00
jake%acutex.net
d520cdb669 Bugzilla was leaking information about bugs marked secure (using bug groups). This checkin fixes bugs 39524, 39527, 39531, and 39533.
Patches by Myk Melez <myk@mozilla.org>.
r= jake@acutex.net
2001-05-31 15:52:25 +00:00
jake%acutex.net
7da1a248bc Bug 80388 - cvsblame shouldn't require layers for popups
r=baloo
2001-05-30 22:13:03 +00:00
jake%acutex.net
8cbb7741ca Fix for bug 45164 - New users created by the admin were not subject to the userregexp for groupsets.
Patch by Joe Robins <jmrobins@tgix.com>
r= jake@acutex.net
2001-05-30 15:47:30 +00:00
justdave%syndicomm.com
17dff3efe0 Dummy commit so I can put the attributions I forgot in the previous one.
Patch from bug 65290 was by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-05-29 21:27:12 +00:00
justdave%syndicomm.com
8f363f7f6e Fix for bug 65290: can now edit user-regexps for system groups 2001-05-29 21:25:02 +00:00
ian%hixie.ch
76d1f38fb9 Change the semantics of address changing, making it faster, smaller, simpler, and better. Aaah... :-) In the new system, instead of cloning the current $session object to pass it back to the output code, you pass the real $session object to the output code, just making sure that the relevant field has been warned to return a different address than found in the database. 2001-05-29 20:34:12 +00:00
justdave%syndicomm.com
de23e17707 Fix for bug 65399: Can't use string ("") as an ARRAY ref while "strict refs" in use at query.cgi due to no components defined in a product.
Patch by Matthias Radestock <matthias@sorted.org>
r= justdave@syndicomm.com
2001-05-29 20:30:51 +00:00
justdave%syndicomm.com
3aaea9ad25 Additional cleanup for bug 73191. newquip.html is no longer needed. 2001-05-29 18:44:00 +00:00
ian%hixie.ch
1b89023d7a Adding some XXX comments regarding a known bug (when the user is changing their address, fields try to update the database before the new address has been authenticated) 2001-05-29 09:11:33 +00:00
ian%hixie.ch
2411ff6005 * Fixing a minor bug in the MySQL implementation of the string data source
* Started implementing the MySQL version of the user data source (completed so far: database creation and a few of the SELECT calls)
* Changed the user property 'disabled' to 'mode' to enable extensibility
* Fix a potential bug with changing addresses (make sure the fake session object doesn't update the database -- this is an incomplete solution so far, fields still have the bug)
2001-05-29 09:07:10 +00:00
justdave%syndicomm.com
c2cf48b4bd Fix for bug 78045: change references to README in error messages to point to the Bugzilla Guide instead.
Patch by Matthew Tuck <matty@chariot.net.au>
r= justdave@syndicomm.com
2001-05-29 08:10:28 +00:00
justdave%syndicomm.com
5205d71b1c Landing quips.cgi (bug 73191) by Owen Taylor <otaylor@redhat.com>
Submitted by Martin Baulig <baulig@suse.de> from bugzilla.gnome.org
r= justdave@syndicomm.com
2001-05-29 04:01:48 +00:00
justdave%syndicomm.com
93046edb9a Fix for bug 77699 and bug 71503: fix javascript errors in quicksearch and improve IE5 compatibility
Patch by Stephan Lee <slee@uk.bnsmc.com> and Andreas Franke <afranke@ags.uni-sb.de>
2001-05-29 03:05:46 +00:00
ian%hixie.ch
fe6643848b * Moving 'type' to the front of the list of things returned by the User data source's 'getField*' methods so that they map more directly to the user field constructor arguments
* Moving 'typeData' around in the order of the user field constructor arguments to match the User data source's 'getField*' methods so that, again, they map more directly
* Renaming the 'getFieldFrom*' methods to 'getFieldBy*' to be consistent with 'getUserBy*'
* Implemented UserFieldFactory.pm
* Implemented Passwords.pm
2001-05-28 23:43:56 +00:00
ian%hixie.ch
e60cd56ae6 * Correcting a typo in Input.pm
* Added a comment to DataSource/User.pm explaining how (typically) to search for a username
* Fleshed out the DataSource/User.pm API by adding some schema management methods
* Added notes on which fields in the database schema should be keys
* Added comment to Service/User.pm noting the difference between Objects, Services, and Service Instances
* Changed 'user.field.factory' to 'user.fieldFactory' to prevent a namespace collision with 'user.field.(type)'
* Calling 'insertField' in one case which I missed when adding the method
* Implemented 'hash', 'joinGroup', 'invalidateRights', 'writeProperties' and 'writeGroups'
* Changed Service/UserField.pm so that one user field class can be used for any category
* Added a 'username' convenience method and implemented 'write'
* Added a comment to Service/UserFieldFactory.pm explaining how it should work
* Removed the 'user.field.generic.generic' field implementation, replaced it with a simpler 'user.field.string' implementation
2001-05-28 20:09:23 +00:00
jake%acutex.net
bbb2c13524 Bug 79739 - Initial Owner and QA Contact were not being handled correctly by the email interface after they were changed to userid's in bug 66876.
r= justdave@syndicomm.com
2001-05-25 12:48:47 +00:00
jake%acutex.net
4cf2c59aa4 Mention the Bugzilla project page and where to report bugs
Patch by Matthew Tuck <matty@chariot.net.au>
r= justdave@syndicomm.com, jake@acutex.net
2001-05-24 12:58:33 +00:00
ian%hixie.ch
1ffb74226d Added some minor corrections and clarifications to the documentation.
Added some comments to various user-related files.
Factored out some code that started becoming common when inserting fields in Service/User.pm.
Added code to deal with adding new contact details.
Added code to support removing fields from a user.
2001-05-24 07:06:41 +00:00
timeless%mac.com
68152b8d2a 62446 extra spaces inside links on some lxr-generated pages
r=terry
2001-05-24 04:10:23 +00:00
timeless%mac.com
2ed9571632 45785 Swapped ALIGN/VALIGN attributes
39224 duplicate word on lxr.mozilla.org/ ("use use")
r=terry
2001-05-24 04:07:43 +00:00
jake%acutex.net
7d7408335b Bug 71552 - Remove oldemailtech from Bugzilla
r= justdave@syndicomm.com
2001-05-24 03:10:49 +00:00
ian%hixie.ch
d9c627c0b9 Started work on fleshing out the user components. This is still work in progress. 2001-05-14 06:45:08 +00:00
ian%hixie.ch
76a1624abe Initial checkin of the Field part of the User work. Just ideas at the moment, nothing here is implemented, and much of it is likely to change. 2001-05-13 20:54:35 +00:00
ian%hixie.ch
57c85fb025 First pass at adding User objects (derived from Session). Lots of XXX code -- none of this works, it's basically all stubs.
In addition to the code that actually does stuff, I still need to add a MySQL implementation of the data source and the Field class and its associated Factory.
Also added Passwords.pm (stubs for a password generator and encryptor) and made Session objects store a pointer to the controller object.
2001-05-13 18:11:54 +00:00
ian%hixie.ch
a47f424255 Added a bit more support for objects (as opposed to services): added a new objectCreate() constructor and an objectInit() method.
Added an optimisation to Controller.pm so that service names will be hashed once accessed. This should make multiple accesses of the same service a lot quicker. To go with this I added some diagnostics code (on exit) and moved the code around a little bit.
Fixed a minor transgression of the coding style guidelines in Magic*Array.pm. :-)
Neatened up the code in Output.pm.
Made it so Session objects assume they have an 'app' property, and so don't need to be passed $app all the time. (Sessions are objects now.)
Added an unimplemented getAddress() method to the Session class.
2001-05-13 18:04:52 +00:00
ian%hixie.ch
b211b52c46 fixing two rather serious (albeit simple) bugs in the strings data source; adding a comment to Input.pm in preparation for doing the user authentication stuff 2001-05-13 05:52:24 +00:00
justdave%syndicomm.com
66952b81d2 Fix for bug 38859: escape invalid email addresses for HTML before displaying to the user.
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net, justdave@syndicomm.com
2001-05-11 18:02:38 +00:00
justdave%syndicomm.com
c3637c7ac6 Fix for bug 80045: 500 Server Error in IE (but not Netscape or Mozilla) on errors looking up email addresses.
Patch by <jake@acutex.net>
r= justdave@syndicomm.com
2001-05-10 18:16:51 +00:00
justdave%syndicomm.com
08322c85b4 Fix for bug 38854: reports.cgi needs to escape (untrusted) url params
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net
2001-05-10 03:02:52 +00:00