Commit Graph

209 Commits

Author SHA1 Message Date
Brian Birtles
f666a95c80 Bug 1109390 part 8 - Rename Start* methods in AnimationPlayer to Trigger*; r=jwatt 2015-03-27 15:56:45 +09:00
Brian Birtles
f7d9eb1f72 Bug 1109390 part 7 - Rename PendingPlayerTracker's Start* methods to Trigger*; r=jwatt
These methods will soon be used to start animations that are waiting to start
and also to finish pausing animations that are waiting to pause. As a result
we rename them to TriggerXXX since that's a bit more generic.

There are still references to StartXXX within PendingPlayerTracker. These will
be updated in a subsequent patch once we have the appropriate methods available
on AnimationPlayer to call.
2015-03-27 15:56:45 +09:00
Brian Birtles
bf038e890e Bug 1109390 part 6 - Generalize PendingPlayerTracker to support pausing as well; r=jwatt
This patch extends the PendingPlayerTracker which is currently used to record
which animations are waiting to play, such that it can also handle animations
which are waiting to complete a pause operation.

It doesn't yet do anything with the pause-pending animations, that will come
in another patch.
2015-03-27 15:56:45 +09:00
Brian Birtles
6b062fb872 Bug 1109390 part 5 - Adjust tests to better handle asynchronous pausing; r=jwatt
A number of animation tests assume that pausing happens instantaneously. This
patch adjust many of those tests so that they will continue to work when
pausing happens asynchronously. In many cases this is possible because we
know the ready promise on AnimationPlayer (soon to be Animation) objects will
be resolved so we can wait on it and it will resolve immediately now, but when
asynchronous pausing is introduced the test the promise won't resolve until
after the pause operation is complete.

There are some tests that can't be so easily adjusted and we will have to fix
these at the same time as we turn on async pausing. However, taking care of
this set of tests now should reduce the size of subsequent patches in this
series.
2015-03-27 15:56:44 +09:00
Mason Chang
ae4567cd01 Bug 1145327 Part 2: Add test to ensure requestAnimationFrame callback timestamps always go forward in time. r=birtles,dholbert 2015-03-24 14:28:34 -07:00
Brian Birtles
511c419852 Bug 1109390 part 3 - Clear the start time when playing a player; r=jwatt
This brings us into line with the algorithm in:

  https://w3c.github.io/web-animations/#play-an-animation

which makes the other patches in this series easier to compare with
the specification.
2015-03-24 09:21:08 +09:00
Brian Birtles
988481e564 Bug 1109390 part 2 - Remove some unneeded startTime tests; r=jwatt
Now that we have separate tests for checking the initial state of startTime we
can remove these checks from tests for setting the startTime.

Also, while we're at it, we needn't check the playState and animationPlayState
since these should be covered by other tests.
2015-03-24 09:21:08 +09:00
Brian Birtles
f00da8e1e6 Bug 1109390 part 1 - Add tests for getting the startTime; r=jwatt 2015-03-24 09:21:07 +09:00
Cameron McCormack
a28a264c22 Bug 1145912 - Make single_transition_reversed and multiple_transitions more robust. r=birtles 2015-03-23 13:07:25 +11:00
Ehsan Akhgari
883849ee32 Bug 1145631 - Part 1: Replace MOZ_OVERRIDE and MOZ_FINAL with override and final in the tree; r=froydnj
This patch was automatically generated using the following script:

function convert() {
echo "Converting $1 to $2..."
find . \
       ! -wholename "*/.git*" \
       ! -wholename "obj-ff-dbg*" \
         -type f \
      \( -iname "*.cpp" \
         -o -iname "*.h" \
         -o -iname "*.c" \
         -o -iname "*.cc" \
         -o -iname "*.idl" \
         -o -iname "*.ipdl" \
         -o -iname "*.ipdlh" \
         -o -iname "*.mm" \) | \
    xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}

convert MOZ_OVERRIDE override
convert MOZ_FINAL final
2015-03-21 12:28:04 -04:00
Jonathan Watt
f7d5a879ea Bug 1127380, part 1 - Initial implementation of AnimationPlayer.playbackRate. r=birtles, r=smaug
--HG--
extra : rebase_source : 5b2dbefbcd986d7529d8567b7f068ac30ad6416e
2015-03-13 20:10:45 +00:00
L. David Baron
40bd226b51 Bug 1125455 patch 5 - Add Animation::GetAnimationOfProperty. r=birtles
This is needed for patch 6.
2015-03-19 21:10:00 -07:00
L. David Baron
c64617d10d Bug 1125455 patch 4 - For main-thread application of transitions, don't apply transitions when animations are also running. r=birtles
I've verified locally that this patch (not others in this series) fixes
the test failures that match the test changes in this patch.
2015-03-19 21:10:00 -07:00
L. David Baron
43ffda7be5 Bug 1125455 patch 1 - Add boolean for whether an animation of a property wins in the CSS cascade. r=birtles 2015-03-19 21:10:00 -07:00
Boris Zbarsky
dc24477d79 Bug 1117172 part 3. Change the wrappercached WrapObject methods to allow passing in aGivenProto. r=peterv
The only manual changes here are to BindingUtils.h, BindingUtils.cpp,
Codegen.py, Element.cpp, IDBFileRequest.cpp, IDBObjectStore.cpp,
dom/workers/Navigator.cpp, WorkerPrivate.cpp, DeviceStorageRequestChild.cpp,
Notification.cpp, nsGlobalWindow.cpp, MessagePort.cpp, nsJSEnvironment.cpp,
Sandbox.cpp, XPCConvert.cpp, ExportHelpers.cpp, and DataStoreService.cpp.  The
rest of this diff was generated by running the following commands:

  find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapObjectInternal\(JSContext *\* *(?:aCx|cx|aContext|aCtx|js))\)/\1, JS::Handle<JSObject*> aGivenProto)/g'

  find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapObjectInternal\((?:aCx|cx|aContext|aCtx|js))\)/\1, aGivenProto)/g'

  find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapNode\(JSContext *\* *(?:aCx|cx|aContext|aCtx|js))\)/\1, JS::Handle<JSObject*> aGivenProto)/g'

  find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapNode\((?:aCx|cx|aContext|aCtx|js))\)/\1, aGivenProto)/g'

  find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapObject\(JSContext *\* *(?:aCx|cx|aContext|aCtx|js))\)/\1, JS::Handle<JSObject*> aGivenProto)/g'

  find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(Binding(?:_workers)?::Wrap\((?:aCx|cx|aContext|aCtx|js), [^,)]+)\)/\1, aGivenProto)/g'
2015-03-19 10:13:33 -04:00
Carsten "Tomcat" Book
47fe95d629 Backed out 7 changesets (bug 1125455) for test failures in m1 test_animation-player-ready.html on a CLOSED TREE
Backed out changeset 8a316064caff (bug 1125455)
Backed out changeset ad326dbcbd03 (bug 1125455)
Backed out changeset 83dab9578e23 (bug 1125455)
Backed out changeset 5bd86c20cd02 (bug 1125455)
Backed out changeset 751177025dcb (bug 1125455)
Backed out changeset f60c5b4adf84 (bug 1125455)
Backed out changeset 326ef9a86c85 (bug 1125455)
2015-03-18 16:32:54 +01:00
L. David Baron
82ad97d447 Bug 1125455 patch 5 - Add Animation::GetAnimationOfProperty. r=birtles
This is needed for patch 6.
2015-03-18 07:35:30 -07:00
L. David Baron
8f015c4370 Bug 1125455 patch 4 - For main-thread application of transitions, don't apply transitions when animations are also running. r=birtles
I've verified locally that this patch (not others in this series) fixes
the test failures that match the test changes in this patch.
2015-03-18 07:35:30 -07:00
L. David Baron
065aeaa603 Bug 1125455 patch 1 - Add boolean for whether an animation of a property wins in the CSS cascade. r=birtles 2015-03-18 07:35:29 -07:00
Brian Birtles
807e40e6b9 Bug 1113425 part 4 - Enable test_deferred_start.html on all platforms; r=mattwoodrow 2015-03-17 18:38:12 +09:00
Brian Birtles
e3f0c2f97e Bug 1113425 part 3 - Make test_deferred_start.html wait an extra frame; r=mattwoodrow
This is needed to avoid intermittent failures on Mulet and B2G ICS Emulator.
2015-03-17 18:38:12 +09:00
Brian Birtles
80be8bcd01 Bug 1113425 part 1 - Fix some bad CSS comment syntax in animation tests; r=mattwoodrow 2015-03-17 18:38:12 +09:00
Cameron McCormack
df118d4a47 Bug 1143314 - Don't use very short transition/animation durations in test_animation_observers.html. r=birtles 2015-03-17 17:13:20 +11:00
L. David Baron
a8fa9e2011 Bug 1143314 - Temporary disable two tests that are frequently failing intermittently, added about 12 hours ago in bug 1123523, on a CLOSED TREE. 2015-03-14 10:20:27 -07:00
Cameron McCormack
c8f4387af1 Bug 1123523 - Part 10: Tests. r=birtles 2015-03-14 16:34:40 +11:00
Cameron McCormack
9d635d78ad Bug 1123523 - Part 9: Dispatch an nsIAnimationObserver notification when an animation is changed. r=birtles 2015-03-14 16:34:40 +11:00
Cameron McCormack
d648fe467f Bug 1123523 - Part 8: Dispatch nsIAnimationObserver notifications when an animation is added or removed. r=birtles 2015-03-14 16:34:40 +11:00
Cameron McCormack
7edb0d374f Bug 1123523 - Part 3: Store a flag on AnimationPlayer for whether it is exposed by Element.getAnimationPlayers(). r=birtles 2015-03-14 16:34:40 +11:00
Jonathan Griffin
d1c61bc9b6 Bug 1116187 - Disable failing mochitest-chrome tests for B2G, r=gbrown 2015-02-06 16:30:37 -08:00
Jonathan Watt
0e1b8d416c Bug 1072037, part 2 - Tests for the effect of setting CSS animation's AnimationPlayer.currentTime. r=birtles
--HG--
rename : dom/animation/test/css-animations/test_animation-player-starttime.html => dom/animation/test/css-animations/test_animation-player-currenttime.html
2015-03-09 16:50:39 +00:00
Jonathan Watt
39fe510f93 Bug 1072037, part 1 - Implement web-animations proceedure to 'set the current time' and make AnimationPlayer.startTime writeable. r=birtles, r=smaug 2015-03-09 16:50:39 +00:00
Jonathan Watt
d5681f75bf Bug 1070744 - Backout c482c88b0393 and c5d5202c3d72 for being attributed to this bug instead of bug 1072037. r=me, and faking r=smaug since backout 2015-03-11 15:28:07 +00:00
Jonathan Watt
5bffcdb7ca Bug 1070744, part 2 - Tests for the effect of setting CSS animation's AnimationPlayer.currentTime. r=birtles
--HG--
rename : dom/animation/test/css-animations/test_animation-player-starttime.html => dom/animation/test/css-animations/test_animation-player-currenttime.html
2015-03-09 16:50:39 +00:00
Jonathan Watt
f6effca850 Bug 1070744, part 1 - Implement web-animations proceedure to 'set the current time' and make AnimationPlayer.startTime writeable. r=birtles, r=smaug 2015-03-09 16:50:39 +00:00
Jonathan Watt
6fce4aa41e Bug 1073379, part 7 - Tests for the effect of setting a CSS transition's AnimationPlayer.startTime. r=birtles
--HG--
rename : dom/animation/test/css-animations/test_animation-player-starttime.html => dom/animation/test/css-transitions/test_animation-player-starttime.html
2015-03-06 15:23:17 +00:00
Jonathan Watt
21f90d17db Bug 1141710, part 14 - Get rid of the checks at 90% through the active duration. r=birtles 2015-03-05 13:07:20 +00:00
Jonathan Watt
cf99e48829 Bug 1141710, part 13 - Wrap all lines at the 80 column mark. r=birtles 2015-03-05 13:07:19 +00:00
Jonathan Watt
74ff18bb06 Bug 1141710, part 12 - Check that the hold time is updated when the startTime is set to null. r=birtles 2015-03-11 07:19:44 +00:00
Jonathan Watt
4e2bbb40b0 Bug 1141710, part 11 - Assert that seeking over the before and active phases worked. r=birtles 2015-03-05 13:07:19 +00:00
Jonathan Watt
8b770d6a97 Bug 1141710, part 10 - Update some assertion text and comments. r=birtles 2015-03-05 13:07:19 +00:00
Jonathan Watt
408721a5f1 Bug 1141710, part 9 - Get the timeline from the player instead of from the document. r=dholbert
--HG--
extra : rebase_source : 1d737817af45cdc5a55a9793dea248e70bc66cb3
2015-03-04 02:49:44 +00:00
Jonathan Watt
4ecf9b15a0 Bug 1141710, part 8 - Create helpers to get the startTime corresponding to various points through the active duration. r=dholbert
--HG--
extra : rebase_source : 77ce022fad96c8f9de09ba88e53473674b3b5d11
2015-03-04 02:49:43 +00:00
Jonathan Watt
0b2deb137c Bug 1141710, part 7 - Store the generated 'animation' property string in a global constant and reuse that constant. r=dholbert
--HG--
extra : rebase_source : 539673cc79c80f67043bd94e933fe54f24a25be1
2015-03-04 02:49:43 +00:00
Jonathan Watt
d4dc6c2561 Bug 1141710, part 7 - Create helpers to get the startTime corresponding to various points through the active duration. r=dholbert
--HG--
extra : rebase_source : 29ba71854e2f77cbb088dc5e3545c95ca242c6d7
2015-03-04 02:49:43 +00:00
Jonathan Watt
4f75f74035 Bug 1141710, part 5 - Change from assert_true() to the new assert_unreached(). r=dholbert
--HG--
extra : rebase_source : 5b12f7d32ff7f67af4cdc7fe1198153ab2775c8e
2015-03-04 02:49:43 +00:00
Jonathan Watt
e1211720f1 Bug 1141710, part 4 - Avoid race condition when taking timestamps by reusing the original timestamp. r=dholbert
--HG--
extra : rebase_source : a3eab56b57d605af01e5dc450b30a8aa7c77a417
2015-03-04 02:49:43 +00:00
Jonathan Watt
c8eaf51e66 Bug 1141710, part 3 - Stop using ECMAScript 6 features in test_animation-player-starttime.html, since other browsers don't support them. r=dholbert
--HG--
extra : rebase_source : 7886c2f67f84b2547b2fdd6d08f6db88684bfba4
2015-03-04 02:49:43 +00:00
Jonathan Watt
6d6eb9d3d9 Bug 1141710, part 2 - Update comments to be non-Mozilla specific. r=dholbert
--HG--
extra : rebase_source : f8104546849e7d213b70eac66fc75f51e27749f0
2015-03-04 02:49:43 +00:00
Jonathan Watt
f8f1365639 Bug 1141710, part 1 - Update to the new version of addDiv() in testcommon.js. r=dholbert
--HG--
extra : rebase_source : 0366f678e6075d4d929a5cc0a25d217215108ee7
2015-03-04 02:49:43 +00:00
Jonathan Watt
008986f33d Bug 1141498, part 2 - Enable calls to DOM animation test's testcommon.js's addDiv() to set attributes. r=dholbert
--HG--
extra : rebase_source : 807b3f7cd65c7611f8b8c2d0582fa65a9008fbef
2015-03-04 02:49:43 +00:00