Commit Graph

42 Commits

Author SHA1 Message Date
Kershaw Chang
b65ed86652 Bug 1301259 - Part2: Close the connected/connecting connection before starting reconnecting, r=smaug 2016-09-28 23:35:00 +02:00
Kershaw Chang
6c373070a1 Bug 1228474 - Support sending blob/arraybuffer for data channel. r=smaug 2016-09-17 19:42:00 -04:00
Kershaw Chang
5bb5c52b40 Bug 1299040 - Implement transport builder constructor. r=smaug 2016-09-16 08:59:00 -04:00
Phil Ringnalda
069b27b0aa Backed out changeset e684bf18e5d9 (bug 1299040) for bad implicit conversion constructor bustage
CLOSED TREE
2016-09-15 19:31:32 -07:00
Kershaw Chang
048198ad45 Bug 1299040 - Implement transport builder constructor. r=smaug 2016-09-15 07:09:00 -04:00
Shih-Chiang Chien
db74baa4e1 Bug 1264110 - fix timing issue in test cases. r=kershaw.
MozReview-Commit-ID: 2Ia4L7EizrA

--HG--
extra : rebase_source : dda92d84e51a124d5820176d36cada7c20bfad2e
2016-09-05 18:18:11 +08:00
Nicholas Nethercote
34dcc7b852 Bug 1299384 - Use MOZ_MUST_USE with NS_warn_if_impl(). r=erahm.
This change avoids lots of false positives for Coverity's CHECKED_RETURN
warning, caused by NS_WARN_IF's current use in both statement-style and
expression-style.

In the case where the code within the NS_WARN_IF has side-effects, I made the
following change.

> NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));
> -->
> Unused << NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));

In the case where the code within the NS_WARN_IF lacks side-effects, I made the
following change.

> NS_WARN_IF(!condWithoutSideEffects);
> -->
> NS_WARNING_ASSERTION(condWithoutSideEffects, "msg");

This has two improvements.
- The condition is not evaluated in non-debug builds.
- The sense of the condition is inverted to the familiar "this condition should
  be true" sense used in assertions.

A common variation on the side-effect-free case is the following.

> nsresult rv = Fn();
> NS_WARN_IF_(NS_FAILED(rv));
> -->
> DebugOnly<nsresult rv> = Fn();
> NS_WARNING_ASSERTION(NS_SUCCEEDED(rv), "Fn failed");

--HG--
extra : rebase_source : 58788245021096efa8372a9dc1d597a611d45611
2016-09-02 17:12:24 +10:00
Kershaw Chang
9eedf3c0a7 Bug 1295063 - Send reconnect command when NotifyConnected. r=smaug
--HG--
extra : rebase_source : e6ef7aa0852dbbb7de3214d38ca77899cb60f042
2016-08-16 19:32:00 -04:00
Shih-Chiang Chien
240af6bcf8 Bug 1284188 - use nsINetworkInfoService to obtain self IP address. r=smaug.
MozReview-Commit-ID: 1QwjrkV9cEk

--HG--
extra : rebase_source : 2aa7c8620505074aeba012de358d56edf0dc2af5
2016-08-12 15:27:33 +08:00
Shih-Chiang Chien
a99142a2c5 Bug 1287717 - Part 2, close receiver page while loading fail. r=smaug.
MozReview-Commit-ID: Dogham2LmHG
2016-08-04 09:46:14 +08:00
Kershaw Chang
4f5b2c7d11 Bug 1197690 - Part2: Implement reconnect, r=smaug
--HG--
extra : rebase_source : b40f774b3af223910da37094b2f82bfc5b8b92d2
2016-08-02 19:11:00 +02:00
Shih-Chiang Chien
d75d9bf8c4 Bug 1276378 - Part 2: Implement PresentationConnection.terminate(). r=smaug
MozReview-Commit-ID: 7GqgIdsuM3f

--HG--
extra : rebase_source : 8a860c6bf0aa103eda26d175548256c1d619ce19
2016-06-14 08:15:07 +01:00
Junior Hsu
64ded9c3d1 Bug 1264513 - Part 2: PPresentationBuilder.ipdl changes - OOP handling for builder, r=smaug 2016-06-03 14:48:26 +08:00
Junior Hsu
60de51a4c5 Bug 1264513 - Part 1: IPresentationSessionTransportBuilder.idl changes - necessary refactory in in-proc data channel handling, r=smaug 2016-06-03 14:48:26 +08:00
Kershaw Chang
7649e6aa87 Bug 1258600 - Part2: Implement onconnect, onclose and onterminate event handlers, r=smaug 2016-05-30 08:48:00 +02:00
Kershaw Chang
9cbfe7debc Bug 1258602 - Part3: Changes for making the initial state to “connecting”, r=smaug 2016-05-29 23:01:00 +02:00
Kershaw Chang
70abe8c5e3 Bug 1258602 - Part1: Add PresentationConnectionList, r=smaug 2016-05-29 19:59:00 +02:00
KuoE0
846c1e60ec Bug 1234492 - Part 1 - Add direction in PresentationService, r=smaug
Conflicts:
	dom/presentation/PresentationConnection.cpp
	dom/presentation/PresentationService.cpp
	dom/presentation/interfaces/nsIPresentationService.idl
	dom/presentation/ipc/PPresentation.ipdl
	dom/presentation/ipc/PresentationIPCService.cpp
	dom/presentation/ipc/PresentationParent.cpp

--HG--
extra : rebase_source : c592a64c13113cc323a18a68c103faaa7614d314
2016-04-18 02:19:00 +02:00
Ryan VanderMeulen
2fea4e0c11 Backed out 3 changesets (bug 1234492) for frequent OSX test_presentation_dc_receiver.html failures.
Backed out changeset 94ec70bf8c22 (bug 1234492)
Backed out changeset ac0e65743b5d (bug 1234492)
Backed out changeset 801cac365dd9 (bug 1234492)
2016-04-24 18:50:55 -04:00
KuoE0
e5175b9483 Bug 1234492 - Part 1: Add direction in PresentationService. r=smaug
--HG--
extra : rebase_source : 56c30d5565e5875b2f30f8f07fad01f91a15f0f0
extra : histedit_source : 7273fb211f9656ab0487301227b3d6361644b7e8
2015-11-27 16:06:32 +08:00
Junior Hsu
fce48d6554 Bug 1148307 - Part 4, use data channel in substitution for TCP session transport (in-process), r=smaug
--HG--
rename : dom/presentation/tests/mochitest/test_presentation_receiver.html => dom/presentation/tests/mochitest/test_presentation_tcp_receiver.html
rename : dom/presentation/tests/mochitest/test_presentation_receiver_establish_connection_error.html => dom/presentation/tests/mochitest/test_presentation_tcp_receiver_establish_connection_error.html
rename : dom/presentation/tests/mochitest/test_presentation_receiver_establish_connection_timeout.html => dom/presentation/tests/mochitest/test_presentation_tcp_receiver_establish_connection_timeout.html
rename : dom/presentation/tests/mochitest/test_presentation_receiver_oop.html => dom/presentation/tests/mochitest/test_presentation_tcp_receiver_oop.html
rename : dom/presentation/tests/mochitest/test_presentation_sender.html => dom/presentation/tests/mochitest/test_presentation_tcp_sender.html
rename : dom/presentation/tests/mochitest/test_presentation_sender_default_request.html => dom/presentation/tests/mochitest/test_presentation_tcp_sender_default_request.html
rename : dom/presentation/tests/mochitest/test_presentation_sender_disconnect.html => dom/presentation/tests/mochitest/test_presentation_tcp_sender_disconnect.html
rename : dom/presentation/tests/mochitest/test_presentation_sender_establish_connection_error.html => dom/presentation/tests/mochitest/test_presentation_tcp_sender_establish_connection_error.html
extra : rebase_source : 01a976ea5c73abcc15b86594b97eed7aff57a95b
2016-04-11 11:20:55 +08:00
Junior Hsu
5888006d05 Bug 1148307 - Part 2, let session transport send DOM string. r=smaug
--HG--
extra : rebase_source : 33b444a23d3a0b94d1830849d948156323ec8557
2016-04-11 11:20:55 +08:00
Junior Hsu
f215592724 Bug 1148307 - Part1, separate object bruilder from nsIPresentationSessionTransport, r=smaug
--HG--
rename : dom/presentation/PresentationSessionTransport.cpp => dom/presentation/PresentationTCPSessionTransport.cpp
rename : dom/presentation/PresentationSessionTransport.h => dom/presentation/PresentationTCPSessionTransport.h
extra : rebase_source : 6da6bde55ed99a07a22f6cd2ec509fe2b6578201
2015-09-24 16:16:47 +08:00
Sebastian Hengst
f17e7a91b7 Backed out changeset 17dfb6404d37 (bug 1148307) for OS X build bustage. r=backout on a CLOSED TREE
--HG--
rename : dom/presentation/PresentationTCPSessionTransport.cpp => dom/presentation/PresentationSessionTransport.cpp
rename : dom/presentation/PresentationTCPSessionTransport.h => dom/presentation/PresentationSessionTransport.h
2016-04-11 13:12:34 +02:00
Sebastian Hengst
ae9f706ab7 Backed out changeset dfe4cc7062d1 (bug 1148307) 2016-04-11 13:12:26 +02:00
Sebastian Hengst
3e646cbd97 Backed out changeset 3cb658c3e3f9 (bug 1148307)
--HG--
rename : dom/presentation/tests/mochitest/test_presentation_tcp_receiver.html => dom/presentation/tests/mochitest/test_presentation_receiver.html
rename : dom/presentation/tests/mochitest/test_presentation_tcp_receiver_establish_connection_error.html => dom/presentation/tests/mochitest/test_presentation_receiver_establish_connection_error.html
rename : dom/presentation/tests/mochitest/test_presentation_tcp_receiver_establish_connection_timeout.html => dom/presentation/tests/mochitest/test_presentation_receiver_establish_connection_timeout.html
rename : dom/presentation/tests/mochitest/test_presentation_tcp_receiver_oop.html => dom/presentation/tests/mochitest/test_presentation_receiver_oop.html
rename : dom/presentation/tests/mochitest/test_presentation_tcp_sender.html => dom/presentation/tests/mochitest/test_presentation_sender.html
rename : dom/presentation/tests/mochitest/test_presentation_tcp_sender_default_request.html => dom/presentation/tests/mochitest/test_presentation_sender_default_request.html
rename : dom/presentation/tests/mochitest/test_presentation_tcp_sender_disconnect.html => dom/presentation/tests/mochitest/test_presentation_sender_disconnect.html
rename : dom/presentation/tests/mochitest/test_presentation_tcp_sender_establish_connection_error.html => dom/presentation/tests/mochitest/test_presentation_sender_establish_connection_error.html
2016-04-11 13:12:13 +02:00
Junior Hsu
a8a1aaba30 Bug 1148307 - Part 4 - use data channel in substitution for TCP session transport (in-process), r=smaug
--HG--
rename : dom/presentation/tests/mochitest/test_presentation_receiver.html => dom/presentation/tests/mochitest/test_presentation_tcp_receiver.html
rename : dom/presentation/tests/mochitest/test_presentation_receiver_establish_connection_error.html => dom/presentation/tests/mochitest/test_presentation_tcp_receiver_establish_connection_error.html
rename : dom/presentation/tests/mochitest/test_presentation_receiver_establish_connection_timeout.html => dom/presentation/tests/mochitest/test_presentation_tcp_receiver_establish_connection_timeout.html
rename : dom/presentation/tests/mochitest/test_presentation_receiver_oop.html => dom/presentation/tests/mochitest/test_presentation_tcp_receiver_oop.html
rename : dom/presentation/tests/mochitest/test_presentation_sender.html => dom/presentation/tests/mochitest/test_presentation_tcp_sender.html
rename : dom/presentation/tests/mochitest/test_presentation_sender_default_request.html => dom/presentation/tests/mochitest/test_presentation_tcp_sender_default_request.html
rename : dom/presentation/tests/mochitest/test_presentation_sender_disconnect.html => dom/presentation/tests/mochitest/test_presentation_tcp_sender_disconnect.html
rename : dom/presentation/tests/mochitest/test_presentation_sender_establish_connection_error.html => dom/presentation/tests/mochitest/test_presentation_tcp_sender_establish_connection_error.html
2016-04-11 11:20:55 +08:00
Junior Hsu
248ceef0ca Bug 1148307 - Part 2 - let session transport send DOM string. r=smaug 2016-04-11 11:20:55 +08:00
Junior Hsu
d6cfc97f77 Bug 1148307 - Part1 - separate object bruilder from nsIPresentationSessionTransport, r=smaug
--HG--
rename : dom/presentation/PresentationSessionTransport.cpp => dom/presentation/PresentationTCPSessionTransport.cpp
rename : dom/presentation/PresentationSessionTransport.h => dom/presentation/PresentationTCPSessionTransport.h
2015-09-24 16:16:47 +08:00
Nathan Froyd
c381a6b86c Bug 1218454 - part 2 - don't #include nsContentUtils.h from CallbackObject.h; r=bz
We used to need nsContentUtils.h here for nsCxPusher, but since that got
moved to ScriptSettings.h, we no longer need nsContentUtils.h for
anything.
2015-10-26 12:14:47 -04:00
Liang-Heng Chen
0727e1ae3e Bug 1205237 - Part 3: get self Wi-Fi IP address; r=seanlin 2015-10-21 07:53:00 +02:00
Carsten "Tomcat" Book
bdf50df75e Backed out changeset b47029d8d419 (bug 1205237) 2015-10-21 11:14:48 +02:00
Liang-Heng Chen
1388286814 Bug 1205237 - Part 3: get self Wi-Fi IP address; r=seanlin
--HG--
extra : rebase_source : b86c2f05e6f0bf6389864e5a2b36756c08afef0b
2015-10-20 02:32:00 +02:00
Nathan Froyd
01583602a9 Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat
The bulk of this commit was generated with a script, executed at the top
level of a typical source code checkout.  The only non-machine-generated
part was modifying MFBT's moz.build to reflect the new naming.

CLOSED TREE makes big refactorings like this a piece of cake.

 # The main substitution.
find . -name '*.cpp' -o -name '*.cc' -o -name '*.h' -o -name '*.mm' -o -name '*.idl'| \
    xargs perl -p -i -e '
 s/nsRefPtr\.h/RefPtr\.h/g; # handle includes
 s/nsRefPtr ?</RefPtr</g;   # handle declarations and variables
'

 # Handle a special friend declaration in gfx/layers/AtomicRefCountedWithFinalize.h.
perl -p -i -e 's/::nsRefPtr;/::RefPtr;/' gfx/layers/AtomicRefCountedWithFinalize.h

 # Handle nsRefPtr.h itself, a couple places that define constructors
 # from nsRefPtr, and code generators specially.  We do this here, rather
 # than indiscriminantly s/nsRefPtr/RefPtr/, because that would rename
 # things like nsRefPtrHashtable.
perl -p -i -e 's/nsRefPtr/RefPtr/g' \
     mfbt/nsRefPtr.h \
     xpcom/glue/nsCOMPtr.h \
     xpcom/base/OwningNonNull.h \
     ipc/ipdl/ipdl/lower.py \
     ipc/ipdl/ipdl/builtin.py \
     dom/bindings/Codegen.py \
     python/lldbutils/lldbutils/utils.py

 # In our indiscriminate substitution above, we renamed
 # nsRefPtrGetterAddRefs, the class behind getter_AddRefs.  Fix that up.
find . -name '*.cpp' -o -name '*.h' -o -name '*.idl' | \
    xargs perl -p -i -e 's/nsRefPtrGetterAddRefs/RefPtrGetterAddRefs/g'

if [ -d .git ]; then
    git mv mfbt/nsRefPtr.h mfbt/RefPtr.h
else
    hg mv mfbt/nsRefPtr.h mfbt/RefPtr.h
fi

--HG--
rename : mfbt/nsRefPtr.h => mfbt/RefPtr.h
2015-10-18 01:24:48 -04:00
Sean Lin
fb882d073c Bug 1205219 - [Presentation WebAPI] Support terminate semantics. Part 1 - WebIDL & implementation changes. r=smaug 2015-10-08 18:11:10 +08:00
Sean Lin
258942501c Bug 1192101 - Part 4 -Support PresentationRequest / PresentationAvailability / getSession(s). Part 4 - Rename PresentationSessionInfo relevant classes. r=smaug 2015-09-09 17:41:55 +08:00
Sean Lin
16cb2d0274 Bug 1192727 - Improve the way that Presentation receiver gets the ID of the incoming session. r=smaug
--HG--
extra : histedit_source : 9ca69ab5fb5b440050bf6cd9e9e95242d31c2b27
2015-08-31 13:24:35 +08:00
Sean Lin
1efa4382a3 Bug 1069230 - Presentation API implementation. Part 8 - Data transport channel. r=jdm 2015-04-22 16:01:38 +08:00
Sean Lin
4e9ad23c31 Bug 1069230 - Presentation API implementation. Part 6 - mozChromeEvent for app launch. r=fabrice r=smaug 2015-03-30 15:48:11 +08:00
Sean Lin
4eb814cda5 Bug 1069230 - Presentation API implementation. Part 5 - Establish session (receiver). r=smaug 2015-03-30 15:46:11 +08:00
Sean Lin
0a8b5f2ba1 Bug 1069230 - Presentation API implementation. Part 4 - Establish session (sender) & available changes. r=smaug 2015-03-30 14:27:27 +08:00
Sean Lin
ffb77b7af4 Bug 1069230 - Presentation API implementation. Part 2 - Presentation service and listeners. r=smaug 2015-03-25 19:47:56 +08:00