This was a little tricky to get right. The "spin the event loop" bit is weird
but doing a setTimout to call resolve is already redundant since resolve calls
the promise callbacks on the next turn of the event loop anyway. Basically,
the test just needed to move more stuff to the content process.
MozReview-Commit-ID: KrZZU5reJf7
--HG--
extra : rebase_source : 0817cdefc2e3941a5f59e3e8365d72395d8c4869
There are a series of tests strewn about the tree that seem to exercise window
opening in one form or another, so I thought I'd put them under a tag.
MozReview-Commit-ID: 74JwLUTzaMU
--HG--
extra : rebase_source : 87439bacd9643ab63d015f58f44af2f8a74675a0
extra : source : 9d903a6a12aa7182252ec3e220c89b569c14e11b
There are a series of tests strewn about the tree that seem to exercise window
opening in one form or another, so I thought I'd put them under a tag.
MozReview-Commit-ID: 74JwLUTzaMU
--HG--
extra : rebase_source : 0c92084914ffe44a781f034b2416e17905656607
- the test case was failing because of an additional error message which is logged only on DevEdition.
- this patch makes the assertions on the cached messages more resilient to this kind of changes in the logged messages, by filtering the cached messages and then making assertions on the length of the messages found.
MozReview-Commit-ID: GIPOkWzM9Bo
--HG--
extra : rebase_source : ba0b92859105afcc6f2101a95e74b99b5a3f9aae
Previously, every test and support file would be synced to the objdir
when running any test. Now that only those support files and tests requested
are synced, we note support files required beyond those in a test's
directory in ini manifests.
MozReview-Commit-ID: EmlDz9d4lqt
Save the originAttributes of the current principal into the console events,
so that we can filter the console messages by originAttributes (e.g.
WebExtensions console events can be filtered using the addonId that the
ExtensionPages' originAttributes contain.
MozReview-Commit-ID: 5v9BWLbgskd
--HG--
extra : transplant_source : %2C%A1%D4%8AEp%E6G%8A%2C%DA%A8%EE%B3%EA%0E%84xk%FF
This will make sure that window.scrollbars correctly reflects the respective
chrome flags in e10s mode.
We also update nsXULWindow::SetContentScrollbarVisibility() to the new
nsContentUtils helper. That code is responsible for doing this work in the
single process case.
This will make sure that window.scrollbars correctly reflects the respective
chrome flags in e10s mode.
We also update nsXULWindow::SetContentScrollbarVisibility() to the new
nsContentUtils helper. That code is responsible for doing this work in the
single process case.
The timeout timer of a geolocation request holds a strong reference to
the request. This can cause the window to leak if the request is not
completed before the tab containing the window is closed.
To fix this, I made the timer instead hold a strong reference to a
wrapper class that has only a weak reference to the request. The
request destructor must now cancel the timeout timer.
I also outlined a call to StopTimeoutTimer() in
nsGeolocationRequest::Shutdown().
The timeout timer of a geolocation request holds a strong reference to
the request. This can cause the window to leak if the request is not
completed before the tab containing the window is closed.
To fix this, I made the timer instead hold a strong reference to a
wrapper class that has only a weak reference to the request. The
request destructor must now cancel the timeout timer.
I also outlined a call to StopTimeoutTimer() in
nsGeolocationRequest::Shutdown().