Commit Graph

389 Commits

Author SHA1 Message Date
Eitan Isaacson
f80fe575c5 Bug 1672694 - P2: Don't fire AXSelectedTextChanged if target is not selectable. r=morgan
This causes VoiceOver to mess with `AXFocused` and as a result redirect the VO cursor.

Differential Revision: https://phabricator.services.mozilla.com/D95784
2020-11-04 00:26:27 +00:00
Eitan Isaacson
33d5e972fd Bug 1674196 - Don't return children columns in layout tables. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D95228
2020-10-30 04:42:18 +00:00
Eitan Isaacson
ef1779b14c Bug 1672776 - Return nil TextMarker(Range) if GeckoTextMarker(Range) is invalid. r=morgan
It seems like the GeckoTextMarker::Range can sometimes return invalid ranges.
We need to check if they are valid or not before marshalling them.

Differential Revision: https://phabricator.services.mozilla.com/D95230
2020-10-30 04:41:20 +00:00
Eitan Isaacson
617e00d069 Bug 1672803 - Add AXMozDebugDescription and override NSObject description when logging. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D94473
2020-10-28 20:22:02 +00:00
Ricky Stewart
02a7b4ebdf Bug 1654103: Standardize on Black for Python code in mozilla-central.
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-26 18:34:53 +00:00
Bogdan Tara
da1098d4aa Backed out 10 changesets (bug 1654103, bug 1672023, bug 1518999) for PanZoomControllerTest.touchEventForResult gv-junit failures CLOSED TREE
Backed out changeset ff3fb0b4a512 (bug 1672023)
Backed out changeset e7834b600201 (bug 1654103)
Backed out changeset 807893ca8069 (bug 1518999)
Backed out changeset 13e6b92440e9 (bug 1518999)
Backed out changeset 8b2ac5a6c98a (bug 1518999)
Backed out changeset 575748295752 (bug 1518999)
Backed out changeset 65f07ce7b39b (bug 1518999)
Backed out changeset 4bb80556158d (bug 1518999)
Backed out changeset 8ac8461d7bd7 (bug 1518999)
Backed out changeset e8ba13ee17f5 (bug 1518999)
2020-10-24 03:36:18 +03:00
Ricky Stewart
c0cea3b0fa Bug 1654103: Standardize on Black for Python code in mozilla-central. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-23 20:40:42 +00:00
Eitan Isaacson
0e6061d30d Bug 1672243 - Introduce AXIndexForChildUIElement and implement AXTopLevelUIElement. r=MarcoZ
AXTopLevelUIElement is not really testable because it doesn't give a useful result in
headless mode. Since it is a clone of AXWindow, this shouldn't be much of an issue.

Differential Revision: https://phabricator.services.mozilla.com/D94154
2020-10-22 17:12:39 +00:00
Dorel Luca
1ff59cb7a3 Backed out changeset 7558c8821a07 (bug 1654103) for multiple failures. CLOSED TREE 2020-10-22 03:51:06 +03:00
Ricky Stewart
50762dacab Bug 1654103: Standardize on Black for Python code in mozilla-central. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-21 21:27:27 +00:00
Morgan Reschenberg
c5ff480218 Bug 1668101: Support same/different type naviagation with VO r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D91833
2020-10-15 16:42:14 +00:00
Eitan Isaacson
2e476d423a Bug 1671049 - Invalidate cached ARIA role and role in mozAccessible when role changes. r=morgan
Besides the ARIA role invalidation, this fixes an issue where the mozAccessible's role is also incorrect when the aria role changes on a body tag.

Depends on D93439

Differential Revision: https://phabricator.services.mozilla.com/D93440
2020-10-14 00:04:49 +00:00
Eitan Isaacson
c548ecd683 Bug 1671049 - Cache proxy ARIA role in mozAccessible. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D93439
2020-10-14 00:04:54 +00:00
Eitan Isaacson
7a572196df Bug 1669821 - Implement search predicate API on virtual root. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D92820
2020-10-07 20:34:21 +00:00
Eitan Isaacson
f050b91638 Bug 1669599 - Support AXEditableAncestor and make it text event target. r=morgan
Depends on D92689

Differential Revision: https://phabricator.services.mozilla.com/D92690
2020-10-07 00:13:34 +00:00
Eitan Isaacson
c173a1f486 Bug 1669596 - Allow subdoc GeckoTextMarker to be demarshalled in top document. r=morgan
Depends on D92688

Differential Revision: https://phabricator.services.mozilla.com/D92689
2020-10-06 23:31:32 +00:00
Eitan Isaacson
16d2fdfadc Bug 1669595 - Use top AXWebArea as text event source. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D92688
2020-10-07 18:38:52 +00:00
Eitan Isaacson
029b948f0c Bug 1668958 - Don't wrap to first word when getting right word at end of input. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D92310
2020-10-06 22:19:13 +00:00
Eitan Isaacson
10dfa8214c Bug 1668936 - Return element when calling AXUIElementForTextMarker in entry. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D92309
2020-10-06 22:19:11 +00:00
Eitan Isaacson
7293c05ee8 Bug 1668933 - Fix get previous marker outside of entry. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D92308
2020-10-06 22:19:03 +00:00
Eitan Isaacson
bacf4042da Bug 1668961 - Avoid 2 IPC round trips in moxStringForTextMarkerRange. r=morgan
The state checking can happen in the iterator in HyperTextAccessibleWrap.

Differential Revision: https://phabricator.services.mozilla.com/D92307
2020-10-06 22:18:56 +00:00
Morgan Reschenberg
bff9a869c8 Bug 1666380: Add support for AXTextFieldSearchKey to VO rotor r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D90941
2020-10-06 18:50:31 +00:00
Eitan Isaacson
68fd6a3f35 Bug 1669359 - Fix GeckoTextMarker lesser-than operator. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D92511
2020-10-06 17:24:19 +00:00
Eitan Isaacson
7ae60f9637 Bug 1669294 - Add debug description attributes for text marker and range. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D92472
2020-10-05 21:58:57 +00:00
Morgan Reschenberg
75caa1c350 Bug 1668655: Add support for AXGraphicSearchKey r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D92144
2020-10-05 19:52:15 +00:00
Morgan Reschenberg
3445c53c34 Bug 1668653: Add support for navigating by heading level with VO r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D92136
2020-10-05 19:52:15 +00:00
Morgan Reschenberg
8ea7a5cbaf Bug 1668663: Add support for navigation by blockquote r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D92145
2020-10-05 19:52:09 +00:00
Eitan Isaacson
96fe811eb7 Bug 1668142 - Support AXDirectionPrevious in rotor with no start element. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D91878
2020-10-02 16:33:42 +00:00
Eitan Isaacson
e3bbc94ed8 Bug 1668137 - Use search root for rule's aDirectDescendantsFrom argument. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D91875
2020-10-02 16:33:34 +00:00
Butkovits Atila
6a98c9beb2 Backed out 2 changesets (bug 1668142, bug 1668137) for build bustage on MOXSearchInfo.mm. CLOSED TREE
Backed out changeset 05c9cc6dd872 (bug 1668142)
Backed out changeset 4c62dd862ae3 (bug 1668137)
2020-10-02 03:53:25 +03:00
Eitan Isaacson
34f9d53bb7 Bug 1668142 - Support AXDirectionPrevious in rotor with no start element. r=morgan
Depends on D91875

Differential Revision: https://phabricator.services.mozilla.com/D91878
2020-10-01 18:55:57 +00:00
Eitan Isaacson
f4182287b4 Bug 1668137 - Use search root for rule's aDirectDescendantsFrom argument. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D91875
2020-10-01 18:56:52 +00:00
Morgan Reschenberg
671ed0bc10 Bug 1665960: Add AXStaticTextSearchKey support r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D90746
2020-09-29 23:39:49 +00:00
Eitan Isaacson
474e7874b9 Bug 1667262 - Add AXStyleTextMarkerRangeForTextMarker. r=morgan
Depends on D91357

Differential Revision: https://phabricator.services.mozilla.com/D91850
2020-09-29 23:25:35 +00:00
Eitan Isaacson
a77a63afc1 Bug 1667218 - Introduce AXParagraphTextMarkerRangeForTextMarker. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D91357
2020-09-29 21:00:05 +00:00
Eitan Isaacson
1e470443ea Bug 1668100 - Make target root for AXUIElementsForSearchPredicate. r=morgan
Instead of having the web area be the implicit root, the search results should
exclusively be descendants of the target element that the search is called on.

Differential Revision: https://phabricator.services.mozilla.com/D91826
2020-09-29 20:49:29 +00:00
Morgan Reschenberg
1c31973d81 Bug 1666356: Add support for AXCheckboxSearchKey to VO rotor r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D91169
2020-09-29 18:48:34 +00:00
Morgan Reschenberg
c1ac0d9327 Bug 1666357: Add AXRadioGroupSearchKey support to VO rotor
Differential Revision: https://phabricator.services.mozilla.com/D90922
2020-09-28 22:32:05 +00:00
Morgan Reschenberg
39d40dbb3f Bug 1667174: Create RotorRule base class to abstract checks duplicated across current rotor rules r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D91325
2020-09-28 22:32:07 +00:00
Cosmin Sabou
25fe081468 Backed out 3 changesets (bug 1665962, bug 1666357, bug 1667174) for OS X bustages on MOXSearchInfo.mm and conflicts on browser_rotor.js. CLOSED TREE
Backed out changeset 495a69dcd720 (bug 1665962)
Backed out changeset 9cdbf4e04e19 (bug 1666357)
Backed out changeset 0d9d32b08317 (bug 1667174)
2020-09-28 22:18:32 +03:00
Morgan Reschenberg
11491354e7 Bug 1666357: Add AXRadioGroupSearchKey support to VO rotor
Differential Revision: https://phabricator.services.mozilla.com/D90922
2020-09-28 18:16:10 +00:00
Morgan Reschenberg
b9b1c5400f Bug 1667174: Create RotorRule base class to abstract checks duplicated across current rotor rules r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D91325
2020-09-28 18:16:10 +00:00
Razvan Maries
e146bab5ce Backed out 4 changesets (bug 1665962, bug 1666356, bug 1666380, bug 1665960) for perma failure on browser_content_tree.js and browser_treeupdate_list.js. CLOSED TREE
Backed out changeset 29f8600da112 (bug 1666380)
Backed out changeset f01adb0a0e05 (bug 1666356)
Backed out changeset bed1c58441de (bug 1665960)
Backed out changeset 65d6078a5314 (bug 1665962)
2020-09-24 22:18:08 +03:00
Morgan Reschenberg
f42da71073 Bug 1666380: Add support for AXTextFieldSearchKey to VO rotor r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D90941
2020-09-23 21:19:31 +00:00
Morgan Reschenberg
1840888b31 Bug 1666356: Add support for AXCheckboxSearchKey to VO rotor r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D91169
2020-09-23 21:20:08 +00:00
Morgan Reschenberg
fd938aacbb Bug 1665960: Add AXStaticTextSearchKey support r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D90746
2020-09-22 23:31:41 +00:00
Eitan Isaacson
1080fb58d3 Bug 1661760 - Part 3: Add line boundary support in mac. r=morgan
The left and right line getters don't seem to be used often by voiceover,
so I am not sure if they always return the expected result.

Differential Revision: https://phabricator.services.mozilla.com/D90938
2020-09-24 16:04:56 +00:00
Eitan Isaacson
10d6dd02bc Bug 1661760 - Part 1: Unify all range from offset methods to one. r=morgan,nika
There are at least 8 different methods for getting a range from an offset:
1. left word
2. right word
3. line
4. left line
5. right line
6. sentence
7. paragraph
8. range with same style.

Having a single wrapper and IPDL method for all of those with an enum would remove
a lot of redundancies.

Differential Revision: https://phabricator.services.mozilla.com/D90936
2020-09-24 16:04:41 +00:00
Morgan Reschenberg
a5ce9d8bd3 Bug 1666348: Add support for AXListSearchKey to VO rotor r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D90917
2020-09-21 23:15:33 +00:00
Eitan Isaacson
4777d9b2a2 Bug 1661765 - Part 4: Implement AXSelectedTextMarkerRange setter. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D90594
2020-09-21 22:00:08 +00:00