Commit Graph

118 Commits

Author SHA1 Message Date
Tom Ritter
701ee70a22 Bug 1406687 Pass return values from fwrite to Unused to silence the warn-unused-result warning r=njn
MozReview-Commit-ID: 4v6tPF5aMz7

--HG--
extra : rebase_source : fe434db73a8da686391462c12b91648348abcdc9
2017-10-09 15:01:48 -05:00
JW Wang
acb1219279 Bug 1406821 - improve error logging to facilitate debugging mochitest timeouts in OPT builds. r=kinetik
MozReview-Commit-ID: KTmGRueZkxF

--HG--
extra : rebase_source : f6eb1fcdf9cda7cb6b9e8610c567451111386686
extra : intermediate-source : f06e68706b55b602ccb650641da8186bf74ad1a3
extra : source : 1ad5c0d65ecc4875bd5dc388606bf42e363f9353
2017-10-09 10:18:37 +08:00
Sebastian Hengst
ee63f2e30a Backed out changeset 0317bcff40bc (bug 1406687) for build bustage at testing/gtest/gtest/src/gtest.cc:3871: 'Unused' was not declared in this scope. r=backout 2017-10-09 18:52:39 +02:00
Tom Ritter
22d2cdf063 Bug 1406687 Pass return values from fwrite to Unused to silence the warn-unused-result warning r=njn
MozReview-Commit-ID: 4v6tPF5aMz7

--HG--
extra : rebase_source : c54b129c6815096035e262322f40aa0884b1ae56
2017-10-09 00:26:16 -05:00
Matthew Gregan
2bf67b1eb5 Bug 1403043 - Avoid reentering libcubeb from data_callback. r=jwwang
AudioStream::DataCallback uses cubeb_get_backend_id to work around a bug in
libcubeb's winmm backend, but calling libcubeb APIs from within libcubeb
callbacks is not safe.  Move the query to AudioStream::Init and check a simple
bool from within the callback instead.
2017-09-29 17:19:47 +13:00
Chris Pearce
52ca837455 Bug 1399559 - Include nsXULAppAPI.h in AudioStream.cpp. r=jwwang
This ensures XRE_IsContentProcess() is defined, as it's used in this file.

MozReview-Commit-ID: JFCmvZ8aZdT

--HG--
extra : rebase_source : 5852da1b4b76f767e7d36071cdfa1f97eaedbf8c
2017-09-14 15:56:35 +12:00
Chun-Min Chang
b7f3746bab Bug 1392930 - part 2: Make AudioStream inherit from DeviceChangeListener; r=jwwang
--HG--
extra : rebase_source : 384f30c0fe923609b1c1f0822179f0165d987d4a
2017-08-29 18:08:46 +08:00
Matthew Gregan
f4d992a821 Bug 1388229 - Remove B2G-only audio stream type handling. r=kamidphish 2017-08-10 13:00:07 +12:00
Eric Rahm
01f545fea7 Bug 1386825 - Part 1: Remove MOZ_B2G from dom. r=bkelly
MozReview-Commit-ID: 1zzP2r01B7U
2017-08-08 14:41:05 -07:00
Chun-Min Chang
030729930f Bug 1361336 - part5: Register the AudioStream into AudioNotificationReceiver when it's created; r=cpearce
--HG--
extra : rebase_source : bec94f3f8a710b8b8d21912f0feb5a752e92c7de
2017-07-26 14:50:48 +08:00
Chun-Min Chang
7d076c3ac2 Bug 1361336 - part2: Prevent AudioStream::ResetDefaultDevice() from being called before stream is started; r=cpearce,kinetik
--HG--
extra : rebase_source : 95030be6e9ce493b6d42e837f9a7e652907836a8
2017-07-21 17:45:45 +08:00
Chun-Min Chang
bfe0bce52c Bug 1361336 - part1: A new API for AudioStream that it can reset stream to the default device; r=kinetik
MozReview-Commit-ID: ErUYXK9fUvE

--HG--
extra : rebase_source : ced74fba605b6892674a58611d7eb33616c81ce6
2017-07-12 14:51:07 +08:00
Chun-Min Chang
c369131664 Bug 1365225 - Prevent overflow. r=jwwang
MozReview-Commit-ID: 6jA1DTgVmrU
2017-05-24 09:22:42 -04:00
Chun-Min Chang
561671475d Bug 1321502 - part 1: Enable multi-channel support in Gecko on Windows; r=jya
MozReview-Commit-ID: KURUk3EffOu

--HG--
extra : rebase_source : a0ce3fb8691f45a33995a3ce1ba895c254a35c8c
2017-01-26 17:35:31 +08:00
Paul Adenot
f012888dd8 Bug 1332905 - For mono or stereo in AudioStream.cpp until the rest of the code is multichannel-aware. r=achronop a=tomcat
MozReview-Commit-ID: 5eqBlPnHVk2
2017-01-23 11:36:58 +01:00
Alex Chronopoulos
bad8dea079 Bug 1331869 - Initialize new field of cubeb_stream_params. r=kinetik,padenot
MozReview-Commit-ID: KZ08mckJX44

--HG--
extra : rebase_source : 6789db291ace421114055063efa37481cfc524ef
2017-01-20 16:54:00 +02:00
Carsten "Tomcat" Book
572e74ee99 merge mozilla-inbound to mozilla-central a=merge 2016-09-28 15:56:33 +02:00
Paul Adenot
cb690a7e56 Bug 1301648 - Add a pref to be able to control the AudioCallbackDriver requested latency. r=kinetik
MozReview-Commit-ID: 19BZUjyXFlq

--HG--
extra : rebase_source : 96df59a9b5c9f8bd7e5f8211a09b854d65833b3b
2016-09-09 15:21:50 +02:00
Gerald Squelart
0614bdb71f Bug 1247056 - Report specific cubeb-init error code - r=jwwang
MozReview-Commit-ID: AqR2jKKtNHL

--HG--
extra : rebase_source : 7ffdae6ca2e10e1fbb43ba84c7c398f0017d040c
2016-09-07 21:26:01 -07:00
Wes Kocher
b20dd04b94 Backed out 13 changesets (bug 1247056) for WinXP bc7 failures in browser_decoderDoctor.js CLOSED TREE
Backed out changeset ff3538fd40fe (bug 1247056)
Backed out changeset a444d7cb1091 (bug 1247056)
Backed out changeset 03553484a062 (bug 1247056)
Backed out changeset 001b42631702 (bug 1247056)
Backed out changeset d0d71a80a029 (bug 1247056)
Backed out changeset cd40559e25d7 (bug 1247056)
Backed out changeset b8857adc4003 (bug 1247056)
Backed out changeset 1f3b037bfd1f (bug 1247056)
Backed out changeset c5cd9597ec02 (bug 1247056)
Backed out changeset 2bfe3aeb9f59 (bug 1247056)
Backed out changeset 934d7c9628f1 (bug 1247056)
Backed out changeset 63094a80bee7 (bug 1247056)
Backed out changeset 511ed53eee9a (bug 1247056)
2016-09-26 12:15:55 -07:00
Gerald Squelart
e46d041220 Bug 1247056 - Report specific cubeb-init error code - r=jwwang
MozReview-Commit-ID: AqR2jKKtNHL

--HG--
extra : histedit_source : a2789615fa45e191e04657e57f571362d86daf76
2016-09-07 21:26:01 -07:00
Alex Chronopoulos
27be8363ef Bug 1286041 - AudioStream disable the assert when backend audio is winmm. r=padenot 2016-09-12 12:25:19 +03:00
Alex Chronopoulos
3951f5ffd7 Bug 1286041 - Assert audio callback is not called in initialized state. r=jwwang 2016-07-12 16:53:58 +02:00
Carsten "Tomcat" Book
70d30f62af Backed out 12 changesets (bug 1247056) for windows bc7 test failures
Backed out changeset 13434fa439d1 (bug 1247056)
Backed out changeset e1e5be2fc586 (bug 1247056)
Backed out changeset f48fd90bf839 (bug 1247056)
Backed out changeset 8e164f6d6c5c (bug 1247056)
Backed out changeset 024d7295b6f4 (bug 1247056)
Backed out changeset 32fc8121ca20 (bug 1247056)
Backed out changeset 49558f78782a (bug 1247056)
Backed out changeset 2b3dce1c98f6 (bug 1247056)
Backed out changeset be036a725d3a (bug 1247056)
Backed out changeset 344a41f87a23 (bug 1247056)
Backed out changeset 0ce3c5cb6e6a (bug 1247056)
Backed out changeset 01aa7f5bde71 (bug 1247056)
2016-09-23 16:02:54 +02:00
Gerald Squelart
74bd3981f5 Bug 1247056 - Report specific cubeb-init error code - r=jwwang
MozReview-Commit-ID: AqR2jKKtNHL

--HG--
extra : histedit_source : 3b61cc82b635437cad618275ebd0fddfccc4151d
2016-09-07 21:26:01 -07:00
Matthew Gregan
0ebace12e5 Bug 1302348 - Report cubeb context init failures via telemetry. r=padenot 2016-09-16 12:54:24 +12:00
Wes Kocher
677438b338 Backed out 4 changesets (bug 1286041) for making various media tests really failure prone a=backout
Backed out changeset af4c053741f1 (bug 1286041)
Backed out changeset b5be689abefa (bug 1286041)
Backed out changeset 2aad01ffac9f (bug 1286041)
Backed out changeset 48117ed311a1 (bug 1286041)
2016-09-12 15:17:23 -07:00
Alex Chronopoulos
c498e1f9a0 Bug 1286041 - AudioStream disable the assert when backend audio is winmm. r=padenot 2016-09-12 12:25:19 +03:00
Alex Chronopoulos
6a23c81135 Bug 1286041 - Assert audio callback is not called in initialized state. r=jwwang 2016-07-12 16:53:58 +02:00
Nicholas Nethercote
34dcc7b852 Bug 1299384 - Use MOZ_MUST_USE with NS_warn_if_impl(). r=erahm.
This change avoids lots of false positives for Coverity's CHECKED_RETURN
warning, caused by NS_WARN_IF's current use in both statement-style and
expression-style.

In the case where the code within the NS_WARN_IF has side-effects, I made the
following change.

> NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));
> -->
> Unused << NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));

In the case where the code within the NS_WARN_IF lacks side-effects, I made the
following change.

> NS_WARN_IF(!condWithoutSideEffects);
> -->
> NS_WARNING_ASSERTION(condWithoutSideEffects, "msg");

This has two improvements.
- The condition is not evaluated in non-debug builds.
- The sense of the condition is inverted to the familiar "this condition should
  be true" sense used in assertions.

A common variation on the side-effect-free case is the following.

> nsresult rv = Fn();
> NS_WARN_IF_(NS_FAILED(rv));
> -->
> DebugOnly<nsresult rv> = Fn();
> NS_WARNING_ASSERTION(NS_SUCCEEDED(rv), "Fn failed");

--HG--
extra : rebase_source : 58788245021096efa8372a9dc1d597a611d45611
2016-09-02 17:12:24 +10:00
Sebastian Hengst
8df190bd97 Backed out changeset 71b9d48efac6 (bug 1286041) for failing wpt mediasource-seek-beyond-duration.html on Linux. r=backout on a CLOSED TREE 2016-09-06 19:08:20 +02:00
Sebastian Hengst
c150583370 Backed out changeset bb04b5569ab9 (bug 1286041) 2016-09-06 19:06:51 +02:00
Paul Adenot
bf8d30bacd Bug 1286041 - Disable an assert when using winmm, on a CLOSED TREE. r=achronop
MozReview-Commit-ID: HHWIDARNPft
2016-09-06 15:34:57 +02:00
Alex Chronopoulos
379cc5172a Bug 1286041 - Assert audio callback is not called in initialized state. r=jwwang
MozReview-Commit-ID: 3epBfvUHYFo
2016-07-12 16:53:58 +02:00
Igor
175543fda8 Bug 1293384 - Part 2: Rename Snprintf.h header to Sprintf.h. r=froydnj 2016-08-14 23:43:21 -07:00
Igor
a57972337d Bug 1293384 - Part 1: Rename snprintf_literal to SprintfLiteral. r=froydnj 2016-08-14 23:44:00 -07:00
Paul Adenot
5ce5a2cc20 Bug 1283020 - Update cubeb consumers to pass in latency in frames and not in ms. r=achronop
MozReview-Commit-ID: D7HjHNPRIre
2016-07-20 15:02:23 +02:00
Wes Kocher
cdd7fc4a11 Backed out changeset 344300260f4c (bug 1283020) for frequent m(gl) failures CLOSED TREE 2016-07-20 15:08:09 -07:00
Paul Adenot
4e73b0eead Bug 1283020 - Update cubeb consumers to pass in latency in frames and not in ms. r=achronop
MozReview-Commit-ID: D7HjHNPRIre
2016-07-20 15:02:23 +02:00
Paul Adenot
be6cf8e090 Bug 1280630 - Add telemetry probes to know which cubeb back-end is used the most. r=kinetik data-review=bsmedberg
MozReview-Commit-ID: AxJlcxjYh3M
2016-06-23 17:50:52 +02:00
JW Wang
6c194b8486 Bug 1277473 - fix data race in gDumpedAudioCount. r=kinetik.
MozReview-Commit-ID: F9Twn0MlDBV

--HG--
extra : rebase_source : aaab07dbdb236ced54e01d0ce26692b2479d355b
2016-06-02 15:53:39 +08:00
JW Wang
ed7bec1506 Bug 1277198. Part 3 - remove AudioStream::mInRate/mOutRate. r=kinetik.
MozReview-Commit-ID: KTiyzO8VEZh

--HG--
extra : rebase_source : 49589d5bd8ea1b2575caaf608569c64fab307c5b
2016-06-01 18:00:15 +08:00
JW Wang
510020f774 Bug 1277198. Part 2 - fix OpenDumpFile(). r=kinetik.
MozReview-Commit-ID: IWzvlWnhuFe

--HG--
extra : rebase_source : 39c105ad766947ebe350b8b2afc2685bb00339dc
2016-06-01 17:54:37 +08:00
JW Wang
51c02cde54 Bug 1277198. Part 1 - add AudioClock::GetInputRate/GetOutputRate. r=kinetik.
MozReview-Commit-ID: HsaiSq83MtD

--HG--
extra : rebase_source : d578e00f15300fbcf1cc41fb5242868a4b31b57d
2016-06-01 17:38:47 +08:00
JW Wang
d292fa5e3a Bug 1277776 - Use SaferMultDiv in AudioClock::GetPositionInFrames(). r=jya.
MozReview-Commit-ID: 711czooNf55

--HG--
extra : rebase_source : cf2ba4ab351775be5ab08a820de9d4a1ac356dac
2016-06-06 11:13:34 +08:00
JW Wang
59371c367d Bug 1277188. Part 5 - rename AudioClock::SetPlaybackRateUnlocked(). r=kinetik.
MozReview-Commit-ID: C7m8xeMAJES

--HG--
extra : rebase_source : 2a94db443d9696e9f4b1ee5caa4915df69e745af
2016-06-01 16:45:32 +08:00
JW Wang
e84f041b19 Bug 1277188. Part 4 - remove AudioClock::mAudioStream. r=kinetik.
MozReview-Commit-ID: KjrfgHIg8z4

--HG--
extra : rebase_source : 8208e3ead2d8dfbe02fb899e5fb376651715be61
2016-06-01 16:36:10 +08:00
JW Wang
2a587ee2df Bug 1277188. Part 3 - remove AudioClock::GetPositionUnlocked(). r=kinetik.
MozReview-Commit-ID: 9g3wqI63OsR

--HG--
extra : rebase_source : 216e0a7e9909572ad828c262063e348df462a5ef
2016-06-01 16:30:54 +08:00
JW Wang
0b95bcdd11 Bug 1277188. Part 2 - fix AudioStream::GetPositionInFrames(). r=kinetik.
MozReview-Commit-ID: 3NhoRCPu8fU

--HG--
extra : rebase_source : d3b177d25a86f03ac65c5231dc389e66cbb5aba5
2016-06-01 16:18:56 +08:00
JW Wang
050beb7609 Bug 1277188. Part 1 - fix AudioStream::GetPosition(). r=kinetik.
MozReview-Commit-ID: ECGPX04hM6U

--HG--
extra : rebase_source : 0a0762173432be070582ea789ea58ca4e63b73cf
2016-06-01 16:19:35 +08:00