Commit Graph

5908 Commits

Author SHA1 Message Date
ffxbld
2eb3b6566d Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release 2019-12-02 11:59:11 +00:00
ffxbld
095a889675 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D55438

--HG--
extra : moz-landing-system : lando
2019-12-02 14:02:17 +00:00
Daniel Varga
b6af88ada4 Backed out changeset 6e7d21f9e8ef (bug 1598562) causing bug 1600450 in 72 beta
--HG--
extra : rebase_source : eb7b34c8d7259529189837a2a51dec53263c7cef
2019-12-02 01:19:09 +02:00
Mathieu Leplatre
11ef5b562c Bug 1598562 - Prevent Remote Settings server URL to be modified in release r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D54262

--HG--
extra : moz-landing-system : lando
2019-11-29 10:29:44 +00:00
Sylvestre Ledru
ba488cdc09 Bug 1598971 - codespell: Fix typos in the doc r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,ato
Depends on D54430

Differential Revision: https://phabricator.services.mozilla.com/D54431

--HG--
extra : moz-landing-system : lando
2019-11-25 10:06:12 +00:00
Mark Hammond
818e5a5c52 Bug 1598997 - Mock profile fetching function in xpcshell tests. r=eoger
Differential Revision: https://phabricator.services.mozilla.com/D54450

--HG--
extra : moz-landing-system : lando
2019-11-25 21:21:46 +00:00
Mathieu Leplatre
a6d949c39b Bug 1559132 - Add ability to download Remote Settings attachments as bytes r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D53812

--HG--
extra : moz-landing-system : lando
2019-11-25 16:13:52 +00:00
ffxbld
97c99c1595 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D54500

--HG--
extra : moz-landing-system : lando
2019-11-25 13:53:13 +00:00
Mark Hammond
9ff9e9548a Bug 1595954 - record event as the user explicitly connects or disconnects sync or fxa. r=eoger
Differential Revision: https://phabricator.services.mozilla.com/D53907

--HG--
extra : moz-landing-system : lando
2019-11-25 00:12:01 +00:00
Mathieu Leplatre
280083669e Bug 1597337 - Report download errors in uptake telemetry r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D53783

--HG--
extra : moz-landing-system : lando
2019-11-22 08:35:30 +00:00
ffxbld
533132c23d No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D54125

--HG--
extra : moz-landing-system : lando
2019-11-21 15:29:52 +00:00
Gijs Kruitbosch
734a4ade99 Bug 1597785 - fix review nits from bug 1594521, r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D53861

--HG--
extra : moz-landing-system : lando
2019-11-19 21:44:10 +00:00
Gijs Kruitbosch
acafdba483 Bug 1594521 - avoid instantiating remote settings worker after shutdown, r=leplatrem,asuth
Differential Revision: https://phabricator.services.mozilla.com/D53751

--HG--
extra : moz-landing-system : lando
2019-11-19 15:14:07 +00:00
Moritz Birghan
975648e245 Bug 1571656 - Use Assert.jsm numeric comparison functions in tests r=mixedpuppy,MattN
Differential Revision: https://phabricator.services.mozilla.com/D40614

--HG--
extra : moz-landing-system : lando
2019-11-18 13:03:58 +00:00
ffxbld
a55a956277 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D53414

--HG--
extra : moz-landing-system : lando
2019-11-18 13:25:41 +00:00
Mark Hammond
c56be6e72f Bug 1594704 - ensure sync data choices made before connecting sync are honored. r=eoger
Differential Revision: https://phabricator.services.mozilla.com/D53138

--HG--
extra : moz-landing-system : lando
2019-11-15 19:12:16 +00:00
Mark Hammond
7979d6602b Bug 1596659 - Delete declineDisabled from engines.js. r=lina
Differential Revision: https://phabricator.services.mozilla.com/D53141

--HG--
extra : moz-landing-system : lando
2019-11-15 20:04:53 +00:00
ffxbld
6e44b2aa1e No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D53009

--HG--
extra : moz-landing-system : lando
2019-11-14 23:48:44 +00:00
Vijay Budhram
0929b414ed Bug 1590231 - Update sync preferences panel to match decouple designs r=fluent-reviewers,markh
Differential Revision: https://phabricator.services.mozilla.com/D50931

--HG--
extra : moz-landing-system : lando
2019-11-14 21:01:23 +00:00
Mark Hammond
e57be9d2f3 Bug 1594929 - Remove invalidateCertificate from FxAccountsKeys.jsm. r=rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D52623

--HG--
extra : moz-landing-system : lando
2019-11-12 04:05:28 +00:00
Mark Hammond
ab41353fa5 Bug 1548404 - Update UITour to reflect the decoupling of FxA and Sync. r=MattN,andreio,rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D51976

--HG--
extra : moz-landing-system : lando
2019-11-12 23:58:03 +00:00
ffxbld
46cd67e91a No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D52533

--HG--
extra : moz-landing-system : lando
2019-11-11 14:21:48 +00:00
rfkelly
048a518c75 Bug 1591312 - Revert to using BrowserID to generate OAuth tokens. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D50770

--HG--
extra : moz-landing-system : lando
2019-11-08 06:28:54 +00:00
ffxbld
02b887e62e No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D52150

--HG--
extra : source : 90745d442c4b0885b14449065509484da5de9fe5
2019-11-07 15:36:28 +00:00
Ciure Andrei
98e9f97749 Backed out changeset 90745d442c4b for causing build bustages CLOSED TREE 2019-11-07 18:19:01 +02:00
ffxbld
3d9a3dab4a No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D52150

--HG--
extra : moz-landing-system : lando
2019-11-07 15:36:28 +00:00
Coroiu Cristina
27a753cc4a Backed out changeset 96048cce4b80 (bug 1571656) for xpcshell failures at toolkit/components/places/tests/unifiedcomplete/test_autofill_origins.js on a CLOSED TREE 2019-11-06 22:59:45 +02:00
Moritz Birghan
70c7a633fb Bug 1571656 - Use Assert.jsm numeric comparison functions in tests r=mixedpuppy,MattN
Differential Revision: https://phabricator.services.mozilla.com/D40614

--HG--
extra : moz-landing-system : lando
2019-11-06 18:07:54 +00:00
Oana Pop Rus
6c038766da Backed out changeset dd5c1030d23b (bug 1590231) for bc failures in browser_search_within_preferences_2.js on a CLOSED TREE 2019-11-06 19:44:13 +02:00
Vijay Budhram
b9c626a520 Bug 1590231 - Update sync preferences panel to match decouple designs r=fluent-reviewers,markh
Differential Revision: https://phabricator.services.mozilla.com/D50931

--HG--
extra : moz-landing-system : lando
2019-11-06 16:51:03 +00:00
Thom Chiovoloni
0aee355709 Bug 1582263 - Move devices list to top level of sync ping. r=markh
Move devices list to top level of sync ping

Differential Revision: https://phabricator.services.mozilla.com/D49194

--HG--
extra : moz-landing-system : lando
2019-11-05 17:21:12 +00:00
ffxbld
7ecd576f74 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D51601

--HG--
extra : moz-landing-system : lando
2019-11-04 13:51:07 +00:00
Gijs Kruitbosch
00778dd54e Bug 1591212 - make webchannel work with fission, r=vladikoff,mconley
Differential Revision: https://phabricator.services.mozilla.com/D51214

--HG--
rename : toolkit/modules/WebChannel.jsm => toolkit/actors/WebChannelParent.jsm
rename : browser/base/content/test/general/browser_web_channel.js => toolkit/modules/tests/browser/browser_web_channel.js
rename : browser/base/content/test/general/browser_web_channel.html => toolkit/modules/tests/browser/file_web_channel.html
rename : browser/base/content/test/general/browser_web_channel_iframe.html => toolkit/modules/tests/browser/file_web_channel_iframe.html
extra : moz-landing-system : lando
2019-11-02 00:39:35 +00:00
ffxbld
c1e90a0ee7 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D51261

--HG--
extra : moz-landing-system : lando
2019-10-31 14:46:55 +00:00
ffxbld
b6ddb7ea53 No Bug, mozilla-central repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D50806

--HG--
extra : moz-landing-system : lando
2019-10-28 13:17:59 +00:00
Thom Chiovoloni
962b41a45b Bug 1238810 - Replace {FXA,WEAVE}_CONFIGURED with entries in the telemetry environment. r=chutten,markh,loines
Replace {FXA,WEAVE}_CONFIGURED with entries in the telemetry environment

Differential Revision: https://phabricator.services.mozilla.com/D49166

--HG--
extra : moz-landing-system : lando
2019-10-25 21:38:01 +00:00
rfkelly
ebf99d6f4f Bug 1590948 - Properly inspect context param when handling fxa_status webchannel message. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D50408

--HG--
extra : moz-landing-system : lando
2019-10-25 00:23:09 +00:00
Cosmin Sabou
23c6504831 Bug 1590486 - Fix eslint failure. r=eslint-fix 2019-10-24 06:58:21 +03:00
Mark Hammond
274e0280b0 Bug 1590486 - ensure FxA web channels can grab the session token. r=eoger
Differential Revision: https://phabricator.services.mozilla.com/D50359

--HG--
extra : moz-landing-system : lando
2019-10-24 03:30:57 +00:00
lougenia
4a5ba28d8a Bug 1588948 - Check passwords engine handles incoming records with null or missing username fields r=lina
Differential Revision: https://phabricator.services.mozilla.com/D49805

--HG--
extra : source : b300b58faf473a242d4ed3428a97dec17bcd862c
2019-10-23 17:49:51 +00:00
Cosmin Sabou
68edcb2abb Backed out changeset b300b58faf47 (bug 1588948) for browser chrome failures on test_basic_form_autocomplete.html. 2019-10-24 02:06:37 +03:00
Cosmin Sabou
291e0d381d Backed out changeset c5503bc49a73 (bug 1590486) for xpc failures on test_web_channel.js. 2019-10-24 02:04:03 +03:00
lougenia
8fff38140a Bug 1588948 - Check passwords engine handles incoming records with null or missing username fields r=lina
Differential Revision: https://phabricator.services.mozilla.com/D49805

--HG--
extra : moz-landing-system : lando
2019-10-23 17:49:51 +00:00
Mark Hammond
75ea9bc416 Bug 1590486 - ensure FxA web channels can grab the session token. r=eoger
Differential Revision: https://phabricator.services.mozilla.com/D50359

--HG--
extra : moz-landing-system : lando
2019-10-23 21:21:23 +00:00
Oana Pop Rus
5033d599b4 Backed out changeset 3d7b77564cb7 (bug 1238810) for bc perma failures in browser_startup.js on a CLOSED TREE 2019-10-24 00:38:10 +03:00
Thom Chiovoloni
b8fe187695 Bug 1238810 - Replace {FXA,WEAVE}_CONFIGURED with entries in the telemetry environment. r=chutten,markh,loines
Replace {FXA,WEAVE}_CONFIGURED with entries in the telemetry environment

Differential Revision: https://phabricator.services.mozilla.com/D49166

--HG--
extra : moz-landing-system : lando
2019-10-15 22:57:58 +00:00
Drew Willcoxon
c7e19ee271 Bug 1579334 - Properly limit remote tab matches in the quantumbar. r=mak
This is a narrow patch that simply adds a `maxMatches` param to `PlacesRemoteTabsAutocompleteProvider.getMatches`.

Differential Revision: https://phabricator.services.mozilla.com/D50019

--HG--
extra : moz-landing-system : lando
2019-10-22 15:22:48 +00:00
Mark Hammond
12dd37165b Bug 1574051 - make FxA's session/account status checking sane and understandable. r=rfkelly,mtigley
Differential Revision: https://phabricator.services.mozilla.com/D49689

--HG--
extra : moz-landing-system : lando
2019-10-22 00:58:36 +00:00
Mark Hammond
9a28c6748d Bug 1574052 - only return public fields from fxAccounts.getSignedInUser(). r=rfkelly,eoger
Differential Revision: https://phabricator.services.mozilla.com/D49525

--HG--
extra : moz-landing-system : lando
2019-10-22 00:57:27 +00:00
Narcis Beleuzu
2b0d2dd8e7 Merge autoland to mozilla-central. a=merge 2019-10-22 00:50:23 +03:00
ffxbld
4c889635b4 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D49928

--HG--
extra : moz-landing-system : lando
2019-10-21 13:23:30 +00:00
ffxbld
716fe01e26 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D49605

--HG--
extra : moz-landing-system : lando
2019-10-17 14:34:51 +00:00
ffxbld
7b3edc3d02 Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release 2019-10-21 18:00:38 +00:00
Lina Cambridge
a0d2e56628 Bug 1588329 - Centralize array chunking in PlacesUtils.chunkArray. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D49072

--HG--
extra : moz-landing-system : lando
2019-10-15 21:23:07 +00:00
Dorel Luca
b6eeb7d5d3 Backed out changeset 35d4451f348d (bug 1588458) as requested by the dev 2019-10-15 19:04:22 +03:00
Sylvestre Ledru
0f71aeba53 Bug 1588458 - Replace dxr by searchfox in the doc r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D49140

--HG--
extra : moz-landing-system : lando
2019-10-15 15:27:13 +00:00
Sam Foster
9b996482ca Bug 1567196 - Ignore invalid password date values. r=markh
Depends on D48941

Differential Revision: https://phabricator.services.mozilla.com/D49218

--HG--
extra : moz-landing-system : lando
2019-10-15 00:23:42 +00:00
Mark Hammond
0481284ac7 Bug 1583897 - Send a telemetry event for new sendtab. r=tcsc,eoger,lina
Differential Revision: https://phabricator.services.mozilla.com/D48153

--HG--
extra : moz-landing-system : lando
2019-10-14 22:17:28 +00:00
Mark Hammond
c7296e7825 Bug 1587769 - update the pref we watch to ensure we sync immediately after device name change. r=eoger
Differential Revision: https://phabricator.services.mozilla.com/D49102

--HG--
extra : moz-landing-system : lando
2019-10-14 16:30:27 +00:00
ffxbld
cbc7251ad9 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D49151

--HG--
extra : moz-landing-system : lando
2019-10-14 13:16:30 +00:00
Lina Cambridge
5ac45f3f35 Bug 1588018 - Remove remaining event telemetry from the bookmarks mirror. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D49049

--HG--
extra : moz-landing-system : lando
2019-10-14 00:22:10 +00:00
Mark Hammond
1b362fb843 Bug 1587837 - better checking of the Firefox Account password changing. r=eoger
Differential Revision: https://phabricator.services.mozilla.com/D48936

--HG--
extra : moz-landing-system : lando
2019-10-11 16:41:44 +00:00
Edouard Oger
25eb2d60df Bug 1549049 - Unify Sync Now buttons logic. r=markh,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D48410

--HG--
extra : moz-landing-system : lando
2019-10-11 17:06:57 +00:00
Andreea Pavel
eb350d4f6b Backed out changeset 4695136f7e82 (bug 1549049) for assertion failures at ErrorResult.h on a CLOSED TREE 2019-10-11 00:53:42 +03:00
Edouard Oger
136a86deed Bug 1549049 - Unify Sync Now buttons logic. r=markh,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D48410

--HG--
extra : moz-landing-system : lando
2019-10-10 21:08:01 +00:00
Mark Hammond
b559ec6b1b Bug 1587691 - Firefox Accounts webchannel message should allow login without engine choices. r=eoger
Differential Revision: https://phabricator.services.mozilla.com/D48797

--HG--
extra : moz-landing-system : lando
2019-10-10 16:57:42 +00:00
ffxbld
8d4072c53b No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D48836

--HG--
extra : moz-landing-system : lando
2019-10-10 14:38:00 +00:00
Edouard Oger
79a871cd9c Bug 1577690 - WebChannel support for optional Sync. r=vladikoff
Differential Revision: https://phabricator.services.mozilla.com/D46316

--HG--
extra : moz-landing-system : lando
2019-10-08 15:19:23 +00:00
Edouard Oger
da3f0d0753 Bug 1581709 - Use sessionTokens for OAuth requests. r=vladikoff
Differential Revision: https://phabricator.services.mozilla.com/D46517

--HG--
extra : moz-landing-system : lando
2019-10-08 15:45:06 +00:00
Razvan Maries
9c27546918 Backed out changeset 6852bdb8d8c5 (bug 1581709) for Linting failures. CLOSED TREE 2019-10-08 18:42:11 +03:00
Edouard Oger
1093781abc Bug 1581709 - Use sessionTokens for OAuth requests. r=vladikoff
Differential Revision: https://phabricator.services.mozilla.com/D46517

--HG--
extra : moz-landing-system : lando
2019-10-08 14:19:11 +00:00
Edouard Oger
44a0e91fcd Bug 1584249 - Update enabled sync engines before opening CWTS dialog. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D48272

--HG--
extra : moz-landing-system : lando
2019-10-07 15:25:38 +00:00
ffxbld
5a0922f7cb No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D48342

--HG--
extra : moz-landing-system : lando
2019-10-07 13:11:07 +00:00
Lina Cambridge
397d3a1156 Bug 1583413 - Fetch the Send Tab target list from FxA, not Sync. r=markh,eoger
Instead of using the list of FxA devices from the Sync clients engine,
we now fetch the list of Send Tab devices from FxA. This works like
this:

* `FxAccountsDevice#getDeviceList` has been split up into
  `recentDeviceList` and `refreshDeviceList`.
* `recentDeviceList` synchronously returns the last fetched list, so
  that consumers like Send Tab can use it right away.
* `refreshDeviceList` is asynchronous, and refreshes the last fetched
  list. Refreshes are limited to once every minute by default, matching
  the minimum sync interval (Send Tab passes the `ignoreCached` option
  to override the limit if the user clicks the "refresh" button).
  Concurrent calls to `refreshDeviceList` are also serialized, to
  ensure the list is only fetched once.
* The list is flagged as stale when a device is connected or
  disconnected. It's still kept around, but the next call to
  `refreshDeviceList` will fetch a new list from the server.
* The Send Tab UI refreshes FxA devices in the background. Matching FxA
  devices to Sync client records is best effort; we don't do it if Sync
  isn't configured or hasn't run yet. This only impacts the fallback
  case if the target doesn't support FxA commands.

Differential Revision: https://phabricator.services.mozilla.com/D47521

--HG--
extra : moz-landing-system : lando
2019-10-03 22:40:55 +00:00
Lina Cambridge
51e03623ee Bug 1583413 - Move device-related methods into FxAccountsDevice.jsm. r=eoger
This commit contains no functional changes, just moving code around to
make the next patch in this series easier to write.

Differential Revision: https://phabricator.services.mozilla.com/D47520

--HG--
extra : moz-landing-system : lando
2019-10-03 22:40:41 +00:00
ffxbld
9238ced3bb No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D48055

--HG--
extra : moz-landing-system : lando
2019-10-03 13:40:24 +00:00
Mark Hammond
47380e1a34 Bug 1581980 - change the text of many Sync notifications so they aren't Sync specific. r=flod,eoger
Differential Revision: https://phabricator.services.mozilla.com/D47853

--HG--
extra : moz-landing-system : lando
2019-10-03 05:52:58 +00:00
Mark Hammond
51a55ec4ba Bug 1585299 - ensure only 1 fxaccounts:onverified notification when a new account verifies. r=lina
Differential Revision: https://phabricator.services.mozilla.com/D47861

--HG--
extra : moz-landing-system : lando
2019-10-03 01:18:09 +00:00
Bogdan Tara
11b09d510c Backed out changeset 961eac228e3e (bug 1585299) for ES Lint failures on FxAccounts.jsm && test_accounts.js CLOSED TREE 2019-10-02 09:41:37 +03:00
Mark Hammond
c0a71bf7f1 Bug 1585299 - ensure only 1 fxaccounts:onverified notification when a new account verifies. r=lina
Differential Revision: https://phabricator.services.mozilla.com/D47861

--HG--
extra : moz-landing-system : lando
2019-10-02 06:03:39 +00:00
Mark Hammond
499384cb8e Bug 1585211 - Have TPS enable sync when the test user logs in. r=tcsc
Differential Revision: https://phabricator.services.mozilla.com/D47714

--HG--
extra : moz-landing-system : lando
2019-10-01 00:32:01 +00:00
ffxbld
8a664f77d8 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D47597

--HG--
extra : moz-landing-system : lando
2019-09-30 13:11:37 +00:00
ffxbld
c9b081d8c9 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D47244

--HG--
extra : moz-landing-system : lando
2019-09-26 14:33:06 +00:00
Mark Hammond
4b629788b2 Bug 1570567 - update about:preferences#sync to reflect the decoupling of FxA and Sync. r=Gijs,eoger,flod,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D46574

--HG--
extra : moz-landing-system : lando
2019-09-26 10:48:22 +00:00
Mark Hammond
7ec2097ae8 Bug 1582633 - allow an FxA user to be signed in without sync being enabled. r=eoger,lina
Differential Revision: https://phabricator.services.mozilla.com/D46572

--HG--
extra : moz-landing-system : lando
2019-09-25 06:51:18 +00:00
Geoff Brown
dcb380399e Bug 1582785 - Enable some xpcshell tests on Android; r=geckoview-reviewers,agi
Most of these tests have been disabled for a long time; they run well
in the current test environment.

Differential Revision: https://phabricator.services.mozilla.com/D46642

--HG--
extra : moz-landing-system : lando
2019-09-23 22:43:55 +00:00
Edouard Oger
5431bbfab3 Bug 1547120 - Add a method to list attached clients. r=rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D46838

--HG--
extra : moz-landing-system : lando
2019-09-23 20:43:56 +00:00
ffxbld
bdeece726d No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D46777

--HG--
extra : moz-landing-system : lando
2019-09-23 13:09:04 +00:00
Edouard Oger
7f39ae82a2 Bug 1582542 - Use getUserAccountData in FxA commands invoke. r=vladikoff
Differential Revision: https://phabricator.services.mozilla.com/D46511

--HG--
extra : moz-landing-system : lando
2019-09-19 19:51:41 +00:00
ffxbld
959ff7f82f No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D46469

--HG--
extra : moz-landing-system : lando
2019-09-19 14:37:28 +00:00
Edouard Oger
3017be71f8 Bug 1582537 - Call getScopedKeys on keys field. r=vladikoff
Differential Revision: https://phabricator.services.mozilla.com/D46509

--HG--
extra : moz-landing-system : lando
2019-09-19 19:28:48 +00:00
Mark Hammond
7531325c86 Bug 1582023 - Replace "sync disconnect" dialog and local data removal with simple confirmation dialog. r=eoger,flod,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D46253

--HG--
extra : moz-landing-system : lando
2019-09-19 05:59:51 +00:00
Mark Hammond
140dc3f765 Bug 1578217 - remove the sync 'yellow state' telemetry. r=tcsc
Differential Revision: https://phabricator.services.mozilla.com/D45765

--HG--
extra : moz-landing-system : lando
2019-09-19 00:34:04 +00:00
Ehsan Akhgari
1ba181f8bf Bug 1581160 - Prepackage url-classifier-skip-urls into the binaries; r=leplatrem,glasserc
Differential Revision: https://phabricator.services.mozilla.com/D45871

--HG--
extra : moz-landing-system : lando
2019-09-13 16:26:57 +00:00
Edouard Oger
a6c404619f Bug 1570569 p2 - Add Sync Disabled state to Synced Tabs sidebar. r=fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D44485

--HG--
extra : moz-landing-system : lando
2019-09-10 18:23:31 +00:00
Edouard Oger
926c5d067c Bug 1570569 p1 - Add Sync Disabled state to Synced Tabs menu. r=vbudhram,fluent-reviewers,flod,markh
Differential Revision: https://phabricator.services.mozilla.com/D44484

--HG--
extra : moz-landing-system : lando
2019-09-11 01:17:46 +00:00
ffxbld
5af1f73d04 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D45662

--HG--
extra : moz-landing-system : lando
2019-09-12 13:37:51 +00:00
Mark Hammond
0203cd1dd5 Bug 1574048 - Remove FxAccounts internal/external/Object.freeze()/ weirdness. r=lina,rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D44083

--HG--
extra : moz-landing-system : lando
2019-09-12 02:08:50 +00:00
Mark Hammond
e074186422 Bug 1575921 - store the FxA device ID in an FxA-specific pref branch. r=eoger
Differential Revision: https://phabricator.services.mozilla.com/D43897

--HG--
extra : moz-landing-system : lando
2019-09-11 01:37:50 +00:00
Bogdan Tara
0f5e9e5206 Backed out changeset 93d2d4bbe263 (bug 1575921) for xpcshell failures on test_device.js CLOSED TREE 2019-09-10 04:42:15 +03:00
Mark Hammond
15535c9309 Bug 1575921 - store the FxA device ID in an FxA-specific pref branch. r=eoger
Differential Revision: https://phabricator.services.mozilla.com/D43897

--HG--
extra : moz-landing-system : lando
2019-09-10 00:09:52 +00:00
ffxbld
426de7d9bd Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release 2019-09-02 09:00:31 +00:00
ffxbld
3b375c8b7b No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D43967

--HG--
extra : moz-landing-system : lando
2019-08-29 13:14:59 +00:00
Mathieu Leplatre
43084d5e54 Bug 1577218 - Upgrade kinto-offline-client to 12.7.0 r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D43773

--HG--
extra : moz-landing-system : lando
2019-08-28 16:08:29 +00:00
Sylvestre Ledru
d264b841c9 Bug 1576502 - Fix some wording issues r=mhoye
Differential Revision: https://phabricator.services.mozilla.com/D43363

--HG--
extra : moz-landing-system : lando
2019-08-27 15:38:58 +00:00
Luca Greco
b2c8b8875b Bug 1572711 - Record extensions.blocklist.useXML and services.blocklist.*.checked prefs into new telemetry scalars. r=janerik,leplatrem,Gijs
Depends on D41734

Differential Revision: https://phabricator.services.mozilla.com/D41735

--HG--
extra : moz-landing-system : lando
2019-08-22 16:32:19 +00:00
ffxbld
409e5b7a75 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D43052

--HG--
extra : moz-landing-system : lando
2019-08-22 13:43:50 +00:00
Mark Hammond
c2a3916396 Bug 1574382 - use yaml to parse TPS tests. r=tcsc
Differential Revision: https://phabricator.services.mozilla.com/D42263

--HG--
extra : moz-landing-system : lando
2019-08-19 20:55:05 +00:00
Ciure Andrei
9a123fb597 Backed out changeset 81156ff3f4fa (bug 1571656) for causing browser_PageActions.js and test_insertTree_fixupOrSkipInvalidEntries.js to perma fail CLOSED TREE 2019-08-19 13:00:44 +03:00
Moritz Birghan
240771fa29 Bug 1571656 - Use Assert.jsm numeric comparison functions in tests r=mixedpuppy,MattN
Differential Revision: https://phabricator.services.mozilla.com/D40614

--HG--
extra : moz-landing-system : lando
2019-08-19 07:17:12 +00:00
Mark Banner
b1970e6a2f Bug 1571466 - Cleanup unnecessary ESLint global definitions. r=mossop
These are raised as redeclares or unused variables by ESLint 6.

Differential Revision: https://phabricator.services.mozilla.com/D37268

--HG--
extra : moz-landing-system : lando
2019-08-19 07:11:56 +00:00
Lina Cambridge
a17323e9d8 Bug 1573709 - Return an aborted watchdog for testing interrupted bookmark merges. a=testonly
Differential Revision: https://phabricator.services.mozilla.com/D41876

--HG--
extra : moz-landing-system : lando
2019-08-14 00:28:52 +00:00
Lina Cambridge
65dfa84ccd Bug 1573305 - Remove the check for unmerged synced bookmark changes. r=markh
When a local or remote item changed, we'd potentially scan three tables
(with an expensive `LEFT JOIN`!) to check if anything changed...then
scan the same tables again to build the local and remote trees. This
check was originally meant to avoid unnecessary merges. However, the
bottleneck isn't merging now; it's reading from the database.

Since the merger has been rewritten in Rust, is synchronous, doesn't
keep a transaction open for the entire merge (see the
`total_sync_changes` check), and only emits ops for items that actually
changed, it's more efficient to build and merge optimistically, and
bail before applying if nothing changed.

This commit also moves `validateLocalRoots` into Rust.

Differential Revision: https://phabricator.services.mozilla.com/D41690

--HG--
extra : moz-landing-system : lando
2019-08-13 22:58:16 +00:00
Lina Cambridge
19557885f6 Bug 1572615 - Abort bookmark merges that take longer than 5 minutes. r=markh
This commit introduces a new `Watchdog` class that signals an abort,
either after a delay or at shutdown, and wires up the buffered engine
to use it.

Differential Revision: https://phabricator.services.mozilla.com/D41311

--HG--
extra : moz-landing-system : lando
2019-08-13 18:48:25 +00:00
ffxbld
21d02cb6fe No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D41541

--HG--
extra : moz-landing-system : lando
2019-08-12 13:08:23 +00:00
Nicholas Nethercote
41a012cce7 Bug 1572621 - Merge services-sync.js into all.js. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D41323

--HG--
extra : moz-landing-system : lando
2019-08-09 09:18:41 +00:00
Nicholas Nethercote
73d5a12400 Bug 1572621 - Merge services-common.js into all.js. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D41322

--HG--
extra : moz-landing-system : lando
2019-08-09 09:18:27 +00:00
Lina Cambridge
0d63b1e98f Bug 1498073 - Use centisecond precision for modified times in Sync tests. a=testonly
Differential Revision: https://phabricator.services.mozilla.com/D41266

--HG--
extra : moz-landing-system : lando
2019-08-08 19:19:47 +00:00
Jared Wein
22ae3511f6 Bug 1571567 - Fix no-fallthrough errors in /services. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D40878

--HG--
extra : moz-landing-system : lando
2019-08-08 15:18:36 +00:00
Bogdan Tara
844afcfb06 Backed out 10 changesets (bug 1571567) complementary backout after es lint failure on the patch CLOSED TREE
Backed out changeset ce83fa75ae32 (bug 1571567)
Backed out changeset 7aa97ba7cce9 (bug 1571567)
Backed out changeset 777d79076e99 (bug 1571567)
Backed out changeset fbdf6b75a484 (bug 1571567)
Backed out changeset e2ed4620f232 (bug 1571567)
Backed out changeset 2c67015f12c6 (bug 1571567)
Backed out changeset 7ec086bb5bd5 (bug 1571567)
Backed out changeset 42df735c8556 (bug 1571567)
Backed out changeset 7d5fc57b2809 (bug 1571567)
Backed out changeset 606bafb8211c (bug 1571567)
2019-08-08 18:13:54 +03:00
Jared Wein
9cf685253f Bug 1571567 - Fix no-fallthrough errors in /services. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D40878

--HG--
extra : moz-landing-system : lando
2019-08-08 01:38:51 +00:00
Mark Hammond
05df0254b8 Bug 1568353 - set the default rest.js timeout to be 5 minutes. r=rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D40927

--HG--
extra : moz-landing-system : lando
2019-08-07 05:25:49 +00:00
Mark Hammond
40d28c338b Bug 1561762 - better handle concurrent requests for FxA oauth tokens. r=eoger,rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D38036

--HG--
extra : moz-landing-system : lando
2019-08-06 15:25:05 +00:00
Lina Cambridge
9320172d8f Bug 1567238 - Refactor the bookmarks mirror merge triggers to do less work. r=tcsc,markh
This commit reduces the number of database writes and table scans
needed to merge synced bookmarks.

* Remove `fetchNew{Local, Remote}Contents`. Fetching the tree already
  scans the table, so we can piggyback on it to fetch content info for
  deduping.
* Store completion ops in temp tables to only update changed parts of
  the local tree, and remove the `mergeStates` table and views.
* Replace the `itemsToMerge` view with an indexed `itemsToApply` temp
  table.
* Replace the `updateGuidsAndSyncFlags` trigger with a `changeGuidOps`
  table and a `changeGuids` trigger.
* Replace the `updateLocalItems` trigger with an `apply_remote_items`
  function to bulk upsert new and updated items.
* Replace the `structureToMerge` view with an
  `applyNewLocalStructureOps` table that holds parents and positions
  for moved items, and an `applyNewLocalStructure` trigger to update
  them.
* Remove tombstones for revived items, update change counters, and flag
  mirror items as merged directly in `update_local_items_in_places`,
  instead of indirecting through temp tables.
* Don't mark items flagged for reupload as merged, since we'll write
  them back to the mirror after upload.
* Use a scalar subquery instead of a join in the `localTags` view to
  look up the tags root ID.
* Replace `relatedIdsToReupload` with a `Store::prepare` method that
  flags all bookmarks with keyword-URL mismatches for reupload.
* Trigger frecency updates for origins once, not for every item.
* Remove two extra scans on `itemsAdded` and `itemsChanged` when
  recording observer notifications for changed keywords.
* Notify all `bookmark-added` listeners in a single batch.

This also fixes some edge cases:

* Update root positions correctly after deleting a non-syncable root
  or item.
* Keyword-URL mismatches may reupload more items than before, but now
  ensure that all bookmarks with the same URL have the same keyword.
* Only set items with deduped GUIDs to `SYNC_STATUS_NORMAL` after
  merging.
* Bump the last modified time for modified items only.

Differential Revision: https://phabricator.services.mozilla.com/D39889

--HG--
extra : moz-landing-system : lando
2019-08-06 23:48:03 +00:00
ffxbld
6dfb6ea6a1 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D40198

--HG--
extra : moz-landing-system : lando
2019-08-01 13:24:01 +00:00
Ehsan Akhgari
f172f95ac0 Bug 1568341 - Part 4: Pre-package the anti-tracking-url-decoration.json remote settings bucket for new profiles or fresh upgrades; r=leplatrem
Differential Revision: https://phabricator.services.mozilla.com/D39922

--HG--
extra : moz-landing-system : lando
2019-07-31 19:32:07 +00:00
Luke Crouch
940333a24b Bug 1566591: catch and log RemoteSettings errors r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D39824

--HG--
extra : moz-landing-system : lando
2019-07-30 19:39:03 +00:00
Mathieu Leplatre
68a314f460 Bug 1569894 - Upgrade kinto-http-client.js to 4.7.3 r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D39852

--HG--
extra : moz-landing-system : lando
2019-07-30 13:32:45 +00:00
ffxbld
9ee911f801 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D39676

--HG--
extra : moz-landing-system : lando
2019-07-29 13:29:43 +00:00
ffxbld
b7828720b0 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D39331

--HG--
extra : moz-landing-system : lando
2019-07-25 13:20:25 +00:00
Edouard Oger
684e965f89 Bug 1556276 p2 - Build metrics-flow and legal FxA URLs. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D39033

--HG--
extra : moz-landing-system : lando
2019-07-25 01:12:31 +00:00
Edouard Oger
1c060fbfab Bug 1556276 p1 - Allow extraParams to be passed when constructing FxA URLs. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D39032

--HG--
extra : moz-landing-system : lando
2019-07-24 18:34:06 +00:00
Mathieu Leplatre
5cb0d4bf75 Bug 1563180 - Prevent synchronization to be ran in parallel multiple times r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D36921

--HG--
extra : moz-landing-system : lando
2019-07-22 13:50:04 +00:00
Mark Hammond
fb1ef8ec44 Bug 1567376 - remove support for the old custom FxA server prefs. r=eoger
Differential Revision: https://phabricator.services.mozilla.com/D38616

--HG--
extra : moz-landing-system : lando
2019-07-19 17:31:21 +00:00
ffxbld
28af937c05 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D38478

--HG--
extra : moz-landing-system : lando
2019-07-18 12:58:04 +00:00
Mark Hammond
60f4926fea Bug 1564131 - re-enable syncing of builtin themes. r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D37837

--HG--
extra : moz-landing-system : lando
2019-07-18 01:25:50 +00:00
ffxbld
4ede446d10 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D38063

--HG--
extra : moz-landing-system : lando
2019-07-15 17:06:26 +00:00
Luca Greco
55b47893cf Bug 1541496 - Ensure storage.sync does sync the data for previously synced extensions without an active extension context. r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D37413

--HG--
extra : moz-landing-system : lando
2019-07-11 14:30:20 +00:00
ffxbld
7c0acde6a7 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D37716

--HG--
extra : moz-landing-system : lando
2019-07-11 12:55:28 +00:00
Narcis Beleuzu
8478c8b076 Merge autoland to mozilla-central. a=merge 2019-07-09 06:43:17 +03:00
ffxbld
6ca9b306bd Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release 2019-07-08 17:27:36 +00:00
Coroiu Cristina
6e3840ddec Backed out changeset 7aa8180f36eb (bug 1563180) for ESlint failure 2019-07-06 19:43:30 +03:00
Mathieu Leplatre
4039e268d2 Bug 1563180 - Prevent synchronization to be ran in parallel multiple times r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D36921

--HG--
extra : moz-landing-system : lando
2019-07-06 16:05:12 +00:00
Mathieu Leplatre
326c302870 Bug 1563213 - Upgrade kinto-http-client.js to 4.7.2 r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D36752

--HG--
extra : moz-landing-system : lando
2019-07-05 13:45:56 +00:00
Jonathan Kingston
31441f82ea Bug 1560455 - rename CodebasePrincipal to ContentPrincipal. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D35504

--HG--
extra : moz-landing-system : lando
2019-07-08 16:37:45 +00:00
ffxbld
18132fb6de No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D37242

--HG--
extra : moz-landing-system : lando
2019-07-08 12:47:22 +00:00
Victor Porof
34c33b48c4 Bug 1561435 - Fix linting errors for services/, r=standard8
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35931

--HG--
extra : source : f441e31c307bc815c7f05e99c0cd8ee77344dc80
extra : intermediate-source : 7e366ab79479e3a9bbdf9e61f04cfa7b6c271990
2019-06-21 13:38:54 -07:00
Victor Porof
9d673f1f0f Bug 1561435 - Format services/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35930

--HG--
extra : source : 073567e8ded785e46382ba7e402d8da939a69d7b
2019-07-05 10:58:22 +02:00
Victor Porof
b5a4cb3848 Bug 1558517 - Pre 3.0: Remove conflicting eslint rules, and turn on "curly: all" everywhere, r=standard8
Differential Revision: https://phabricator.services.mozilla.com/D34535

--HG--
extra : source : 74ed7ee773393d305c4e948a57a1b1e32b1f12e8
extra : intermediate-source : 403d0757d61683e0a85d0bb07768eb39fbd0af72
2019-06-28 17:14:01 +02:00
Mathieu Leplatre
56afa0ab7c Bug 1559514 - Emit sync event when up-to-date if JSON dump is loaded r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D35240

--HG--
extra : moz-landing-system : lando
2019-07-04 15:15:48 +00:00
ffxbld
c3dff17808 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D36908

--HG--
extra : moz-landing-system : lando
2019-07-04 13:06:12 +00:00
Mathieu Leplatre
e661f9a03d Bug 1558710 - Make sure clients never try to push local changes r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D36718

--HG--
extra : moz-landing-system : lando
2019-07-03 13:41:21 +00:00
ffxbld
bba7a6fe2b No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D36484

--HG--
extra : moz-landing-system : lando
2019-07-01 13:15:39 +00:00
Mathieu Leplatre
3e347218c9 Bug 1560451 - Fix duplicates in list of created on sync event r=glasserc
Depends on D36171

Differential Revision: https://phabricator.services.mozilla.com/D36182

--HG--
extra : moz-landing-system : lando
2019-06-27 13:40:24 +00:00
Mathieu Leplatre
0cf601cfff Bug 1559158 - Improve performance of sync for large collections r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D36171

--HG--
extra : moz-landing-system : lando
2019-06-27 13:25:57 +00:00
ffxbld
ab68b05adf No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D36187

--HG--
extra : moz-landing-system : lando
2019-06-27 12:57:42 +00:00
Marco Bonardo
eb9461aa93 Bug 1508973 - Remove getAnnotationsForItem and unused bookmark annotations APIs. r=Standard8,lina
Differential Revision: https://phabricator.services.mozilla.com/D35009

--HG--
extra : moz-landing-system : lando
2019-06-25 15:21:53 +00:00
Mark Hammond
adf91feaf8 Bug 1538015 (part 2) - restrict when incoming synced prefs are applied. r=tcsc,pauljt,Gijs
Specifically, a "control pref" for a pref must already exist locally, or
a new preference, `services.sync.prefs.dangerously_allow_arbitrary` must
be set to true.

This also removes a few preferences from the set we sync by default based
due to potential harm which can be caused syncing inappropriate values.

Differential Revision: https://phabricator.services.mozilla.com/D29775

--HG--
extra : moz-landing-system : lando
2019-06-25 04:40:58 +00:00
Mark Hammond
e5bb9b8a73 Bug 1538015 (part 1) - test only change to tighten up the checks being made. r=tcsc
This is a test-only change to make the existing synced prefs tests more
explicit about values being checked and moves a couple of prefs around to make
things a bit clearer, which should make the test changes in part 2 clearer.

Differential Revision: https://phabricator.services.mozilla.com/D29774

--HG--
extra : moz-landing-system : lando
2019-06-25 04:40:41 +00:00
Noemi Erli
2e091fbe26 Backed out 2 changesets (bug 1559514) for failures in browser_CTP_plugins.js CLOSED TREE
Backed out changeset 157999f49345 (bug 1559514)
Backed out changeset f31cd670c9ac (bug 1559514)
2019-06-21 02:00:18 +03:00
Mathieu Leplatre
4fcd8eaee9 Bug 1559514 - Emit sync event when up-to-date if JSON dump is loaded r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D35240

--HG--
extra : moz-landing-system : lando
2019-06-20 19:02:31 +00:00
Mathieu Leplatre
5a828c9d6d Bug 1559514 - Emit sync event when JSON dump is loaded from .get() r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D35239

--HG--
extra : moz-landing-system : lando
2019-06-20 20:45:55 +00:00
ffxbld
91d0636848 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D35423

--HG--
extra : moz-landing-system : lando
2019-06-20 15:37:06 +00:00
Mathieu Leplatre
31482b455c Bug 1559114 - Optimize signature verification of Remote Settings dumps r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D34879

--HG--
extra : moz-landing-system : lando
2019-06-18 23:17:50 +00:00
Mathieu Leplatre
1d103e317f Bug 1559114 - Improve debug logging of Remote Settings r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D34878

--HG--
extra : moz-landing-system : lando
2019-06-18 23:17:47 +00:00
ffxbld
b3eeba3ad1 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D35180

--HG--
extra : moz-landing-system : lando
2019-06-17 14:27:42 +00:00
ffxbld
6a9bae1546 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D34868

--HG--
extra : moz-landing-system : lando
2019-06-13 13:48:29 +00:00
Mark Hammond
c36f7aecc7 Bug 1550967 - ensure sync's username pref is set whenever FxA has a user. r=tcsc
Differential Revision: https://phabricator.services.mozilla.com/D34309

--HG--
extra : moz-landing-system : lando
2019-06-13 01:32:07 +00:00
Mathieu Leplatre
94be713565 Bug 1558812 - Upgrade kinto-offline-client to 12.4.3 r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D34715

--HG--
extra : moz-landing-system : lando
2019-06-12 14:20:59 +00:00
Boris Zbarsky
9de72a3ac6 Bug 1557793 part 2. Stop using [array] in nsIStringBundle. r=Pike
Differential Revision: https://phabricator.services.mozilla.com/D34196

--HG--
extra : moz-landing-system : lando
2019-06-11 15:51:51 +00:00
Mathieu Leplatre
a102f01554 Bug 1543598 - Move OneCRL and Pinning blocklist clients out of services r=jcj,glasserc
Differential Revision: https://phabricator.services.mozilla.com/D32297

--HG--
rename : services/common/tests/unit/test_blocklist_onecrl.js => security/manager/ssl/tests/unit/test_blocklist_onecrl.js
rename : services/common/tests/unit/test_blocklist_pinning.js => security/manager/ssl/tests/unit/test_blocklist_pinning.js
extra : moz-landing-system : lando
2019-06-11 10:14:40 +00:00
ffxbld
d70372dc0c No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D34344

--HG--
extra : moz-landing-system : lando
2019-06-10 13:57:19 +00:00
Sebastian Hengst
3f89105d67 Backed out changeset 4f2475241df7 (bug 1550473) on request from ckerschb. a=backou
--HG--
extra : rebase_source : 8297426f6df40a9dc94fccf514ba3f4efa88889e
2019-06-06 15:33:55 +02:00
Edouard Oger
d3751d4293 Bug 1555771 - Update Sync and FxA illustrations. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D33234

--HG--
extra : moz-landing-system : lando
2019-06-05 17:46:54 +00:00
Mathieu Leplatre
ad6b27eaf9 Bug 1556761 - Stop logging 'Initialize remote settings' all the time r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D33692

--HG--
extra : moz-landing-system : lando
2019-06-05 08:05:43 +00:00
Matthew Noorenberghe
7d5f0874a4 Bug 1148205 - Replace misnamed formSubmitURL and hostname properties on nsILoginInfo in services/fxaccounts/ r=vladikoff
Differential Revision: https://phabricator.services.mozilla.com/D33348

--HG--
extra : moz-landing-system : lando
2019-06-05 03:59:55 +00:00
Matthew Noorenberghe
e7afdd4c3e Bug 1148205 - Replace misnamed formSubmitURL and hostname properties on nsILoginInfo in services/sync/ r=markh,tcsc
Differential Revision: https://phabricator.services.mozilla.com/D33347

--HG--
extra : moz-landing-system : lando
2019-06-05 03:59:46 +00:00
Lina Cambridge
ede2c0b68a Bug 1552621 - Include optional steps in Sync engine telemetry. r=tcsc,tdsmith
Before this commit, we used event telemetry to record timing and counts
for the different steps of a bookmark merge (fetching the local tree,
new local contents, remote tree, and new remote contents; merging;
applying; fetching outgoing records; and notifying observers).

This has several limitations. We need to store all numbers as strings,
include a "flow ID" to tag events from the same merge, and collect
failure reasons twice. We also can't correlate these events to the
existing engine telemetry, meaning we can't see other stats for that
engine, or for the entire sync. Finally, we need to run separate
queries on these events for analysis, instead of extending our
existing engine dashboards.

This approach also feels like an abuse of event telemetry, so this
commit adds a "steps" field for each engine in the Sync ping. Each step
has a name, time taken, and additional named counts, like the number of
items in the tree, or merged structure stats.

Currently, only the `buffered-bookmarks` engine records these steps.

Differential Revision: https://phabricator.services.mozilla.com/D33411

--HG--
extra : moz-landing-system : lando
2019-06-04 20:08:07 +00:00
Lina Cambridge
efa5e0cc06 Bug 1552621 - Record bookmark validation telemetry for the buffered engine. r=tcsc
Differential Revision: https://phabricator.services.mozilla.com/D33410

--HG--
extra : moz-landing-system : lando
2019-06-04 20:08:51 +00:00
Lina Cambridge
0c9500bf00 Bug 1552621 - Record shutdown blocker progress in the bookmarks mirror. r=markh,tcsc
This commit introduces a `mozISyncedBookmarksMirrorProgressListener`
interface for capturing telemetry and updating shutdown blocker state
after each step of the merge, instead of waiting until the end. This
also means we can also record events for interrupted and failed merges,
and pass validation data through to the Sync ping.

Shutdown hang crash reports now have a `steps` field, indicating the
sequence of completed steps and when they were recorded. If the last
step in the hang report is `fetchLocalTree`, we know the merger is
blocked on `fetchNewLocalContents`. If the last step is
`fetchNewLocalContents`, the merger is stuck at `fetchRemoteTree`,
since that's the next step after `fetchNewLocalContents`.

This commit also implements `Driver::record_telemetry_event` to
dispatch progress callback runnables to the main thread.

Differential Revision: https://phabricator.services.mozilla.com/D31950

--HG--
extra : moz-landing-system : lando
2019-06-03 23:04:37 +00:00
Coroiu Cristina
598c42a9d2 Backed out changeset 8aca39389e35 (bug 1555771) for browser-chrome failures at browser/components/extensions/test/browser/browser_ext_tabs_events.js 2019-06-04 03:22:59 +03:00
Edouard Oger
6387709163 Bug 1555771 - Update Sync and FxA illustrations. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D33234

--HG--
extra : moz-landing-system : lando
2019-06-03 21:24:42 +00:00
shindli
7849b17acb Backed out changeset 7f8884b7de4e (bug 1555771) for causing perma browser chrome failures in browser/base/content/test/sync/browser_sync.js CLOSED TREE 2019-06-03 22:14:42 +03:00
Edouard Oger
52eba7cee8 Bug 1555771 - Update Sync and FxA illustrations. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D33234

--HG--
extra : moz-landing-system : lando
2019-06-03 17:33:47 +00:00
Mathieu Leplatre
80c3d0b5ca Bug 1553831 - Fetch metadata on sync even if local data is up-to-date r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D32769

--HG--
extra : moz-landing-system : lando
2019-06-03 10:02:13 +00:00
Mathieu Leplatre
921d7af3d5 Bug 1553831 - Minor cleanups in Remote Settings client r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D32768

--HG--
extra : moz-landing-system : lando
2019-06-03 09:59:29 +00:00
ffxbld
5cd2a9bc7d No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D33506

--HG--
extra : moz-landing-system : lando
2019-06-03 15:44:26 +00:00
Brian Grinstead
402bc3a970 Bug 1553188 - Part 4 - Update remaining references to browser.xul;r=bdahl
These are generally:
- Code comments to browser.xhtml
- Testcases, assertions that were mostly using browser.xul as a generic chrome URL
- References to the browser.xul path in tree

Differential Revision: https://phabricator.services.mozilla.com/D33208
2019-05-28 16:40:42 -07:00
Dorel Luca
5e31d37927 Backed out 2 changesets (bug 1553831) for XPCshell failure in services/settings/test/unit/test_remote_settings.js
Backed out changeset d03a51956262 (bug 1553831)
Backed out changeset 4f62dfaee27f (bug 1553831)
2019-05-31 14:43:50 +03:00
Mathieu Leplatre
365261e7d6 Bug 1553995 - Remote Settings should not throw with dummy server r=glasserc,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D32549

--HG--
extra : moz-landing-system : lando
2019-05-31 09:53:05 +00:00
Mathieu Leplatre
f4957e385f Bug 1553831 - Fetch metadata on sync even if local data is up-to-date r=glasserc
Depends on D32768

Differential Revision: https://phabricator.services.mozilla.com/D32769

--HG--
extra : moz-landing-system : lando
2019-05-30 19:48:49 +00:00
Mathieu Leplatre
13c9f8aeb9 Bug 1553831 - Minor cleanups in Remote Settings client r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D32768

--HG--
extra : moz-landing-system : lando
2019-05-28 13:58:29 +00:00
ffxbld
669d19df08 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D33154

--HG--
extra : moz-landing-system : lando
2019-05-30 13:07:37 +00:00
Tom Ritter
11e541177c Bug 1539595 - Reject FXA messages if they don't come from the correct type of process r=rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D30277

--HG--
extra : moz-landing-system : lando
2019-05-29 11:32:15 +00:00
ffxbld
dafef8c4a2 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D32686

--HG--
extra : moz-landing-system : lando
2019-05-28 20:34:21 +00:00
Sebastian Hengst
fba75a919c Backed out 4 changesets (bug 1539595) for build bustage in nsAboutRedirector.cpp. CLOSED TREE
Backed out changeset 2b0bb889b087 (bug 1539595)
Backed out changeset 95f0b82ec253 (bug 1539595)
Backed out changeset 6310e6dabceb (bug 1539595)
Backed out changeset ba3e353c6957 (bug 1539595)

--HG--
rename : browser/base/content/test/tabs/browser_e10s_about_page_triggeringprincipal.js => browser/base/content/test/general/browser_e10s_about_page_triggeringprincipal.js
rename : browser/base/content/test/tabs/browser_e10s_about_process.js => browser/base/content/test/general/browser_e10s_about_process.js
rename : browser/base/content/test/tabs/browser_e10s_chrome_process.js => browser/base/content/test/general/browser_e10s_chrome_process.js
rename : browser/base/content/test/tabs/browser_e10s_javascript.js => browser/base/content/test/general/browser_e10s_javascript.js
rename : browser/base/content/test/tabs/browser_e10s_switchbrowser.js => browser/base/content/test/general/browser_e10s_switchbrowser.js
rename : browser/base/content/test/tabs/file_about_child.html => browser/base/content/test/general/file_about_child.html
rename : browser/base/content/test/tabs/file_about_parent.html => browser/base/content/test/general/file_about_parent.html
rename : browser/base/content/test/tabs/test_process_flags_chrome.html => browser/base/content/test/general/test_process_flags_chrome.html
rename : browser/base/content/test/tabs/browser_new_tab_in_privilegedabout_process_pref.js => browser/base/content/test/tabs/browser_new_tab_in_privileged_process_pref.js
2019-05-28 19:49:17 +02:00
Tom Ritter
f94a4bdb87 Bug 1539595 - Reject FXA messages if they don't come from the correct type of process r=rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D30277

--HG--
extra : moz-landing-system : lando
2019-05-28 14:09:08 +00:00
Mathieu Leplatre
9871d095db Bug 1554178 - Disable events sampling for uptake telemetry tests r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D32484

--HG--
extra : moz-landing-system : lando
2019-05-27 07:35:45 +00:00
Mathieu Leplatre
8708f07d79 Bug 1553797 - Fix OneCRL tests when MOZ_NEW_CERT_STORAGE is disabled r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D32331

--HG--
extra : moz-landing-system : lando
2019-05-24 14:32:13 +00:00
Narcis Beleuzu
b9bb66c9e0 Backed out changeset 204c7f42d427 (bug 1554178) for xpcshell failures on test_remote_settings.js . CLOSED TREE 2019-05-25 02:41:41 +03:00