Rajesh Kathiriya
48e6bc2124
Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8
...
MozReview-Commit-ID: FadrI2li43G
--HG--
extra : rebase_source : b455e846ab79c8141150517e67e542e3e06d630e
2017-07-25 23:45:41 +05:30
Sebastian Hengst
804a36e668
Backed out changeset f5922a7ed25a (bug 1374620) for failing eslint at telemetry/tests/unit/test_TelemetrySend.js:358: ["os"] is better written in dot notation. r=backout
2017-07-31 14:44:34 +02:00
Rajesh Kathiriya
22dfa54ef4
Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8
...
MozReview-Commit-ID: FadrI2li43G
--HG--
extra : rebase_source : 5992bdde34bcc2421350433bc8c1e498a6bba848
2017-07-25 23:45:41 +05:30
Jonathan Hao
331f2a04e2
Bug 1369327 - Remove low memory platform checks in reader mode. r=Gijs
...
MozReview-Commit-ID: 1VUprtntsK0
--HG--
extra : rebase_source : 389628cf2f4086e1b4354d4ab0017b670a393c21
2017-07-18 14:44:56 +08:00
Mark Banner
35f3666937
Bug 1380009 - Enable the ESLint no-return-await call to avoid unnecessary intermediate promise creation. r=mossop
...
MozReview-Commit-ID: EnhSBHMjurr
--HG--
extra : rebase_source : 74ba4c10e369067629af95bf705a9acd0df1089b
2017-07-11 22:49:55 +01:00
Gijs Kruitbosch
583c888194
Bug 1364056 - don't try to use doc
reference when it might be dead, r=baku
...
MozReview-Commit-ID: Lt7aOU8hPSV
--HG--
extra : rebase_source : 9d31f166f5e84aee958756963e2f152508994a48
2017-05-15 22:01:40 +01:00
Florian Quèze
5e3539e504
Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop.
2017-05-12 14:42:39 +02:00
Sebastian Hengst
57a0c453bb
Bug 1358248 - update uri call in log statement to fix failure detected by eslint. r=eslint-fix
2017-05-09 13:24:10 +02:00
Gijs Kruitbosch
f97861db4a
Bug 1358248, r=evanxd
...
MozReview-Commit-ID: 55otSuRxdsa
--HG--
extra : histedit_source : 025337331f01368b0620256234717242b8e1da89
2017-04-22 15:07:41 +01:00
Gijs Kruitbosch
70316b8ea8
Bug 1358248, r=nechen,evanxd
...
MozReview-Commit-ID: 1EBZFcyvmY1
--HG--
extra : histedit_source : 62066947ec5c3eb6218869be6131dcae15159d74
2017-04-22 15:00:22 +01:00
Florian Queze
37ff4fc7cc
Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws.
2017-04-14 21:51:38 +02:00
Sebastian Hengst
a07223d699
Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout
2017-04-14 23:39:22 +02:00
Florian Queze
95d4d20c17
Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws.
2017-04-14 21:51:38 +02:00
Evan Tseng
bd60fe4e05
Bug 1177360 - Disable reader mode button for amazon.com, r=Gijs
...
MozReview-Commit-ID: Cg9Gm4HCHbA
--HG--
extra : rebase_source : 59555eadd075d273d823ad5d4fd55f650b7e2520
2017-03-01 18:22:45 +08:00
Jared Wein
43bac26d30
Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
...
MozReview-Commit-ID: 6tv0Z06CO4a
--HG--
extra : rebase_source : 014c0b04d8538dc5f15bc6dd4ed6bd220c55c5d4
2017-01-17 09:48:17 -06:00
Jim Chen
e56ec60a5b
Bug 1328683 - Convert ReadingListHelper events to bundle events; r=sebastian
2017-01-10 23:01:27 -05:00
Florian Quèze
34e970eb9b
Bug 1329182 - remove trailing newURI null parameters in toolkit/, r=jaws.
2017-01-09 20:27:25 +01:00
Jared Wein
ecab54a7c9
Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
...
MozReview-Commit-ID: 7E7LPorrEje
--HG--
extra : rebase_source : 0572a35415a766a3f31d266760ecd07f0dcc3f72
2016-12-29 18:34:54 -05:00
Wes Kocher
0dfb7c2b5c
Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
...
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
7255df4e9a
Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
...
MozReview-Commit-ID: 8WoGr8i6oCR
--HG--
extra : rebase_source : da7172285d43b820421557ed3b05887e091ff939
2016-12-29 15:20:47 -05:00
fiveNinePlusR
ab0ead8b92
Bug 1265304 - Add an estimated time range to reader mode, r=gijs,ui-r=emanuela
...
Uses an upper and lower bound found from this study: http://iovs.arvojournals.org/article.aspx?articleid=2166061
--HG--
extra : amend_source : 22344c00dc23d18604d5f2b9b59e617696e73eed
2016-12-11 21:35:00 +00:00
Dave Townsend
c5bb304fd9
Bug 1316882: Turn on space-before-function-paren eslint rule (toolkit). r=jaws
...
MozReview-Commit-ID: FGFwg6TYkvm
--HG--
extra : rebase_source : 4073cebbef1694393efe312aaafbdb803adbd304
2016-11-11 15:22:34 -08:00
Wes Kocher
008fdd9329
Merge inbound to central, a=merge
2016-11-08 13:58:20 -08:00
Sébastien Blin
26b39d5a68
Bug 1189491 - Take anchors into account in the reader view, r=gijs
...
MozReview-Commit-ID: 1udixhxnVao
--HG--
rename : browser/base/content/test/general/browser_bug1124271_readerModePinnedTab.js => toolkit/components/reader/test/browser_bug1124271_readerModePinnedTab.js
rename : browser/base/content/test/general/browser_readerMode.js => toolkit/components/reader/test/browser_readerMode.js
rename : browser/base/content/test/general/browser_readerMode_hidden_nodes.js => toolkit/components/reader/test/browser_readerMode_hidden_nodes.js
rename : browser/base/content/test/general/readerModeArticle.html => toolkit/components/reader/test/readerModeArticle.html
rename : browser/base/content/test/general/readerModeArticleHiddenNodes.html => toolkit/components/reader/test/readerModeArticleHiddenNodes.html
extra : rebase_source : fe5a56da7c51be03b3f6e4fca298f15fe1cc3552
extra : intermediate-source : 1cb8dac3eb40e519ee45a3fc5a9490b889ee5fc7
extra : source : 4da7d22ebcd2fdd3047487d7c2e483093324263c
2016-11-03 05:50:00 +00:00
Evan Tseng
ecf2d44244
Bug 1173823 - Always use document.baseURI as the uri parameter of _readerParse method, r=Gijs
...
MozReview-Commit-ID: RnICyZALNb
--HG--
extra : rebase_source : 80b27a4ba1dfd2e491dad17f1ea9a2d3b744b25b
2016-11-07 17:31:23 +08:00
Sebastian Hengst
8011a32eb6
Backed out changeset 1cb8dac3eb40 (bug 1189491) for failing browser_readerMode.js. r=backout
...
--HG--
rename : toolkit/components/reader/test/browser_bug1124271_readerModePinnedTab.js => browser/base/content/test/general/browser_bug1124271_readerModePinnedTab.js
rename : toolkit/components/reader/test/browser_readerMode.js => browser/base/content/test/general/browser_readerMode.js
rename : toolkit/components/reader/test/browser_readerMode_hidden_nodes.js => browser/base/content/test/general/browser_readerMode_hidden_nodes.js
rename : toolkit/components/reader/test/readerModeArticle.html => browser/base/content/test/general/readerModeArticle.html
rename : toolkit/components/reader/test/readerModeArticleHiddenNodes.html => browser/base/content/test/general/readerModeArticleHiddenNodes.html
2016-11-05 13:54:35 +01:00
Sébastien Blin
6287f35fa4
Bug 1189491 - Take anchors into account in the reader view, r=gijs
...
MozReview-Commit-ID: 1udixhxnVao
--HG--
rename : browser/base/content/test/general/browser_bug1124271_readerModePinnedTab.js => toolkit/components/reader/test/browser_bug1124271_readerModePinnedTab.js
rename : browser/base/content/test/general/browser_readerMode.js => toolkit/components/reader/test/browser_readerMode.js
rename : browser/base/content/test/general/browser_readerMode_hidden_nodes.js => toolkit/components/reader/test/browser_readerMode_hidden_nodes.js
rename : browser/base/content/test/general/readerModeArticle.html => toolkit/components/reader/test/readerModeArticle.html
rename : browser/base/content/test/general/readerModeArticleHiddenNodes.html => toolkit/components/reader/test/readerModeArticleHiddenNodes.html
extra : source : 4da7d22ebcd2fdd3047487d7c2e483093324263c
extra : amend_source : 908bd9662f57bfe1c9be558a8fbf0b357eb0af63
2016-11-03 05:50:00 +00:00
Wes Kocher
79698719f9
Backed out changeset 4da7d22ebcd2 (bug 1189491) for multiple eslint failures a=backout CLOSED TREE
...
--HG--
rename : toolkit/components/reader/test/browser_bug1124271_readerModePinnedTab.js => browser/base/content/test/general/browser_bug1124271_readerModePinnedTab.js
rename : toolkit/components/reader/test/browser_readerMode.js => browser/base/content/test/general/browser_readerMode.js
rename : toolkit/components/reader/test/browser_readerMode_hidden_nodes.js => browser/base/content/test/general/browser_readerMode_hidden_nodes.js
rename : toolkit/components/reader/test/readerModeArticle.html => browser/base/content/test/general/readerModeArticle.html
rename : toolkit/components/reader/test/readerModeArticleHiddenNodes.html => browser/base/content/test/general/readerModeArticleHiddenNodes.html
extra : amend_source : 858e9c3c129ac9431436602580b8904d6a6b7cf0
2016-11-04 11:55:56 -07:00
Sébastien Blin
dc19409368
Bug 1189491 - Take anchors into account in the reader view, r=gijs
...
MozReview-Commit-ID: 1udixhxnVao
--HG--
rename : browser/base/content/test/general/browser_bug1124271_readerModePinnedTab.js => toolkit/components/reader/test/browser_bug1124271_readerModePinnedTab.js
rename : browser/base/content/test/general/browser_readerMode.js => toolkit/components/reader/test/browser_readerMode.js
rename : browser/base/content/test/general/browser_readerMode_hidden_nodes.js => toolkit/components/reader/test/browser_readerMode_hidden_nodes.js
rename : browser/base/content/test/general/readerModeArticle.html => toolkit/components/reader/test/readerModeArticle.html
rename : browser/base/content/test/general/readerModeArticleHiddenNodes.html => toolkit/components/reader/test/readerModeArticleHiddenNodes.html
extra : rebase_source : a0e552f409f1807d36c419a4cb93cdd88468b8cf
2016-11-03 05:50:00 +00:00
Gijs Kruitbosch
e42c48fb95
No bug, fix eslint errors introduced when enabling more rules in .eslintrc.js, rs=bustage
...
MozReview-Commit-ID: GADYtKhyd50
--HG--
extra : rebase_source : 3e2eb3ef0ab081396996cf98452d1b0a7d6bf5ab
2016-11-02 11:33:21 +01:00
Jared Wein
fd84c776c7
Bug 1292042
- Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh
...
MozReview-Commit-ID: EMjJ3yWt9Wt
--HG--
extra : rebase_source : 2b8327e5a7cf0bfd190d696ad5fe475f13faa3cc
2016-08-04 03:28:58 -04:00
Gijs Kruitbosch
e8a725d826
Bug 1281536 - remove reader mode telemetry that's out of date, extend two existing probes, r=margaret,data-r=bsmedberg
...
MozReview-Commit-ID: 2FSr4v4fPWU
--HG--
extra : rebase_source : 7b73decd9ea17a12827ba239458ac1ffd10ba14b
extra : amend_source : b4fdfc64ac3c51de403cb50418b904d9cbe34035
2016-06-24 15:39:23 +01:00
Timothy Guan-tin Chien
e3df65a0b0
Bug 1266372 - De-dup code to ReaderMode.leaveReaderMode, r=gijs
...
Additionally, implements ReaderMode.enterReaderMode.
MozReview-Commit-ID: 8MPvFhX4ws7
--HG--
extra : transplant_source : %91%0D%CEZkOO%90%1C3%A24%3E%9Bq%D5%BB%13F%0A
2016-04-26 12:52:50 +08:00
Andrzej Hunt
45f826fa31
Bug 1263628 - Ignore fragments when comparing URLs during reader view caching r=gijs
...
This seems to be a common issue with medium.com articles, but affects any page which was
opened using a fragment in the URL (e.g. foo.com/bar#baz is the same page as foo.com/bar,
however our reader view caching code didn't recognise the former as being equivalent to
the latter).
MozReview-Commit-ID: BtRmHq3sD9z
--HG--
extra : rebase_source : ac96a0a5e09c2cc60644a23cdbe8e72e94c1fcc9
extra : amend_source : 37d603820880ce751dbf571da49bbf8dcd7e6d03
extra : source : 7977a317cba8dbd983ac2988d346e01887f94a14
2016-04-15 11:17:36 -07:00
Andrzej Hunt
f099c53749
Bug 1263628 - meta-refresh can use a relative URL, ensure base URI is included r=gijs
...
E.g. articles on facebook.com provide a meta-refresh containing "0; URL=/foo/bar?....",
and we previously attempted to use just this URL component, instead of constructing it
using the current page URL.
MozReview-Commit-ID: 4vSoz5lc1e
--HG--
extra : rebase_source : 95c9c060c1b96be7e9d95eab22b9b8ffebdbbc69
extra : source : 5243687171c0bb47611e0d5ddc2e56038d1af0b3
2016-04-15 13:53:19 -07:00
Andrzej Hunt
6a00381326
Bug 1234331 - Push article into readercache when bookmarking readerview page r=margaret
...
MozReview-Commit-ID: D7Yy45xkFd8
--HG--
extra : rebase_source : 653ee379315cb9ee9bdc6103547f34282b4f930b
extra : histedit_source : 6577ff825ebfb1cdbd5a8558b3e9666cc071a0ff
2016-03-29 20:08:09 -07:00
Dave Townsend
6e44ebad84
Bug 1257246: Update toolkit for eslint 2. r=Gijs
...
Most of this is fixing functions that in some cases return a value but then
can also run to completion without returning anything. ESLint 2 catches this
where previous versions didn't. Unless there was an obvious other choice I just
made these functions return undefined at the end which is effectively what
already happens.
MozReview-Commit-ID: KHYdAkRvhVr
--HG--
extra : rebase_source : 720cc9d864175248508146a7f4704b4bf3f02439
extra : histedit_source : 6cc0ecbf21a571e1a41d517b67512a3452fac19a
2016-04-05 11:33:48 -07:00
Gijs Kruitbosch
a8ddd18486
Bug 1210366 - block youtube and pinterest from reader mode, r=MattN
...
--HG--
extra : commitid : 9yhZga6Ky4v
extra : rebase_source : 3b7f362b63fdb502da2aa39be38f4d6c7ffd684a
2016-01-12 18:57:38 +00:00
Gijs Kruitbosch
214bd6a3f9
Bug 1222792 - fix comparing escaped URIs in reader mode when detecting redirects, r=margaret
...
--HG--
extra : commitid : 70OdQAGYdRh
extra : rebase_source : 45bbb481643776eeff880794c292ddb2bcc32841
2015-12-15 15:57:03 +00:00
Dave Townsend
6fcdc1e67d
Bug 1229519: Fix miscellaneous parts of toolkit to pass eslint checks. r=MattN
...
--HG--
extra : commitid : 1iLsb7ZpSpI
extra : rebase_source : ed920934f04e520f5410454ec3930cd5992aa965
2015-12-03 10:02:45 -08:00
Gijs Kruitbosch
268d43a9b6
Bug 1195976, r=bnicholson
...
--HG--
extra : commitid : 5DPNingTUyr
extra : histedit_source : e8a169bc2481f75cc61e869a93239a08cd69d2d0
2015-08-27 13:20:47 +01:00
Gijs Kruitbosch
127aeefe17
Bug 1182778, r=margaret,f=bz
...
--HG--
extra : commitid : ATLsconKiIq
extra : rebase_source : 4e6c3207ce438c4429dc32695dcbc4fbf5a2c022
2015-07-17 13:30:42 +01:00
Frederik Braun
90d0900a2f
Bug 1184056 - Non-case sensitive redirects in reader mode. r=margaret
2015-07-15 18:25:10 +02:00
Gijs Kruitbosch
cc921d71fa
Bug 1172270 - don't cause extra flushes for reader mode, r=margaret,smaug
...
--HG--
rename : browser/base/content/test/general/browser_readerMode.js => browser/base/content/test/general/browser_readerMode_hidden_nodes.js
rename : browser/base/content/test/general/readerModeArticle.html => browser/base/content/test/general/readerModeArticleHiddenNodes.html
extra : rebase_source : 184f260d55a83e866b20befda517ffe42a704002
extra : histedit_source : 4da59cfad20b681e6af20d53df03d4ed4b1ab2fb
2015-06-08 16:56:34 +01:00
Gijs Kruitbosch
914f8c67b1
Bug 1172009 - don't show reader mode button for file:///, r=margaret
...
--HG--
extra : rebase_source : 03ea4b1f995ca16e21380b1e85b25bb2ee7c4857
extra : histedit_source : c672d0100c81a025faef5e9015bbef137e7d59a2
2015-06-09 13:48:11 +01:00
Margaret Leibovic
b921c823ab
Bug 1166364 - Fix typo in telemetry probe. r=me
2015-05-19 10:33:00 -07:00
Gijs Kruitbosch
4276f1730c
Bug 1164426 - build reader mode blocklist, r=margaret
...
--HG--
extra : rebase_source : f17054b616a47a70194a083d749c0858fe299864
2015-05-15 00:31:39 +01:00
Margaret Leibovic
d16da0c2cd
Bug 1129029 - Telemetry probes for reader mode performance. r=Gijs
...
--HG--
extra : rebase_source : 84d342b520b9fdec97c5c2dc406aff9576eab36f
2015-04-30 14:51:02 -07:00
Gijs Kruitbosch
5530655991
Bug 1160775
- fix reader mode detection to force 1 flush so we don't think the entire page is invisible, r=margaret
...
--HG--
extra : rebase_source : b714449d1ca3894a38662e28d6592824f5907f89
2015-05-06 17:40:20 +01:00
Margaret Leibovic
2371b1312f
Bug 1158228 - Disable visibility check helper function to avoid test bustage. rs=me
...
--HG--
extra : rebase_source : 5e78d06ec4595aebb98339d789d8c21c46a3e4f4
2015-05-02 07:29:12 -07:00