Sylvestre Ledru
4c29c24344
Bug 1856530 - run file-whitespace on toml files r=linter-reviewers,Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D189896
2023-10-03 09:22:18 +00:00
Joel Maher
1bd2e4bdf6
Bug 1853245 - Migrate .ini manifests to .toml (Batch 7.5). r=aryx,extension-reviewers,robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D189264
2023-09-29 11:38:53 +00:00
Jan Varga
c458754592
Bug 1855134 - Move existing MOZ_TRY macros to a dedicated header file; r=glandium
...
Differential Revision: https://phabricator.services.mozilla.com/D189226
2023-09-28 20:46:07 +00:00
Nika Layzell
a2f7e06013
Bug 1841660 - Fix potential deadlock waiting for StartupCache ThreadedPrefetch, r=jesup
...
In a previous change to this logic, we missed a hidden early return in
the `MMAP_FAULT_HANDLER_CATCH()` macro which can early return on both
Linux and Windows. If this is hit, we could end up blocking at various
points waiting for the StartupCache to be prefetched.
This patch changes the logic to notify to happen in a ScopeExit instead,
ensuring that it'll happen on all return paths.
In addition, there was another potential deadlock due to the
ThreadedPrefetch thread acquiring mTableLock. This was fixed by passing
in the pointers in the runnable instead. This should be OK as we are
making sure to block on ThreadedPrefetch before we clear the startup
data already.
Differential Revision: https://phabricator.services.mozilla.com/D182732
2023-07-04 19:05:06 +00:00
Mark Banner
8219a5c503
Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
...
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Otto Länd
50897e24f4
Bug 1724509: apply code formatting via Lando
...
# ignore-this-changeset
2023-05-17 20:06:03 +00:00
Kris Maglione
5061dadd5a
Bug 1724509: Part 2 - Don't load preloader caches when startup cache is being ignored. r=mccr8
...
Differential Revision: https://phabricator.services.mozilla.com/D122029
2023-05-17 20:03:19 +00:00
Randell Jesup
271058f7fc
Bug 1828265: Remove StartupCache temporary prefetch thread r=kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D175551
2023-04-22 13:58:06 +00:00
Randell Jesup
95f7a79d8e
Bug 1746447: StartupCache cleanup r=mccr8
...
Differential Revision: https://phabricator.services.mozilla.com/D138961
2023-04-22 13:58:05 +00:00
serge-sans-paille
e6ba96df3d
Bug 1817313 - Make startupcache/ buildable outside of a unified build environment r=andi
...
Differential Revision: https://phabricator.services.mozilla.com/D170124
2023-02-19 21:40:36 +00:00
Norisz Fay
d85572c196
Backed out 11 changesets (bug 1817309, bug 1817315, bug 1817313, bug 1817317, bug 1817310, bug 1817314, bug 1817308
, bug 1817312, bug 1817311, bug 1817316, bug 1817318) for causing build bustages on nss_secutil.h CLOSED TREE
...
Backed out changeset 288b4848b023 (bug 1817308
)
Backed out changeset 6ac5107e1c81 (bug 1817309)
Backed out changeset 6f6e7a258930 (bug 1817310)
Backed out changeset 32cadd62fec3 (bug 1817311)
Backed out changeset 5bfcee2bfb8b (bug 1817312)
Backed out changeset bfd59ae03c4f (bug 1817313)
Backed out changeset 0080bdd6ab3f (bug 1817314)
Backed out changeset e1e81a3a933d (bug 1817315)
Backed out changeset 151d9b5d1883 (bug 1817316)
Backed out changeset 1b03cabc6e5a (bug 1817317)
Backed out changeset 52b44c5d4b08 (bug 1817318)
2023-02-19 18:37:26 +02:00
serge-sans-paille
137c5ce4e6
Bug 1817313 - Make startupcache/ buildable outside of a unified build environment r=andi
...
Differential Revision: https://phabricator.services.mozilla.com/D170124
2023-02-19 15:33:55 +00:00
Csoregi Natalia
41e332d499
Backed out 11 changesets (bug 1817308
, bug 1817311, bug 1817317, bug 1817310, bug 1817309, bug 1817314, bug 1817316, bug 1817318, bug 1817313, bug 1817312, bug 1817315) for causing hybrid bustage on WrapperFactory.cpp. CLOSED TREE
...
Backed out changeset 1fb2fdbeecec (bug 1817308
)
Backed out changeset 7153cb681119 (bug 1817309)
Backed out changeset 44e4198e2cdc (bug 1817310)
Backed out changeset ef9b097a07c4 (bug 1817311)
Backed out changeset e6f4e9a4cfc6 (bug 1817312)
Backed out changeset 4fa0b794c1e1 (bug 1817313)
Backed out changeset 13841a7b93a6 (bug 1817314)
Backed out changeset af16df862459 (bug 1817315)
Backed out changeset a157a7c3146f (bug 1817316)
Backed out changeset f9048fa7e1d9 (bug 1817317)
Backed out changeset 10219437a634 (bug 1817318)
2023-02-18 01:58:57 +02:00
serge-sans-paille
ca79bf4993
Bug 1817313 - Make startupcache/ buildable outside of a unified build environment r=andi
...
Depends on D170123
Differential Revision: https://phabricator.services.mozilla.com/D170124
2023-02-17 22:17:43 +00:00
Tooru Fujisawa
e5c2ee72c8
Bug 1800050 - Use UniqueFreePtr in StartupCache::PutBuffer. r=nbp
...
Differential Revision: https://phabricator.services.mozilla.com/D163453
2022-12-01 10:46:34 +00:00
Kagami Sascha Rosylight
fac20df060
Bug 1796085 - Part 1: Define MOZ_BACKGROUNDTASKS macro globally r=smaug,necko-reviewers,application-update-reviewers,nalexander,valentin
...
There are 10+ separate macro definition for this, we can do it globally instead.
Differential Revision: https://phabricator.services.mozilla.com/D156911
2022-10-19 12:04:08 +00:00
Nika Layzell
0316dc51b9
Bug 1790614 - Part 2: Use {ASSERT,ENSURE}_NS_{SUCCEEEDED,FAILED} in gtests, r=ahal,necko-reviewers
...
These macros will produce better outputs when they fail than these existing
patterns using `ENSURE_TRUE(NS_SUCCEEDED(...))` or similar, so this is a bulk
rewrite of existing tests to use them.
It should also help with discoverability when people base their tests off of
other existing tests.
Differential Revision: https://phabricator.services.mozilla.com/D157214
2022-09-15 14:51:50 +00:00
Fabrice Desré
c50cb528fc
Bug 1761040 - Prefix thread safety macros with MOZ_ r=geckoview-reviewers,media-playback-reviewers,alwu,jesup,m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D152575
2022-08-03 16:39:41 +00:00
Andreea Pavel
3ccd75af8d
Backed out changeset b9d2965591b9 (bug 1761040) for landing with wrong author CLOSED TREE DONTBUILD
2022-08-03 18:55:00 +03:00
Andreea Pavel
fdb7cb2ecd
Bug 1761040 - Prefix thread safety macros with MOZ_ r=geckoview-reviewers,media-playback-reviewers,alwu,jesup,m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D152575
2022-08-03 15:27:43 +00:00
Andreea Pavel
89d63c91e6
Backed out changeset a907159a482f (bug 1761040) for causing build bustages on a CLOSED TREE
2022-08-02 04:59:08 +03:00
Fabrice Desré
0f4ac7ad97
Bug 1761040 - Prefix thread safety macros with MOZ_ r=geckoview-reviewers,media-playback-reviewers,alwu,jesup,m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D152575
2022-08-02 00:49:41 +00:00
Nika Layzell
997047e2a4
Bug 1772006 - Part 4: Simplify and move the string comparison APIs from ns[T]StringObsolete, r=xpcom-reviewers,necko-reviewers,dragana,barret
...
This patch moves EqualsIgnoreCase to ns[T]StringObsolete, and removes
the aCount argument, instead migrating callers to use `StringBeginsWith`
with a case-insensitive comparator.
In addition, nsTStringRepr::Compare was removed and replaced with either
calls to methods like `StringBeginsWith` or the global `Compare` method.
These changes required some modifications at call-sites but should make
the behaviour less surprising and more consistent.
Differential Revision: https://phabricator.services.mozilla.com/D148299
2022-07-30 00:12:48 +00:00
Tooru Fujisawa
1332af1b0d
Bug 1777486 - Part 8: Update testcase comments that mentions XPCOMUtils. r=kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D151220
2022-07-12 04:21:37 +00:00
Andreea Pavel
7738a75fdd
Backed out 11 changesets (Bug 1777486) for failing bc at browser_startup.js on a CLOSED TREE
...
Backed out changeset b6c4c386f1a6 (Bug 1777486)
Backed out changeset 195cc2de8433 (Bug 1777486)
Backed out changeset 20c746fb1648 (Bug 1777486)
Backed out changeset d5fd8173d62d (Bug 1777486)
Backed out changeset 6d758fab5a3e (Bug 1777486)
Backed out changeset e938b601ba15 (Bug 1777486)
Backed out changeset 0c4ea0b9416b (Bug 1777486)
Backed out changeset 0559c53cc668 (Bug 1777486)
Backed out changeset eea573d3a9f9 (Bug 1777486)
Backed out changeset 9ce3a6496a49 (bug 1777486)
Backed out changeset b0867652fc48 (bug 1777486)
2022-07-11 22:24:40 +03:00
Tooru Fujisawa
6a043ab687
Bug 1777486 - Part 8: Update testcase comments that mentions XPCOMUtils. r=kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D151220
2022-07-11 15:09:16 +00:00
criss
c6b2c5db61
Backed out 9 changesets (bug 1772006) causing build bustages on nsTString.cpp. CLOSED TREE
...
Backed out changeset f17c7565707b (bug 1772006)
Backed out changeset c725fe1f5882 (bug 1772006)
Backed out changeset d19663161261 (bug 1772006)
Backed out changeset b6611ab002d9 (bug 1772006)
Backed out changeset 790f42b64af9 (bug 1772006)
Backed out changeset 79a734b4e4d9 (bug 1772006)
Backed out changeset 42730aae16ea (bug 1772006)
Backed out changeset b2542aef3054 (bug 1772006)
Backed out changeset 962bfea4a309 (bug 1772006)
2022-06-11 01:13:42 +03:00
Nika Layzell
1475267b8c
Bug 1772006 - Part 5: Simplify and move the string comparison APIs from ns[T]StringObsolete, r=xpcom-reviewers,necko-reviewers,dragana,barret
...
In addition to moving these methods to a more appropriate file, they were
simplified to make them easier to maintain in the future.
nsTStringRepr::Compare was extended to also work on char16_t strings, and the
case insensitive and other options were removed as they aren't necessary. This
required some changes to callers in the tree.
The EqualsIgnoreCase method was also simplified by using `std::string_view`.
Differential Revision: https://phabricator.services.mozilla.com/D148299
2022-06-10 21:12:07 +00:00
Tooru Fujisawa
4de0e49a0d
Bug 1752212 - Part 1: Pass loader type to PathifyURI. r=nbp
...
Differential Revision: https://phabricator.services.mozilla.com/D143574
2022-04-13 14:08:06 +00:00
criss
1d40b54278
Backed out 3 changesets (bug 1752209, bug 1752212) for causing build bustages on nsXULPrototypeCache.cpp. CLOSED TREE
...
Backed out changeset 8f10b666008a (bug 1752209)
Backed out changeset 557c428fb6bc (bug 1752212)
Backed out changeset e38fbd381ed3 (bug 1752212)
2022-04-13 16:09:50 +03:00
Tooru Fujisawa
7f252a9982
Bug 1752212 - Part 1: Pass loader type to PathifyURI. r=nbp
...
Differential Revision: https://phabricator.services.mozilla.com/D143574
2022-04-13 11:41:10 +00:00
Jan Rio Krause
057785b6d5
Bug 1519200 - Remove NS_ERROR_FILE_TARGET_DOES_NOT_EXIST
in favor of NS_ERROR_FILE_NOT_FOUND
. r=xpcom-reviewers,nika,dom-storage-reviewers,jstutte
...
Differential Revision: https://phabricator.services.mozilla.com/D77575
2022-04-05 15:17:03 +00:00
Greg Tatum
c7b453b99a
Bug 1755181 - Allow live language reloading to invalidate the startup cache; r=dthayer
...
The startup cache essentially leaks memory here for the old startup cache
data. My assumption here is that there can be dangling pointers into this
data so it's not safe to delete these old tables. Live language switching
is a relatively rare event, so this leak should be acceptable compared to
adding locking mechanisms to the underlying data.
Differential Revision: https://phabricator.services.mozilla.com/D140968
2022-03-22 15:19:47 +00:00
Randell Jesup
c5917ed65a
Bug 1207753: Basic thread-safety annotations to quiet errors until real annotations land r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D141062
2022-03-17 18:39:15 +00:00
Randell Jesup
fcaf70841e
Bug 1207753 - Add MOZ_UNANNOTATED to all Mutexes/Monitors r=nika,kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D140849
2022-03-16 18:47:08 +00:00
Noemi Erli
2390d257e6
Backed out changeset 12a59e5a50bf (bug 1207753) for causing build bustage CLOSED TREE
2022-03-16 18:32:51 +02:00
Randell Jesup
4b033a5256
Bug 1207753 - Add MOZ_UNANNOTATED to all Mutexes/Monitors r=nika,kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D140849
2022-03-16 16:16:14 +00:00
Butkovits Atila
927ad62c6a
Backed out changeset a68ee4b09f92 (bug 1207753) for causing Hazard bustages. CLOSED TREE
2022-03-16 14:38:14 +02:00
Randell Jesup
7d4b5fae04
Bug 1207753 - Add MOZ_UNANNOTATED to all Mutexes/Monitors r=nika,kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D140849
2022-03-16 12:01:14 +00:00
Iulian Moraru
64193785d4
Backed out 3 changesets (bug 1724509) for causing marionette failures. CLOSED TREE
...
Backed out changeset d47ffc49daff (bug 1724509)
Backed out changeset b267592b49db (bug 1724509)
Backed out changeset b34151a18850 (bug 1724509)
2021-10-06 03:57:57 +03:00
Kris Maglione
ad9c87880c
Bug 1724509: Part 2 - Don't load preloader caches when startup cache is being ignored. r=mccr8
...
Differential Revision: https://phabricator.services.mozilla.com/D122029
2021-10-05 19:06:43 +00:00
Andi-Bogdan Postelnicu
2fc4f70e9b
Bug 1725145 - Preparation for the hybrid build env. r=necko-reviewers,firefox-build-system-reviewers,valentin,glandium
...
Automatically generated path that adds flag `REQUIRES_UNIFIED_BUILD = True` to `moz.build`
when the module governed by the build config file is not buildable outside on the unified environment.
This needs to be done in order to have a hybrid build system that adds the possibility of combing
unified build components with ones that are built outside of the unified eco system.
Differential Revision: https://phabricator.services.mozilla.com/D122345
2021-08-25 10:46:17 +00:00
Simon Giesecke
146858a245
Bug 708901 - Migrate to nsTHashSet in startupcache. r=dthayer
...
Depends on D109325
Differential Revision: https://phabricator.services.mozilla.com/D109326
2021-03-23 10:36:39 +00:00
sachinchauhan2889@gmail.com
9834c92a95
Bug 1688511 - do not use 'else' after 'return'. r=sylvestre
...
Differential Revision: https://phabricator.services.mozilla.com/D103970
2021-02-04 09:24:19 +00:00
Dave Townsend
b57ef60b0e
Bug 1667276 - Pre: Disable the startup cache when running a background task. r=dthayer
...
Differential Revision: https://phabricator.services.mozilla.com/D95198
2021-01-27 22:53:54 +00:00
Butkovits Atila
89fe8f250d
Backed out 8 changesets (bug 1679440, bug 1682069, bug 1667276) for causing failure on test_crash_backgroundtask_moz_crash.js. CLOSED TREE
...
Backed out changeset f06504e3219f (bug 1682069)
Backed out changeset 4d325f68ea24 (bug 1679440)
Backed out changeset 9ab334e527a5 (bug 1667276)
Backed out changeset 1c8d51d2c90f (bug 1667276)
Backed out changeset 8d6f10d83c6b (bug 1667276)
Backed out changeset 62488ec634f9 (bug 1667276)
Backed out changeset 1dcb2d1be264 (bug 1667276)
Backed out changeset c673fff5bd85 (bug 1667276)
2021-01-27 22:17:17 +02:00
Dave Townsend
dedd68dcac
Bug 1667276 - Pre: Disable the startup cache when running a background task. r=dthayer
...
Differential Revision: https://phabricator.services.mozilla.com/D95198
2021-01-26 21:54:12 +00:00
Csoregi Natalia
0b28701943
Backed out 8 changesets (bug 1679440, bug 1682069, bug 1667276) for causing failures on browser_all_files_referenced.js. CLOSED TREE
...
Backed out changeset f1a65c9b3ca2 (bug 1682069)
Backed out changeset 310d2116faf7 (bug 1679440)
Backed out changeset f970ef0897cd (bug 1667276)
Backed out changeset 38c20196aabc (bug 1667276)
Backed out changeset 60c2f2dbc676 (bug 1667276)
Backed out changeset cf52687c4433 (bug 1667276)
Backed out changeset 74580a0f2633 (bug 1667276)
Backed out changeset ab6f830f6e75 (bug 1667276)
2021-01-26 06:49:04 +02:00
Dave Townsend
deb11ffd7f
Bug 1667276 - Pre: Disable the startup cache when running a background task. r=dthayer
...
Differential Revision: https://phabricator.services.mozilla.com/D95198
2021-01-25 23:55:58 +00:00
Simon Giesecke
971b645fe3
Bug 1660470 - Add missing include directives/forward declarations. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D87865
2020-11-23 16:21:38 +00:00