Commit Graph

82 Commits

Author SHA1 Message Date
Mark Banner
0df151fa88 Bug 1500476 - Re-implement FX_URLBAR_SELECTED_RESULT_METHOD on the new Quantumbar. r=dao
This doesn't enable the rightClick option for telemetry reporting as that is complicated to support, see bug 1528250.

Differential Revision: https://phabricator.services.mozilla.com/D19951

--HG--
extra : moz-landing-system : lando
2019-02-17 06:57:58 +00:00
Kris Maglione
e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
Ehsan Akhgari
d4b2c4dbef Bug 1511818 - Keep track of unique domains with a valid hostname for the purposes of the automatic access grant heuristics of the Storage Access API r=mikedeboer
This is an attempt to fix a Talos regression caused by the cost of URL
parsing.  The approach I'm taking here is to modify the requirements of
bug 1509047 part 2 slightly so that I can remove the expensive code
which resulted in the Talos regression.

The change in behaviour is that the automatic access grants for the
Storage Access API will use the number of unique domains visited in the
session as opposed to the number of unique origins visited.

Differential Revision: https://phabricator.services.mozilla.com/D14156

--HG--
extra : moz-landing-system : lando
2018-12-12 15:21:32 +00:00
Mark Banner
47d25a826d Bug 1505411 - Add basic monitoring for partner search pages with ads and clicks. Depends on D11188 r=adw,Felipe,chutten
Differential Revision: https://phabricator.services.mozilla.com/D11656

--HG--
extra : moz-landing-system : lando
2018-12-05 20:33:01 +00:00
Ehsan Akhgari
4aa18e126d Bug 1509047 - Part 2: Add an API for measuring the number of unique origins visited in the past 24 hours; r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D12863
2018-11-29 00:45:06 -05:00
Drew Willcoxon
b8258389b8 Bug 1499193 - Follow-up 2: Update SEARCH_COUNTS key r=mkaply
Change the `<engine>.<alias>.urlbar` `SEARCH_COUNTS` keys to `<engine>.alias` as described in bug 1499193 comment 23 and later.

Differential Revision: https://phabricator.services.mozilla.com/D12038

--HG--
extra : moz-landing-system : lando
2018-11-16 21:15:54 +00:00
Mark Banner
7e8a95c1c9 Bug 1505456 - Move recordSearchURLTelemetry to its own module. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D11188

--HG--
rename : toolkit/components/search/tests/xpcshell/test_urltelemetry.js => browser/components/search/test/unit/test_urlTelemetry.js
extra : moz-landing-system : lando
2018-11-15 14:45:20 +00:00
Michael Kaply
fb81651d50 Bug 1504686 - Don't count search for same document changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D11394

--HG--
extra : moz-landing-system : lando
2018-11-09 11:24:59 +00:00
Drew Willcoxon
9fbda91757 Bug 1504370 - Update SEARCH_COUNTS telemetry for private browsing mode r=mkaply
* If a search is performed in a private window and the new pref `browser.engagement.search_counts.pbm` is true, then do not record `SEARCH_COUNTS` telemetry. Note that the the pref must be true. If it's false or doesn't exist, then we record telemetry even in pbm like we normally do currently. (We record `SEARCH_COUNTS` telemetry in two places: (1) In BrowserUsageTelemetry.jsm, and (2) "in-content" telemetry directly in the search service. So skip both of those places.)
* Also skip the other ancillary telemetry recorded by `BrowserUsageTelemetry._recordSearch`: a keyed scalar and a telemetry event.
* I made some modifications to the search service to let me test the "in-content" telemetry keys

Differential Revision: https://phabricator.services.mozilla.com/D10851

--HG--
extra : moz-landing-system : lando
2018-11-06 17:58:07 +00:00
Drew Willcoxon
28cc94facb Bug 1499193 - Add new SEARCH_COUNTS telemetry for internal search engine alias usage. r=mkaply
Modify `BrowserUsageTelemetry.recordSearch` to take an alias instead of the bool `isAlias`. If an alias is given and it's an internal alias of the given engine, then increment a new `"engineName.@engine.source"` key under the `SEARCH_COUNTS` histogram -- in addition to incrementing the usual `"engineName.source"` key under that same histogram.

Differential Revision: https://phabricator.services.mozilla.com/D10633

--HG--
extra : moz-landing-system : lando
2018-11-03 16:47:16 +00:00
Michael Kaply
44622e08e5 Bug 1492233 - Add telemetry for search from webextension. r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D6262

--HG--
extra : moz-landing-system : lando
2018-09-21 20:08:28 +00:00
Michael Kaply
4adab6a925 Bug 1482158 - Add telemetry for other major engines. r=mikedeboer
--HG--
extra : amend_source : b98d9a76daed3ec0dd27ec2a91d998d19645a0ad
2018-09-06 16:14:25 -05:00
Tiberius Oros
9df3c85d93 Backed out changeset b38e10e9dcf8 (bug 1482158) for eslint failure at builds/worker/checkouts/gecko/browser/modules/BrowserUsageTelemetry.jsm on a CLOSED TREE 2018-09-10 23:37:11 +03:00
Michael Kaply
5d4baca1a6 Bug 1482158 - Add telemetry for other major engines. r=mikedeboer
--HG--
extra : amend_source : 0097cbe78a73cba3250a98978e1094d20c5024be
2018-09-06 16:14:25 -05:00
Mark Banner
691543ee89 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439

--HG--
extra : moz-landing-system : lando
2018-08-31 05:59:17 +00:00
Bianca Danforth
16d89ecabc Bug 1457226 - Revert Savant Shield study commits; r=rhelmer
The Savant pref flip Shield study was ended on 08-20-18 (https://bugzilla.mozilla.org/show_bug.cgi?id=1457226#c28), so this patch removes all temporary study code from Firefox.

Differential Revision: https://phabricator.services.mozilla.com/D4285

--HG--
extra : moz-landing-system : lando
2018-08-27 18:17:43 +00:00
Kris Maglione
80327d3561 Bug 1484496: Part 5a - Convert browser/ nsISimpleEnumerator users to use JS iteration. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D3729

--HG--
extra : rebase_source : e187b8e9a6b6db7ebc762adda5e489b25c7a7e43
extra : histedit_source : 868cb99d09954a51d6be321fcb516475ef70eb33
2018-08-18 19:27:33 -07:00
Michael Kaply
925e710ffa Bug 1483939 - Account for anchor when creating URLSearchParams. r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D3525

--HG--
extra : moz-landing-system : lando
2018-08-17 17:58:23 +00:00
Michael Kaply
494e9c1b45 Bug 1481869 - Correct in-content reporting payload r=Dolske
Differential Revision: https://phabricator.services.mozilla.com/D3124

--HG--
extra : moz-landing-system : lando
2018-08-10 20:34:56 +00:00
Michael Kaply
0880b79763 Bug 1475571 - Replace follow-on addon with in tree telemetry. r=mikedeboer,florian
Differential Revision: https://phabricator.services.mozilla.com/D2125

--HG--
extra : moz-landing-system : lando
2018-08-07 11:59:16 +00:00
Tiberius Oros
a6e0ebd8ef Backed out changeset 502893089232 (bug 1475571) for browser_preferences_usage.js on a CLOSED TREE 2018-08-07 04:46:22 +03:00
Michael Kaply
5eb09563bc Bug 1475571 - Replace follow-on addon with in tree telemetry. r=mikedeboer,florian
Differential Revision: https://phabricator.services.mozilla.com/D2125

--HG--
extra : moz-landing-system : lando
2018-08-06 22:02:02 +00:00
Michael Kaply
6cf31b8253 Bug 1477042 - Add a pref for counting URIs in private browsing mode. r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D2479

--HG--
extra : moz-landing-system : lando
2018-07-27 22:45:29 +00:00
Cosmin Sabou
09e026181d Backed out changeset c03547ff0797 (bug 1477042) for browser chrome failures on browser_address_edit. CLOSED TREE 2018-07-28 00:17:19 +03:00
Michael Kaply
7f005b8d0d Bug 1477042 - Add a pref for counting URIs in private browsing mode. r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D2479

--HG--
extra : moz-landing-system : lando
2018-07-27 20:00:12 +00:00
Mark Banner
6feaa5a9c3 Bug 1478308 - Remove unnecessary ChromeUtils.imports in browser/ r=mikedeboer
MozReview-Commit-ID: BYTDdLU2HoM

--HG--
extra : rebase_source : 1e31ff288280d09ae226cdc698331263ba969205
2018-07-25 09:10:07 +01:00
Narcis Beleuzu
d47c829065 Backed out 4 changesets (bug 1478308) for ESlint failure on AttributionCode.jsm. CLOSED TREE
Backed out changeset a809b45ff49b (bug 1478308)
Backed out changeset c68131530742 (bug 1478308)
Backed out changeset 0e4ba7a6dc1a (bug 1478308)
Backed out changeset 32a27f317a77 (bug 1478308)
2018-07-26 11:13:28 +03:00
Mark Banner
180233c593 Bug 1478308 - Remove unnecessary ChromeUtils.imports in browser/ r=mikedeboer
MozReview-Commit-ID: BYTDdLU2HoM

--HG--
extra : rebase_source : 67dc15c0cdff0234d3274f1a8978d1f2a5b3f411
2018-07-25 09:10:07 +01:00
Bianca Danforth
dc4455c3b2 Bug 1465704 - Add follow_urlbar_link event telemetry for Savant Shield study; r=adw
These probes will register and record (for the duration of the study only):
* When the user clicks on a history link displayed by the urlbar
* When the user clicks on a bookmark link displayed by the urlbar

It should be noted that the same site can be multiple result types at the same time, so there will be times when a bookmark and/or history selection is captured as a result type other than bookmark or history (e.g. 'switchtab', 'autofill' or 'visiturl').

MozReview-Commit-ID: FEKVoaTIkiH

--HG--
extra : rebase_source : 26a84bd3c58fe24c293448f2d60e413ec62c682d
2018-06-06 03:51:01 -07:00
Bianca Danforth
e28be9ee4b Bug 1462725 - Dupe 'search' event probe under 'savant' category; r=rhelmer
The duplication is so that this study’s use of the probe does not affect and is not affected by other uses of the probe.

MozReview-Commit-ID: 5JUbiQdZc3R

--HG--
extra : rebase_source : edcc1ece90b8cc6a072703914bcfc1e6c87b7670
2018-06-04 16:19:51 -07:00
Kris Maglione
a259026c9d Bug 1456035: Part 4 - Convert callers of XPCOMUtils.generateQI to ChromeUtils.generateQI. r=mccr8
This also removes any redundant Ci.nsISupports elements in the interface
lists.

This was done using the following script:

acecb401b7/processors/chromeutils-generateQI.jsm

MozReview-Commit-ID: AIx10P8GpZY

--HG--
extra : rebase_source : a29c07530586dc18ba040f19215475ac20fcfb3b
2018-04-22 20:55:06 -07:00
Boris Zbarsky
45a3faf8f6 Bug 1455052 part 12. Remove JS uses of nsIDOMEvent. r=masayuki,kmag
MozReview-Commit-ID: 5g0H3rzxTXt
2018-04-20 12:55:31 -04:00
Marco Bonardo
257c0cb28b Bug 1452890 - Move address bar right-click selection from 'enterSelection' to its own histogram bucket. r=adw
MozReview-Commit-ID: AcP7Spl0sdZ

--HG--
extra : rebase_source : 9de517c50674956526c0de4bc91fbf2ab6e02afc
2018-04-13 16:11:19 +02:00
Boris Zbarsky
837dc7eaaa Bug 1446711 part 8. Get rid of nsIDOMMouseEvent. r=qdot
MozReview-Commit-ID: 2FK1MA4LGZj
2018-03-20 00:16:07 -04:00
Marco Bonardo
e381a1f62d Bug 1437803 - Add telemetry to understand how many users use TAB to cycle through Address Bar results. r=adw,dzeber
MozReview-Commit-ID: 6zdiIoxVIn1

--HG--
extra : rebase_source : a7d3ba1873fece0e82c0e6cee70bc74260df9630
2018-02-27 18:13:59 +01:00
Florian Quèze
682b1ec3b2 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Andrew McCreight
5dec0e0beb Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG

--HG--
extra : rebase_source : d9c41878036c1ef7766ef5e91a7005025bc1d72b
2018-02-06 09:36:57 -08:00
Kris Maglione
918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
2018-01-29 15:20:18 -08:00
Cosmin Sabou
9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
2018-01-29 15:20:18 -08:00
Brindusan Cristian
af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
2018-01-29 15:20:18 -08:00
Myk Melez
e7777b5ded Bug 1414386 - ensure BrowserUsageTelemetry is inited before uniniting it; r=mak 2017-11-06 10:43:25 -08:00
Michael Kaply
84dc410d2d Bug 1378461 - Report other search engine names. r=mak, data-r=rweiss
--HG--
extra : rebase_source : 0b3088af1691db055a13feeff86041e6ab6346b2
2017-09-06 17:36:07 -05:00
Sebastian Hengst
ec19d57d55 Backed out changeset 9018e3691e11 (bug 1378461) for failing browser-chrome's browser_oneOffContextMenu.js. r=backout 2017-09-07 00:26:17 +02:00
Michael Kaply
55f5d65f9d Bug 1378461 - Report other search engine names. r=mak, data-r=rweiss
--HG--
extra : rebase_source : bc3d6c3f8bc4931d3aa3e25801e89e94387afdc2
2017-09-06 15:11:25 -05:00
Sebastian Hengst
f575346459 Backed out changeset ed1101844eea (bug 1381460) for eslint failure at browser/modules/test/browser/browser_UsageTelemetry_content.js:148: 'getSearchCountsHistogram' is not defined. r=backout 2017-08-21 18:27:57 +02:00
Andrei Oprea
dafc6cbd15 Bug 1381460 - Add telemetry search event for Activity Stream. r=Dexter data-r=bsmedberg
MozReview-Commit-ID: GLbDNLglvDY

--HG--
extra : rebase_source : 2aee316d1b8354f67c7b3236f75f5e4b104f8705
2017-08-05 17:59:49 +02:00
Lie Ryan
0270e19add Bug 1361855 - Filter TAB_COUNT histogram to record only on 5 minute intervals; r=Gijs
MozReview-Commit-ID: F5mI1eiffWN

--HG--
extra : rebase_source : 477b4c7df0c6c7dec0fad0648ff069037fc8e696
2017-06-16 12:48:19 +00:00
Lie Ryan
360b5ce3ad Bug 1361855 - Update tab count on page load and other URL changes; r=Gijs
MozReview-Commit-ID: gKqdEHI3M1

--HG--
extra : rebase_source : 39876c42493acc46733bb73a5a42cf7630983eb0
2017-06-11 19:28:20 +00:00