Commit Graph

10905 Commits

Author SHA1 Message Date
Emilio Cobos Álvarez
232ec02559 servo: Merge #19558 - selectors: Manually inline any(..) in matches_selector_list (from emilio:sadness); r=heycam
Since the compiler refuses to inline the inner closure even with -O3, which is
sad :(.

Sad try run:

  https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=c2724c47e98f990826327da05220cd83b772d144&newProject=try&newRevision=52ac88b40a08a5ef6a629bd681f2e5a444b75f54&framework=1

Source-Repo: https://github.com/servo/servo
Source-Revision: 370f5acf6dcf2fa2b4755105376302b41a88fed3

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : c9111fe877a9e1d7893c91f13be33fded64acbe9
2017-12-14 10:19:23 -06:00
Emilio Cobos Álvarez
a0e7854c60 servo: Merge #19556 - Move list quotes out of mako (from emilio:quotes-mako); r=emilio
Rebase of https://github.com/servo/servo/pull/19154.

Source-Repo: https://github.com/servo/servo
Source-Revision: 26feea3be5bc70fed7a642ca768187d29469fee0

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 7e29dfb2e654d65b512942e77f2bb48c449df9b9
2017-12-14 01:39:38 -06:00
Emilio Cobos Álvarez
7e7d23433a servo: Merge #19541 - selectors: Add parsing support for ::slotted() (from emilio:parse-slotted); r=heycam
Without turning it on yet, of course.

The reason why I didn't use the general PseudoElement mechanism is because this
pseudo is a bit of its own thing, and I found easier to make ::selectors know
about it (because you need to jump to the assigned slot) than the other way
around.

Also, we need to support ::slotted(..)::before and such, and supporting multiple
pseudo-elements like that breaks some other invariants around the SelectorMap,
and fixing those would require special-casing slotted a lot more in other parts
of the code.

Let me know if you think otherwise.

I also don't like much the boolean tuple return value, but I plan to do some
cleanup in the area in a bit, so it should go away soon, I'd hope.

Source-Repo: https://github.com/servo/servo
Source-Revision: f5129ef7b5efa59a176cac98dc68d910cb3279c9

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 5f956f568b12d8aa7611bc05ac7b1d1497689189
2017-12-14 00:22:45 -06:00
Emilio Cobos Álvarez
750fde1fd6 servo: Merge #19551 - style: Make anon boxes account for :visited (from emilio:anon-box-visited); r=heycam
This should fix one of the test failures of:

  https://bugzilla.mozilla.org/show_bug.cgi?id=616436

Source-Repo: https://github.com/servo/servo
Source-Revision: c258bfb430fabc2ebc55db679a52f09c7df04b58

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : be8406d2a2836f38ebf74b0814cca306b2f023f7
2017-12-13 22:47:38 -06:00
Emilio Cobos Álvarez
f0d9de7275 servo: Merge #19539 - mach: Fix cargo-geckolib check / cargo-geckolib build after #19476 (from emilio:cargo-geckolib); r=SimonSapin
Source-Repo: https://github.com/servo/servo
Source-Revision: 11d32d8800dcd32834961ee4013cd58a718d3762

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : f0a1de1bcedf2c27524732723afd4475b82cceb0
2017-12-13 20:26:43 -06:00
CYBAI
1fe45bc205 servo: Merge #19548 - style: Move outline-style outside of mako (from CYBAI:move-outline-style-out-of-mako); r=emilio
This is a sub-PR of #19015
r? emilio

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19546
- [x] These changes do not require tests

Source-Repo: https://github.com/servo/servo
Source-Revision: 714c1b2455bc6f651e982b5efec85e3bf711f708

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : c435362b7e4d8abcae2548a7bfd07e7e77328e8a
2017-12-13 19:30:26 -06:00
Glenn Watson
b35fce9024 servo: Merge #19552 - Update WR (fix transformed primitives with hidpi) (from glennw:update-wr-fixes); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 8ca43e41efca61b015c47f4d109c4d49b2a4ea0b

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : e78437976056ec4abb520092d76bb0723be02716
2017-12-13 11:20:12 -06:00
Alan Jeffrey
2c43d71711 servo: Merge #19507 - Add a --date option to test-perf (from asajeffrey:test-perf-date-option); r=avadacatavra
<!-- Please describe your changes on the following line: -->

To generate old test-perf results, we need a way to set the date when running `./mach test-perf`.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because they're test infrastructure

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: b93579a8f0e59c8102a243133455d8012e82e415

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 0d2ca17707b8299fe0232a605741a6bea14661bd
2017-12-12 13:52:59 -06:00
Manish Goregaokar
c9afd2ae75 servo: Merge #19549 - Add telemetry probe for measuring frequency of parallel restyles (from Manishearth:telemetry); r=emilio
Servo side of https://bugzilla.mozilla.org/show_bug.cgi?id=1421195

r=emilio

Source-Repo: https://github.com/servo/servo
Source-Revision: 80341b291b3c1f0d423d8b8ab4eb8b1e78e03f2a

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 246f365e3ae9434619fed6d187e97f9224c48d0c
2017-12-12 10:14:31 -06:00
Alex Touchet
63728c35c2 servo: Merge #19542 - Add Windows as a development platform in Readme (from atouchet:readme-windows); r=jdm
<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 0fa605d2439c4f640b7f180c18d768a7a14e7f1e

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 498a62bafec0736638d14968d5a5ac90f9d7f1d8
2017-12-11 01:01:42 -06:00
Jon Leighton
29c83eed34 servo: Merge #19461 - Handle cases where selection API doesn't apply (from jonleighton:issue-19171-4); r=KiChjang
The selection API only applies to certain <input> types:

https://html.spec.whatwg.org/multipage/#do-not-apply

This commit ensures that we handle that correctly.

Some notes:

1. TextControl::set_dom_selection_direction now calls
   set_selection_range(), which means that setting selectionDirection will
   now fire a selection event, as it should per the spec.

2. There is a test for the firing of the select event in
   tests/wpt/web-platform-tests/html/semantics/forms/textfieldselection/select-event.html,
   however the test did not run due to this syntax error:

   (pid:26017) "ERROR:script::dom::bindings::error: Error at http://web-platform.test:8000/html/semantics/forms/textfieldselection/select-event.html:50:11 missing = in const declaration"

   This happens due to the us of the "for (const foo of ...)" construct.
   Per https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/for...of
   this should actually work, so it's somewhat unsatisfying to have to
   change the test.

3. I removed tests/wpt/web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application-textarea.html
   because it doesn't seem to add any extra value - the selection API
   always applies to textarea elements, and the API is tested elsewhere.

4. If an `<input>`'s type is unset, it defaults to a text, and the
   selection API applies. Also, if an `<input>`'s type is set to an
   invalid value, it defaults to a text too. This second case doesn't
   currently work, and I'll need to do more restructuring of the code in
   a future commit. See discussion with nox in IRC:
   https://mozilla.logbot.info/servo/20171201#c13946454-c13946594

Source-Repo: https://github.com/servo/servo
Source-Revision: db41cc00be93523114092125859534b107ec772a

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 1ac0a74fcea1cfc06a94607896101667847e727c
2017-12-10 18:37:58 -06:00
Glenn Watson
44f20cec67 servo: Merge #19531 - Update WR (bitmap font fixes, serde deserialization optimizations) (from glennw:update-wr-bitmap-fonts); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 92cbf5630966c2a3f655e1edefa451628f2811ef

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : e017cb40f1afa6b46a5ba30885224b87aa3fb414
2017-12-10 11:12:20 -06:00
Simon Sapin
0a48e0345b servo: Merge #19540 - Check that 'style' is compiled in a supported configuration (from servo:style-features); r=emilio
Provide an explanatory error message when the compilation would fail because of missing or duplicate items.

Source-Repo: https://github.com/servo/servo
Source-Revision: 29d960ee5c043ba87ec0da565b5d61979a8a9b78

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 938036878f0738eb87e98a6f70a0f031d465b240
2017-12-09 20:00:23 -06:00
Emilio Cobos Álvarez
be9bd84788 servo: Merge #19536 - style: Move the code to parse a list of compound selectors (from emilio:compound-selector-list); r=mbrubeck
I'll need this for ::slotted().

Source-Repo: https://github.com/servo/servo
Source-Revision: c6bf85eca90b9cb71ff05d4454a43a7da5fc3ac8

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 02f9868af7469734b70d02e8ddb0470a9c8d407d
2017-12-09 17:15:14 -06:00
Emilio Cobos Álvarez
8093a3dd29 servo: Merge #19533 - style: Remove unused SelectorImpl::pseudo_element_cascade_type (from emilio:unused-code-should-die); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 95520ca39c4dde7296584227d49d70615dda0bf0

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 1a97cecaec5781d0a5fe9a9c53dda6eb7982ba8e
2017-12-09 15:27:49 -06:00
Emilio Cobos Álvarez
d6ec9e4c13 servo: Merge #19538 - Use ? in Option more often (from emilio:questions-questions-questions); r=mbrubeck
Source-Repo: https://github.com/servo/servo
Source-Revision: 548028fd07d85dbbbd0511386f88ea19825dc258

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 4599b24e3d0dbd27d08d9232272f98c0c36cecd7
2017-12-09 13:58:25 -06:00
Matt Brubeck
e9500aa84a servo: Merge #19537 - style: Use the ? operator for Option (from mbrubeck:try); r=nox
This is stable in Rust 1.22 (#19532).

---

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because it is refactoring only

Source-Repo: https://github.com/servo/servo
Source-Revision: 5f4f355cea4a24992ac9efa97f4a6e1837008e0b

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 3a61f3b466e9f3c80f94b7ecb30f70f85efa55b3
2017-12-09 10:50:55 -06:00
Emilio Cobos Álvarez
342c95966f servo: Merge #19534 - style: Simplify naming and signatures of single-colon pseudo stuff (from emilio:naming-is-a-bit-hard-but-not-that-hard); r=nox
Also drop a few FIXMEs while at it, since they look bogus.

Source-Repo: https://github.com/servo/servo
Source-Revision: 051eb6bcb9204ecab1c1481a275a09fd50bf0467

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 049f90ddd1ae37e05adec201fbaa6f876cbdddfe
2017-12-09 09:52:27 -06:00
Matt Brubeck
d8e57cef81 servo: Merge #19532 - Use Rust 1.22.1 for geckolib (from mbrubeck:rustup); r=SimonSapin
This matches the version required for Firefox builds:
https://bugzilla.mozilla.org/show_bug.cgi?id=1421097

Source-Repo: https://github.com/servo/servo
Source-Revision: 051a715721b026c9ec2d256adfe432c404fd6788

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 3498391f66ad4846da3f1480dc8ac1cb14ddee34
2017-12-09 01:14:02 -06:00
Emilio Cobos Álvarez
1bdfa1c2a6 servo: Merge #19530 - style: Don't unconditionally extend() the declaration block vector (from emilio:extend-not-much); r=jdm
Since it appears in profiles when used from CSSOM, like the one in the bug
mentioned in the comment.

Source-Repo: https://github.com/servo/servo
Source-Revision: f8a87a76b2c940fdcf1ced230c616b5312e97402

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : a56d1632cd6ce0fc9015a0e4ae5f6603a0de65bb
2017-12-08 19:59:38 -06:00
Xidorn Quan
b5dc8edd90 servo: Merge #19526 - Add @supports -moz-bool-pref() support for stylo (from upsuper:moz-bool-pref); r=emilio
This is the Servo side change for [bug 1267890](https://bugzilla.mozilla.org/show_bug.cgi?id=1267890).

Source-Repo: https://github.com/servo/servo
Source-Revision: 42a3c1631c27dde2d845338ccf80e0fb1b3cf9bf

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : b027cf2d3d0234e7e54675d1c76c5915fe21db1f
2017-12-08 18:49:39 -06:00
Emilio Cobos Álvarez
63378542f1 servo: Merge #19520 - selectors: Simplify :visited by only using the "is inside link" information (from emilio:simplify-visited); r=jryans
Right now we go through a lot of hoops to see if we ever see a relevant link.

However, that information is not needed: if the element is a link, we'll always
need to compute its visited style because its its own relevant link.

If the element inherits from a link, we need to also compute the visited style
anyway.

So the "has a relevant link been found" is pretty useless when we know what are
we inheriting from.

The branches at the beginning of matches_complex_selector_internal were
affecting performance, and there are no good reasons to keep them.

I've verified that this passes all the visited tests in mozilla central, and
that the test-cases too-flaky to be landed still pass.

Source-Repo: https://github.com/servo/servo
Source-Revision: 7a8733723551201d2c06acde9b0915b4c03938b4

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 00a655d0bcdf9cec70330c34eea0756b73c38cc3
2017-12-08 17:37:32 -06:00
Keith Yeung
755f12989a servo: Merge #19522 - Remove border_collapse field in InternalTable (from KiChjang:remove-border-collapse-field); r=emilio
This field doesn't seem to serve a purpose after #18252.

Source-Repo: https://github.com/servo/servo
Source-Revision: fd785f2424bacd6f60cb1937648fed28a43b0f36

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : b67e4a7581ff797e73348c8f7e8d35639f974d15
2017-12-08 16:02:09 -06:00
Alan Jeffrey
cf16493499 servo: Merge #19524 - Use urllib rather than httplib2 when downloading build perf data (from asajeffrey:build-perf-urllib); r=jdm
<!-- Please describe your changes on the following line: -->

Fixes http://build.servo.org/builders/linux-nightly/builds/534/steps/shell__3/logs/stdio

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because this is test infrastructire

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: ab7187cb665914d3038d79411e563e4ff12a0f65

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : baaaf15cab9472c1ef8bb58fc123dd78415bb339
2017-12-08 14:30:46 -06:00
Simon Sapin
7412becfe8 servo: Merge #19527 - Fix running cargo test at the repository root (from servo:root); r=SimonSapin
Source-Repo: https://github.com/servo/servo
Source-Revision: 8a8c06ac7b77ca1199c778f2ab6f1c27d88a340a

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 9788f0e00ebfa0724aa3d910efda8dcb367969c7
2017-12-08 12:30:03 -06:00
Matt Brubeck
f8fdec5746 servo: Merge #19525 - Update to webdriver 0.33 (from mbrubeck:deps); r=nox
Removes the extra version of the `cookie` crate

Source-Repo: https://github.com/servo/servo
Source-Revision: a8be1597c9d1b4d019ed93d68cc7fdfba8ca1f86

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : b7b0c6e20e3d75414de87d9ccddf2bb177ed5d18
2017-12-08 10:29:08 -06:00
Simon Sapin
a869d43078 servo: Merge #19510 - Update some dependencies, remove heapsize from the build (from servo:heapsize); r=nox
Source-Repo: https://github.com/servo/servo
Source-Revision: 07bd84ecc8dc9ba56df873453696993118e18583

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 92be8729bbeadf778435c95878ddef5c3195879c
2017-12-08 07:49:54 -06:00
Emilio Cobos Álvarez
95703831fd servo: Merge #19518 - style: Remove useless type parameter (from emilio:useless-code-is-useless); r=KiChjang
Source-Repo: https://github.com/servo/servo
Source-Revision: 22472b4db4564f7bc274eb01447e4f04fd7e7205

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 4c9671fc867830cf6fb5ccd528e7c0beafe39548
2017-12-07 20:32:11 -06:00
Matt Brubeck
b64e68ef18 servo: Merge #19517 - Defend against bugs in SelectorFlagsMap (from mbrubeck:uluru); r=emilio
Some defensive programming:

* Make `SelectorFlagsMap::apply_flags` private so it's easier to ensure it is called from the correct thread.

* Clear the cache and the map at the same time; otherwise `apply_flags` leaves `SelectorFlagsMap` in an inconsistent state.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because they do not change behavior

Source-Repo: https://github.com/servo/servo
Source-Revision: 254bbf50a7676b00bb4c5f515c45f2cd3e8e283a

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : afe8557cdba4e6dba6843aa657bd6e28164ca412
2017-12-07 19:09:07 -06:00
Matt Brubeck
84f6c35c0f servo: Merge #19512 - Improve LRU cache behavior in SelectorFlagsMap (from mbrubeck:uluru); r=emilio
This code used to insert duplicate entries to avoid expensive shuffling of the LRU cache.  With uluru this is no longer necessary, because reordering the cache is cheap.

Now it uses the `LRUCache::find` method from uluru 0.2 to update entries in-place.  This should increase cache hits by eliminating unnecessary evictions.

This PR also updates `arrayvec` because `uluru` depends on it, and `immeta` because it depends on `arrayvec`.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because they don't change behavior

Source-Repo: https://github.com/servo/servo
Source-Revision: 0c13f14aaa151764e1b3dd2d4503cb6fc3c9595b

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : b1551f8e564b25ef5a332d0492584e8e179e9325
2017-12-07 16:02:44 -06:00
Fernando Jiménez Moreno
bd85a1bbe9 servo: Merge #19516 - Print url of recorded PWM (from ferjm:pwm.url); r=jdm
This makes it a bit easier to compare results with other browsers.

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

Source-Repo: https://github.com/servo/servo
Source-Revision: c4482ebe77fd6ac517dc75b7084d08e3a82a7036

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 8e9d07fa9a2f4ff32e1e9efbe3402c72bb4a4181
2017-12-07 14:54:03 -06:00
Bastien Orivel
6af9f7520e servo: Merge #19514 - Bump string_cache, html5ever and xml5ever (from Eijebong:bump); r=SimonSapin
Source-Repo: https://github.com/servo/servo
Source-Revision: 4016551e89e1cbb9dae988e6fca33a26f1537f02

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 863e0f8b0de4f227501bd226fe5eaa8e7b4f67cb
2017-12-07 13:43:13 -06:00
Fernando Jiménez Moreno
5d913c504f servo: Merge #19498 - Fix float conversion of paint timing metrics (from ferjm:pwm.f64); r=jdm
This is a follow up of #19077

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

Source-Repo: https://github.com/servo/servo
Source-Revision: ff70c4426d9ea2f36dc18216678f743e9f56f561

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : a54b8a720c19fdb3b5850b48e8f371a0fb8468df
2017-12-07 10:31:45 -06:00
Jon Leighton
c3439b7b58 servo: Merge #19509 - Remove support for <input type=datetime> (from jonleighton:remove-input-type-datetime); r=jdm
It has been removed from the spec: https://github.com/whatwg/html/issues/336

See also https://github.com/servo/servo/pull/19471#pullrequestreview-80711878

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 8e3056d0cc7caebc218d51373b3aa0ccd331fa20

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 76bd32c1d97be56bee2675857fcb5b20f2ed2d42
2017-12-07 09:08:15 -06:00
Simon Sapin
d35e64e0bf servo: Merge #19476 - Use workspace.default-members to specify default crates for cargo build (from servo:default-members); r=nox
… and 'cargo test', etc. Include Servo and its unit tests, but not Stylo because that would try to compile the style crate with incompatible feature flags: https://github.com/rust-lang/cargo/issues/4463

`workspace.default-members` was added in https://github.com/rust-lang/cargo/pull/4743. Older Cargo versions ignore it.

Source-Repo: https://github.com/servo/servo
Source-Revision: df68eea3f21cc3bbf24d5bbb66be42c4e3a9e427

--HG--
rename : servo/tests/unit/stylo/Cargo.toml => servo/ports/geckolib/tests/Cargo.toml
rename : servo/tests/unit/stylo/build.rs => servo/ports/geckolib/tests/build.rs
rename : servo/tests/unit/stylo/lib.rs => servo/ports/geckolib/tests/lib.rs
rename : servo/tests/unit/stylo/servo_function_signatures.rs => servo/ports/geckolib/tests/servo_function_signatures.rs
rename : servo/tests/unit/stylo/size_of.rs => servo/ports/geckolib/tests/size_of.rs
rename : servo/tests/unit/stylo/specified_values.rs => servo/ports/geckolib/tests/specified_values.rs
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 0939a7049dc771e9d1b4f45f6e3ade2866266fa4
2017-12-07 06:53:07 -06:00
Glenn Watson
aae0c25865 servo: Merge #19414 - Update WR (AA on transformed box-shadows, resource leak fixes) (from glennw:update-wr-leaks); r=wafflespeanut
Source-Repo: https://github.com/servo/servo
Source-Revision: e64647188879b8269b62c1d5c8aa05732ab9d96d

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 5a0d09d3ae5f2ac49d71d8add1303ee51ed77533
2017-12-07 00:57:40 -06:00
Sandeep Hegde
1468322d37 servo: Merge #19417 - Mutation Test: with more mutation strategies (from dsandeephegde:master); r=asajeffrey,jdm
<!-- Please describe your changes on the following line: -->

1. Added following mutation strategies:
 - If True (make if always true)
 - If False(make if always false)
 - Modify Comparision (<= to <, >= to >)
 - Plus To Minus
 - Minus To Plus
 - Changing Atomic Strings (make string constant empty)
 - Duplicate Line
 - Delete If Block
2. Randomized the test order.
3. Introduced logging instead of print.
4. Added retry mechanism when mutation cannot be performed on a file by a strategy.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes #18529 (github issue number if applicable).

<!-- Either: -->
- [X] These changes do not require tests because it is a python script to run mutation test and does not change any behavior.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 6aae59e7e50531f45d78495cf07970001ef05f86

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 5b9134e3b3c9bb21f2a14e759967f8c171c0a6f2
2017-12-06 15:26:21 -06:00
Jon Leighton
34df3abb2b servo: Merge #19471 - Expand InputType to cover all possible types (from jonleighton:input-type); r=jdm
This came out of a conversation with nox in IRC:
https://mozilla.logbot.info/servo/20171201#c13946454-c13946594

The code I was working on which motivated this change is here:
https://github.com/servo/servo/pull/19461

Previously, InputType::Text was used to represent several different
values of the type attribute on an input element.

If an input element doesn't have a type attribute, or its type attribute
doesn't contain a recognised value, then the input's type defaults to
"text".

Before this change, there were a number of checks in the code which
directly looked at the type attribute. If those checks matched against
the value "text", then they were potentially buggy, since an input with
type=invalid should also behave like an input with type=text.

Rather than have every conditional which cares about the input type also
have to deal with invalid input types, we can convert the type attribute
to an InputType enum once, and then match against the enum.

A secondary benefit is that the compiler can tell us whether we've
missed branches in a match expression. While working on this I
discovered that the HTMLInputElement::value_mode() method misses a case
for inputs with type=hidden (this resulted in a failing WPT test
passing).

I've also implemented the Default trait for InputType, so we now only
have one place in the code which knows that InputType::Text is the
default, where previously there were several.

Source-Repo: https://github.com/servo/servo
Source-Revision: 6a6da9c2a4805d28365961c6ecd1e8dc7559b0b1

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : f18c1efa8e5697d9338a1ee65c1ac855537bdd5f
2017-12-06 14:16:04 -06:00
Boris Chiou
5f1cc1b488 servo: Merge #19504 - hashglobe: Dump more information if out of memory while allocating a table (from BorisChiou:stylo/crash/out_of_memory); r=emilio
This is for Bug 1418806 and Bug 1416903. Sometimes, we got a crash message on stylo:

>  called `Result::unwrap()` on an `Err` value: FailedAllocationError {
>  reason: "out of memory when allocating RawTable" }

but this is not enough to debug, so let's add one more field in
FailedAllocationError, so we can know the size we are allocating.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

Source-Repo: https://github.com/servo/servo
Source-Revision: 7fd7c21c4c99dd9f8e118948f0c52d4b4073d559

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 6566ffbcab15da7dc3f80551089fc433b2635936
2017-12-06 02:38:22 -06:00
Emilio Cobos Álvarez
f6572324f9 servo: Merge #19500 - style: Make all keywords CamelCase for consistency (from emilio:camel-case-all-the-way); r=nox
style: Make all keywords CamelCase for consistency.

Source-Repo: https://github.com/servo/servo
Source-Revision: b24778202a4d886a990ee493adfb6851ac4be40c

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 9d8fcab8dc2664b0282591a370d6f17e93e00a58
2017-12-05 19:35:25 -06:00
Nazım Can Altınova
d00339bc47 servo: Merge #19499 - stylo: Hide accidentally exposed subgrid behind prefs (from canaltinova:subgrid-pref); r=upsuper
Reviewed by xidorn on Bugzilla.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix [Bug 1421645](https://bugzilla.mozilla.org/show_bug.cgi?id=1421645)

Source-Repo: https://github.com/servo/servo
Source-Revision: 1aadbd463a28275056826c27f8acc233e052adea

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 38478c40c4a425cf3ee533b78f1fdd0dafd9a328
2017-12-05 15:16:37 -06:00
Bastien Orivel
2c7fc91a30 servo: Merge #19494 - Update smallvec to 0.6 (from Eijebong:smallvec); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: c20fd7d58a36496ea7d12ea3284172712da006b0

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 20803a41dd88a558e75d008dd808939d0a71429b
2017-12-05 13:44:19 -06:00
Emilio Cobos Álvarez
22eeea2e48 servo: Merge #19497 - style: Add internal overflow-clip-box-block/-inline properties and make overflow-clip-box a shorthand (from emilio:overflow-clip-box); r=emilio,nox
These are the changes from bug 1422839. First commit is reviewed by me, the second is a fixup to that.

Source-Repo: https://github.com/servo/servo
Source-Revision: 479847d8b906654b34aeddb09c7e89a3b3beb99c

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 9bc7f6e2789a2947956ad3ff452ee2d9510eb11e
2017-12-05 12:43:45 -06:00
tigercosmos
89778e9157 servo: Merge #19492 - use entry global's origin in is_origin_clean check for canvas rendering (from tigercosmos:b1); r=jdm
use entry global's origin in `is_origin_clean` check for canvas rendering

There is no change with:
```
./mach test-wpt tests/wpt/web-platform-tests/2dcontext
./mach test-wpt tests/wpt/web-platform-tests/html/semantics/embedded-content/the-canvas-element
```

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix  #19480 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 79f43ec3b555621d549567f36adb071d33f2d6cc

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : f2603c4c8aeed1cc9b91e86381da6efafa69319e
2017-12-05 11:33:03 -06:00
Bastien Orivel
7c6e509871 servo: Merge #19487 - Update lazy_static to 1.0 (from Eijebong:bump); r=jdm
For now it'll be duplicated

Source-Repo: https://github.com/servo/servo
Source-Revision: e2a7360e17e5d6ae8aca274183f67db18f37a6c4

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : dfcd68496ca486045b0b0bc0c51ea4293d8487de
2017-12-05 10:31:16 -06:00
Alan Jeffrey
55e63d21cf servo: Merge #19450 - Upload buildbot perf data to S3 (from asajeffrey:buildbot-perf-upload-to-s3); r=jdm
<!-- Please describe your changes on the following line: -->

Upload performance data to S3.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because this is test infrastructure

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: b56d7b8070e3280a6dc43463b110e1a1cb4ea305

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 39133abe814b418c50e82d0b74df2f342a43dcf8
2017-12-05 09:19:19 -06:00
Boris Chiou
cb9276bc80 servo: Merge #19491 - stylo: Implement FontFaceSet and Font Descriptors parsers (from BorisChiou:stylo/fontface/parser); r=heycam
This is the inter-dependent patches for Bug 1408303. We implement the FFI for the
parsers of font descriptors and FontFaceSet APIs.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix [Bug 1408303](https://bugzilla.mozilla.org/show_bug.cgi?id=1408303).
- [X] These changes do not require tests because this is for Gecko and we have tests there.

Source-Repo: https://github.com/servo/servo
Source-Revision: 3029f83b0d0654ccb3942722171f5b3d01400e4a

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 69afaec1a7ea5b9b31c53f8c4a7fe71df8f22e8e
2017-12-05 08:09:35 -06:00
Fabrice Desré
bc29ed2086 servo: Merge #19468 - Prevent an unused import warning on non desktop platforms (from servo:fabricedesre-patch-1); r=jdm
opts is not used on Android for instance.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because the test is that the build passes.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 9ca9d6bd1c603e3f2efd10d923524c63562733a4

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 2c0fead51ffb9eb63c254504b91109e13cf46d43
2017-12-05 07:13:46 -06:00
Emilio Cobos Álvarez
bfd5d2191a servo: Merge #19493 - style: Some stylo-chrome perf tweaks (from emilio:chrome-perf); r=xidorn,Manishearth
Source-Repo: https://github.com/servo/servo
Source-Revision: 8f30880d362ef54a2c6881c4927b96303ff763ef

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 680fd60a85bcdf4b28e86c397d2e39c02bead9cb
2017-12-05 06:05:25 -06:00
Alan Jeffrey
6a39ca35c5 servo: Merge #19484 - Moved the test-perf http server to a different port (from asajeffrey:test-perf-different-port); r=jdm
<!-- Please describe your changes on the following line: -->

Run the test-perf http server on a different port than WPT uses.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because this is test infrastructure

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 58a52331d904b8bf2acaec94adc417c9325bc2cc

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 5703854148443fcb4c6d1773a97b930f0ea72ca9
2017-12-05 04:43:18 -06:00
Emilio Cobos Álvarez
e1034ae8d0 servo: Merge #19457 - style: support calc() in color functions (from emilio:color-calc); r=SimonSapin
Depends on #19456 and https://github.com/servo/rust-cssparser/pull/207.

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=984021

Source-Repo: https://github.com/servo/servo
Source-Revision: 3cef09ae217ece7fa276d1be653c7c36dee7febc

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 5e87eadeda400ec41303d8d2aa506bf65fd86ea4
2017-12-05 03:37:18 -06:00
Anthony Ramine
df991e3f77 servo: Merge #19475 - Update gecko-media (fixes #19348) (from servo:bumps); r=SimonSapin
Source-Repo: https://github.com/servo/servo
Source-Revision: aab3d766739b126656358416b7ab9bb4021a7046

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 78dfa0f52be19b3c2a25d74390a1e6c38633c9a3
2017-12-05 02:09:57 -06:00
Cameron McCormack
bea48ffe01 servo: Merge #19473 - geckolib: Fix typo in CSS parser error message name (from servo:error-message); r=aethanyc
Source-Repo: https://github.com/servo/servo
Source-Revision: 005fd9cfa864a22473d0cdb980a11b874bcd1b03

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : edeaa38a02726e51f02c340776c714de87687c32
2017-12-05 00:54:12 -06:00
Cameron McCormack
a1f120e672 servo: Merge #19490 - allow Gecko FFI functions for color parsing to report errors (from heycam:canvas-color); r=Aethanyc
This is the Servo-side part of https://bugzilla.mozilla.org/show_bug.cgi?id=1420026.

Source-Repo: https://github.com/servo/servo
Source-Revision: e5637770086be7ef69f44c6eb7c9a621fa577d96

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 64d4ae259a985dc3b4cf41586a537bdce41c5866
2017-12-04 23:32:15 -06:00
Cameron McCormack
1d69d9bcb9 servo: Merge #19489 - add FFI functions for Gecko @counter-style value parsing (from heycam:counter-parse-2); r=upsuper
Trying to land #19441 again.

Source-Repo: https://github.com/servo/servo
Source-Revision: 5bfab782ec862189209931e424fbd4325b8f9172

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 4e3e38ee429faeefb02a6903abd097350a67e1a8
2017-12-04 21:22:50 -06:00
tigercosmos
b73dbbfaea servo: Merge #19385 - implement "Date type inputs", "Month type inputs" (from tigercosmos:b1); r=KiChjang
<!-- Please describe your changes on the following line: -->
implement "Date type inputs", "Month type inputs"

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] `./mach test-unit` does not report any errors

Source-Repo: https://github.com/servo/servo
Source-Revision: 68cefb1b0031c05c7f2f4aa433eb1a21e7863f8f

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 1cadc19ec7e70ded4bb31329408a5d89311d9919
2017-12-04 19:58:08 -06:00
Andreea Pavel
172683ac43 Backed out 1 changesets because the gecko part (bug 1420117) has to be backed out for the mochitests r=backout on a CLOSED TREE
Backed out changeset baada68cad47
2017-12-05 02:15:45 +02:00
Simon Wörner
cb32d51a05 servo: Merge #19379 - Implemented sanitize_value for time input (from SWW13:htmlinput_sanitize_time); r=KiChjang
Implemented value sanitization for `<input type=time/>`.
The value has the be valid time string (https://html.spec.whatwg.org/multipage/common-microsyntaxes.html#valid-time-string) or set to empty string.

---

The following test results look expected to me, but I'm not sure:
```
  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/type-change-state.html:
  │ FAIL [expected PASS] change state from time to text
  │   → assert_equals: input.value should be   foobar   after change of state expected "  foobar  " but got ""
  │ FAIL [expected PASS] change state from time to search
  │   → assert_equals: input.value should be   foobar   after change of state expected "  foobar  " but got ""
  │ FAIL [expected PASS] change state from time to tel
  │   → assert_equals: input.value should be   foobar   after change of state expected "  foobar  " but got ""
  │ FAIL [expected PASS] change state from time to url
  │   → assert_equals: input.value should be foobar after change of state expected "foobar" but got ""
  │ FAIL [expected PASS] change state from time to password
  │   → assert_equals: input.value should be   foobar   after change of state expected "  foobar  " but got ""
  │
  │ @http://web-platform.test:8000/html/semantics/forms/the-input-element/type-change-state.html:53:15
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1489:20
  │ test@http://web-platform.test:8000/resources/testharness.js:511:9
  └ @http://web-platform.test:8000/html/semantics/forms/the-input-element/type-change-state.html:37:9

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/type-change-state.html:
  │ FAIL [expected PASS] change state from color to time
  │   → assert_equals: input.value should be #000000 after change of state expected "#000000" but got ""
  │
  │ @http://web-platform.test:8000/html/semantics/forms/the-input-element/type-change-state.html:55:15
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1489:20
  │ test@http://web-platform.test:8000/resources/testharness.js:511:9
  └ @http://web-platform.test:8000/html/semantics/forms/the-input-element/type-change-state.html:37:9
```

All other tests do now `PASS` instead of `FAIL`.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix *part of* #19172
- [x] There are tests for these changes
  - [x] All tests `PASS`

Source-Repo: https://github.com/servo/servo
Source-Revision: eed3adc957fb3c52de24c560112533963572f525

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 0da8c76b388e47205d00c739b2737b05a7606187
2017-12-04 15:44:58 -06:00
Cameron McCormack
f99309301e servo: Merge #19441 - add FFI functions for Gecko @counter-style value parsing (from heycam:counter-parse); r=upsuper
Servo-side part of https://bugzilla.mozilla.org/show_bug.cgi?id=1420117, reviewed there by Xidorn.

Source-Repo: https://github.com/servo/servo
Source-Revision: 221d72a81ed9300e260d33d2d2d6557b5a118fac

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 73e138d1c06d8e7f29fc9d084ebda2bd1950c03b
2017-12-04 14:36:32 -06:00
Alan Jeffrey
ff8de48862 servo: Merge #19474 - Move the trap instruction in /etc/ci/performance/test_all.sh (from asajeffrey:test-perf-move-trap); r=jdm
<!-- Please describe your changes on the following line: -->

At the moment if the performance tests fail, the local server doesn't get killed, because the trap instruction is after the test run. This PR moves it to before.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because this is test infrastructure

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 9f117ae0abe49e189eb7015e44425a0656ce0fa7

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 2d5d0a9ec9d09362291a3805a448fd03905181f4
2017-12-04 11:32:13 -06:00
Emilio Cobos Álvarez
fbf9d655be servo: Merge #19462 - style: Cleanup Angle parsing (from emilio:angle-parsing); r=nox
This PR also contains a functional change, allowing to parse unitless zero angles in hue-rotate().

See the links and the comments for why.

Source-Repo: https://github.com/servo/servo
Source-Revision: e4dba3abef2a4941c5a4d95d58ae0b864ad10961

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : ca23c77ffb43f42fc16b8934780f0ce94ce890a0
2017-12-03 09:14:59 -06:00
Emilio Cobos Álvarez
6ac9b1e2d9 servo: Merge #19463 - style: Remove free parsing functions, use Integer::parse and Number::parse instead (from emilio:bye-parse-functions); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 14f757817e16a873e60035c1946ae82535038641

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : ebb08a34ecae53148c89dc1118b7422e21211d94
2017-12-03 06:02:12 -06:00
Ting-Yu Lin
dd31a370eb servo: Merge #19436 - style: Support 'shape-image-threshold' property (from aethanyc:shape-image-threshold); r=heycam
This has been reviewed in https://bugzilla.mozilla.org/show_bug.cgi?id=1265343

Source-Repo: https://github.com/servo/servo
Source-Revision: d198caa9ff9fc4e7210085576df189b7fbf56374

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : a22ad7503bfdaadd6bea511c3fdfeaa4e8f27a44
2017-12-02 10:03:16 -06:00
Emilio Cobos Álvarez
54299ade5a servo: Merge #19454 - style: Add a missing fast-path in GeckoElement::each_class (from emilio:has-class-is-stupid); r=upsuper
This shows up when inserting elements in the bloom filter.

Source-Repo: https://github.com/servo/servo
Source-Revision: 45bbbac9d934bc375c735fd167730e37ce063325

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 0d8775c67ddbc18f5708796b9362f0f774b6a1a1
2017-12-02 01:40:00 -06:00
Emilio Cobos Álvarez
ddb93e1de5 servo: Merge #19452 - style: Remove pretty useless layer of abstraction (from emilio:layers-as-an-onion); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: e8593e29633a67e6a8f61a213217a19278aa2739

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 1be2c6957976b130222813f9f23016c02c9cd367
2017-12-01 22:08:22 -06:00
Emilio Cobos Álvarez
e61587fcae servo: Merge #19455 - style: Don't waste an allocation when failing to parse a CSSParserColor (from emilio:color-does-stupid-things-too); r=upsuper
I see that allocation show up in the profiles, and it makes sense, because
system colors and such are common in Firefox, and they're just wasting it.

Note that the clone() added is refcounted.

Source-Repo: https://github.com/servo/servo
Source-Revision: 49e6594bc9f4c8178175232ab4a61581144dfa8e

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 9cbfebb4036f9b67e1346da0c681b93aa19a91cf
2017-12-01 18:03:11 -06:00
Emilio Cobos Álvarez
4b8603c01c servo: Merge #19451 - style: Inline some things that should never ever appear in a profile (from emilio:inlining-is-fun); r=upsuper
Source-Repo: https://github.com/servo/servo
Source-Revision: f7aa22a87ee2571d3cdb90bfe361b22ba45ddb23

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : cb3fcff96422313c36f06435a585eed84c82d62b
2017-12-01 16:52:34 -06:00
Emilio Cobos Álvarez
6d8177ca14 servo: Merge #19453 - style: Add a fast-path for GeckoElement::is_root (from emilio:is-root-is-slow); r=upsuper
Source-Repo: https://github.com/servo/servo
Source-Revision: bca8951182dc3608f3d8c6948bcce636f7860529

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : da8b2d4567782e69c382bc63f3d050720e62353c
2017-12-01 15:14:13 -06:00
Emilio Cobos Álvarez
334f5f8700 servo: Merge #19447 - servo_arc: Add some #[inline] and repr(C) annotations (from emilio:arc-soundness); r=jdm
inline is probably unnecessary, but anyway... We rely on those being repr(C), so
they rather have some.

Source-Repo: https://github.com/servo/servo
Source-Revision: 210d0ab30a72b58c2797d29db3c2a5521730285e

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : d675471a908fe1b961aa39e2fd0b637d29bdc175
2017-12-01 12:58:11 -06:00
ddh
247165dd5b servo: Merge #19307 - change parse_own_css to queue event not fire synchronously (from avadacatavra:domrefcellpanic); r=jdm
<!-- Please describe your changes on the following line: -->
fixes a panic and aligns with spec

I've also added checks around each mutable borrow of the tokenizer to see if we can catch any other panics

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #18930 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 712d75af01e02fe9689d18d7a94c89318e39f52b

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 66a16b12a0302d6a108f7b6345a0554794c0f8de
2017-12-01 11:41:47 -06:00
Emilio Cobos Álvarez
bde5c06616 servo: Merge #19446 - style: Make -moz-border-colors chrome only (from emilio:bye-moz-border-colors); r=xidorn
This also makes the `border` shorthand not reset them.

Bug: 1417200
Reviewed-by: xidorn
MozReview-Commit-ID: KNais1e5FnE
Source-Repo: https://github.com/servo/servo
Source-Revision: af8d53372f1cb7364b07f48bbd3d9ecd01d9b69a

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 20695ab01754b373d7f8514f5303c768d0edb3b1
2017-12-01 10:41:33 -06:00
Alan Jeffrey
9ee1f72e41 servo: Merge #19344 - Download the buildbot statistics and save them as CSV (from asajeffrey:buldbot-perf-download-json); r=jdm
<!-- Please describe your changes on the following line: -->

Download timing data from build.servo.org, and convert it to CSV for feeding to Google Data Studio.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because this is test infrastructure

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 9da7663e29af1a00980c3e7f30f8e0ae4760979d

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 7cf8bcbc2c6636c2346a9357f16564ee66e96653
2017-12-01 06:52:26 -06:00
Alan Jeffrey
b7449e03bd servo: Merge #19440 - Added explicit UTF-8 encoding to test-perf (from asajeffrey:test-perf-utf8); r=jdm
<!-- Please describe your changes on the following line: -->

Added explicit UTF-8 encoding to test-perf, to try to avoid:
```
Traceback (most recent call last):
  File "runner.py", line 371, in <module>
    main()
  File "runner.py", line 361, in main
    save_result_csv(results, args.output_file, testcases, args.runs, args.base)
  File "runner.py", line 287, in save_result_csv
    writer.writerows(results)
  File "/usr/lib/python3.4/csv.py", line 159, in writerows
    return self.writer.writerows(rows)
UnicodeEncodeError: 'ascii' codec can't encode characters in position 101-107: ordinal not in range(128)
```
http://build.servo.org/builders/linux-nightly/builds/526/steps/test/logs/stdio

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because this is test infrastructure

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: b7bb6ffbb85aed4e94f36a71fac112ae64d46911

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : ad9fe0f3b169941176e91eaaf34ddfa6d8c4d367
2017-11-30 13:46:15 -06:00
Simon Sapin
34aa40c687 servo: Merge #19437 - Remove 5 second pause in ./mach test-unit (from servo:SimonSapin-patch-1); r=jdm
Details of why this pause happens in the first place are at https://github.com/servo/servo/issues/19439.

Source-Repo: https://github.com/servo/servo
Source-Revision: ba0240a3887e828a084929ab5c8952800ab01123

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 4c0b1e68939a749f50714e8f0f5c7dfdcbddfe15
2017-11-30 12:15:45 -06:00
Emilio Cobos Álvarez
99b58138da servo: Merge #19438 - style: Remove redundant style sharing check (from emilio:redundant-sharing); r=upsuper
We check that a few lines before calling test_candidate.

Source-Repo: https://github.com/servo/servo
Source-Revision: ec794c82978a60dd0d5fb65b7712138c3535b714

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 48c3487be52f9a09cf5a16c4ec337aef54110042
2017-11-30 10:45:14 -06:00
Anthony Ramine
b7f989e2f9 servo: Merge #19433 - Update openssl to 0.9.22 (from servo:bumps); r=emilio
This removes foreign-types 0.2.

Source-Repo: https://github.com/servo/servo
Source-Revision: d85641bcbbab546e2e3a1cb4c7db01d95c77c78f

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 41dedb605eaaa0d5adbae4a4f09249652d46bdbc
2017-11-30 09:33:20 -06:00
Xidorn Quan
a96c0d5b96 servo: Merge #19429 - Don't try to share style on quirks mode whenever two elements have different id (from upsuper:sharing-quirks-id); r=emilio
This fixes [bug 1420946](https://bugzilla.mozilla.org/show_bug.cgi?id=1420946).

Source-Repo: https://github.com/servo/servo
Source-Revision: fce44a2e139478a5fc3524c2fd72fbeea6e3eec1

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : c90308252a2d4f0d49388aa6210514f88144d61c
2017-11-30 08:23:07 -06:00
Emilio Cobos Álvarez
0a671ea58c servo: Merge #19434 - style: Disable @-moz-document on author sheets on nightly and early beta (from emilio:moz-document); r=xidorn
Bug: 1035091
Reviewed-by: xidorn
MozReview-Commit-ID: AAUs1jJifjS
Source-Repo: https://github.com/servo/servo
Source-Revision: 3b78cf1045939754526e636d1b72fafbb5cefbb4

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 12a18445715cf7303dc7b956e46161003cf5766e
2017-11-30 07:24:27 -06:00
Emilio Cobos Álvarez
b941bc4b3f servo: Merge #19432 - style: Bail out from invalidation if we're the root and got tons of descendant invalidations (from emilio:invalidation-bail); r=heycam
Bug: 1420741
Reviewed-by: heycam
MozReview-Commit-ID: 4Kja20Ep9qD
Source-Repo: https://github.com/servo/servo
Source-Revision: e4d5e9699b9e784e5eba0aec316a35d048786052

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 705ee3ef74c8f09702fa0e09bd9924f58bfc8ac7
2017-11-30 05:30:01 -06:00
Ting-Yu Lin
c488e7bfef servo: Merge #19406 - Add a new value inner-spin-button to -moz-appearance in stylo (from ghoo1125:add_inner_spin); r=heycam
<!-- Please describe your changes on the following line: -->
Add a new value inner-spin-button to -moz-appearance. See bug 1417751.
https://reviewboard.mozilla.org/r/200244/diff/6#index_header

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: cc8f9305e415fbe773d1ea899db0755cd4a9145c

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 6bdeacd007685540cda0a86dcaaab1c629ef8aa5
2017-11-29 19:14:41 -06:00
Emilio Cobos Álvarez
a1ac90919c servo: Merge #19426 - style: Require an nth-index cache for invalidation (from emilio:cache-invalidation); r=xidorn
Source-Repo: https://github.com/servo/servo
Source-Revision: 95aac490a5150fd1a354f25c61b01ee0406a1e84

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : ca65470776263fe2a7f0bb65ad54a64034c956d5
2017-11-29 16:36:48 -06:00
CYBAI
6c6269e554 servo: Merge #19412 - style: Move grid-template-areas outside of mako (from CYBAI:grid-template-areas-out-of-mako); r=emilio
This is a sub-PR of #19015
r? emilio

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19409
- [x] These changes do not require tests

Source-Repo: https://github.com/servo/servo
Source-Revision: fa3f3896d349053a74c1bdc4c32cec61f3d05b1b

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : ef7a1dbaf74de18e8daa9452b598ed3953a14c98
2017-11-29 15:24:33 -06:00
Emilio Cobos Álvarez
a991a8ccee servo: Merge #19425 - style: Log a bit more information about invalidation collection (from emilio:log-invalidation); r=xidorn
Source-Repo: https://github.com/servo/servo
Source-Revision: 05b57e67b6f57ac8af8008c63134deeb5b5c1e12

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : e62bc48cb6ec1979ebdb25a1f1415ea19cc17a32
2017-11-29 14:14:58 -06:00
Matt Brubeck
21cbde587b servo: Merge #19424 - Remove unused generic from push_applicable_declarations (from mbrubeck:veclike); r=emilio
This function is only ever used with one type.

This gets rid of the only use of the `smallvec::VecLike` trait, which we may want to deprecate (servo/rust-smallvec#35).  If we do need to make this function generic in the future, we can do it using standard traits instead.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because they are removing unused code

Source-Repo: https://github.com/servo/servo
Source-Revision: dbe3136a055008d2c27c7d96f20e0c9ce4b1cb1c

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : fd711a25e3eeb999712269c39a74c99981975a63
2017-11-29 11:47:33 -06:00
Anthony Ramine
49e723f986 servo: Merge #19423 - Update cbindgen to 0.3.2 (from servo:bumps); r=jdm
Should help us understand #19418.

Source-Repo: https://github.com/servo/servo
Source-Revision: f1fe370117bc93da7a7578b926c9b3a0d3e85fcc

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : a674ea6cd870b28fcf03f1a78b891d516ac2eb24
2017-11-29 10:26:46 -06:00
Anthony Ramine
b69f221997 servo: Merge #19419 - Update openssl to 0.9.21 (from servo:bumps); r=avadacatavra
This replaces bitflags 0.8.2 by 0.9.1.

Source-Repo: https://github.com/servo/servo
Source-Revision: 9d602a7bb9f452fc45f9367a09fbf2fe52d3e20e

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : eb934fdb0e4a6d44f4a4181ba498b8d200fa5d6a
2017-11-29 06:25:46 -06:00
Josh Matthews
ce2eb12862 servo: Merge #19413 - Don't confuse Cargo when building dependencies (from servo:jdm-patch-9); r=avadacatavra
It's not totally clear why this is experienced intermittently (see #19402), but this allowed mp4parse-capi to actually build on my machine.

Source-Repo: https://github.com/servo/servo
Source-Revision: 462409ada54b002689d01c7c7243f0d9fe90df26

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 182fa4cffbe71a92d7ad424966a75cee6d151ffc
2017-11-29 05:24:48 -06:00
Ting-Yu Lin
f050f169f0 servo: Merge #19415 - style: Support shape-image: <image> (from aethanyc:shape-image); r=heycam
This was reviewed in nhttps://bugzilla.mozilla.org/show_bug.cgi?id=1418224

Reland #19376

Source-Repo: https://github.com/servo/servo
Source-Revision: 1f30196a3721290a6e3b4c59f8f2d51284413f06

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 05eff558ff1a6b3a3dec57c00c006d011277fb87
2017-11-28 21:34:16 -06:00
Anthony Ramine
721e87b91d servo: Merge #19402 - Update gecko-media and clap (from servo:bumps); r=emilio
This removes moz-cheddar and thus syntex from Servo's dependencies.

Source-Repo: https://github.com/servo/servo
Source-Revision: 077d74795a2f0b06f9a65d8062676cec35481fc1

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 879f2cb568bbb94b45bb96a6bd51fa89400c25be
2017-11-28 16:10:17 -06:00
Simon Sapin
681567b0a4 servo: Merge #19411 - Replace parse-hosts crate with 10 lines of code (from servo:parse-hosts); r=nox
This removes 3927 lines of Rust code in 6 crates from the dependency graph: parse-hosts, multistr, bow, extra-default, len-trait, and push-trait.

One of these crates doesn’t build in today’s Nightly: https://github.com/rust-lang/rust/issues/46328

Source-Repo: https://github.com/servo/servo
Source-Revision: ae3c3ba1c2f265e01a377f73f4a9016aded54367

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : b7d289b529cbdba3679c1e6c626264d90dd648d2
2017-11-28 09:20:44 -06:00
Simon Sapin
c3d79c4968 servo: Merge #19410 - Firefox is now on Rust 1.21 (from servo:SimonSapin-patch-1); r=nox
https://bugzilla.mozilla.org/show_bug.cgi?id=1409533

Source-Repo: https://github.com/servo/servo
Source-Revision: 2eb266b314dce2d4f130ada717a802875eb457e0

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : a1e40459923c2992786ba089e31c1d783591062a
2017-11-28 07:33:38 -06:00
CYBAI
78fd0c5b9b servo: Merge #19378 - style: Move grid-auto-flow outside of mako (from CYBAI:grid-auto-flow-out-of-mako); r=emilio
This is a sub-PR of #19015
r? emilio

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19375
- [x] These changes do not require tests

Source-Repo: https://github.com/servo/servo
Source-Revision: 66d0a41127a350d162c6a809053290c3da30c7eb

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 16855a4491275c8c831d6815d02d6698346a4ac2
2017-11-28 05:16:49 -06:00
CYBAI
5ad2eebeb0 servo: Merge #19384 - Call children_changed on the parent node consistently (from CYBAI:fix-19177); r=emilio
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19177
- [x] There are tests for these changes

Source-Repo: https://github.com/servo/servo
Source-Revision: 5568c4e3d30c4f777ee25f1a5d1765755b2c1a32

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 6ec5ce1e18ad67e7428c4575e3019fb61d8ca4f6
2017-11-28 04:08:51 -06:00
Boris Chiou
0f040a0d3f servo: Merge #19388 - stylo: Implement Servo_ParseTransformIntoMatrix (from BorisChiou:stylo/dommatrix/parser); r=emilio,heycam
This is an inter-dependent patch of Bug 1408310.

DOMMatrix needs to convert a specified transform list into a matrix, so we rewrite
to_transform_3d_matrix by generics for both specified and computed transform lists.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix [Bug 1408310](https://bugzilla.mozilla.org/show_bug.cgi?id=1408310).
- [X] These changes do not require tests because we can count on the wpt tests for DOMMatrix on Gecko side.

Source-Repo: https://github.com/servo/servo
Source-Revision: 823da9e34aacca750942c0fb53a29d6ca16c394d

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 15f0da28648677213a6642cf2b377a3d7f3e7073
2017-11-27 20:13:34 -06:00
Glenn Watson
e8053bcf9f servo: Merge #19399 - Update WR (rasterize test in transform space, render target optimizations) (from glennw:update-wr-xf-text); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: c93f989e11b954e5cc104502684bd8e3f353d5f3

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : e8405320ab9936ed689edad10f7e3a1bab118101
2017-11-27 18:53:41 -06:00
Emilio Cobos Álvarez
bc6d1d8988 servo: Merge #19391 - style: Add a comment about why early properties are early (from emilio:early-props-docs); r=upsuper
Source-Repo: https://github.com/servo/servo
Source-Revision: df50a9a81cfef5161c0dbb6b47d7d1df2b921bf5

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 3525d4e0511d10ebf4965b0e26bca0d3ef2da4d0
2017-11-27 17:42:50 -06:00
Alan Jeffrey
c841d86c08 servo: Merge #19323 - Run test-perf on linux-nightly (from asajeffrey:test-perf-run-nightly); r=edunham
<!-- Please describe your changes on the following line: -->

Run test-perf on linux-nightly.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12988
- [X] These changes do not require tests because this is test infrastructure

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 8b6b2e97c87528c4b78c20f92f7e036fca7aa962

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 9419a74c788e141a082897bcf2d1400608b822da
2017-11-27 16:12:14 -06:00
Emilio Cobos Álvarez
e264f3413f servo: Merge #19398 - style: Disable :visited if the document is being used as an image (from emilio:visited-as-an-image); r=dholbert
Bug: 1420001
Reviewed-by: dholbert
MozReview-Commit-ID: F9MeT1kXZER
Source-Repo: https://github.com/servo/servo
Source-Revision: 7c99ae3bb8056f7e30a3b40340200eced385902d

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 1dbc92124efa960b3c4e4b83dd6aa02576dc0ade
2017-11-27 14:57:57 -06:00
Emilio Cobos Álvarez
58cb2b2abf servo: Merge #19380 - style: Bring back the optimization to avoid traversing XBL subtrees that will likely change (from emilio:my-existence-seems-a-continuous-fight-with-xbl); r=heycam
Bug: 1420496
Reviewed-by: heycam
MozReview-Commit-ID: 3sIGtcVOt0r
Source-Repo: https://github.com/servo/servo
Source-Revision: 769b643c0f03054ed58542005356085312c77d9f

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : f094a1d45de724ccc72f72b056efc8fd3d0a2634
2017-11-27 13:35:28 -06:00
Emilio Cobos Álvarez
6d09e3b33f servo: Merge #19390 - style: Minor cleanups while the sync service is down (from emilio:never-enough-cleanup); r=nox
I cannot land my Gecko-dependent patches, so let's do some cleanup in the meantime.

Source-Repo: https://github.com/servo/servo
Source-Revision: 6d49ec83a15f440f85cb9a045eaf104f30bd3053

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 9e7ca996dadd40cba10a28a3c950328686c930fa
2017-11-27 08:41:46 -06:00
Emilio Cobos Álvarez
3babb12b90 servo: Merge #19382 - style: Deindent some property declaration code (from emilio:pdb-deindent); r=canaltinova
Source-Repo: https://github.com/servo/servo
Source-Revision: ac6e04ebfbf27317fea00ea93e855520237b538d

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : d2765dbe94552a630170d2c60a58277058542fe0
2017-11-26 12:45:41 -06:00
Josh Matthews
4d0e223be0 servo: Merge #19383 - Add clang packages for non-debian linuxes (from emilio:rerere); r=emilio
This relands #19381. Hopefully the sync service lands this PR and everything can go back to normal.

Source-Repo: https://github.com/servo/servo
Source-Revision: e44c0b74967298c098be8ee2ea9a956b1f42e300

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : bc6a32fd758fb419f4346c9d56d025574bbeb9fd
2017-11-26 10:53:33 -06:00
Emilio Cobos Álvarez
7ec56ef8cd servo: Merge #19381 - Revert "Add clang packages for non-debian linuxes." (from emilio:sync-service-broken); r=emilio
This reverts commit 1d2456e076249c85dbaa1e1d9c28204b173f0cb8, in an attempt to
restore the sync state across repos. Will reland if this fixes it (and if it
doesn't too).

Source-Repo: https://github.com/servo/servo
Source-Revision: a8c7940ea38157bc4dfc2c1f0c9bc2e9852baeeb

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 6c7b49f0306510ee20bb9b361d17217e7de7242b
2017-11-26 09:56:35 -06:00
Josh Matthews
399a7f38c1 servo: Merge #19353 - Add clang packages for non-debian linuxes (from servo:jdm-patch-7); r=KiChjang
Per https://github.com/servo/gecko-media/issues/71#issuecomment-346606660.

Source-Repo: https://github.com/servo/servo
Source-Revision: 10e5ae2c65575aeea4681a89da8ba6aead23af54

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 527e88303ca768901dd1c2f68eae77916f0c574e
2017-11-27 13:48:51 -05:00
Csoregi Natalia
e06f6769a6 Backed out changeset 077ce85c466b for failing devtools webconsole/test/browser_webconsole_bug_595934_message_categories.js on Windows 7 debug without e10s. r=backout on a CLOSED TREE 2017-11-26 13:01:43 +02:00
Csoregi Natalia
7d839a753c Backed out changeset 1fdcd69d2524 for Build Bustage. r=backout on a CLOSED TREE 2017-11-26 12:59:10 +02:00
Ting-Yu Lin
6c9d3c567e servo: Merge #19376 - style: Support shape-image: <image> (from aethanyc:shape-image); r=heycam
This is reviewed in https://bugzilla.mozilla.org/show_bug.cgi?id=1404222

Source-Repo: https://github.com/servo/servo
Source-Revision: 286ac51c0727c43239c782d9fc4759f0c0d4690b

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : eed86f694275322017819d3876c96f36cdab063d
2017-11-26 03:30:39 -06:00
Cameron McCormack
5c3c6a548e servo: Merge #19374 - geckolib: Return from Servo_ComputeColor whether the value was currentcolor (from heycam:compute-color); r=TYLin
Servo part of https://bugzilla.mozilla.org/show_bug.cgi?id=1420026, reviewed there by TYLin.

Source-Repo: https://github.com/servo/servo
Source-Revision: b8b5c5371f66a95da9ffb238cba2c549f4c85f59

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : abb4932506d8df0e29b9485f10f7e085c8e48638
2017-11-25 21:25:16 -06:00
Jon Leighton
22939c4977 servo: Merge #19358 - Move selection to end when textarea value is assigned (from jonleighton:issue-19171-3); r=KiChjang
Issue #19171

Source-Repo: https://github.com/servo/servo
Source-Revision: 3f0ccd0fef1ad108a22c731e399aa815d0af5441

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 617f3a81ce569cd8edfb20af8f4be58765c989b9
2017-11-25 16:10:41 -06:00
CYBAI
4fb0a4619e servo: Merge #19366 - style: Move font-family outside of mako (from CYBAI:font-family-out-of-mako); r=emilio
This is a sub-PR of #19015
Besides, this is the last PR for `font.mako.rs`! 🎉
r? emilio

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19355
- [x] These changes do not require tests

Source-Repo: https://github.com/servo/servo
Source-Revision: 8f61fde3907f2dde3e697791ccfb9a4d86d1a48c

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 1e3e438583f418932f96140dc434e1a64e4aceff
2017-11-25 13:06:31 -06:00
Emilio Cobos Álvarez
b17aa7c172 servo: Merge #19372 - Bump clang-sys to work around a Rust miscompilation (from emilio:bump-clang-sys); r=rillian
Works around: https://github.com/rust-lang/rust/issues/46239

Source-Repo: https://github.com/servo/servo
Source-Revision: 49658860d12186b9ccc45fcdb0394886f00afe37

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 3837b58c04f3b30d34d9abef95fdaf9e96372908
2017-11-25 11:48:44 -06:00
tigercosmos
75df70a706 servo: Merge #19369 - Remove WrappedHttpResponse abstraction (from tigercosmos:a1); r=jdm
<!-- Please describe your changes on the following line: -->
Remove `WrappedHttpResponse` abstraction, and use `HyperResponse`

---

<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #19361 (github issue number if applicable).

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: adfd51c8426b6629545e4a4ae45be7de1cdfe5fd

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : d8e2d5921134140c3a1af7179918adbbaba759a3
2017-11-25 10:56:06 -06:00
Emilio Cobos Álvarez
a6b4bb18ed servo: Merge #19371 - style: Don't insert into the seen set before ignoring document colors (from emilio:doc-colors); r=whoops
Otherwise we may stop honoring other colors in other cascade levels.

Fixes: #19370
Source-Repo: https://github.com/servo/servo
Source-Revision: 2377d60fa1deb56dcb5196e2206ef2b44ed296d5

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 5113fa4aad29a16ac1a77a9be0dffdefd1047b66
2017-11-24 19:10:00 -06:00
Botond Ballo
0b68301bed servo: Merge #19368 - Bug 951793 - Add support for the 'overscroll-behavior' CSS property (Servo changes) (from theres-waldo:bug951793); r=emilio
Servo changes for [bug 951793](https://bugzilla.mozilla.org/show_bug.cgi?id=951793).

Source-Repo: https://github.com/servo/servo
Source-Revision: 6158a4bf91d8d38900c5fec8bb20ff219e444f61

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : b3142a8aae8deb3d9c00a3907f30bde63b570fdd
2017-11-24 17:02:56 -06:00
Emilio Cobos Álvarez
8036ceae73 servo: Merge #19370 - style: Perform variable substitution less often (from emilio:not-so-many-vars); r=xidorn
We're wasting a bunch of work unneedlessly.

Source-Repo: https://github.com/servo/servo
Source-Revision: 990058475797e5832467616d77e7fed651c8a357

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 6c23fb88cb24150cf43be099c6a626926fac072a
2017-11-24 15:59:00 -06:00
Emilio Cobos Álvarez
7c2ab483b0 servo: Merge #19367 - style: Make a Servo-only assertion apply to Gecko too (from emilio:gecko-assert); r=upsuper
Gecko passes it now, and we want to know if that ever changes.

Source-Repo: https://github.com/servo/servo
Source-Revision: 8349be1b3e768b85fbb09ecb3dd4e9480a24f29e

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 2582aced86ba89e34fe59bef17af04c8fdb587a6
2017-11-24 14:51:46 -06:00
Simon Wörner
f3077be9d4 servo: Merge #19362 - Enable pip error output in mach_bootstrap.py (from SWW13:pip_log); r=jdm
When `pip` encounters an error during mach bootstrapping in `mach_bootstrap.py` there is no error log because of `-q`. The output will only be read when an error was encountered, so this looks like an unintended mistake.

---

This gives error outputs like:
```
D:\Code\moz\servo>mach.bat -h
Pip failed to execute properly:
Output: Collecting marionette_driver>=2.4 (from -r D:\Code\moz\servo\tests\wpt\web-platform-tests\tools\wptrunner\requirements_firefox.txt (line 1))
  Using cached marionette_driver-2.4.0.tar.gz
Collecting mozprofile>=0.21 (from -r D:\Code\moz\servo\tests\wpt\web-platform-tests\tools\wptrunner\requirements_firefox.txt (line 2))
  Using cached mozprofile-0.28.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "C:\Users\$USER\AppData\Local\Temp\pip-build-zqivz5en\mozprofile\setup.py", line 12, in <module>
        assert sys.version_info[0] == 2
    AssertionError

    ----------------------------------------

Error: Command "python setup.py egg_info" failed with error code 1 in C:\Users\$USER\AppData\Local\Temp\pip-build-zqivz5en\mozprofile\
```

instead of:

```
D:\Code\moz\servo>mach.bat -h
Pip failed to execute properly:
Output:
Error: Command "python setup.py egg_info" failed with error code 1 in C:\Users\$USER\AppData\Local\Temp\pip-build-htd5no9k\mozprofile\
```

Source-Repo: https://github.com/servo/servo
Source-Revision: b5b24559254f265a6783c3e91a833d51319dccfa

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 304689f45f488ccddaf0547df80f066bf199b484
2017-11-24 13:48:19 -06:00
Anthony Ramine
ae458a6643 servo: Merge #19363 - Use GeckoMedia and only that on platforms that support it (from nox:canplaytype-warning); r=ferjm
Source-Repo: https://github.com/servo/servo
Source-Revision: 3907953d8099dacde06d2156ee906d6ac043760d

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 358fb8014f85d51443be04bc3887d8ff7b455d44
2017-11-24 08:47:31 -06:00
Anthony Ramine
4734d50728 servo: Merge #19364 - Update cookie to 0.10 (from nox:cookie); r=KiChjang
Except in webdriver, which source is in m-c.

Source-Repo: https://github.com/servo/servo
Source-Revision: 56b5a4d8cb3a6feecf4df45f9b54f87fa0cb48cb

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : d2390ee9709c884aee5379d4a055c7d71eaaec6d
2017-11-24 03:50:37 -06:00
Markus Stange
96705bf9b0 servo: Merge #19359 - Bug 1417709, round two (from mstange:bug1417709-try2); r=emilio
<!-- Please describe your changes on the following line: -->

These are the servo changes that need to go with [bug 1417709](https://bugzilla.mozilla.org/show_bug.cgi?id=1417709).

r? @emilio

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because without these changes Firefox doesn't build.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 2374224cdfdf0bb4e8349646427e24e56d8955eb

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : b9cc2bfd643db36449407386a0eac2985e2aaea2
2017-11-23 15:21:06 -06:00
Dzmitry Malyshau
38716187af servo: Merge #19360 - WR update to 4595561c49939cb21be9554c1b85c244508bde73 (from kvark:wr-fix); r=jdm
<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19347

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because: no new logic

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

cc @glennw

Source-Repo: https://github.com/servo/servo
Source-Revision: 964b9b42cb81af0abda6b8f0231f4bef6a9a40d9

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 10f3089f0d50b57b040b43b9c9d6a0ceebc5efdc
2017-11-23 14:03:19 -06:00
Imanol Fernandez
1dd16e6fa6 servo: Merge #19357 - Update glutin to 0.13.1 (from MortimerGoro:glutin_131); r=jdm
<!-- Please describe your changes on the following line: -->

Includes https://github.com/servo/glutin/pull/133

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 177285ad4a2a7fc2c211d616e58f2a98844c8013

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : ed4e16a621cde9d0f2e2650eafdec921fad4830f
2017-11-23 12:35:10 -06:00
Imanol Fernandez
f0305f871b servo: Merge #19352 - Handle arraybuffer responseType in XHR (from MortimerGoro:xhr_arraybuffer); r=jdm
<!-- Please describe your changes on the following line: -->

Handle arraybuffer responseType in XHR

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 55049c2a676caff72e86a5631350309061a14352

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 58f2d5275dad5a37ebaa7f7f15b1c68f421f4dc8
2017-11-23 11:14:11 -06:00
tigercosmos
b0ab9e37b0 servo: Merge #19356 - update readme for ubuntu build (from tigercosmos:r1); r=jdm
<!-- Please describe your changes on the following line: -->

Fix Ubuntu build

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix  #19351 (github issue number if applicable).

Source-Repo: https://github.com/servo/servo
Source-Revision: 6009441f5ed52a1b723b386f6845b4fd4564c8f5

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 0e0b8a69970252f270d22c91411b34cc4549f9c1
2017-11-23 10:14:30 -06:00
Cameron McCormack
a3410a7eb3 servo: Merge #19349 - style: Stop using nsMediaExpression_Range (from heycam:media-feature-range); r=emilio
Servo part of https://bugzilla.mozilla.org/show_bug.cgi?id=1420071, reviewed there by Emilio.

Source-Repo: https://github.com/servo/servo
Source-Revision: 7ac376eed62ae6a7bb16b1115e718f9c9aee3b00

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : a0989874e79071d6f258445079bc184651e5a812
2017-11-23 09:23:25 -06:00
Keith Yeung
46d1b9337d servo: Merge #19185 - Implement secure and host cookie prefixes (from KiChjang:cookie-prefixes); r=avadacatavra
Part of #8700.

I modified the algorithm so that it accurately checks for the presence of the `Path` attribute of the cookie, before checking whether it has a value of `/`.

Source-Repo: https://github.com/servo/servo
Source-Revision: 7029e07ab980f7ae16b0e827066529bf145c5ff5

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 204d3ed55802460096d320bd31ac7ecaa39c710a
2017-11-23 08:26:03 -06:00
Philippe Normand
c5440617e9 servo: Merge #19337 - Implement HTMLMediaElement::canPlayType using gecko-media (from philn:gecko-canPlayType); r=nox
<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: c5b446a5731f41d06a250f7a8222a43c49dd33a9

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 311eb7174241447dac85a1e0a7974dc18cf5727e
2017-11-23 06:52:27 -06:00
Emilio Cobos Álvarez
d417e50177 servo: Merge #19341 - stylo: Make TraverseSubtree cheaper in the initial styling case (from emilio:traversal-new-faster); r=heycam
This helps with bug 1419694.

Source-Repo: https://github.com/servo/servo
Source-Revision: cd70a01d327d4e690626b4ce6f301d4cc6ae9a87

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 1f52f926d453a5038f4c9f160150196bf3059c42
2017-11-23 05:44:09 -06:00
CYBAI
a3d74b53c4 servo: Merge #19339 - style: Move -moz-script-size-multiplier outside of mako (from CYBAI:moz-script-size-multiplier-out-of-mako); r=emilio
This is a sub-PR of #19015
r? emilio

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19333
- [x] These changes do not require tests

Source-Repo: https://github.com/servo/servo
Source-Revision: ac576910d27eaee91ae21a38607a44cf7d33e15d

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : b9a1d19a17d3d3cc6c4d155e4f2ff0601a625e3c
2017-11-23 04:28:18 -06:00
Simon Sapin
0ead2435b5 servo: Merge #19346 - Remove compiletest from Travis script (from servo:SimonSapin-patch-1); r=asajeffrey
This should have been in https://github.com/servo/servo/pull/19338

Source-Repo: https://github.com/servo/servo
Source-Revision: ca15c1000372b8cdec6000ef1a09fb5fa5985338

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 7f1d1620c93c55491a1180dc275dcafd599917ef
2017-11-22 21:05:07 -06:00
Bastien Orivel
e2d8bcc867 servo: Merge #19330 - Add a sanitize_value implementation for the color input (from Eijebong:sanitize_color); r=KiChjang
I had to change the test a little bit to avoid some failures due to
color and text both having a sanitizedValue which was making the test
use the first assertion instead of the second one in some cases.

The sanitize_value implementation is pretty simple, we iterate over the
content and checks that the content is 7 characters long, that the first
character is a `#` and then that all the following characters are
hexadecimal. If all those requirements are met, we lowercase the
content, otherwise we put `#000000` in it.

Source-Repo: https://github.com/servo/servo
Source-Revision: 72e7f6095e56ca6230651fc73bced8b460487569

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : e4985200fa96b3d6e40d09c9f30b5df47d8cbf3a
2017-11-22 19:42:58 -06:00
Manish Goregaokar
f1502e5e7d servo: Merge #19329 - Add RAII guard for cancelling fetch when the consumer no longer cares about it (from Manishearth:fetchcanceller); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 976f9e3d13b6a7676dd863dd397dd6c60e868d58

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 9d7caa9c57c75423e10f6802d23835b2522d9f14
2017-11-22 18:30:57 -06:00
Margareta Eliza Balazs
7258d432e6 Backed out changeset 2e20100d8f59 (bug 1417709) for error in toolkit/library/rust/target r=backout on a CLOSED TREE 2017-11-23 01:18:45 +02:00
Markus Stange
e758202341 servo: Merge #19255 - Bug 1417709 - Add -moz-appearance: -moz-mac-vibrant-titlebar-light/dark and system colors with the same name (from mstange:bug1417709); r=emilio
<!-- Please describe your changes on the following line: -->

These are the servo changes that need to go with [bug 1417709](https://bugzilla.mozilla.org/show_bug.cgi?id=1417709).

r? emilio

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because without these changes Firefox doesn't build.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 9ac05a5bee6c0a0af05e46b6e423ba206435d485

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 1a1112340aaeccc26015009723d139afea934c1c
2017-11-22 13:32:38 -06:00
Maxim Novikov
bda10d4bd8 servo: Merge #19325 - Report an errror if a package has duplicates allowed but there are no duplicates (from m-novikov:tidy-ignore-without-duplicates); r=jdm
Resolves: #19306

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #19306 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: a812af51d614bd96402da91d8f648ce51b301a1b

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 7b3783a62fa804997c3477b5bab3a6593014a67a
2017-11-22 11:49:40 -06:00
Josh Matthews
c49b68f4f1 servo: Merge #19336 - Instruct how to deal with outdated manifests (from servo:jdm-patch-6); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 218edeb883f8b46fde5b218be4e1e38a32b39b56

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 8f60844c1199f9de93b7948f89fe9a9e9fbb05dc
2017-11-22 10:36:04 -06:00
Simon Sapin
b8801aff08 servo: Merge #19338 - Replace compiletest suite by doc-tests with compile_fail (from servo:compiletest); r=nox
`compiletest-rs` use internal rustc APIs and is broken in today’s Nightly. rustdoc however is maintained with rustc and so much less fragile.

Closes #9945.

Source-Repo: https://github.com/servo/servo
Source-Revision: 5213e2a5a9ed8859a004e480f52c7e04f8d7f85e

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 4549a7b8d21ba3085be304d96d93b958f1a83655
2017-11-22 09:35:54 -06:00
Josh Matthews
3a6121544a servo: Merge #19335 - Unbreak docs build (from servo:jdm-patch-5); r=nox
Running rustdoc on gecko-media is broken right now.

Source-Repo: https://github.com/servo/servo
Source-Revision: 3a08f87ec89456900da4cffda1356c02b6a9b8c8

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 217b86c8f1cd5e7766189e59ddeb2502832d602d
2017-11-22 06:48:10 -06:00
Michael Wilson
af624511f7 servo: Merge #19332 - moving :dir() param serialization FIXME (from wilsoniya:moving-fixme); r=emilio
<!-- Please describe your changes on the following line: -->
Per emilio's comment, https://github.com/servo/servo/pull/19195#discussion_r152205644, a `FIXME` regarding `:dir()` parameter serialization has been moved.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because they only modify comment lines

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 3ecd0174cc7817cdd2007850c29b8b069a845b46

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : bd40b06fc49360f0a8ac206558734ec557c741cc
2017-11-22 04:04:39 -06:00
Hiroyuki Ikezoe
70cac6f846 servo: Merge #19331 - Resolve base style for pseudo (from hiikezoe:resolve-base-style-for-pseudo); r=emilio
<!-- Please describe your changes on the following line: -->
This is a PR for https://bugzilla.mozilla.org/show_bug.cgi?id=1418867

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

Source-Repo: https://github.com/servo/servo
Source-Revision: a6ce817045b293b2898aca4d393c6b744955e730

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 5409294d683e06e8de99f05d93c5e7b1047e9dec
2017-11-21 22:16:58 -06:00
Bastien Orivel
34af56766c servo: Merge #19328 - Remove cancellation map and ResourceId from the net* components (from Eijebong:remove_old_cancellation_code); r=KiChjang
Fixes #19327

Source-Repo: https://github.com/servo/servo
Source-Revision: 78fb3c206d30da8e7b16ea941268b733b21059ed

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : e76d89bd5fee0f74bc9592960a3c220bb6c37436
2017-11-21 21:01:35 -06:00
Josh Matthews
51867bfcaa servo: Merge #19326 - Use same build environment during mutation testing (from servo:jdm-patch-2); r=asajeffrey
ccache complains that the C++ compiler doesn't match the cached version.

Source-Repo: https://github.com/servo/servo
Source-Revision: 93c2a5da89b7413837e61ec92ed529debd4cf5f8

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 4c88ae2dabf7ec0298843d19e910aef69952723d
2017-11-21 19:43:49 -06:00
Dzmitry Malyshau
36090d6c06 servo: Merge #19314 - Update WR and the whole macOS crate stack (from servo:wr); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 37fa711657e6684e234e855be03470a0e17307de

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 32bc1b95ef736f61e86d6802d3acef52477adde3
2017-11-21 18:40:36 -06:00
Andrés Barreiro
f192eda281 servo: Merge #19324 - Get back to working dir after vcvarsall.bat (from drewler:fix_matchbat); r=jdm
<!-- Please describe your changes on the following line: -->

When using cmd.exe directly (instead of `x86_x64 Cross Tools Command Prompt for VS 2017`), vcvarsall.bat changes the working directory.
To prevent this, pushd and popd could be used.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] These changes do not require tests because they are part of the build process.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: a20efc6d7bbbfa7261eea9a0aa534420724a1dbc

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 89a364953e569531902d36ce013b46ca19fca33b
2017-11-21 17:27:34 -06:00
Emilio Cobos Álvarez
3fe9aed3ba servo: Merge #19321 - style: Avoid unneessary malloc churn when evaluating @supports rules (from emilio:supports-dumb); r=SimonSapin
Source-Repo: https://github.com/servo/servo
Source-Revision: 06d834c1b984b4fae55da4ac82b5fbe002295dda

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 83c008e721f609dfd446a4e32f271e41c4bdf119
2017-11-21 15:27:59 -06:00
CYBAI
347f6537f1 servo: Merge #19322 - style: Move -x-lang outside of mako (from CYBAI:x-lang-out-of-mako); r=emilio
This is a sub-PR of #19015
r? emilio

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19320
- [x] These changes do not require tests

Source-Repo: https://github.com/servo/servo
Source-Revision: d1e4fdb7faf5b32079e83fa03fe0386bb7c65db3

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 16e203987bea90eb6c6bbaecd78db06f990c19d3
2017-11-21 13:46:49 -06:00
Josh Matthews
9245d92e5c servo: Merge #19318 - Make wdspec tests runnable (from jdm:webdriver); r=jgraham
This makes it possible to run tests in tests/wpt/web-platform-tests/webdriver/tests and focus on investigating why they fail.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix (partially) #15274.
- [x] There are tests for these changes

Source-Repo: https://github.com/servo/servo
Source-Revision: dc35457b4a6dec744de1e8b61bf8fb9b3947a3ba

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 47dad9396967053f7849320a2445a66ea03db895
2017-11-21 12:25:55 -06:00
Alan Jeffrey
7c95954d4d servo: Merge #19244 - Submit test-perf CSV files to S3 (from asajeffrey:test-perf-submit-to-s3); r=jdm
<!-- Please describe your changes on the following line: -->

Submit CSV files to S3 rather than json files to Perfherder.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because this is test infrastructure

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 755fa371cb96dd89f5b3e07c09043fc138347ef1

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 616219bbb1a5a298de2244a7c92e54f91b2e7593
2017-11-21 11:07:55 -06:00
Anthony Ramine
288e2656fe servo: Merge #19225 - Shut down the media stack when shutting down the constellation (from servo:media); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: b13107a31864b24463d112aca4e94c93d597243c

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 41778f20edd1d2c0e08a812e5b8444d186dd7336
2017-11-21 10:13:02 -06:00
Hugh Gallagher
6af6c776d0 servo: Merge #19319 - Removed unused import in net/http_cache.rs (from hgallagher1993:local_branch); r=jdm
<!-- Please describe your changes on the following line: -->
`use http_loader::is_redirect_status;` was unused

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 9e5fe11f5af0982d7e6766b41658fc5d53094678

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 05cb8d4ac0090104c1b17e43e37c4adb85167292
2017-11-21 08:51:52 -06:00