Atul Varma
fe2957c61d
Removed a line of code that was raising a strict warning, and which also just defined an unused local variable that called no functions and therefore had no side effects (unless there were property getters that had side-effects involved, which hopefully wasn't the case).
2008-06-23 14:32:55 -07:00
Atul Varma
3f66c5c26a
Moved the FakeGUIDService from test_passwords.js to head.js.
2008-06-23 14:13:46 -07:00
Atul Varma
0559b0e418
A tiny bit more refactoring to test_passwords.
2008-06-20 18:36:33 -07:00
Atul Varma
3d1514d12d
Oops, forgot to recommit the canonical log for test_passwords in my last commit.
2008-06-20 18:36:11 -07:00
Atul Varma
cc43d11f3c
Fake GUID generator now provides a different yet deterministic GUID upon each invocation.
2008-06-20 18:25:21 -07:00
Atul Varma
8b16c18fe7
test_passwords now also removes a user after doing everything else.
2008-06-20 18:04:59 -07:00
Atul Varma
4b0e7167bd
Factored out the fake filesystem related functions in test_passwords.js into a FakeFilesystemService class in head.js.
2008-06-20 17:47:32 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
bf4b17ef6b
The XMPP server is now configured to use LDAP for authentication (on sm-labs01, and soon to be on services.mozilla too) so the xmpp username/password will now be the same as the weave username/password. So I now use those to login, and I got rid of the two extra preferences which we used to have for xmpp username/password.
2008-06-20 17:19:10 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
e81cd3694a
fixed some minor formatting
2008-06-20 16:46:38 -07:00
Atul Varma
b93ec60294
Refactored test_passwords to make it more modular and readable, changed the formatting of some log messages to be more descriptive.
2008-06-20 15:39:07 -07:00
Atul Varma
02bbaa5ff6
Improved test_passwords so that it syncs, re-syncs, adds a new user, and re-syncs again.
...
Fixed a strict warning in engines.js.
2008-06-20 14:22:06 -07:00
Atul Varma
0ea26a3466
Made the tracking of async generators/coroutines more robust for debugging purposes.
...
Refactored code in syncCores.js to use Utils.makeTimerForCall().
Improved test_passwords to perform an additional sync after the initial one.
2008-06-20 13:58:56 -07:00
Atul Varma
c0b0185e09
Added more informative output for fake DAV, so that log-based tests are both more self-documenting re: Weave's behavior and serve as more robust test cases.
2008-06-20 12:49:25 -07:00
Atul Varma
85a56e5aa8
Added an expected-log for the passwords sync engine unit test.
2008-06-20 12:39:50 -07:00
Atul Varma
15d84c6df5
Refactoring: consolidated duplicate code creating GUIDs via XPCOM gunk into a new function, Utils.makeGUID().
...
Note that there are some strange things re: whitespace in engines/bookmarks.js in this changeset; I literally only changed one line, though, and I'm not sure where they came from. Maybe it was js2-mode?
2008-06-20 12:34:29 -07:00
Atul Varma
5fe60a3ceb
Minor code tidying.
2008-06-20 12:27:17 -07:00
Atul Varma
8e53749c97
Changed log level in a unit test.
2008-06-20 12:24:02 -07:00
Justin Dolske
48d96ab71d
Small bug fix from my last small bugfix. :(
2008-06-19 20:18:59 -07:00
Atul Varma
d808b40fee
Fixed a bug in the outstanding-callback-warning system and made Generator.throw() and Generator.cont() private methods because no client code was using them and it could introduce bugs in the system if they do; we can revisit making them public again later if we want.
2008-06-19 19:03:10 -07:00
Maria Emerson
03ae7c8d0d
Automated merge with ssh://memerson@mozilla.com@hg.mozilla.org/labs/weave
2008-06-19 17:55:09 -07:00
Atul Varma
7f5209a1c7
Modified the way logging works in unit testing; fake testing components now log as part of the 'Testing' logger instead of the root logger.
2008-06-19 17:04:04 -07:00
Atul Varma
ba5e6be87c
Removed warning message from ID.get() because it's actually normal to pass in an ID that doesn't exist to it, to test for its existence. Though perhaps there should be an exists() method for such a use case instead.
2008-06-19 16:37:53 -07:00
Atul Varma
f9a93ee91d
Added more fake prefs to the password test to eliminate strict warnings, added logging code to identity.js to aid in debugging.
2008-06-19 16:03:42 -07:00
Maria Emerson
8c35fd7043
updating wizard
2008-06-19 15:43:50 -07:00
Justin Dolske
e8e2bce2ce
Fix reference to undefined function and bad async arg.
2008-06-19 15:36:24 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
603b5e26ba
Fixed some more missing commas that were preventing engines/bookmarks.js from loading
2008-06-19 15:25:25 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
92c242b8df
Added missing comma after function definition
2008-06-19 15:23:01 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
ab9f0aa2bb
Backed out changeset 7720a1dd564a because the new crypto stuff that it uses hasn't been enabled yet.
2008-06-19 11:59:52 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
69da8061fb
Applied dolske's patch from bug 433949 to make the bookmarkEngine work with the new improved Crypto interface.
2008-06-19 11:41:57 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
5f7b9953fd
merged
2008-06-19 10:51:54 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
f02bb1638d
Reimplemented most of _updateIncomingShare to work with the new implementation of _updateOutgoingShare. No more need for the ugly hack to temporarily set the root directory of DAV, hooray
2008-06-18 23:27:48 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
52fd203c7d
Implemented _stopOutgoingShare (though it's still not being called from anywhere).
2008-06-18 23:00:09 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
5524c106b5
Added documentation to createIncomingShare, rewrote it a little to be consistent with the other new stuff, and made it use annotations to keep track of the server path to the shared data.
2008-06-18 22:37:06 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
f2d0ad6ab6
Gave the bookmarksEngine a permanent (lazy-initialized) reference to the annotation service, rather than recreating the reference every single time we use the service. Which is a lot of times now.
2008-06-18 20:53:11 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
080ec435c2
Implemented _updateAllOutgoingShares in bookmarkEngine.
2008-06-18 20:45:01 -07:00
Myk Melez
001d6fc9e7
Automated merge with ssh://hg.mozilla.org/labs/weave/
2008-06-18 19:35:31 -07:00
Myk Melez
26e6962578
bug 439553: add a 'change password' form to the weave preferences
2008-06-18 19:35:23 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
fd658ea35e
Removed an unneeded yield statement from startXmppClient (this was raising warnings about yeilding without a callback.)
2008-06-18 18:48:17 -07:00
Atul Varma
d4048117ef
Finished test_passwords.js, although it raises a number of strict warnings.
2008-06-18 18:08:33 -07:00
Atul Varma
6c09312d2a
Replaced boilerplate XPCOM code with calls to util.js functions.
2008-06-18 18:04:01 -07:00
Atul Varma
8742aa37bd
Fixed a preference typo in test_service.js.
2008-06-18 17:33:44 -07:00
Atul Varma
8f20b9b0d9
Automated merge with http://hg.mozilla.org/labs/weave
2008-06-18 17:28:38 -07:00
Atul Varma
6c5227493a
test_passwords.js now performs a fake sync, but I ran into an issue that may be a bug in remote.js.
2008-06-18 17:28:28 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
d2c2945873
Set the default preference for weave's xmpp server-url to be the new secure url for the ejabberd server on sm-labs01.
2008-06-18 17:25:46 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
6f0992239d
Turned all remaining dump()s in transportLayer.js into Log4Moz debug calls.
2008-06-18 17:23:04 -07:00
Atul Varma
cb0d33d536
Refactoring; moved code out of test_service.js and into unit/head.js for use by other tests.
2008-06-18 16:51:54 -07:00
Atul Varma
6e83ffc460
Added a new property to async.js, Async.outstandingGenerators, which returns the number of generators that haven't yet been finalized. This can be used for diagnostic purposes to determine whether generators haven't yet been called back.
2008-06-18 16:11:15 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
bdff709f9e
Imported Log4Moz to xmpp/transportLayer.js and xmpp/authenticationLayer.js, so they're no longer raising errors about Log4Moz being undefined (oops, sorry, should have tested before pushing.)
2008-06-18 14:59:06 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
4895e6e665
Merged
2008-06-18 14:53:30 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
39e5ae9520
XMPPClient sends its debugging output to log4moz (mostly debug level) now instead of dump, so it's less annoyingly verbose.
2008-06-18 14:50:02 -07:00
