15622 Commits

Author SHA1 Message Date
David Shin
c90c9255df Bug 1918673: Make parsing of position-try-fallbacks order-dependent. r=firefox-style-system-reviewers,emilio
Spec currently says canonical order, but this should not be the case (See
bug 1918670).

Differential Revision: https://phabricator.services.mozilla.com/D222296
2024-09-16 18:38:09 +00:00
Oriol Brufau
44cac6a76d Bug 1919009 - Derive MallocSizeOf for ComputedValueFlags on Servo. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D222277
2024-09-16 14:02:00 +00:00
Emilio Cobos Álvarez
9cd09c2624 Bug 1918454 - Prevent divide by zero when inverting effective zoom. r=firefox-style-system-reviewers,layout-reviewers,boris
See comment.

Differential Revision: https://phabricator.services.mozilla.com/D222090
2024-09-13 18:24:57 +00:00
David Shin
eaa4082b34 Bug 1900229: Parse position-try shorthand. r=firefox-style-system-reviewers,emilio
Differential Revision: https://phabricator.services.mozilla.com/D221988
2024-09-12 20:08:09 +00:00
David Shin
c507c766c3 Bug 1918463: Fix inset auto-completion. r=firefox-style-system-reviewers,emilio
Prevent `anchor()`'s inner keywords from suggested, and make the suggestion of
`anchor()` only if the relevant pref is flipped.

Differential Revision: https://phabricator.services.mozilla.com/D222018
2024-09-12 19:18:27 +00:00
Nico Burns
4b4b38dcee Bug 1918374: Enable adjust_for_table_text_align in Servo (r=emilio)
Differential Revision: https://phabricator.services.mozilla.com/D221960
2024-09-12 14:00:58 +00:00
David Shin
150d59da52 Bug 1900231: Parse anchor-center for self-alignment properties. r=firefox-style-system-reviewers,emilio
Differential Revision: https://phabricator.services.mozilla.com/D221872
2024-09-12 13:07:26 +00:00
Emilio Cobos Álvarez
99662b69fb Bug 1917034 - Remove some related always-on prefs. r=firefox-style-system-reviewers,zrhoffman
Differential Revision: https://phabricator.services.mozilla.com/D221769
2024-09-12 11:25:35 +00:00
Emilio Cobos Álvarez
f299fb9ba0 Bug 1917034 - Apply color-scheme after forced-color-adjust. r=firefox-style-system-reviewers,zrhoffman
It is one of the skipped-on-forced-colors properties.

Differential Revision: https://phabricator.services.mozilla.com/D221768
2024-09-12 11:25:34 +00:00
Emilio Cobos Álvarez
f384fcaaef Bug 1909625 - Ignore CSS zoom and text zoom for canvas. r=gfx-reviewers,lsalzman
The spec doesn't mention anything about applying them, and other
browsers don't, so let's just be consistent...

Differential Revision: https://phabricator.services.mozilla.com/D221709
2024-09-11 13:46:45 +00:00
Martin Robinson
d00f1e579e Bug 1917544 - Stop using time@0.1 in stylo code r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D221449
2024-09-11 08:19:48 +00:00
Tom Schuster
ceef5a0694 Bug 1917555 - Remove MediaDocumentKind::Plugin. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D221439
2024-09-11 08:00:48 +00:00
Tamas Szentpeteri
c71207a11c Backed out changeset dfb3a55370d3 (bug 1909625) for causing mochitest failures on test_canvas_font_setter.html. CLOSED TREE 2024-09-11 00:12:59 +03:00
Emilio Cobos Álvarez
e02418a02c Bug 1909625 - Ignore CSS zoom and text zoom for canvas. r=gfx-reviewers,lsalzman
The spec doesn't mention anything about applying them, and other
browsers don't, so let's just be consistent...

Differential Revision: https://phabricator.services.mozilla.com/D221709
2024-09-10 18:14:40 +00:00
David Shin
b6b6fcd242 Bug 1900230: Move Inset from length to position module. r=emilio
Depends on D221546

Differential Revision: https://phabricator.services.mozilla.com/D221639
2024-09-10 14:11:16 +00:00
Emilio Cobos Álvarez
c698a4becf Bug 1900230 - Minor nits and improvements. r=dshin
This should allow animating anchor percentages and so on.

Depends on D220285

Differential Revision: https://phabricator.services.mozilla.com/D221546
2024-09-10 14:11:16 +00:00
David Shin
f60d2015e9 Bug 1900230: Implement parsing of anchor() function in inset properties. r=firefox-style-system-reviewers,emilio
Differential Revision: https://phabricator.services.mozilla.com/D220285
2024-09-10 14:11:15 +00:00
Nicolas Guichard
0d9b59bd37 Bug 1917746 - Fix Rust 1.82's new elided_named_lifetimes warning. r=emilio
This warning was introduced by https://github.com/rust-lang/rust/pull/129207.

Differential Revision: https://phabricator.services.mozilla.com/D221462
2024-09-10 04:51:23 +00:00
David Shin
ded398854c Bug 1917089: Let nested @scope rule to use relative selector in scope-start. r=firefox-style-system-reviewers,emilio
Depends on D221253

Differential Revision: https://phabricator.services.mozilla.com/D221254
2024-09-09 15:24:56 +00:00
David Shin
bc34853aa8 Bug 1917087: @scope selectors are now unforgiving. r=firefox-style-system-reviewers,emilio
As per https://github.com/w3c/csswg-drafts/issues/10042.

Differential Revision: https://phabricator.services.mozilla.com/D221253
2024-09-09 15:24:53 +00:00
Emilio Cobos Álvarez
4a665f56b1 Bug 1914735 - Track color-scheme dependencies for non-inherited rule cache. r=firefox-style-system-reviewers,boris
Differential Revision: https://phabricator.services.mozilla.com/D220134
2024-09-04 20:35:55 +00:00
Cristian Tuns
0438e6b693 Backed out changeset 4075eab1fdc4 (bug 1914735) for causing build bustages with "error: missing documentation for a struct field" CLOSED TREE 2024-09-04 15:29:31 -04:00
Emilio Cobos Álvarez
cbd27def34 Bug 1914735 - Track color-scheme dependencies for non-inherited rule cache. r=firefox-style-system-reviewers,boris
Differential Revision: https://phabricator.services.mozilla.com/D220134
2024-09-04 16:56:38 +00:00
Boris Chiou
d524f0f5e5 Bug 1911216 - Part 2: Support :only-child for view transition selectors. r=layout-reviewers,firefox-style-system-reviewers,emilio
Introduce the concept of pseudo element tree and make sure we achieve
the following behaviors:
1. `::view-transition` doesn't accept any non-functional pseudo class
   after it.
2. `::view-transition-*(name)` accepts only `only-child` pseudo class
   after it.

So for named view transition pseudo elements, we make them accept
non-functional pseudo classes and tree structural pseudo classes after
them, for consistency. However, only `:only-child` is allowed.

Differential Revision: https://phabricator.services.mozilla.com/D219714
2024-09-03 19:29:33 +00:00
Boris Chiou
7c3a0ab05d Bug 1911216 - Part 1: Add CSS selector parsing support for view transition pseudo-elements. r=layout-reviewers,firefox-style-system-reviewers,emilio,devtools-reviewers,nchevobbe
This adds the pasring support for:
1. `::view-transition`
2. `::view-transition-group(name)`
3. `::view-transition-image-pair(name)`
4. `::view-transition-old(name)`
5. `::view-transition-new(name)`

The `name` here is a `<custom-ident>` or `*`.

Differential Revision: https://phabricator.services.mozilla.com/D219713
2024-09-03 19:29:32 +00:00
Emilio Cobos Álvarez
6e8da4e110 Bug 1914221 - Map pattern/gradientTransform to the transform property. r=longsonr
And fix a typo in a test which got me confused.

Differential Revision: https://phabricator.services.mozilla.com/D220728
2024-09-02 17:26:20 +00:00
Connor Pearson
c0a505c28f Bug 1887455 - max with a NaN argument should simplify to NaN. r=emilio
A NaN argument in min/max should result in NaN. This logic was added to `resolve_internal` but was missing in the simplification.

Differential Revision: https://phabricator.services.mozilla.com/D220490
2024-08-29 13:33:32 +00:00
Emilio Cobos Álvarez
baba6ff61c Bug 1914449 - Fix stylesheet cloning in presence of both @layer and @import. r=zrhoffman,firefox-style-system-reviewers
Hopefully the test for bug 1912996 would catch this.

Differential Revision: https://phabricator.services.mozilla.com/D220083
2024-08-26 13:01:59 +00:00
Emilio Cobos Álvarez
df0fc07466 Bug 1914799 - Move some of the gecko.mako.rs code to property definitions. r=firefox-style-system-reviewers,zrhoffman
This is just a trivial clean-up I noticed reviewing bug 1914777.

Differential Revision: https://phabricator.services.mozilla.com/D220084
2024-08-25 21:47:22 +00:00
Zach Hoffman
3929b2eab0 Bug 1914777 - Use cbindgen for border-image-repeat. r=firefox-style-system-reviewers,layout-reviewers,emilio
nsStyleBorder field mBorderImageRepeat replaces fields
mBorderImageRepeatH and mBorderImageRepeatY.

Differential Revision: https://phabricator.services.mozilla.com/D220074
2024-08-25 15:57:04 +00:00
Zach Hoffman
11860bb190 Bug 1914777 - Use cbindgen for StyleBorderImageRepeatKeyword. r=firefox-style-system-reviewers,layout-reviewers,emilio
Generated enum StyleBorderImageRepeatKeyword replaces enum StyleBorderImageRepeat.

Differential Revision: https://phabricator.services.mozilla.com/D220073
2024-08-25 15:57:04 +00:00
Emily McDonough
042cf5fb44 Bug 1867164 - Share logic for serializing PageRule and StyleRule. r=firefox-style-system-reviewers,emilio
Factor out shared logic into a separate function. This leaves the actual impl
of ToCssWithGuard for the rule itself, and requires the rules to serialize
the preamble separately.

Differential Revision: https://phabricator.services.mozilla.com/D219818
2024-08-23 20:22:45 +00:00
Boris Chiou
a20866136d Bug 1823901 - Add view-transition-name longhand in style system. r=layout-reviewers,firefox-style-system-reviewers,emilio
Add `view-transition-name` into style system, behind the preference,
"dom.viewTransitions.enabled".

We will use `view-transition-name` somewhere when we create the pseudo
elements. This patch only add this atom into style system for future
usage.

Differential Revision: https://phabricator.services.mozilla.com/D218120
2024-08-22 07:21:09 +00:00
David Shin
69d671e227 Bug 1912241: Correctly refer to current matching context's shadow root while matching implicit scopes. r=firefox-style-system-reviewers,emilio
Differential Revision: https://phabricator.services.mozilla.com/D219537
2024-08-21 18:17:21 +00:00
Emilio Cobos Álvarez
4aa1ad81ba Bug 878346 - Make transform a mapped attribute for SVG. r=longsonr,firefox-style-system-reviewers,zrhoffman
The tricky bit is rotate() which in SVG means something different if
there's an origin (you translate-then-untranslate it).

But this seems to work off-hand, and fix the reminder of bug 1906261.

Differential Revision: https://phabricator.services.mozilla.com/D215788
2024-08-21 15:00:48 +00:00
Jonathan Kew
be4a19a0da Bug 1913536 - Expose the special shorthands in the SpecifiedValueInfo for the CSS white-space shorthand. r=firefox-style-system-reviewers,devtools-reviewers,emilio
Differential Revision: https://phabricator.services.mozilla.com/D219426
2024-08-21 14:48:25 +00:00
Emilio Cobos Álvarez
b586de292c Bug 1913322 - Make arrowscrollbox use resizeobserver rather than overflow/underflow events. r=Gijs,dao,desktop-theme-reviewers,tabbrowser-reviewers,frontend-codestyle-reviewers
For that, make the <slot> have a box. Keep firing the overflow /
underflow events, but only in cases relative to the arrowScrollbox.

Remove unneeded scrollbox-clip box, and replace it by
`overflow-clip-box-block: content-box` in the only place that we make
the scrollbox grow.

Differential Revision: https://phabricator.services.mozilla.com/D219249
2024-08-21 12:23:34 +00:00
Cristian Tuns
3447333df4 Backed out changeset 6fb2cecebdd8 (bug 1913322) for causing multiple failures. CLOSED TREE 2024-08-20 21:01:50 -04:00
Emilio Cobos Álvarez
9a8a267f79 Bug 1913322 - Make arrowscrollbox use resizeobserver rather than overflow/underflow events. r=Gijs,dao,desktop-theme-reviewers,tabbrowser-reviewers,frontend-codestyle-reviewers
For that, make the <slot> have a box. Keep firing the overflow /
underflow events, but only in cases relative to the arrowScrollbox.

Remove unneeded scrollbox-clip box, and replace it by
`overflow-clip-box-block: content-box` in the only place that we make
the scrollbox grow.

Differential Revision: https://phabricator.services.mozilla.com/D219249
2024-08-20 22:31:22 +00:00
Emily McDonough
ab8003e318 Bug 1913812 - Remove trivially redundant cases into_boxed_slice following a collect in Servo style code r=firefox-style-system-reviewers,zrhoffman
Differential Revision: https://phabricator.services.mozilla.com/D219544
2024-08-20 21:10:43 +00:00
Iulian Moraru
e0e41bf500 Backed out changeset 1658290c1b95 (bug 1913322) for causing overflow related failures. CLOSED TREE 2024-08-20 17:54:54 +03:00
Emilio Cobos Álvarez
47c031614c Bug 1913322 - Make arrowscrollbox use resizeobserver rather than overflow/underflow events. r=Gijs,dao,desktop-theme-reviewers,tabbrowser-reviewers,frontend-codestyle-reviewers
For that, make the <slot> have a box. Keep firing the overflow /
underflow events, but only in cases relative to the arrowScrollbox.

Remove unneeded scrollbox-clip box, and replace it by
`overflow-clip-box-block: content-box` in the only place that we make
the scrollbox grow.

Differential Revision: https://phabricator.services.mozilla.com/D219249
2024-08-20 12:58:16 +00:00
Emilio Cobos Álvarez
9c457b174d Bug 1911353 - Unify how we reject !important in keyframe and @position-try. r=dshin
This was more the kind of thing I meant, and allows us to get rid of the
keyframe-rule-specific parser.

Differential Revision: https://phabricator.services.mozilla.com/D218488
2024-08-16 13:14:05 +00:00
David Shin
543946adb5 Bug 1900233: Disallow custom property and important declarations in @position-try. r=firefox-style-system-reviewers,emilio
Differential Revision: https://phabricator.services.mozilla.com/D217629
2024-08-16 13:14:05 +00:00
David Shin
604c5a7898 Bug 1909346: Implement CSSPositionTryRule interface. r=firefox-style-system-reviewers,webidl,emilio
Differential Revision: https://phabricator.services.mozilla.com/D217627
2024-08-16 13:14:04 +00:00
David Shin
75e9c1f48f Bug 1900233: Implement parsing @position-try rule. r=firefox-style-system-reviewers,emilio
Differential Revision: https://phabricator.services.mozilla.com/D217626
2024-08-16 13:14:04 +00:00
Emilio Cobos Álvarez
e17c4fe0dc Bug 1913459 - More inline declarations. r=firefox-style-system-reviewers,boris
This helps some speedometer subtests, 32 declarations is not really
that uncommon.

Differential Revision: https://phabricator.services.mozilla.com/D219330
2024-08-16 12:58:03 +00:00
Emilio Cobos Álvarez
4e8cf2fc99 Bug 1913104 - Remove X11 mask code. r=stransky,desktop-theme-reviewers,dao
It's only used in non-compositing WMs, to implement popup transparency,
and it's completely untested.

Instead, do not draw shadows and rounded corners on those WMs.

Differential Revision: https://phabricator.services.mozilla.com/D219141
2024-08-16 12:48:28 +00:00
Jonathan Watt
11482ce7b8 Bug 1909358. Rename inset-area to position-area. r=dshin
Differential Revision: https://phabricator.services.mozilla.com/D219225
2024-08-15 11:30:12 +00:00
David Shin
ed09cb9244 Bug 1913256: Fix up documentation on parse_is_and_where. r=firefox-style-system-reviewers,emilio
Differential Revision: https://phabricator.services.mozilla.com/D219214
2024-08-15 09:38:50 +00:00