2066 Commits

Author SHA1 Message Date
Simon Giesecke
fec8c64d2a Bug 1602452 - Make member functions of nsTStringRepr defined in header constexpr. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D56369

--HG--
extra : moz-landing-system : lando
2019-12-10 08:40:48 +00:00
Mihai Alexandru Michis
f995448544 Backed out changeset bf906a905a26 (bug 1602452) for causing bustages in gtest/TestStrings.cpp
CLOSED TREE
2019-12-09 17:41:25 +02:00
Simon Giesecke
50cf008dd3 Bug 1602452 - Make member functions of nsTStringRepr defined in header constexpr. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D56369

--HG--
extra : moz-landing-system : lando
2019-12-09 15:01:22 +00:00
Gabriele Svelto
5dc21d568c Bug 1600545 - Remove useless inclusions of header files generated from IDL files in modules/, netwerk/, parser/, security/, startupcache/, storage/, toolkit/, tools/, uriloader/, widget/, xpcom/ and xpfe/ r=Ehsan
The inclusions were removed with the following very crude script and the
resulting breakage was fixed up by hand. The manual fixups did either
revert the changes done by the script, replace a generic header with a more
specific one or replace a header with a forward declaration.

find . -name "*.idl" | grep -v web-platform | grep -v third_party | while read path; do
    interfaces=$(grep "^\(class\|interface\).*:.*" "$path" | cut -d' ' -f2)
    if [ -n "$interfaces" ]; then
        if [[ "$interfaces" == *$'\n'* ]]; then
          regexp="\("
          for i in $interfaces; do regexp="$regexp$i\|"; done
          regexp="${regexp%%\\\|}\)"
        else
          regexp="$interfaces"
        fi
        interface=$(basename "$path")
        rg -l "#include.*${interface%%.idl}.h" . | while read path2; do
            hits=$(grep -v "#include.*${interface%%.idl}.h" "$path2" | grep -c "$regexp" )
            if [ $hits -eq 0 ]; then
                echo "Removing ${interface} from ${path2}"
                grep -v "#include.*${interface%%.idl}.h" "$path2" > "$path2".tmp
                mv -f "$path2".tmp "$path2"
            fi
        done
    fi
done

Differential Revision: https://phabricator.services.mozilla.com/D55444

--HG--
extra : moz-landing-system : lando
2019-12-06 09:17:57 +00:00
Kershaw Chang
f3bddbd52b Bug 1596409 - P1.1: Make socket process support IPCStream r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D54289

--HG--
extra : moz-landing-system : lando
2019-12-03 13:41:58 +00:00
Cosmin Sabou
2952534343 Backed out changeset b3f5d18be1e6 (bug 1579581) for causing valgrind bustages. CLOSED TREE 2019-11-27 22:12:02 +02:00
emalysz
563fdba9f3 Bug 1579581, Part 1: Remove remaining CPU info off main-thread and load later on startup. r=mconley,chutten
Differential Revision: https://phabricator.services.mozilla.com/D51704

--HG--
extra : moz-landing-system : lando
2019-11-27 16:14:43 +00:00
Dorel Luca
6e67f20e69 Backed out changeset c7be5c184756 (bug 1579581) for reftest failures in xpcom/base/nsSystemInfo.cpp. CLOSED TREE 2019-11-26 22:35:40 +02:00
emalysz
5c76883c08 Bug 1579581, Part 1: Remove remaining CPU info off main-thread and load later on startup. r=mconley,chutten
Differential Revision: https://phabricator.services.mozilla.com/D51704

--HG--
extra : moz-landing-system : lando
2019-11-26 18:09:05 +00:00
Simon Giesecke
28f1dd4c5b Bug 1595750 - Add MakeBackInserter function to create a back-inserting output iterator for nsTArray. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D52685

--HG--
extra : moz-landing-system : lando
2019-11-13 09:06:42 +00:00
Noemi Erli
985bd5675a Backed out changeset 9b131da7e0cc (bug 1595750) for causing Windows build bustages CLOSED TREE 2019-11-12 20:08:09 +02:00
Simon Giesecke
e0f8b73760 Bug 1595750 - Add MakeBackInserter function to create a back-inserting output iterator for nsTArray. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D52685

--HG--
extra : moz-landing-system : lando
2019-11-12 15:52:24 +00:00
Sylvestre Ledru
f12b9fa5c3 Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D47737

--HG--
extra : moz-landing-system : lando
2019-10-06 18:29:55 +00:00
Geoff Brown
dcb380399e Bug 1582785 - Enable some xpcshell tests on Android; r=geckoview-reviewers,agi
Most of these tests have been disabled for a long time; they run well
in the current test environment.

Differential Revision: https://phabricator.services.mozilla.com/D46642

--HG--
extra : moz-landing-system : lando
2019-09-23 22:43:55 +00:00
Nathan Froyd
ad2dc55c0b Bug 1581941 - ignore the return values of some STL functions; r=sg
These functions are marked `nodiscard` in C++17.

Differential Revision: https://phabricator.services.mozilla.com/D46210

--HG--
extra : moz-landing-system : lando
2019-09-18 06:34:37 +00:00
Henri Sivonen
c193518677 Bug 1490601 part 2 - Move C++ entry points to encoding_c_mem to mfbt/. r=jwalden
Differential Revision: https://phabricator.services.mozilla.com/D43957

--HG--
extra : moz-landing-system : lando
2019-09-18 08:26:34 +00:00
Tom Ritter
be6c896158 Bug 1575974 - Report any non-zero exit code as a process failure in nsIProcess r=gsvelto
EXIT_FAILURE is 'implementation defined' but can be defined to be 1.
In our case, pingsender exits with EXIT_FAILURE but nsIProcess wasn't
reporting it as failure because it thought failures were always negative.

Differential Revision: https://phabricator.services.mozilla.com/D45038

--HG--
extra : moz-landing-system : lando
2019-09-11 04:40:11 +00:00
Razvan Maries
6984e0ca98 Backed out 1 changesets (bug 1575974) for xpcshell perma fails on test_nsIProcess.js. CLOSED TREE
Backed out changeset 44164f4b9d6d (bug 1575974)
2019-09-11 00:17:34 +03:00
Tom Ritter
c1e0ceb8cd Bug 1575974 - Correct the expected topic for positive non-zero return values r=me
CLOSED TREE

--HG--
extra : amend_source : b8385ec54d45e4e62c250fcd6fc013764817ad89
extra : histedit_source : d85d2a9f149d002c4790c8c954541a73117180b1
2019-09-10 22:35:46 +03:00
Simon Giesecke
26a1799ab0 Bug 1575479 - Add support for STL iterators and range-based for to nsBaseHashtable. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D44982

--HG--
extra : moz-landing-system : lando
2019-09-10 12:08:02 +00:00
Coroiu Cristina
77681b7832 Backed out 2 changesets (bug 1575479) for build bustage at build/src/gfx/thebes/gfxFT2Fonts.h on a CLOSED TREE
Backed out changeset dcbc7c69fb64 (bug 1575479)
Backed out changeset 6d54a8115393 (bug 1575479)
2019-09-10 15:01:10 +03:00
Simon Giesecke
1b5be2b03f Bug 1575479 - Add support for STL iterators and range-based for to nsBaseHashtable. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D44982

--HG--
extra : moz-landing-system : lando
2019-09-09 14:27:24 +00:00
Simon Giesecke
51a48d706f Bug 1578647 - Add RemoveElementAt/RemoveElementsAt overloads accepting const_iterator. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D44674

--HG--
extra : moz-landing-system : lando
2019-09-04 16:39:29 +00:00
Simon Giesecke
2ac5a4231e Bug 1578649 - Make ArrayIterator<Element&, ArrayType> convertible to ArrayIterator<const Element&, ArrayType>. r=froydnj
This matches the requirement imposed by the Container concept that its iterator type
should be convertible to its const_iterator type.

Differential Revision: https://phabricator.services.mozilla.com/D44673

--HG--
extra : moz-landing-system : lando
2019-09-04 18:48:05 +00:00
Tom Ritter
d922064696 Bug 1547519 - Rename NS_STRINGIFY to MOZ_STRINGIFY, move to mfbt, and unify stragglers r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D39961

--HG--
extra : moz-landing-system : lando
2019-09-04 02:40:32 +00:00
Sylvestre Ledru
36129ce948 Bug 1577236 - clang-10: Fix -Wimplicit-int-float-conversion warnings in various dirs r=glandium
Depends on D43784

Differential Revision: https://phabricator.services.mozilla.com/D43785

--HG--
extra : moz-landing-system : lando
2019-08-30 09:11:19 +00:00
Hiroyuki Ikezoe
2eec537348 Bug 1573648 - Introduce ToDoubleAllowTrailingChars and ToFloatAllowTrailingChars. r=njn
Differential Revision: https://phabricator.services.mozilla.com/D42239

--HG--
extra : moz-landing-system : lando
2019-08-16 22:38:01 +00:00
Nathan Froyd
f21661fdf8 Bug 1571759 - add nsTArray::EmplaceBack; r=erahm
Much preferred to `AppendElement(T(...))`.

Differential Revision: https://phabricator.services.mozilla.com/D42024

--HG--
extra : moz-landing-system : lando
2019-08-16 00:18:57 +00:00
Nathan Froyd
db237d1092 Bug 1298602 - split condition in TestExpirationTracker; r=KrisWright
This condition is intermittently failing, but it's hard to tell from the
failure which part of the condition is failing.  Split the condition
apart so ideally we'll get some better error messages.  While we're
doing that, use a more explicit `EXPECT_LT` for the first half of the
condition for even better error messages.

Differential Revision: https://phabricator.services.mozilla.com/D40051

--HG--
extra : moz-landing-system : lando
2019-07-31 18:16:35 +00:00
Boris Zbarsky
0f70d08ec8 Bug 1566595. Stop using [array] in nsIBinaryOutputStream. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D38387

--HG--
extra : moz-landing-system : lando
2019-07-22 20:27:39 +00:00
Ciure Andrei
98278afa46 Backed out changeset a858e4411532 (bug 1566595) for causing Windows MinGW builds bustages CLOSED TREE 2019-07-22 21:39:08 +03:00
Boris Zbarsky
9c74919340 Bug 1566595. Stop using [array] in nsIBinaryOutputStream. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D38387

--HG--
extra : moz-landing-system : lando
2019-07-22 14:52:04 +00:00
Kristen Wright
5984a7cba7 Bug 1565769 - Give threads an additional 50 ms to finish up in ShutdownWithTimeout tests r=erahm
Gtest jobs on the osx1014 try hardware are taking longer than anticipated to finish up, and ThreadPool.ShutdownWithTimeout tests need to wait an extra 50ms to let all threads finish on time. On the long term, when the underlying issue is fixed thread timeouts will need to be readjusted back to 300ms.

Differential Revision: https://phabricator.services.mozilla.com/D38452

--HG--
extra : moz-landing-system : lando
2019-07-18 17:57:43 +00:00
Barret Rennie
9d33bd810d Bug 1289211 - Rename InfallibleTArray to nsTArray in xpcom/ r=erahm
Differential Revision: https://phabricator.services.mozilla.com/D36970

--HG--
extra : moz-landing-system : lando
2019-07-10 03:33:59 +00:00
Victor Porof
1fcaa7d445 Bug 1561435 - Format xpcom/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35945

--HG--
extra : source : c64ace0e98b196a9a392d54800159e327921bf99
2019-07-05 11:19:37 +02:00
Nathan Froyd
d613ab5af6 Bug 1561410 - modify TestThreadPool to be more robust with bad timekeeping; r=KrisWright
Giving each logical test its own counter variable will help tests to not
interfere with each other.  We also make one infinite looping thread
exit so we're not chewing CPU after these tests finish.

Differential Revision: https://phabricator.services.mozilla.com/D36522

--HG--
extra : moz-landing-system : lando
2019-07-02 16:47:27 +00:00
Kristen Wright
a77062c3e5 Bug 1544452 - Increase slack boundaries for ExpirationTracker gtest r=froydnj
Increased slack boundaries to account for issues with timer bounds in macos 1014. Lower bound slack = 60ms and upper bound slack = 1200ms. The intent is to get gtests working in the short term while timer delays are fixed, then roll the slack boundary back to 30ms.

Differential Revision: https://phabricator.services.mozilla.com/D36419

--HG--
extra : moz-landing-system : lando
2019-07-01 18:08:25 +00:00
Tarek Ziadé
f9d319bac0 Bug 1558882 - Fixed intermittent on ThreadMetrics.CollectMetrics r=erahm
The first test does not really need to check that we spend less than
200ms, and we can give more time to the scheduler in the second
test, as long as we check that is less than the recursive dispatched
event

Differential Revision: https://phabricator.services.mozilla.com/D34988

--HG--
extra : moz-landing-system : lando
2019-06-14 16:43:01 +00:00
Andrea Marchesini
bb718d74fc Bug 1490044 - Remove DOMPrefs. r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D33510

--HG--
extra : moz-landing-system : lando
2019-06-13 09:02:03 +00:00
Dave Townsend
8f1c76b053 Bug 1556829: Convert version numbers larger or smaller than the 32-bit limit to 0. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D33700

--HG--
extra : rebase_source : 1fd6a7b05bb69a9dec655ffb3e668ae1bf13ee8f
2019-06-04 13:23:04 -07:00
Nicklas Boman
779fb0d72a Bug 1122740 - remove useless null checks after allocating memory with |new| r=erahm
Differential Revision: https://phabricator.services.mozilla.com/D33445

--HG--
extra : moz-landing-system : lando
2019-06-04 04:43:11 +00:00
Andrew McCreight
20b03783b4 Bug 1550770 - Error instead of implicitly converting XPCOM interfaces to builtinclass. r=nika
XPIDL has the requirement that [scriptable] interfaces with [notxpcom]
methods or attributes are [builtinclass]. Currently, if you don't
explicitly mark something builtinclass when it should be, then the
XPIDL compiler will just silently treat it like builtinclass. This
means that you can cause the JS implementation of an XPCOM to start
failing without any warning by marking a method notxpcom.

This patch instead makes it an error. A prior patch fixed the existing
instances in the tree that relied on the implicit behavior.

I also added a test that we reject such classes missing builtinclass
at compile time, as well as classes that inherit from builtinclass
interfaces without themselves being builtinclass. I left behind a part
of the runtime test for this behavior, but now this test just ensures
that you can't implement a [builtinclass] interface in JS.

Differential Revision: https://phabricator.services.mozilla.com/D30984

--HG--
extra : moz-landing-system : lando
2019-05-14 17:39:14 +00:00
Olli Pettay
bf41b4d6d7 Bug 1551203, Bug 1551203 - Give ThrottledEventQueues names, r=erahm
Differential Revision: https://phabricator.services.mozilla.com/D30920

--HG--
extra : moz-landing-system : lando
2019-05-13 18:12:24 +00:00
Jean-Yves Avenard
e0f0e16680 Bug 1548795 - P2. Remove dom.performance.enable_scheduler_timing preference. r=tarek
Differential Revision: https://phabricator.services.mozilla.com/D30467

--HG--
extra : moz-landing-system : lando
2019-05-09 23:12:12 +00:00
Geoff Brown
64c5e023b3 Bug 1545217 - Skip gtest TestThreads.cpp on android again; r=jmaher
I enabled this test yesterday, but it turns out it still crashes intermittently:
https://treeherder.mozilla.org/logviewer.html#?job_id=245063009&repo=autoland
https://taskcluster-artifacts.net/DJEiHJaJRaCYMWk2UMoR8A/0/public/test_info//logcat-emulator-5554.log
05-07 08:47:38.460  2530  2545 I gtest   : TEST-START | Threads.Main
--------- beginning of crash
05-07 08:47:38.570  2530  2545 F libc    : stack corruption detected
05-07 08:47:38.570  2530  2545 W google-breakpad: ExceptionHandler::GenerateDump cloned child

Differential Revision: https://phabricator.services.mozilla.com/D30198

--HG--
extra : moz-landing-system : lando
2019-05-07 14:20:58 +00:00
Geoff Brown
f208694292 Bug 1545217 - Enable some android gtests in xpcom/tests/gtest; r=jmaher
With changes from bug 1548555, some of the gtests previously disabled on Android
can be re-enabled.

Differential Revision: https://phabricator.services.mozilla.com/D30080

--HG--
extra : moz-landing-system : lando
2019-05-06 18:53:55 +00:00
Nathan Froyd
a3df20e771 Bug 1461601 - lower the OOM bound for TArray::test_fallible on Windows; r=erahm
Apparently 7 is not low enough.  Maybe 6 will be.

Differential Revision: https://phabricator.services.mozilla.com/D29503

--HG--
extra : moz-landing-system : lando
2019-05-01 17:04:40 +00:00
Sylvestre Ledru
e226046cb8 Bug 1547143 - Format the tree: Be prescriptive with the pointer style (left) r=Ehsan
# ignore-this-changeset

Depends on D28954

Differential Revision: https://phabricator.services.mozilla.com/D28956

--HG--
extra : moz-landing-system : lando
2019-05-01 08:47:10 +00:00
Edwin Gao
9994405ece Bug 1544961 - comment on gtests that are disabled, disable ThreadUtils.IdleRunnableMethod and Timers.FindExpirationTime for windows10-aarch64 r=jmaher,gbrown,dmajor
Changes:
- added comments for tests being disabled
- disabled two additional tests in order to green the run

Differential Revision: https://phabricator.services.mozilla.com/D28085

--HG--
extra : moz-landing-system : lando
2019-04-23 00:21:37 +00:00
Andrew McCreight
19c1077e83 Bug 1545851, part 1 - Change test_process_directives.js to use nsIProperty. r=froydnj
This will let us make nsISupportsString builtinclass.

Differential Revision: https://phabricator.services.mozilla.com/D28286

--HG--
extra : moz-landing-system : lando
2019-04-22 14:34:55 +00:00