Commit Graph

4165 Commits

Author SHA1 Message Date
Nan Jiang
5180b6c8bf Bug 1397789 - Tune Places data expiration for page metadata collection. r=mak
MozReview-Commit-ID: Kqq1VNVvnYt

--HG--
extra : rebase_source : 7786159d9c00591151144ad2d5fd1fad7af9365b
2017-09-14 09:59:33 -04:00
Simon Lindholm
3f46120d3c Bug 1392263 - Make TELEMETRY_1ST_RESULT count results of all types. r=mak
MozReview-Commit-ID: 82jJDZZG7kb
2017-09-14 00:06:54 +02:00
Simon Lindholm
4b8dbea3cb Bug 1393486 - Reduce subquery evaluations in awesomebar search SQL. r=mak 2017-09-09 02:36:00 -04:00
Kit Cambridge
0d29ca233e Bug 1393904 - Ensure insertTree removes Sync tombstones for restored bookmarks. r=mak
MozReview-Commit-ID: EbGybRbhWKJ

--HG--
extra : rebase_source : 596389e1ffc111f26cc10f014da6d74202f988eb
2017-08-25 12:04:22 -07:00
Ed Lee
0d6e05576c Bug 1396282 - Add query for getting Highlights (recent bookmarks and recent history with metadata). r=mak
Adds index to moz_bookmarks.dateAdded for use by Highlights query for recent bookmarks.
MozReview-Commit-ID: 7Gs8H0kUij2

--HG--
extra : rebase_source : 23498bcde4faeeb116c534dc9e124429a86d3e14
2017-09-02 13:15:04 -07:00
Bob Silverberg
8268904c53 Bug 1293853 - Part 2: Include separators in results from bookmarks.search, r=standard8
This API is only used by WebExtensions, which previously wanted to exclude separators,
but now we want the WebExtensions APIs to be able to return separators.

MozReview-Commit-ID: 7PApWDwWMr1

--HG--
extra : rebase_source : c5e816900cb0288f1cdba86ec07f6565a1c79880
2017-08-29 13:19:05 -04:00
Bob Silverberg
f8c2cd5f82 Bug 1293853 - Part 1: Add numeric typeCode to PlacesUtils.promiseBookmarksTree, r=standard8
This allows promiseBookmarksTree to return nodes that describe their type in both string (i.e., PlacesUtils.TYPE_X_*)
format and numeric (i.e., PlacesUtils.bookmarks.TYPE_*) formats. ext-bookmarks.js would prefer to be able to
use the numeric format as that is what is used throughout the rest of the file.

MozReview-Commit-ID: 7DpqAb3zVio

--HG--
extra : rebase_source : d6a9ead83e3de14bb8f52d9e19083a0f6ae609ee
2017-08-29 10:27:38 -04:00
Mark Banner
28c1327c42 Bug 1395994 - Clone arrays to fix a leak of windows caused by PlacesTransactions keeping references to arrays passed to it. r=mak
MozReview-Commit-ID: CWMyLtmNQuW

--HG--
extra : rebase_source : 30edd124f43508fab9c9823af151a26377bee610
2017-09-01 16:48:09 +01:00
Marco Bonardo
0b9644341f Bug 1395333 - Remove an unexpected warning from nsNavHistoryResult.cpp. r=standard8
MozReview-Commit-ID: 1Ba2Nwvs0FB

--HG--
extra : rebase_source : 454ce521443bcb07f74592271f79da58dae326d4
2017-09-01 13:55:01 +02:00
Wes Kocher
6472928439 Merge m-c to inbound, a=merge
MozReview-Commit-ID: 77Uz3uceUmk
2017-08-31 16:56:23 -07:00
Simon Lindholm
de414dfd84 Bug 1388331 - Use more precise criteria for stopping auto-complete searches. r=mak 2017-08-31 12:24:00 -04:00
Honza Bambas
8d492fe637 Bug 1395525 - Make all changes landed as part of tracker request tailing preferrable. r=dragana 2017-08-31 06:07:00 -04:00
Sebastian Hengst
2b41ef3155 merge mozilla-central to autoland. r=merge a=merge 2017-08-31 14:37:58 +02:00
Ryan VanderMeulen
94ba01b62f Backed out changeset 299138aaaecb (bug 1388331) for causing browser_urlbar_keyed_search_reflows.js failures. 2017-08-30 21:04:30 -04:00
Marco Bonardo
fe39f5ced4 Bug 1395082 - Intermittent toolkit/components/places/tests/browser/browser_visited_notfound.js. r=standard8
MozReview-Commit-ID: GzAZXNIbBCN

--HG--
extra : rebase_source : 18e79867846705ad5ab79588a9f97eaa3fd37324
2017-08-30 17:32:20 +02:00
Honza Bambas
4263c50db2 Bug 1358060 - Allow postponing of unimportant resources opening during page load, class-of-service Tail flag. r=dragana
--HG--
extra : rebase_source : 1ab691fe066e641c948aa5f42827305411579708
2017-08-30 09:32:00 -04:00
Simon Lindholm
440ff638ee Bug 1388331 - Use more precise criteria for stopping auto-complete searches. r=mak
--HG--
extra : rebase_source : 0ed1b334afe7d247eac3368bc4b2148da48b9dcd
2017-08-30 08:00:00 -04:00
Andrew McCreight
78807d8776 Bug 1391005 - Eliminate NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION_INHERITED. r=peterv
Replace it with NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION, because it
has been the same for a while.

MozReview-Commit-ID: 5agRGFyUry1

--HG--
extra : rebase_source : 5388c56b2f6905c6ef969150f0c5b77bf247624d
2017-08-29 16:02:48 -07:00
Eric Rahm
9398bd6f43 Bug 1393235 - Fix improper usages of string functions. r=njn
This fixes usages of `Find`, `RFind` and the equality operator that kind of
work right now but will break with the proper type checking of a templatized
version of the string classes.

For `Find` and `RFind` it appears that `nsCString::(R)Find("foo", 0)` calls
were being coerced to the `Find(char*, bool, int, int)` versions. The intent was
probably to just start searching from position zero.

For the equality operator, the type of nullptr is nullptr_t rather than
char(16_t)* so we'd need to add an operator overload that takes nullptr_t. In
this case just using `IsVoid` is probably more appropriate.

--HG--
extra : rebase_source : 50f78519084012ca669da0a211c489520c11d6b6
2017-08-22 19:30:46 -07:00
Ehsan Akhgari
bfb5870d18 Bug 1382923 - Avoid AddRef()ing the History service in the Link constructor; r=smaug 2017-08-28 00:51:26 -04:00
Mark Banner
79772e1b13 Bug 1371679 - Use skipDescendantsOnItemRemoval in nsNavHistoryResult to improve performance when deleting bookmark folders. r=mak
MozReview-Commit-ID: FaotgKVaEmH

--HG--
extra : rebase_source : f75a5ab77bdfd887dfe432e3a994b3c902b0b291
2017-08-01 12:40:40 +01:00
Ryan VanderMeulen
3d0158833d Merge autoland to m-c. a=merge 2017-08-24 20:20:08 -04:00
Simon Lindholm
0c65735985 Bug 1393483 - Correctly pass cancel token to _onResultRow. r=mak 2017-08-24 08:20:00 -04:00
Mark Banner
3966840fb0 Bug 1316348 - Make eraseEverything notify for removals within the top-level bookmarks folders to ensure correct updates on the UI. r=mak
MozReview-Commit-ID: 2bt24qqOd4S

--HG--
extra : rebase_source : b6a5ee35e535655ecc249953de532645f40ddc8d
2017-08-23 15:54:36 +01:00
Marco Bonardo
7f569f98d9 Bug 1320301 - Add partial support to sqlite3_interrupt. r=asuth
MozReview-Commit-ID: V3ZjLEjqmT

--HG--
extra : rebase_source : 6f559b473c32dfcfb2bfe919c53199e202f7d636
2017-07-31 22:27:23 +02:00
sellsellgo
54fa77007d Bug 1347452 - Assigned item.guid using PlacesUtils.history.makeGuid() in insertBookmark(). r=mak
MozReview-Commit-ID: LgVFlgNEzHf

--HG--
extra : rebase_source : 2aa9f76bae35842c07bf062f2f4da8c084eed30e
2017-08-17 09:50:25 +02:00
Mark Banner
a53020d022 Bug 1392098 - Enable the new ESLint no-useless-run-test rule across the tree. r=mossop
MozReview-Commit-ID: 35MaseieNUk

--HG--
extra : rebase_source : 98eaec6a67fd3b30ea6b0be641f26c3911012fab
2017-08-20 18:52:05 +01:00
Masatoshi Kimura
35399ee9fc Bug 1392070 - Stop using the StopIteration object in Sqlite.jsm. r=mak
MozReview-Commit-ID: BP3RuM5EweE

--HG--
extra : rebase_source : 1e0a6ba438e51a851013356faf84d8eb91ff78b6
2017-08-19 22:10:44 +09:00
Simon Lindholm
8b0e1c2942 Bug 1387780 - Optimize string searching in MatchAutoCompleteFunction. r=adw, r=emk 2017-08-20 17:21:00 -04:00
Simon Lindholm
56d59da636 Bug 1387780 - Avoid memory allocations when calling MatchAutoCompleteFunction. r=adw, r=froydnj 2017-08-20 17:19:00 -04:00
Nicolas Ouellet-Payeur
b242392e7d Bug 1353217 - importing bookmarks from html doesn't need to reset the bookmarks engine. r=markh
MozReview-Commit-ID: 4F7KF5ZkNuX

--HG--
extra : rebase_source : 521510fe074fa0f84f28212fa8a230a74dfd2ce8
2017-08-11 00:19:01 +00:00
Adam Gashlin
98018281c1 Bug 1376533 - Use low priority timer for places expiration r=kitcambridge
MozReview-Commit-ID: 2FVldA507J3

--HG--
extra : rebase_source : ec6769e617528158d9f45ce92c21980b928077bc
2017-08-10 13:57:13 -07:00
Kit Cambridge
674b6aad46 Bug 1389716 - Bookmarks.reorder shouldn't call withConnectionWrapper from within a transaction. r=mak
MozReview-Commit-ID: A6aMesfFcpF

--HG--
extra : rebase_source : f15465df235a0e1ce22feac62add454ff75104a9
2017-08-11 19:02:48 -07:00
Andrew Sutherland
1a8a11ff09 Bug 1388584 - Part 1: Bind ATTACH DATABASE path argument. r=adw r=markh a=Aryx
This is for the trunk/nightly landing only, and approval was explicitly
requested from #sheriffs to land without tests as a preliminary stop-gap.

Tests and a proper fix will land as part of bug 1389660, but that will be a few
days.

--HG--
extra : rebase_source : 5849f2f37d735387e13ac0486f1fae7906725111
extra : source : 908a4bb55a039985473e1565d88abebfe024c44c
2017-08-12 02:33:09 -04:00
Michael Layzell
82c9240971 Bug 1372433 - Label the PContent::Msg_NotifyVisited runnable, r=billm
I don't bother to label the runnables in the parent process being fired by
VisitedQuery, as we are not planning to perform scheduling in the parent process
if I remember correctly. It would be possible to label those runnables as well.

MozReview-Commit-ID: EosNOu62fEV
2017-08-11 18:07:58 -04:00
Wes Kocher
cff9e9b197 Merge m-c to autoland, a=merge
MozReview-Commit-ID: 2YvHbITn9w3
2017-08-10 18:25:34 -07:00
Wes Kocher
936a9461f6 Merge inbound to m-c a=merge
MozReview-Commit-ID: KRQeIGmhAPA
2017-08-10 18:14:34 -07:00
Sebastian Hengst
40fff72904 Backed out changeset 409b4345b85a (bug 1371679) as requested by Standard8. r=backout 2017-08-10 17:48:02 +02:00
Sebastian Hengst
51d351f567 merge mozilla-central to mozilla-inbound. r=merge a=merge 2017-08-10 17:41:11 +02:00
Masatoshi Kimura
6815cee2bd Bug 1387790 - Remove [deprecated] decodeImageData from imgITools. r=tnikkel
MozReview-Commit-ID: GZBYTPanHH6

--HG--
extra : rebase_source : f6ccc1a661533f7bdba8bb33bc9a85855b51ffae
2017-08-06 10:54:14 +09:00
Thom Chiovoloni
9c7fb28561 Bug 1372927 - Show mobile bookmarks folder in places organizer for sync users even if they have no mobile bookmarks. r=markh
This commit also makes a change to test_ensureMobileQuery in test_sync_utils.js
so that it actually runs (previously it had a typo in an import path that was
imported in a try/catch).

MozReview-Commit-ID: Kj8vqKpFi51

--HG--
extra : rebase_source : 48ac8f203bd800fce3128693ba5627ce13b3f4c9
2017-08-08 17:56:33 -04:00
Ryan VanderMeulen
6eb7aef00e Merge m-c to autoland. a=merge 2017-08-09 18:51:26 -04:00
Thom Chiovoloni
3e1366bdf6 Bug 1388149 - Make PlacesUtils.history.insertMany respect provided GUIDs r=markh
MozReview-Commit-ID: 7g6uABtHKg2

--HG--
extra : rebase_source : 0b43e026ad3de514d2ffbc56568bf3f4e3e17126
2017-08-07 16:01:10 -04:00
Valentin Gosu
3ebf792b66 Bug 1380617 - Change firefox code to use uri.displaySpec when unicode URLs are wanted r=Gijs
* Make URL bar show unicode URL by making losslessDecodeURI call uri.displaySpec
* Make sure URL bar copying returns unicode variant

MozReview-Commit-ID: GTESwOSJW0P
* * *
[mq]: bug1380617-url-autofill.patch

MozReview-Commit-ID: JUxFZcpc3rN
2017-08-09 17:43:51 +02:00
Kris Maglione
0ecfcbc93e Bug 1388215: Part 3 - Use JIT-friendly defineLazy*Getters methods when defining many lazy imports. r=florian
MozReview-Commit-ID: APoFwUhDFdj

--HG--
extra : rebase_source : 15761873b91efaf1d338b6361bf7168ab4348e0d
2017-08-09 13:03:36 -07:00
Mark Banner
17760ce731 Bug 1388250 - Remove old sync isBookmarked and getBookmarkedURIFor APIs from nsINavBookmarksService. r=Paolo
Also remove IsBookmarkedInDatabase(), mItemCount, RecursiveFindRedirectedBookmark(), UpdateKeywordsForRemovedBookmark() from nsNavBookmarks as they aren't used anywhere.

MozReview-Commit-ID: 4cZXAdRuVoF

--HG--
extra : rebase_source : 2c08a09de48cfb06c3e8db261dfe7ea1b1526e10
2017-08-08 07:58:59 +01:00
Mark Banner
0b94d0fe3e Bug 1385733 - Improve the performance of async transactions when bookmarking all tabs. r=adw
Optimise adding a folder with child bookmarks for transactions by allowing PlacesTransactions.NewFolder to take children details and use insertTree rather than needing separate NewFolder and then multiple NewBookmark transactions.

MozReview-Commit-ID: 6s9j0pbsiUB

--HG--
extra : rebase_source : 0b4029905dc76a0ca49d16a7e71c85f1f07b8e2d
2017-08-03 18:32:42 +01:00
Dan Banner
97335e3052 Bug 1382963 - Remove the require-await eslint rule from Places. r=standard8
MozReview-Commit-ID: LPWSUXQSPyH

--HG--
extra : rebase_source : 311f64f64c18146abab7e5c3b04aaec4ee87b756
2017-08-07 15:30:48 +01:00
Nicholas Nethercote
f941156987 Bug 1386600 - Change nsIStringBundle methods to return |AString| instead of |wstring|. r=emk,sr=dbaron.
This removes about 2/3 of the occurrences of nsXPIDLString in the tree. The
places where nsXPIDLStrings are null-checked are replaced with |rv| checks.

The patch also removes a couple of unused declarations from
nsIStringBundle.idl.

Note that nsStringBundle::GetStringFromNameHelper() was merged into
GetStringFromName(), because they both would have had the same signature.

--HG--
extra : rebase_source : ac40bc31c2a4997f2db0bd5069cc008757a2df6d
2017-08-04 14:40:52 +10:00
Masatoshi Kimura
8b713b2b0f Bug 1375125 - Stop using nsILocalFile in the tree. r=froydnj
This mechanically replaces nsILocalFile with nsIFile in
*.js, *.jsm, *.sjs, *.html, *.xul, *.xml, and *.py.

MozReview-Commit-ID: 4ecl3RZhOwC

--HG--
extra : rebase_source : 412880ea27766118c38498d021331a3df6bccc70
2017-08-04 17:49:22 +09:00