gecko-dev/997805-ref.html at master - gecko-dev - Gitea: Git with a cup of tea

Magic-Mirror/gecko-dev

mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-23 04:41:11 +00:00

Ehsan Akhgari 298702866a Bug 997805 - Correctly restore the placeholder text after the editor object is re-attached to a text control as a result of a reframe; r=bzbarsky

Recomputing the placeholder visibility does not require the placeholder div
itself to be present, as the only information required for that is the current
value of the text control which is present either way.  This patch fixes
nsTextEditorState::ValueWasChanged and nsTextEditorState::UpdatePlaceholderVisibility
to that effect.

But the real fix is in nsTextEditorState::UpdatePlaceholderText, where after
setting the placeholder text on the anonymous div, we redo the placeholder
visibility computation.  Since this function can be called from
HTMLTextAreaElement::CreatePlaceholderNode during frame construction, the
GetValue function may return the wrong value since the editor has not properly
been set up yet, resulting in this bug.  And this function call is useless
anyway, because changing the placeholder text does not really affect the
result of the visibility computation, so there is no need to do this work
in the first place.

2014-04-25 16:40:44 -04:00

3 lines

64 B

HTML

Raw Permalink Blame History

	`<!DOCTYPE html>`
	`<textarea placeholder="placeholder"></textarea>`