gecko-dev/dom/html/HTMLOptGroupElement.cpp
Emilio Cobos Álvarez 51758cfc9b Bug 1829189 - Make OnAttrSetButNotChanged and AfterSetAttr infallible. r=smaug
Same rg + sed shenanigans as the first patch.

There were two that could fail, both due to OOM:

 * HTMLInputElement::AfterSetAttr: If we fail (only in the type=range
   case) we end up with an old value without it being clamped by
   min/max/step.

 * HTMLBodyElement::AfterSetAttr: If we fail we won't peek up the
   DocShell's frame margins and styling could be incorrect.

That seems better than having to deal with broken states after we've
already set the attribute.

Depends on D176069

Differential Revision: https://phabricator.services.mozilla.com/D176070
2023-04-21 08:56:27 +00:00

116 lines
4.0 KiB
C++

/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#include "mozilla/EventDispatcher.h"
#include "mozilla/Maybe.h"
#include "mozilla/dom/HTMLOptGroupElement.h"
#include "mozilla/dom/HTMLOptGroupElementBinding.h"
#include "mozilla/dom/HTMLSelectElement.h" // SafeOptionListMutation
#include "nsGkAtoms.h"
#include "nsStyleConsts.h"
#include "nsIFrame.h"
#include "nsIFormControlFrame.h"
NS_IMPL_NS_NEW_HTML_ELEMENT(OptGroup)
namespace mozilla::dom {
/**
* The implementation of <optgroup>
*/
HTMLOptGroupElement::HTMLOptGroupElement(
already_AddRefed<mozilla::dom::NodeInfo>&& aNodeInfo)
: nsGenericHTMLElement(std::move(aNodeInfo)) {
// We start off enabled
AddStatesSilently(ElementState::ENABLED);
}
HTMLOptGroupElement::~HTMLOptGroupElement() = default;
NS_IMPL_ELEMENT_CLONE(HTMLOptGroupElement)
void HTMLOptGroupElement::GetEventTargetParent(EventChainPreVisitor& aVisitor) {
aVisitor.mCanHandle = false;
if (nsIFrame* frame = GetPrimaryFrame()) {
// FIXME(emilio): This poking at the style of the frame is broken unless we
// flush before every event handling, which we don't really want to.
if (frame->StyleUI()->UserInput() == StyleUserInput::None) {
return;
}
}
nsGenericHTMLElement::GetEventTargetParent(aVisitor);
}
Element* HTMLOptGroupElement::GetSelect() {
Element* parent = nsINode::GetParentElement();
if (!parent || !parent->IsHTMLElement(nsGkAtoms::select)) {
return nullptr;
}
return parent;
}
void HTMLOptGroupElement::InsertChildBefore(nsIContent* aKid,
nsIContent* aBeforeThis,
bool aNotify, ErrorResult& aRv) {
const uint32_t index =
aBeforeThis ? *ComputeIndexOf(aBeforeThis) : GetChildCount();
SafeOptionListMutation safeMutation(GetSelect(), this, aKid, index, aNotify);
nsGenericHTMLElement::InsertChildBefore(aKid, aBeforeThis, aNotify, aRv);
if (aRv.Failed()) {
safeMutation.MutationFailed();
}
}
void HTMLOptGroupElement::RemoveChildNode(nsIContent* aKid, bool aNotify) {
SafeOptionListMutation safeMutation(GetSelect(), this, nullptr,
*ComputeIndexOf(aKid), aNotify);
nsGenericHTMLElement::RemoveChildNode(aKid, aNotify);
}
void HTMLOptGroupElement::AfterSetAttr(int32_t aNameSpaceID, nsAtom* aName,
const nsAttrValue* aValue,
const nsAttrValue* aOldValue,
nsIPrincipal* aSubjectPrincipal,
bool aNotify) {
if (aNameSpaceID == kNameSpaceID_None && aName == nsGkAtoms::disabled) {
ElementState disabledStates;
if (aValue) {
disabledStates |= ElementState::DISABLED;
} else {
disabledStates |= ElementState::ENABLED;
}
ElementState oldDisabledStates = State() & ElementState::DISABLED_STATES;
ElementState changedStates = disabledStates ^ oldDisabledStates;
if (!changedStates.IsEmpty()) {
ToggleStates(changedStates, aNotify);
// All our children <option> have their :disabled state depending on our
// disabled attribute. We should make sure their state is updated.
for (nsIContent* child = nsINode::GetFirstChild(); child;
child = child->GetNextSibling()) {
if (auto optElement = HTMLOptionElement::FromNode(child)) {
optElement->OptGroupDisabledChanged(true);
}
}
}
}
return nsGenericHTMLElement::AfterSetAttr(
aNameSpaceID, aName, aValue, aOldValue, aSubjectPrincipal, aNotify);
}
JSObject* HTMLOptGroupElement::WrapNode(JSContext* aCx,
JS::Handle<JSObject*> aGivenProto) {
return HTMLOptGroupElement_Binding::Wrap(aCx, this, aGivenProto);
}
} // namespace mozilla::dom