mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-20 00:35:44 +00:00
780b285e68
Unfortunately, `EventChainVisitor` does not grab the `nsPresContext` with `RefPtr` by itself. Therefore, there is no guarantee of the lifetime without checking the origin when its subclasses are instantiated. This patch changes it and subclasses to `MOZ_STACK_CLASS` since only `EventDispatcher::Dispatch()` creates them in the stack with given `nsPresContext`. Additionally, it's already been marked as MOZ_CAN_RUN_SCRIPT_BOUNDARY`. Therefore, the `nsPresContext` instance has already been guaranteed its lifetime by the caller. For making this fact stronger, this patch marks their constructors as `MOZ_CAN_RUN_SCRIPT`. Therefore, nobody can create those instances without guaranteeing the lifetime of `nsPresContext` and `dom::Event`. Note that it may look like that `mPresContext` of `EventChainPostVisitor` is not guaranteed. However, `EventChainPreVisitor` which gives `nsPresContext` to it is also a stack only class. So, it won't be deleted before `EventChainPostVisitor` instance. Differential Revision: https://phabricator.services.mozilla.com/D30010 --HG-- extra : moz-landing-system : lando
89 lines
2.9 KiB
C++
89 lines
2.9 KiB
C++
/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
/**
|
|
|
|
Eric D Vaughan
|
|
This class lays out its children either vertically or horizontally
|
|
|
|
**/
|
|
|
|
#ifndef nsScrollbarButtonFrame_h___
|
|
#define nsScrollbarButtonFrame_h___
|
|
|
|
#include "mozilla/Attributes.h"
|
|
#include "nsButtonBoxFrame.h"
|
|
#include "nsITimer.h"
|
|
#include "nsRepeatService.h"
|
|
|
|
namespace mozilla {
|
|
class PresShell;
|
|
} // namespace mozilla
|
|
|
|
class nsScrollbarButtonFrame final : public nsButtonBoxFrame {
|
|
public:
|
|
NS_DECL_FRAMEARENA_HELPERS(nsScrollbarButtonFrame)
|
|
|
|
explicit nsScrollbarButtonFrame(ComputedStyle* aStyle,
|
|
nsPresContext* aPresContext)
|
|
: nsButtonBoxFrame(aStyle, aPresContext, kClassID),
|
|
mCursorOnThis(false) {}
|
|
|
|
// Overrides
|
|
virtual void DestroyFrom(nsIFrame* aDestructRoot,
|
|
PostDestroyData& aPostDestroyData) override;
|
|
|
|
friend nsIFrame* NS_NewScrollbarButtonFrame(mozilla::PresShell* aPresShell,
|
|
ComputedStyle* aStyle);
|
|
|
|
virtual nsresult HandleEvent(nsPresContext* aPresContext,
|
|
mozilla::WidgetGUIEvent* aEvent,
|
|
nsEventStatus* aEventStatus) override;
|
|
|
|
static nsresult GetChildWithTag(nsAtom* atom, nsIFrame* start,
|
|
nsIFrame*& result);
|
|
static nsresult GetParentWithTag(nsAtom* atom, nsIFrame* start,
|
|
nsIFrame*& result);
|
|
|
|
bool HandleButtonPress(nsPresContext* aPresContext,
|
|
mozilla::WidgetGUIEvent* aEvent,
|
|
nsEventStatus* aEventStatus);
|
|
|
|
NS_IMETHOD HandleMultiplePress(nsPresContext* aPresContext,
|
|
mozilla::WidgetGUIEvent* aEvent,
|
|
nsEventStatus* aEventStatus,
|
|
bool aControlHeld) override {
|
|
return NS_OK;
|
|
}
|
|
|
|
MOZ_CAN_RUN_SCRIPT
|
|
NS_IMETHOD HandleDrag(nsPresContext* aPresContext,
|
|
mozilla::WidgetGUIEvent* aEvent,
|
|
nsEventStatus* aEventStatus) override {
|
|
return NS_OK;
|
|
}
|
|
|
|
NS_IMETHOD HandleRelease(nsPresContext* aPresContext,
|
|
mozilla::WidgetGUIEvent* aEvent,
|
|
nsEventStatus* aEventStatus) override;
|
|
|
|
protected:
|
|
void StartRepeat() {
|
|
nsRepeatService::GetInstance()->Start(
|
|
Notify, this, mContent->OwnerDoc(),
|
|
NS_LITERAL_CSTRING("nsScrollbarButtonFrame"));
|
|
}
|
|
void StopRepeat() { nsRepeatService::GetInstance()->Stop(Notify, this); }
|
|
void Notify();
|
|
static void Notify(void* aData) {
|
|
static_cast<nsScrollbarButtonFrame*>(aData)->Notify();
|
|
}
|
|
|
|
bool mCursorOnThis;
|
|
};
|
|
|
|
#endif
|