mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-23 02:05:42 +00:00
e930b89c34
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
80 lines
2.3 KiB
JavaScript
80 lines
2.3 KiB
JavaScript
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
"use strict";
|
|
|
|
var EXPORTED_SYMBOLS = [ "Deprecated" ];
|
|
|
|
const PREF_DEPRECATION_WARNINGS = "devtools.errorconsole.deprecation_warnings";
|
|
|
|
const {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
|
|
|
|
// A flag that indicates whether deprecation warnings should be logged.
|
|
var logWarnings = Services.prefs.getBoolPref(PREF_DEPRECATION_WARNINGS);
|
|
|
|
Services.prefs.addObserver(PREF_DEPRECATION_WARNINGS,
|
|
function(aSubject, aTopic, aData) {
|
|
logWarnings = Services.prefs.getBoolPref(PREF_DEPRECATION_WARNINGS);
|
|
});
|
|
|
|
/**
|
|
* Build a callstack log message.
|
|
*
|
|
* @param nsIStackFrame aStack
|
|
* A callstack to be converted into a string log message.
|
|
*/
|
|
function stringifyCallstack(aStack) {
|
|
// If aStack is invalid, use Components.stack (ignoring the last frame).
|
|
if (!aStack || !(aStack instanceof Ci.nsIStackFrame)) {
|
|
aStack = Components.stack.caller;
|
|
}
|
|
|
|
let frame = aStack.caller;
|
|
let msg = "";
|
|
// Get every frame in the callstack.
|
|
while (frame) {
|
|
msg += frame.filename + " " + frame.lineNumber +
|
|
" " + frame.name + "\n";
|
|
frame = frame.caller;
|
|
}
|
|
return msg;
|
|
}
|
|
|
|
var Deprecated = {
|
|
/**
|
|
* Log a deprecation warning.
|
|
*
|
|
* @param string aText
|
|
* Deprecation warning text.
|
|
* @param string aUrl
|
|
* A URL pointing to documentation describing deprecation
|
|
* and the way to address it.
|
|
* @param nsIStackFrame aStack
|
|
* An optional callstack. If it is not provided a
|
|
* snapshot of the current JavaScript callstack will be
|
|
* logged.
|
|
*/
|
|
warning(aText, aUrl, aStack) {
|
|
if (!logWarnings) {
|
|
return;
|
|
}
|
|
|
|
// If URL is not provided, report an error.
|
|
if (!aUrl) {
|
|
Cu.reportError("Error in Deprecated.warning: warnings must " +
|
|
"provide a URL documenting this deprecation.");
|
|
return;
|
|
}
|
|
|
|
let textMessage = "DEPRECATION WARNING: " + aText +
|
|
"\nYou may find more details about this deprecation at: " +
|
|
aUrl + "\n" +
|
|
// Append a callstack part to the deprecation message.
|
|
stringifyCallstack(aStack);
|
|
|
|
// Report deprecation warning.
|
|
Cu.reportError(textMessage);
|
|
},
|
|
};
|