mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-23 02:05:42 +00:00
e930b89c34
*** Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8 This changes the behavior of ChromeUtils.import() to return an exports object, rather than a module global, in all cases except when `null` is passed as a second argument, and changes the default behavior not to pollute the global scope with the module's exports. Thus, the following code written for the old model: ChromeUtils.import("resource://gre/modules/Services.jsm"); is approximately the same as the following, in the new model: var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm"); Since the two behaviors are mutually incompatible, this patch will land with a scripted rewrite to update all existing callers to use the new model rather than the old. *** Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs This was done using the followng script: https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm *** Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8 Differential Revision: https://phabricator.services.mozilla.com/D16747 *** Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D16748 *** Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D16749 *** Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs *** Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D16750 --HG-- extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895 extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
49 lines
1.7 KiB
JavaScript
49 lines
1.7 KiB
JavaScript
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
"use strict";
|
|
|
|
/**
|
|
* This module consolidates various code and data update requests, so flags
|
|
* can be set, Telemetry collected, etc. in a central place.
|
|
*/
|
|
|
|
const {Log} = ChromeUtils.import("resource://gre/modules/Log.jsm");
|
|
const {XPCOMUtils} = ChromeUtils.import("resource://gre/modules/XPCOMUtils.jsm");
|
|
XPCOMUtils.defineLazyGlobalGetters(this, ["XMLHttpRequest"]);
|
|
|
|
var EXPORTED_SYMBOLS = [ "ServiceRequest" ];
|
|
|
|
const logger = Log.repository.getLogger("ServiceRequest");
|
|
logger.level = Log.Level.Debug;
|
|
logger.addAppender(new Log.ConsoleAppender(new Log.BasicFormatter()));
|
|
|
|
/**
|
|
* ServiceRequest is intended to be a drop-in replacement for current users
|
|
* of XMLHttpRequest.
|
|
*
|
|
* @param {Object} options - Options for underlying XHR, e.g. { mozAnon: bool }
|
|
*/
|
|
class ServiceRequest extends XMLHttpRequest {
|
|
constructor(options) {
|
|
super(options);
|
|
}
|
|
/**
|
|
* Opens an XMLHttpRequest, and sets the NSS "beConservative" flag.
|
|
* Requests are always async.
|
|
*
|
|
* @param {String} method - HTTP method to use, e.g. "GET".
|
|
* @param {String} url - URL to open.
|
|
* @param {Object} options - Additional options (reserved for future use).
|
|
*/
|
|
open(method, url, options) {
|
|
super.open(method, url, true);
|
|
|
|
// Disable cutting edge features, like TLS 1.3, where middleboxes might brick us
|
|
if (super.channel instanceof Ci.nsIHttpChannelInternal) {
|
|
super.channel.QueryInterface(Ci.nsIHttpChannelInternal).beConservative = true;
|
|
}
|
|
}
|
|
}
|