gecko-dev/remote/JSONHandler.jsm
Andreas Tolfsen 4f8001ba30 bug 1606612: remote: stop sanitizing JSON payloads from the HTTPD r=remote-protocol-reviewers,whimboo
The CDP protocol expects consistent types to be returned.  By filtering
out null values and strings of zero length we break this promise.

Differential Revision: https://phabricator.services.mozilla.com/D58620

--HG--
extra : moz-landing-system : lando
2020-01-07 16:22:49 +00:00

78 lines
1.9 KiB
JavaScript

/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
"use strict";
var EXPORTED_SYMBOLS = ["JSONHandler"];
const { HTTP_404, HTTP_505 } = ChromeUtils.import(
"chrome://remote/content/server/HTTPD.jsm"
);
const { Log } = ChromeUtils.import("chrome://remote/content/Log.jsm");
const { Protocol } = ChromeUtils.import("chrome://remote/content/Protocol.jsm");
const { RemoteAgentError } = ChromeUtils.import(
"chrome://remote/content/Error.jsm"
);
class JSONHandler {
constructor(agent) {
this.agent = agent;
this.routes = {
"/json/version": this.getVersion.bind(this),
"/json/protocol": this.getProtocol.bind(this),
"/json/list": this.getTargetList.bind(this),
};
}
getVersion() {
const mainProcessTarget = this.agent.targets.getMainProcessTarget();
return {
Browser: "Firefox",
"Protocol-Version": "1.0",
"User-Agent": "Mozilla",
"V8-Version": "1.0",
"WebKit-Version": "1.0",
webSocketDebuggerUrl: mainProcessTarget.toJSON().webSocketDebuggerUrl,
};
}
getProtocol() {
return Protocol.Description;
}
getTargetList() {
return [...this.agent.targets];
}
// nsIHttpRequestHandler
handle(request, response) {
if (request.method != "GET") {
throw HTTP_404;
}
if (!(request.path in this.routes)) {
throw HTTP_404;
}
try {
const body = this.routes[request.path]();
const payload = JSON.stringify(body, null, Log.verbose ? "\t" : null);
response.setStatusLine(request.httpVersion, 200, "OK");
response.setHeader("Content-Type", "application/json");
response.write(payload);
} catch (e) {
new RemoteAgentError(e).notify();
throw HTTP_505;
}
}
// XPCOM
get QueryInterface() {
return ChromeUtils.generateQI([Ci.nsIHttpRequestHandler]);
}
}