mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-11-23 21:01:08 +00:00
c73c31cbe8
When not using blob recordings for vector images we use simple surface providers. When we get an invalidation we will call SurfaceCache::InvalidateImage which will set a dirty bit on all blob recordings and remove all other surfaces from the surface cache. And if it finds a blob recording we will call ResumeHonoringInvalidations. This is not enough to invalidate in the case of a non-animated vector image using the webrender GetImageProvider path. Even though the surface isn't in the surface cache anymore it is still cached on the frame and when we tell it about the invalidation it will just has the image provider to update its key. That will call this code https://searchfox.org/mozilla-central/rev/cdddec7fd690700efa4d6b48532cf70155e0386b/image/DecodedSurfaceProvider.cpp#222 which will just share the same surface as before the invalidation happened again. That will let us handle one invalidation but it still won't fix the bug, we need to call ResumeHonoringInvalidations so that we handle further invalidations. When not using the image provider path, we don't save an image provider on the frame, that alone would avoid this problem. But we also call ResumeHonoringInvalidations for every successful call of VectorImage::Draw. * * * imported patch asvfref Differential Revision: https://phabricator.services.mozilla.com/D174450
67 lines
1.9 KiB
C++
67 lines
1.9 KiB
C++
/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#ifndef MOZILLA_IMAGE_WEBRENDERIMAGEPROVIDER_H_
|
|
#define MOZILLA_IMAGE_WEBRENDERIMAGEPROVIDER_H_
|
|
|
|
#include "nsISupportsImpl.h"
|
|
|
|
namespace mozilla {
|
|
namespace layers {
|
|
class RenderRootStateManager;
|
|
}
|
|
|
|
namespace wr {
|
|
class IpcResourceUpdateQueue;
|
|
struct ExternalImageId;
|
|
struct ImageKey;
|
|
} // namespace wr
|
|
|
|
namespace image {
|
|
|
|
class ImageResource;
|
|
using ImageProviderId = uint32_t;
|
|
|
|
class WebRenderImageProvider {
|
|
public:
|
|
// Subclasses may or may not be XPCOM classes, so we just require that they
|
|
// implement AddRef and Release.
|
|
NS_INLINE_DECL_PURE_VIRTUAL_REFCOUNTING
|
|
|
|
ImageProviderId GetProviderId() const { return mProviderId; }
|
|
|
|
static ImageProviderId AllocateProviderId();
|
|
|
|
/**
|
|
* Generate an ImageKey for the given frame.
|
|
* @param aSurface The current frame. This should match what was cached via
|
|
* SetCurrentFrame, but if it does not, it will need to
|
|
* regenerate the cached ImageKey.
|
|
*/
|
|
virtual nsresult UpdateKey(layers::RenderRootStateManager* aManager,
|
|
wr::IpcResourceUpdateQueue& aResources,
|
|
wr::ImageKey& aKey) {
|
|
return NS_ERROR_NOT_AVAILABLE;
|
|
}
|
|
|
|
/**
|
|
* Invalidate if a blob recording or simple surface provider (both are only
|
|
* used by vector images), requiring it to be regenerated.
|
|
*/
|
|
virtual void InvalidateSurface() {}
|
|
|
|
protected:
|
|
WebRenderImageProvider(const ImageResource* aImage);
|
|
|
|
private:
|
|
ImageProviderId mProviderId;
|
|
};
|
|
|
|
} // namespace image
|
|
} // namespace mozilla
|
|
|
|
#endif /* MOZILLA_IMAGE_WEBRENDERIMAGEPROVIDER_H_ */
|