gecko-dev/widget/cocoa
Masayuki Nakano a028890899 Bug 1317906 When a key press causes a call of InsertText(), it shouldn't mark keypress as consumed but instead, should mark InsertText() caused composition r=m_kato
Currently, when InsertText() which is caused by a key press causes committing composition, it consumes keypress event.  However, Korean 2-set IME calls InsertText() two times when there is composition and key press causes inserting another character next to the composition.  In this case, current design ignores second InsertText() becuase keypress event is already consumed by the first InsertText() call.

For solving this issue safely, InsertText() should mark current key event as "dispatched composition event". Then, following InsertText() calls should cause composition events instead of keypress events since following event order is too odd:

1. keydown (currently not dispatched by TextEventDisaptcher)
2. compositionupdate
3. compositionend
4. keypress
5. keyup

with the new design this becomes:

1. keydown (currently not dispatched by TextEventDispatcher)
2. compositionupdate
3. compositionend
4. compositionstart
5. compositionupdate
6. compositionend
7. keyup

This is similar to Chromium, although, Chromium includes the second InsertText() call into the first composition, we need to fix it later due to risky.

MozReview-Commit-ID: GL42cU2WIL0

--HG--
extra : rebase_source : 2063c56166f6c9ccee25a74e1d29f94daa6b159c
2016-11-17 13:35:21 +09:00
..
crashtests
cursors
resources/MainMenu.nib
ComplexTextInputPanel.h
ComplexTextInputPanel.mm Bug 1282251 - Remove nsCocoaFeatures::OnLionOrLater(), OnMountainLionOrLater() and OnMavericksOrLater(). r=spohl. 2016-07-11 21:19:36 +02:00
CustomCocoaEvents.h
GfxInfo.h Bug 1263249 - Bubble up unique failureId in GetFeatureStatus. r=mconley,milan 2016-04-13 17:12:47 -04:00
GfxInfo.mm Bug 1284341: Add utility functions to recognize OS X 10.12. r=mstange 2016-07-04 17:25:25 -04:00
moz.build Bug 1304829 - rename RELEASE_BUILD to RELEASE_OR_BETA: main part. r=ted,Mossop 2016-10-08 11:14:49 +02:00
mozView.h
NativeKeyBindings.h
NativeKeyBindings.mm Bug 1235261 - Part 1: Rename nsAutoTArray to AutoTArray. r=froydnj 2016-02-02 17:36:30 +02:00
nsAppShell.h
nsAppShell.mm Bug 1313903 - Fix -Wmismatched-parameter-types warning in widget/cocoa/nsAppShell.mm. r=spohl 2016-11-02 21:18:36 -07:00
nsBidiKeyboard.h
nsBidiKeyboard.mm
nsChangeObserver.h
nsChildView.h Bug 1315706 - Pass a wrapper struct to various CompositorWidget functions. r=dvander 2016-11-07 21:16:52 -05:00
nsChildView.mm Bug 1315706 - Pass a wrapper struct to various CompositorWidget functions. r=dvander 2016-11-07 21:16:52 -05:00
nsClipboard.h Bug 1261299 - Implement nsIClipboard methods in nsClipboard.mm with methods specific for osx. (EmptyClipboard, SetData) methods modified from nsBaseClipboard to also set the current selection cache. r=jimm 2016-08-11 16:43:32 -04:00
nsClipboard.mm Bug 1310017 - Remove nsISupportsArray usage from nsITransferable and nsIFormatConverter. r=smaug 2016-10-16 12:43:56 -07:00
nsCocoaDebugUtils.h
nsCocoaDebugUtils.mm
nsCocoaFeatures.h Bug 1282251 - Remove nsCocoaFeatures::OnLionOrLater(), OnMountainLionOrLater() and OnMavericksOrLater(). r=spohl. 2016-07-11 21:19:36 +02:00
nsCocoaFeatures.mm Bug 1282251 - Remove nsCocoaFeatures::OnLionOrLater(), OnMountainLionOrLater() and OnMavericksOrLater(). r=spohl. 2016-07-11 21:19:36 +02:00
nsCocoaUtils.h Bug 1279017 - Remove code specific to 10.6-10.8 in widget/cocoa. r=mstange. 2016-06-10 23:30:25 +02:00
nsCocoaUtils.mm Bug 1284837 - Disallow implicit conversions from float to integer when creating IntPoint and IntSize objects. r=botond 2016-07-26 16:48:30 +02:00
nsCocoaWindow.h Bug 1260850: Ensure that FilePicker (and other native app modal dialogs) on OSX remains responsive when a window modal dialog opens in the background. r=mstange 2016-09-08 15:41:55 -04:00
nsCocoaWindow.mm Bug 1299860 - Don't use the compositor backend of a popup with ImageBridge and VRManager. r=Bas 2016-10-07 11:08:32 +02:00
nsColorPicker.h Bug 1241764: Replace nsPIDOMWindow with nsPIDOMWindowInner/Outer. r=mrbkap,smaug 2016-01-30 09:05:36 -08:00
nsColorPicker.mm Bug 1293593: Fix crash due to an Objective-C exception when calling getRed:green:blue:alpha on an NSColor instance with an incompatible NSColorSpace. r=mstange 2016-08-19 23:17:58 -04:00
nsCursorManager.h
nsCursorManager.mm
nsDeviceContextSpecX.h Bug 1278269 - Make a PrintTarget class and PrintTargetThebes subclass and convert all nsIDeviceContextSpec subclasses to use them. r=Bas 2016-06-03 11:27:31 +01:00
nsDeviceContextSpecX.mm Bug 1313525 - Remove the nsIPrintOptions interface. r=mstange 2016-10-28 00:31:14 +01:00
nsDragService.h Bug 1301673, use device pixels for the supplied drag position and the computed dragrectangle, r=tn 2016-10-19 15:01:39 -04:00
nsDragService.mm Bug 1301673, use the correct coordinates when drag feedback is disabled or fails; this allows the drag feedback on Mac to appear as a grey rectangle, r=tn 2016-10-19 15:01:39 -04:00
nsFilePicker.h
nsFilePicker.mm Bug 1295914, improve the label of the button of folder picker, r=baku,mstange,karlt,jimm 2016-08-24 02:07:21 +03:00
nsIdleServiceX.h
nsIdleServiceX.mm
nsLookAndFeel.h Bug 1280119 - Remove obsolete scrollbar constants in nsLookAndFeel.h. r=mstange. 2016-06-14 23:02:58 +02:00
nsLookAndFeel.mm Bug 1308479, use [NSApp isFullKeyboardAccessEnabled] to get keyboard access state, r=mstange 2016-10-11 14:13:36 -04:00
nsMacCursor.h
nsMacCursor.mm
nsMacDockSupport.h
nsMacDockSupport.mm Bug 1262110 - Null out nsIMacDockSupport.dockMenu on shutdown. r=smaug. 2016-04-05 16:46:43 +02:00
nsMacWebAppUtils.h
nsMacWebAppUtils.mm
nsMenuBarX.h Bug 1265953, part 3 - Convert more widget code from nsAutoPtr to UniquePtr. r=mstange 2016-04-19 23:29:16 +01:00
nsMenuBarX.mm Bug 1265386: Fix white-space errors in widget/, r=nfroyd 2016-07-22 10:56:13 +02:00
nsMenuBaseX.h
nsMenuGroupOwnerX.h Bug 1265953, part 1 - Convert most of the cocoa widget code from nsAutoPtr to UniquePtr. r=mstange 2016-04-19 11:28:12 +01:00
nsMenuGroupOwnerX.mm
nsMenuItemIconX.h Bug 1265953, part 1 - Convert most of the cocoa widget code from nsAutoPtr to UniquePtr. r=mstange 2016-04-19 11:28:12 +01:00
nsMenuItemIconX.mm Bug 1256999 - Pass the right context to new channels for image loads. r=bz r=seth 2016-04-11 10:58:03 +02:00
nsMenuItemX.h Bug 1265953, part 1 - Convert most of the cocoa widget code from nsAutoPtr to UniquePtr. r=mstange 2016-04-19 11:28:12 +01:00
nsMenuItemX.mm Bug 1265386: Fix white-space errors in widget/, r=nfroyd 2016-07-22 10:56:13 +02:00
nsMenuUtilsX.h
nsMenuUtilsX.mm Bug 1248981 - Fix spelling error in nsMenuUtilsX.mm, a=tomcat 2016-02-17 15:57:01 +01:00
nsMenuX.h Bug 1265386: Fix white-space errors in widget/, r=nfroyd 2016-07-22 10:56:13 +02:00
nsMenuX.mm Bug 1018486 - Part 3: Changes in widget/cocoa/, r=mstange 2016-09-07 10:50:38 -04:00
nsNativeThemeCocoa.h Bug 1192053 - Implement NS_THEME_MAC_SOURCE_LIST_SELECTION and NS_THEME_MAC_ACTIVE_SOURCE_LIST_SELECTION. r=mstange. 2016-10-14 22:45:29 +02:00
nsNativeThemeCocoa.mm Bug 1192053 - Implement NS_THEME_MAC_SOURCE_LIST_SELECTION and NS_THEME_MAC_ACTIVE_SOURCE_LIST_SELECTION. r=mstange. 2016-10-14 22:45:29 +02:00
nsNativeThemeColors.h Bug 1279017 - Remove code specific to 10.6-10.8 in widget/cocoa. r=mstange. 2016-06-10 23:30:25 +02:00
nsPIWidgetCocoa.idl Bug 1294553 - Don't pretend that nsCocoaWindow is an interface in nsPIWidgetCocoa.idl, r=mstange 2016-08-11 17:56:10 -04:00
nsPrintDialogX.h Bug 1293117 (part 4) - Change many NS_IMETHODIMP occurrences to NS_IMETHOD. r=froydnj. 2016-08-08 10:54:47 +10:00
nsPrintDialogX.mm Backed out changeset 50f830bdb2c8 (bug 1315121) for failing reftest-sanity/page-width-4.1in.html on OS X 10.10 debug. r=backout on a CLOSED TREE 2016-11-17 21:53:26 +01:00
nsPrintOptionsX.h Bug 1303051 - Printing Issue: Page Setup not being respected since upgrade to 48.01 on Mac; r=mconley 2016-11-09 17:37:40 -08:00
nsPrintOptionsX.mm Backed out changeset 50f830bdb2c8 (bug 1315121) for failing reftest-sanity/page-width-4.1in.html on OS X 10.10 debug. r=backout on a CLOSED TREE 2016-11-17 21:53:26 +01:00
nsPrintSettingsX.h Backed out changeset 50f830bdb2c8 (bug 1315121) for failing reftest-sanity/page-width-4.1in.html on OS X 10.10 debug. r=backout on a CLOSED TREE 2016-11-17 21:53:26 +01:00
nsPrintSettingsX.mm Backed out changeset 50f830bdb2c8 (bug 1315121) for failing reftest-sanity/page-width-4.1in.html on OS X 10.10 debug. r=backout on a CLOSED TREE 2016-11-17 21:53:26 +01:00
nsSandboxViolationSink.h
nsSandboxViolationSink.mm Bug 1302163 - Change code to use SprintfLiteral instead of snprintf. r=ehsan 2016-10-04 17:57:51 +02:00
nsScreenCocoa.h Bug 1240085 - Revert to CSS-pixel units for screenX, screenY, moveTo() APIs, and adjust the origin for secondary displays with differing resolution to avoid overlapping coordinate spaces. r=emk 2016-02-05 16:29:33 +00:00
nsScreenCocoa.mm Bug 1281686 - Part 1: Fix OSX Compile failure due to unified build. r=mstange 2016-06-29 11:24:43 +08:00
nsScreenManagerCocoa.h Bug 1265953, part 1 - Convert most of the cocoa widget code from nsAutoPtr to UniquePtr. r=mstange 2016-04-19 11:28:12 +01:00
nsScreenManagerCocoa.mm Bug 1239007 - Replace nsIntRect by strongly-typed rects in a couple of nsCocoaUtils functions. r=mstange 2016-01-13 07:32:55 +00:00
nsSound.h
nsSound.mm
nsStandaloneNativeMenu.h
nsStandaloneNativeMenu.mm
nsSystemStatusBarCocoa.h Bug 1265953, part 1 - Convert most of the cocoa widget code from nsAutoPtr to UniquePtr. r=mstange 2016-04-19 11:28:12 +01:00
nsSystemStatusBarCocoa.mm
nsToolkit.h Bug 1282251 - Remove nsCocoaFeatures::OnLionOrLater(), OnMountainLionOrLater() and OnMavericksOrLater(). r=spohl. 2016-07-11 21:19:36 +02:00
nsToolkit.mm
nsWidgetFactory.mm Initialize nsAppShell in the GPU process. (bug 1294350 part 5, r=nfroyd) 2016-08-22 22:57:36 -07:00
nsWindowMap.h
nsWindowMap.mm
OSXNotificationCenter.h Bug 1233086, Part 3 - Use unified image loading for OS X alerts. r=mstange 2016-06-10 18:59:25 -07:00
OSXNotificationCenter.mm Bug 862395 - Part 1: Add requireInteraction property to web notifications. r=baku 2016-10-12 17:27:40 -07:00
RectTextureImage.h Bug 1281686 - Part 3: Using MacIOSurface for RectTextureImage. r=mstange 2016-06-29 11:24:44 +08:00
RectTextureImage.mm Bug 1281686 - Part 3: Using MacIOSurface for RectTextureImage. r=mstange 2016-06-29 11:24:44 +08:00
SwipeTracker.h
SwipeTracker.mm Bug 1259667 - part5: rename WidgetSimpleGestureEvent.delta to mDelta. r=masayuki 2016-05-10 04:16:55 +09:00
TextInputHandler.h Bug 1317906 When a key press causes a call of InsertText(), it shouldn't mark keypress as consumed but instead, should mark InsertText() caused composition r=m_kato 2016-11-17 13:35:21 +09:00
TextInputHandler.mm Bug 1317906 When a key press causes a call of InsertText(), it shouldn't mark keypress as consumed but instead, should mark InsertText() caused composition r=m_kato 2016-11-17 13:35:21 +09:00
VibrancyManager.h Bug 1192053 - Implement NS_THEME_MAC_SOURCE_LIST_SELECTION and NS_THEME_MAC_ACTIVE_SOURCE_LIST_SELECTION. r=mstange. 2016-10-14 22:45:29 +02:00
VibrancyManager.mm Bug 1310808 - Make use of the new 10.12 constant NSVisualEffectMaterialSelection. r=mstange. 2016-10-17 22:45:02 +02:00
ViewRegion.h Bug 1070710 - Add mozilla::ViewRegion which assembles a LayoutDeviceIntRegion as NSViews. r=spohl 2016-07-16 17:07:45 -04:00
ViewRegion.mm Bug 1070710 - Add mozilla::ViewRegion which assembles a LayoutDeviceIntRegion as NSViews. r=spohl 2016-07-16 17:07:45 -04:00
WidgetTraceEvent.mm