gecko-dev/dom/svg/SVGTitleElement.cpp
Emilio Cobos Álvarez 6917a38081 Bug 1555216 - Change the signature of BindToTree to be (BindContext&, nsINode& aParentNode). r=bzbarsky
BindContext was going to have way more information at first, but then I realized
that most of the things I wanted to know were basically a flag away using the
parent node.

Still I think it's worth it, now experimenting with BindToTree will only mean
adding a field to a struct that's included from a couple cpp files, instead of a
massive pain.

I also think this is clearer, and doing this highlights quite a few
inconsistencies in our code which I've left untouched, but commented with
FIXMEs.

Steps are:

$ for file in $(rg 'nsresult BindToTree\(' | cut -d : -f 1 | sort | uniq); do sed -i 's#nsresult BindToTree(Document\* aDocument, nsIContent\* aParent,#nsresult BindToTree(BindContext\&, nsINode\& aParent)#g' $file; done
$ for file in $(rg 'nsresult BindToTree\(' | cut -d : -f 1 | sort | uniq); do sed -i 's#                      nsIContent\* aBindingParent) override#override#g' $file; done
$ for file in $(rg '::BindToTree\(' | cut -d : -f 1 | sort | uniq); do sed -i 's#::BindToTree(Document\* aDocument, nsIContent\* aParent,#::BindToTree(BindContext\& aContext, nsINode\& aParent)#g' $file; done
$ for file in $(rg '::BindToTree\(' | cut -d : -f 1 | sort | uniq); do sed -i 's#nsIContent\* aBindingParent)##g' $file; done
$ for file in $(rg '::BindToTree\(' | cut -d : -f 1 | sort | uniq); do sed -i 's#::BindToTree(aDocument, aParent, aBindingParent)#::BindToTree(aContext, aParent)#g' $file; done
$ ./mach clang-format

Then manual fixups.

Depends on D32948

Differential Revision: https://phabricator.services.mozilla.com/D32949
2019-05-31 23:31:52 +02:00

90 lines
2.5 KiB
C++

/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#include "mozilla/dom/SVGTitleElement.h"
#include "mozilla/dom/SVGTitleElementBinding.h"
NS_IMPL_NS_NEW_SVG_ELEMENT(Title)
namespace mozilla {
namespace dom {
JSObject* SVGTitleElement::WrapNode(JSContext* aCx,
JS::Handle<JSObject*> aGivenProto) {
return SVGTitleElement_Binding::Wrap(aCx, this, aGivenProto);
}
//----------------------------------------------------------------------
// nsISupports methods
NS_IMPL_ISUPPORTS_INHERITED(SVGTitleElement, SVGTitleElementBase,
nsIMutationObserver)
//----------------------------------------------------------------------
// Implementation
SVGTitleElement::SVGTitleElement(
already_AddRefed<mozilla::dom::NodeInfo>&& aNodeInfo)
: SVGTitleElementBase(std::move(aNodeInfo)) {
AddMutationObserver(this);
}
void SVGTitleElement::CharacterDataChanged(nsIContent* aContent,
const CharacterDataChangeInfo&) {
SendTitleChangeEvent(false);
}
void SVGTitleElement::ContentAppended(nsIContent* aFirstNewContent) {
SendTitleChangeEvent(false);
}
void SVGTitleElement::ContentInserted(nsIContent* aChild) {
SendTitleChangeEvent(false);
}
void SVGTitleElement::ContentRemoved(nsIContent* aChild,
nsIContent* aPreviousSibling) {
SendTitleChangeEvent(false);
}
nsresult SVGTitleElement::BindToTree(BindContext& aContext, nsINode& aParent) {
// Let this fall through.
nsresult rv = SVGTitleElementBase::BindToTree(aContext, aParent);
NS_ENSURE_SUCCESS(rv, rv);
SendTitleChangeEvent(true);
return NS_OK;
}
void SVGTitleElement::UnbindFromTree(bool aNullParent) {
SendTitleChangeEvent(false);
// Let this fall through.
SVGTitleElementBase::UnbindFromTree(aNullParent);
}
void SVGTitleElement::DoneAddingChildren(bool aHaveNotified) {
if (!aHaveNotified) {
SendTitleChangeEvent(false);
}
}
void SVGTitleElement::SendTitleChangeEvent(bool aBound) {
Document* doc = GetUncomposedDoc();
if (doc) {
doc->NotifyPossibleTitleChange(aBound);
}
}
//----------------------------------------------------------------------
// nsINode methods
NS_IMPL_ELEMENT_CLONE_WITH_INIT(SVGTitleElement)
} // namespace dom
} // namespace mozilla