mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-22 09:45:41 +00:00
bcff2dd108
In order to enable asynchronous launch, destruction of GeckoChildProcessHost (and its subclasses) has to be delayed until after launching (or anything else that might be made asynchronous in the future) has completed, to prevent use-after-free. However, there are other dependencies on process hosts always being destroyed on the I/O thread, so refcounting would be difficult to use. Instead, GeckoChildProcessHost now may not be destroyed directly, but must go through a method that handles the scheduling. There are also some minor cleanups to the affected headers (removed duplicate access modifiers, and made PluginProcessParent final). Depends on D18010 Differential Revision: https://phabricator.services.mozilla.com/D18011 --HG-- extra : moz-landing-system : lando
53 lines
1.5 KiB
C++
53 lines
1.5 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 2 -*-
|
|
* vim: sw=2 ts=4 et :
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#ifndef GMPProcessParent_h
|
|
#define GMPProcessParent_h 1
|
|
|
|
#include "mozilla/Attributes.h"
|
|
#include "base/basictypes.h"
|
|
#include "base/file_path.h"
|
|
#include "base/thread.h"
|
|
#include "chrome/common/child_process_host.h"
|
|
#include "mozilla/ipc/GeckoChildProcessHost.h"
|
|
|
|
class nsIRunnable;
|
|
|
|
namespace mozilla {
|
|
namespace gmp {
|
|
|
|
class GMPProcessParent final : public mozilla::ipc::GeckoChildProcessHost {
|
|
public:
|
|
explicit GMPProcessParent(const std::string& aGMPPath);
|
|
|
|
// Synchronously launch the plugin process. If the process fails to launch
|
|
// after timeoutMs, this method will return false.
|
|
bool Launch(int32_t aTimeoutMs);
|
|
|
|
void Delete(nsCOMPtr<nsIRunnable> aCallback = nullptr);
|
|
|
|
bool CanShutdown() override { return true; }
|
|
const std::string& GetPluginFilePath() { return mGMPPath; }
|
|
|
|
using mozilla::ipc::GeckoChildProcessHost::GetChannel;
|
|
using mozilla::ipc::GeckoChildProcessHost::GetChildProcessHandle;
|
|
|
|
private:
|
|
~GMPProcessParent();
|
|
|
|
void DoDelete();
|
|
|
|
std::string mGMPPath;
|
|
nsCOMPtr<nsIRunnable> mDeletedCallback;
|
|
|
|
DISALLOW_COPY_AND_ASSIGN(GMPProcessParent);
|
|
};
|
|
|
|
} // namespace gmp
|
|
} // namespace mozilla
|
|
|
|
#endif // ifndef GMPProcessParent_h
|