mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-03-06 08:40:56 +00:00
d3eaf3858d
This works on all platforms with the exception of Linux where we remove the exception handler only if the sandbox is disabled. With the sandbox enabled we would have to whitelist sigaltstack() which breakpad uses to remove the alternate signal stack which is not worth the fuss. Besides this patch refactors the code that sets and unsets the exception handler, cutting down on the duplication: * The XRE_UnsetRemoteExceptionHandler() call is removed from XULAppAPI.h since it was no longer used * The duplicate checks for the special strings used to disable the remote exception handler have been removed from CrashReporter::UnsetRemoteExceptionHandler() leaving them in the calling code * The SetRemoteExceptionHandler() function was consolidated into only one piece of code with only one non-platform-specific shared prototype * Some additional code was factored out to improve the readability These changes pave the way both for bug 1614933 and for the oxidation of the exception handler code. Differential Revision: https://phabricator.services.mozilla.com/D67213 --HG-- extra : moz-landing-system : lando