mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-27 04:05:32 +00:00
bd7c1e4e8c
This was a memory-saving optimization introduced as part of dependencies for bug 686875, but a more general system landed in bug 77999 for Gecko and https://github.com/servo/servo/pull/18509 for Servo. So now it's probably even a bit of a pessimization (though probably not huge), and given this causes bugs like bug 1462742, bug 1157592, and bug 1468145, and fishiness like the one pointed out in this bug, we may as well remove it. The performance impact of having to lookup through more rules should be minimal given the bloom filter and the rule hash optimizations. This makes me wonder whether we could remove the whole concept of on-demand UA sheets, since they've caused pain, for example, when the frontend people try loading <svg>s from NAC (since that triggers sheet loading from frame construction, which is not good). I'm not concerned about loading mathml.css and svg.css everywhere, though xul.css may not be as doable since it adds a bunch of attribute-dependent selectors. Though on the other hand I asserted in the xul.css code and we don't load it in content with <video> / <input type="date/time/etc"> and such, afaict, so maybe now that legacy addons are gone we can remove that sheet from content processes altogether. MozReview-Commit-ID: 9JCWNZj6BkT |
||
|---|---|---|
| .. | ||
| crashtests | ||
| test | ||
| moz.build | ||
| nsForwardReference.h | ||
| nsIController.idl | ||
| nsIControllers.idl | ||
| nsIXULOverlayProvider.idl | ||
| nsIXULSortService.idl | ||
| nsXULCommandDispatcher.cpp | ||
| nsXULCommandDispatcher.h | ||
| nsXULContentSink.cpp | ||
| nsXULContentSink.h | ||
| nsXULContentUtils.cpp | ||
| nsXULContentUtils.h | ||
| nsXULControllers.cpp | ||
| nsXULControllers.h | ||
| nsXULElement.cpp | ||
| nsXULElement.h | ||
| nsXULPopupListener.cpp | ||
| nsXULPopupListener.h | ||
| nsXULPrototypeCache.cpp | ||
| nsXULPrototypeCache.h | ||
| nsXULPrototypeDocument.cpp | ||
| nsXULPrototypeDocument.h | ||
| nsXULSortService.cpp | ||
| nsXULSortService.h | ||
| XULDocument.cpp | ||
| XULDocument.h | ||
| XULPopupElement.cpp | ||
| XULPopupElement.h | ||