gecko-dev/editor/libeditor/TextEditUtils.cpp
Masayuki Nakano 23a22c597a Bug 1569902 - part 2: Stop using attribute to consider whether a <br> element is a special node for empty last line or not r=m_kato,smaug
Editor creates a `<br>` element to end of a block if last line
of the block is empty because caret should be placed as there is an empty
line.  Such special `<br>` element has `type` attribute whose value is "_moz".
However, adding/removing the attribute is expensive and such hacky attribute
shouldn't be referred nor changed by web apps.

Therefore, this patch makes `HTMLBRElement` take another specific flag whether
it's a special node for empty last line.  For making the meaning clearer,
this patch calls the such `<br>` elements as "padding `<br>` element for
empty last line" insead of "moz-br".  So, this patch also includes a lot of
renaming methods and variables, and modifying related comments.

Note that with this change, `IMEContentObserver` counts the padding `<br>`
element in `<textarea>` because it's inserted before setting the new flag
and setting the flag does not cause DOM tree mutation.  This issue will be
fixed by the following patches.

Differential Revision: https://phabricator.services.mozilla.com/D39858

--HG--
extra : moz-landing-system : lando
2019-08-02 05:45:18 +00:00

65 lines
1.8 KiB
C++

/* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#include "TextEditUtils.h"
#include "mozilla/Assertions.h"
#include "mozilla/TextEditor.h"
#include "mozilla/dom/Element.h"
#include "mozilla/dom/HTMLBRElement.h"
#include "nsAString.h"
#include "nsCOMPtr.h"
#include "nsCaseTreatment.h"
#include "nsDebug.h"
#include "nsError.h"
#include "nsGkAtoms.h"
#include "nsNameSpaceManager.h"
#include "nsLiteralString.h"
#include "nsString.h"
namespace mozilla {
using namespace dom;
/******************************************************************************
* TextEditUtils
******************************************************************************/
/**
* IsBody() returns true if aNode is an html body node.
*/
bool TextEditUtils::IsBody(nsINode* aNode) {
MOZ_ASSERT(aNode);
return aNode->IsHTMLElement(nsGkAtoms::body);
}
/**
* IsBreak() returns true if aNode is an html break node.
*/
bool TextEditUtils::IsBreak(nsINode* aNode) {
MOZ_ASSERT(aNode);
return aNode->IsHTMLElement(nsGkAtoms::br);
}
/******************************************************************************
* AutoEditInitRulesTrigger
******************************************************************************/
AutoEditInitRulesTrigger::AutoEditInitRulesTrigger(TextEditor* aTextEditor,
nsresult& aResult)
: mTextEditor(aTextEditor), mResult(aResult) {
if (mTextEditor) {
mTextEditor->BeginEditorInit();
}
}
AutoEditInitRulesTrigger::~AutoEditInitRulesTrigger() {
if (mTextEditor) {
mResult = MOZ_KnownLive(mTextEditor)->EndEditorInit();
}
}
} // namespace mozilla