Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-21 01:05:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
0741e754a0
gecko-dev/dom
History
Nika Layzell eb598b2ae9 Bug 1563542 - Correctly align usage of mIsDiscarded and mClosed for BrowsingContext, r=peterv 
In the bug which introduced mIsDiscarded, the code was changed to not set
mClosed during Detach, and only set mIsDiscarded. This was a mistake because a
bunch of places are only reading mClosed. Specifically when creating a
BrowsingContext for an iframe, we check GetClosed() to see whether to skip
creating it. Not doing this check can lead to assertions like the one in this
bug.

This patch changes the behaviour to continue setting `mClosed`, and also updates
the relevant `GetClosed()` checks to correctly check `IsDiscarded()`

Differential Revision: https://phabricator.services.mozilla.com/D37267

--HG--
extra : moz-landing-system : lando
2019-07-08 17:27:27 +00:00
..
abort Bug 1561435 - Format dom/, a=automatic-formatting 2019-07-05 10:44:55 +02:00
animation Bug 1561435 - Format dom/, a=automatic-formatting 2019-07-05 10:44:55 +02:00
audiochannel
base Bug 1563542 - Correctly align usage of mIsDiscarded and mClosed for BrowsingContext, r=peterv 2019-07-08 17:27:27 +00:00
battery
bindings Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan 2019-07-06 08:18:28 +00:00
broadcastchannel Bug 1561435 - Format dom/, a=automatic-formatting 2019-07-05 10:44:55 +02:00
browser-element Bug 1560455 - rename CodebasePrincipal to ContentPrincipal. r=ckerschb 2019-07-08 16:37:45 +00:00
cache Bug 467035 - Add new internal DTD content types r=ckerschb 2019-07-03 17:28:25 +00:00
canvas Bug 1562642 - Add missing MPL2 headers r=mhoye 2019-07-05 17:05:57 +00:00
chrome-webidl Merge mozilla-central to inbound. a=merge CLOSED TREE 2019-07-04 06:38:21 +03:00
clients Backed out 2 changesets (bug 1552168) for causing mochitest crashes on test_menubar.xul CLOSED TREE 2019-07-03 16:08:23 +03:00
commandhandler
console Bug 1561435 - Format dom/, a=automatic-formatting 2019-07-05 10:44:55 +02:00
credentialmanagement Bug 1561435 - Format dom/, a=automatic-formatting 2019-07-05 10:44:55 +02:00
crypto Bug 1561435 - Fix linting errors for dom/, r=standard8 2019-06-28 20:53:14 +02:00
debugger Bug 1529345 - Part 2: Add Gecko infrastructure for receiving notifications about debugger-related events. r=jimb,smaug 2019-06-17 04:36:29 +00:00
docs
encoding Bug 1561435 - Format dom/, a=automatic-formatting 2019-07-05 10:44:55 +02:00
events Bug 1561435 - Format dom/, a=automatic-formatting 2019-07-05 10:44:55 +02:00
fetch Bug 467035 - Add new internal DTD content types r=ckerschb 2019-07-03 17:28:25 +00:00
file Bug 1561435 - Format dom/, a=automatic-formatting 2019-07-05 10:44:55 +02:00
filehandle
filesystem Bug 1561435 - Format dom/, a=automatic-formatting 2019-07-05 10:44:55 +02:00
flex Bug 1532937 - Enable ESLint for dom/flex and dom/grid (automatic changes). r=Standard8,smaug 2019-06-03 10:42:12 +00:00
gamepad Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan 2019-07-06 08:18:28 +00:00
geolocation Backed out changeset 14faf5e9443e (bug 1529591) for multiple failures. e.g. toolkit/components/extensions/test/mochitest/test_ext_geolocation.html on a CLOSED TREE 2019-07-05 00:28:07 +03:00
grid Bug 1559546 - Use atoms for grid line names. r=mats 2019-06-19 05:58:11 +00:00
html Bug 1560455 - rename CodebasePrincipal to ContentPrincipal. r=ckerschb 2019-07-08 16:37:45 +00:00
imptests
indexedDB Bug 1560455 - rename CodebasePrincipal to ContentPrincipal. r=ckerschb 2019-07-08 16:37:45 +00:00
interfaces Bug 1560455 - rename CodebasePrincipal to ContentPrincipal. r=ckerschb 2019-07-08 16:37:45 +00:00
ipc Bug 1563542 - Correctly align usage of mIsDiscarded and mClosed for BrowsingContext, r=peterv 2019-07-08 17:27:27 +00:00
jsurl Bug 1555050: Always (if non null) set any CSP as cspToInherit on the loadinfo of new document load. Update documentation for GetCSP, GetPreloadCSP() and GetCSPToInherit and update two callsites which called GetCSP instead of GetCSPToInherit. r=bzbarsky 2019-06-06 20:19:56 +00:00
l10n Bug 1562642 - Add missing MPL2 headers r=mhoye 2019-07-05 17:05:57 +00:00
locales Bug 1454622: Remove DOMQuad bounds attribute r=bzbarsky 2019-06-29 02:27:47 +00:00
localstorage Bug 1560455 - rename CodebasePrincipal to ContentPrincipal. r=ckerschb 2019-07-08 16:37:45 +00:00
manifest Bug 1561435 - Format dom/, a=automatic-formatting 2019-07-05 10:44:55 +02:00
mathml Bug 1557793 part 3. Change the signatures of various nsContentUtils localization methods to play nicer with the new stringbundle API. r=smaug 2019-06-08 21:26:12 +00:00
media Bug 1560455 - rename CodebasePrincipal to ContentPrincipal. r=ckerschb 2019-07-08 16:37:45 +00:00
messagechannel Bug 1561435 - Format dom/, a=automatic-formatting 2019-07-05 10:44:55 +02:00
midi Bug 1561435 - Format dom/, a=automatic-formatting 2019-07-05 10:44:55 +02:00
network Bug 1561435 - Format dom/, a=automatic-formatting 2019-07-05 10:44:55 +02:00
notification Bug 1560455 - rename CodebasePrincipal to ContentPrincipal. r=ckerschb 2019-07-08 16:37:45 +00:00
offline Bug 1557904. Stop using [array] in appcache interfaces. r=mayhemer 2019-06-12 12:02:37 +00:00
payments Bug 1561435 - Format dom/, a=automatic-formatting 2019-07-05 10:44:55 +02:00
performance Bug 1561435 - Format dom/, a=automatic-formatting 2019-07-05 10:44:55 +02:00
permission Bug 1541557: Part 3 - Update callers of sync SpecialPowers functions to await the return value. r=nika 2019-06-12 11:41:32 -07:00
plugins Bug 1560455 - rename CodebasePrincipal to ContentPrincipal. r=ckerschb 2019-07-08 16:37:45 +00:00
power
presentation Bug 1560455 - rename CodebasePrincipal to ContentPrincipal. r=ckerschb 2019-07-08 16:37:45 +00:00
prio
promise Bug 1561435 - Format dom/, a=automatic-formatting 2019-07-05 10:44:55 +02:00
prototype Bug 1557793 part 3. Change the signatures of various nsContentUtils localization methods to play nicer with the new stringbundle API. r=smaug 2019-06-08 21:26:12 +00:00
push Bug 1560455 - rename CodebasePrincipal to ContentPrincipal. r=ckerschb 2019-07-08 16:37:45 +00:00
quota Bug 1560455 - rename CodebasePrincipal to ContentPrincipal. r=ckerschb 2019-07-08 16:37:45 +00:00
reporting Bug 1561435 - Format dom/, a=automatic-formatting 2019-07-05 10:44:55 +02:00
res
script Bug 1560455 - rename CodebasePrincipal to ContentPrincipal. r=ckerschb 2019-07-08 16:37:45 +00:00
security Bug 1560455 - rename CodebasePrincipal to ContentPrincipal. r=ckerschb 2019-07-08 16:37:45 +00:00
serviceworkers Bug 1560455 - rename CodebasePrincipal to ContentPrincipal. r=ckerschb 2019-07-08 16:37:45 +00:00
simpledb
smil Bug 1561435 - Format dom/, a=automatic-formatting 2019-07-05 10:44:55 +02:00
storage Bug 1560455 - rename CodebasePrincipal to ContentPrincipal. r=ckerschb 2019-07-08 16:37:45 +00:00
svg Bug 1561435 - Format dom/, a=automatic-formatting 2019-07-05 10:44:55 +02:00
system Bug 1561435 - Format dom/, a=automatic-formatting 2019-07-05 10:44:55 +02:00
tests Bug 1560455 - rename CodebasePrincipal to ContentPrincipal. r=ckerschb 2019-07-08 16:37:45 +00:00
u2f Bug 1561435 - Format dom/, a=automatic-formatting 2019-07-05 10:44:55 +02:00
url Bug 1561435 - Format dom/, a=automatic-formatting 2019-07-05 10:44:55 +02:00
vr Bug 1561435 - Format dom/, a=automatic-formatting 2019-07-05 10:44:55 +02:00
webauthn Bug 1561435 - Format dom/, a=automatic-formatting 2019-07-05 10:44:55 +02:00
webbrowserpersist Bug 1557793 part 2. Stop using [array] in nsIStringBundle. r=Pike 2019-06-11 15:51:51 +00:00
webgpu
webidl Bug 467035 - Avoid leaking browser language via DTD r=Gijs,bzbarsky 2019-07-08 10:47:05 +00:00
websocket Bug 1561435 - Format dom/, a=automatic-formatting 2019-07-05 10:44:55 +02:00
workers Bug 1558299 - Fix ESLint failures in browser_fileURL.js on a CLOSED TREE. r=eslint 2019-07-05 16:29:44 -04:00
worklet Bug 1561435 - Format dom/, a=automatic-formatting 2019-07-05 10:44:55 +02:00
xbl Bug 1562642 - Add missing MPL2 headers r=mhoye 2019-07-05 17:05:57 +00:00
xhr Bug 1529345 - Part 2: Add Gecko infrastructure for receiving notifications about debugger-related events. r=jimb,smaug 2019-06-17 04:36:29 +00:00
xml Bug 1561435 - Format dom/, a=automatic-formatting 2019-07-05 10:44:55 +02:00
xslt Bug 1560455 - rename CodebasePrincipal to ContentPrincipal. r=ckerschb 2019-07-08 16:37:45 +00:00
xul Bug 1563405, part 2 - Use move refs for Push in nsXULContentSink. r=bzbarsky 2019-07-04 05:55:54 +00:00
jar.mn
moz.build Bug 1529345 - Part 2: Add Gecko infrastructure for receiving notifications about debugger-related events. r=jimb,smaug 2019-06-17 04:36:29 +00:00