mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-21 01:05:45 +00:00
e930b89c34
*** Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8 This changes the behavior of ChromeUtils.import() to return an exports object, rather than a module global, in all cases except when `null` is passed as a second argument, and changes the default behavior not to pollute the global scope with the module's exports. Thus, the following code written for the old model: ChromeUtils.import("resource://gre/modules/Services.jsm"); is approximately the same as the following, in the new model: var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm"); Since the two behaviors are mutually incompatible, this patch will land with a scripted rewrite to update all existing callers to use the new model rather than the old. *** Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs This was done using the followng script: https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm *** Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8 Differential Revision: https://phabricator.services.mozilla.com/D16747 *** Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D16748 *** Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D16749 *** Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs *** Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D16750 --HG-- extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895 extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
83 lines
2.7 KiB
JavaScript
83 lines
2.7 KiB
JavaScript
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this file,
|
|
* You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
"use strict";
|
|
|
|
this.EXPORTED_SYMBOLS = ["OpenInTabsUtils"];
|
|
|
|
const {XPCOMUtils} = ChromeUtils.import("resource://gre/modules/XPCOMUtils.jsm");
|
|
const {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
|
|
|
|
XPCOMUtils.defineLazyGetter(this, "bundle", function() {
|
|
return Services.strings.createBundle("chrome://browser/locale/tabbrowser.properties");
|
|
});
|
|
|
|
/**
|
|
* Utility functions that can be used when opening multiple tabs, that can be
|
|
* called without any tabbrowser instance.
|
|
*/
|
|
this.OpenInTabsUtils = {
|
|
getString(key) {
|
|
return bundle.GetStringFromName(key);
|
|
},
|
|
|
|
getFormattedString(key, params) {
|
|
return bundle.formatStringFromName(key, params, params.length);
|
|
},
|
|
|
|
/**
|
|
* Gives the user a chance to cancel loading lots of tabs at once.
|
|
*/
|
|
confirmOpenInTabs(numTabsToOpen, aWindow) {
|
|
const WARN_ON_OPEN_PREF = "browser.tabs.warnOnOpen";
|
|
const MAX_OPNE_PREF = "browser.tabs.maxOpenBeforeWarn";
|
|
if (!Services.prefs.getBoolPref(WARN_ON_OPEN_PREF)) {
|
|
return true;
|
|
}
|
|
if (numTabsToOpen < Services.prefs.getIntPref(MAX_OPNE_PREF)) {
|
|
return true;
|
|
}
|
|
|
|
// default to true: if it were false, we wouldn't get this far
|
|
let warnOnOpen = { value: true };
|
|
|
|
const messageKey = "tabs.openWarningMultipleBranded";
|
|
const openKey = "tabs.openButtonMultiple";
|
|
const BRANDING_BUNDLE_URI = "chrome://branding/locale/brand.properties";
|
|
let brandShortName = Services.strings.createBundle(BRANDING_BUNDLE_URI).
|
|
GetStringFromName("brandShortName");
|
|
|
|
let buttonPressed = Services.prompt.confirmEx(
|
|
aWindow,
|
|
this.getString("tabs.openWarningTitle"),
|
|
this.getFormattedString(messageKey, [numTabsToOpen, brandShortName]),
|
|
(Services.prompt.BUTTON_TITLE_IS_STRING * Services.prompt.BUTTON_POS_0) +
|
|
(Services.prompt.BUTTON_TITLE_CANCEL * Services.prompt.BUTTON_POS_1),
|
|
this.getString(openKey), null, null,
|
|
this.getFormattedString("tabs.openWarningPromptMeBranded",
|
|
[brandShortName]),
|
|
warnOnOpen
|
|
);
|
|
|
|
let reallyOpen = (buttonPressed == 0);
|
|
// don't set the pref unless they press OK and it's false
|
|
if (reallyOpen && !warnOnOpen.value) {
|
|
Services.prefs.setBoolPref(WARN_ON_OPEN_PREF, false);
|
|
}
|
|
|
|
return reallyOpen;
|
|
},
|
|
|
|
/*
|
|
* Async version of confirmOpenInTabs.
|
|
*/
|
|
promiseConfirmOpenInTabs(numTabsToOpen, aWindow) {
|
|
return new Promise(resolve => {
|
|
Services.tm.dispatchToMainThread(() => {
|
|
resolve(this.confirmOpenInTabs(numTabsToOpen, aWindow));
|
|
});
|
|
});
|
|
},
|
|
};
|