mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-08 19:04:45 +00:00
7a10d13a65
Currently we avoid posting animation restyles when unbinding an element by removing the element from the document before deleting its animation collections. As a result, when canceled animations go to post a restyle, they can't find a pres context and give up posting a restyle. However, this is problematic for two reasons: * It means we can't remove such canceled animations from the PendingAnimationTracker if they are present there (i.e. it regresses the fix from bug 1223445). * It means we can't post cancel events for such animations/transitions since we can't lookup the appropriate AnimationEventDispatcher. In the next patch in this series we will change that order to fix the above problems but before we do that, we need to introduce another mechanism to make sure that we don't post restyles when unbinding an element or else we will regress bug 1396041. This patch does that by introducing a flag which causes us to not post restyles when we are doing DOM surgery. For all other cases we actually _do_ need to post restyles in order to update the style correctly. Without this patch, layout/style/crashtests/1396041.html would fail after applying the next patch in this series. Differential Revision: https://phabricator.services.mozilla.com/D28021 --HG-- extra : moz-landing-system : lando
112 lines
3.7 KiB
C++
112 lines
3.7 KiB
C++
/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#ifndef mozilla_AnimationCollection_h
|
|
#define mozilla_AnimationCollection_h
|
|
|
|
#include "mozilla/dom/Animation.h"
|
|
#include "mozilla/dom/Element.h"
|
|
#include "mozilla/Assertions.h"
|
|
#include "mozilla/LinkedList.h"
|
|
#include "mozilla/RefPtr.h"
|
|
#include "nsCSSPseudoElements.h"
|
|
#include "nsDOMMutationObserver.h"
|
|
#include "nsTArray.h"
|
|
|
|
class nsAtom;
|
|
class nsIFrame;
|
|
class nsPresContext;
|
|
|
|
namespace mozilla {
|
|
|
|
// Traits class to define the specific atoms used when storing specializations
|
|
// of AnimationCollection as a property on an Element (e.g. which atom
|
|
// to use when storing an AnimationCollection<CSSAnimation> for a ::before
|
|
// pseudo-element).
|
|
template <class AnimationType>
|
|
struct AnimationTypeTraits {};
|
|
|
|
template <class AnimationType>
|
|
class AnimationCollection
|
|
: public LinkedListElement<AnimationCollection<AnimationType>> {
|
|
typedef AnimationCollection<AnimationType> SelfType;
|
|
typedef AnimationTypeTraits<AnimationType> TraitsType;
|
|
|
|
AnimationCollection(dom::Element* aElement, nsAtom* aElementProperty)
|
|
: mElement(aElement), mElementProperty(aElementProperty) {
|
|
MOZ_COUNT_CTOR(AnimationCollection);
|
|
}
|
|
|
|
public:
|
|
~AnimationCollection() {
|
|
MOZ_ASSERT(mCalledPropertyDtor,
|
|
"must call destructor through element property dtor");
|
|
MOZ_COUNT_DTOR(AnimationCollection);
|
|
LinkedListElement<SelfType>::remove();
|
|
}
|
|
|
|
void Destroy() {
|
|
mCalledDestroy = true;
|
|
|
|
// This will call our destructor.
|
|
mElement->DeleteProperty(mElementProperty);
|
|
}
|
|
|
|
static void PropertyDtor(void* aObject, nsAtom* aPropertyName,
|
|
void* aPropertyValue, void* aData);
|
|
|
|
// Get the collection of animations for the given |aElement| and
|
|
// |aPseudoType|.
|
|
static AnimationCollection<AnimationType>* GetAnimationCollection(
|
|
const dom::Element* aElement, PseudoStyleType aPseudoType);
|
|
|
|
// Given the frame |aFrame| with possibly animated content, finds its
|
|
// associated collection of animations. If |aFrame| is a generated content
|
|
// frame, this function may examine the parent frame to search for such
|
|
// animations.
|
|
static AnimationCollection<AnimationType>* GetAnimationCollection(
|
|
const nsIFrame* aFrame);
|
|
|
|
// Get the collection of animations for the given |aElement| and
|
|
// |aPseudoType| or create it if it does not already exist.
|
|
//
|
|
// We'll set the outparam |aCreatedCollection| to true if we have
|
|
// to create the collection and we successfully do so. Otherwise,
|
|
// we'll set it to false.
|
|
static AnimationCollection<AnimationType>* GetOrCreateAnimationCollection(
|
|
dom::Element* aElement, PseudoStyleType aPseudoType,
|
|
bool* aCreatedCollection);
|
|
|
|
dom::Element* mElement;
|
|
|
|
// the atom we use in mElement's prop table (must be a static atom,
|
|
// i.e., in an atom list)
|
|
nsAtom* mElementProperty;
|
|
|
|
InfallibleTArray<RefPtr<AnimationType>> mAnimations;
|
|
|
|
private:
|
|
static nsAtom* GetPropertyAtomForPseudoType(PseudoStyleType aPseudoType);
|
|
|
|
// We distinguish between destroying this by calling Destroy() vs directly
|
|
// calling DeleteProperty on an element.
|
|
//
|
|
// The former case represents regular updating due to style changes and should
|
|
// trigger subsequent restyles.
|
|
//
|
|
// The latter case represents document tear-down or other DOM surgery in
|
|
// which case we should not trigger restyles.
|
|
bool mCalledDestroy = false;
|
|
|
|
#ifdef DEBUG
|
|
bool mCalledPropertyDtor = false;
|
|
#endif
|
|
};
|
|
|
|
} // namespace mozilla
|
|
|
|
#endif // mozilla_AnimationCollection_h
|