mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-09 03:15:11 +00:00
11ac9e9cf8
* Remove redundant virtual keywords
* Mark all destructors of inheriting classes as virtual for clarity
* Mark all classes without virtual destructor as final (exposed errors)
* Make destructor virtual where it needed to be (some were missing)
* Replace empty ({}) code declaration in header with = default
* Remove virtual unused methods
I probably missed some, it quickly became a rabbit hole.
Differential Revision: https://phabricator.services.mozilla.com/D26060
--HG--
extra : moz-landing-system : lando
85 lines
1.8 KiB
C++
85 lines
1.8 KiB
C++
/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#ifndef MOZILLA_GFX_CRITICALSECTION_H_
|
|
#define MOZILLA_GFX_CRITICALSECTION_H_
|
|
|
|
#ifdef WIN32
|
|
# include <windows.h>
|
|
#else
|
|
# include <pthread.h>
|
|
# include "mozilla/DebugOnly.h"
|
|
#endif
|
|
|
|
namespace mozilla {
|
|
namespace gfx {
|
|
|
|
#ifdef WIN32
|
|
|
|
class CriticalSection {
|
|
public:
|
|
CriticalSection() { ::InitializeCriticalSection(&mCriticalSection); }
|
|
|
|
~CriticalSection() { ::DeleteCriticalSection(&mCriticalSection); }
|
|
|
|
void Enter() { ::EnterCriticalSection(&mCriticalSection); }
|
|
|
|
void Leave() { ::LeaveCriticalSection(&mCriticalSection); }
|
|
|
|
protected:
|
|
CRITICAL_SECTION mCriticalSection;
|
|
};
|
|
|
|
#else
|
|
// posix
|
|
|
|
class PosixCondvar;
|
|
class CriticalSection {
|
|
public:
|
|
CriticalSection() {
|
|
DebugOnly<int> err = pthread_mutex_init(&mMutex, nullptr);
|
|
MOZ_ASSERT(!err);
|
|
}
|
|
|
|
~CriticalSection() {
|
|
DebugOnly<int> err = pthread_mutex_destroy(&mMutex);
|
|
MOZ_ASSERT(!err);
|
|
}
|
|
|
|
void Enter() {
|
|
DebugOnly<int> err = pthread_mutex_lock(&mMutex);
|
|
MOZ_ASSERT(!err);
|
|
}
|
|
|
|
void Leave() {
|
|
DebugOnly<int> err = pthread_mutex_unlock(&mMutex);
|
|
MOZ_ASSERT(!err);
|
|
}
|
|
|
|
protected:
|
|
pthread_mutex_t mMutex;
|
|
friend class PosixCondVar;
|
|
};
|
|
|
|
#endif
|
|
|
|
/// RAII helper.
|
|
struct CriticalSectionAutoEnter final {
|
|
explicit CriticalSectionAutoEnter(CriticalSection* aSection)
|
|
: mSection(aSection) {
|
|
mSection->Enter();
|
|
}
|
|
~CriticalSectionAutoEnter() { mSection->Leave(); }
|
|
|
|
protected:
|
|
CriticalSection* mSection;
|
|
};
|
|
|
|
} // namespace gfx
|
|
} // namespace mozilla
|
|
|
|
#endif
|