gecko-dev/docshell
Olli Pettay 0d3cc17e7f Bug 1697905, requestedIndex may not always be cleared, r=peterv
The previous version was trying to make index handling too generic.
But history loads need to update index to the requested index, not to the index of the current entry,
because the requested index was already passed to the child process when the
history load started. If there are several pending history loads, commit of the first one
will update the index based on requested index and send new index to the child.
When child side receives the index update, other pending history loads have been already
processed.

New loads can just clear the requested index, since the child side has
PendingSHistoryChange object to update the effective index and length to the
correct one and when parent side sends back the current index and length the
relevant PendingSHistoryChange object is removed.

With this version both
testing/web-platform/tests/old-tests/submission/Microsoft/history/history_000.htm
and
docshell/test/navigation/browser_test_simultaneous_normal_and_history_loads.js
pass now even on a debug build.


I think there might be a case for the issue happening also without SHIP, but
since it is way less asynchronous, triggering that issue is hard.
So the patch and test are for SHIP only.

Differential Revision: https://phabricator.services.mozilla.com/D116744
2021-06-15 16:21:07 +00:00
..
base Bug 1697905, requestedIndex may not always be cleared, r=peterv 2021-06-15 16:21:07 +00:00
build Bug 1695817 - Part 2: Introduce a blank page about:third-party r=Gijs,fluent-reviewers,xpcom-reviewers,kmag 2021-05-28 22:35:57 +00:00
resources/content Bug 1710334 - Fix misplacement of about:netError "Try Again" button. r=ckerschb,johannh 2021-05-30 22:48:07 +00:00
shistory Bug 1715852 - Fix SessionHistoryEntry::mSrcdocData to work with session restore, r=peterv 2021-06-15 13:34:01 +00:00
test Bug 1697905, requestedIndex may not always be cleared, r=peterv 2021-06-15 16:21:07 +00:00
moz.build Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00